[jdk11u-dev] RFR: 8155246: Throw error if default java.security file is missing [v2]
Martin Doerr
mdoerr at openjdk.org
Thu Jun 1 09:17:09 UTC 2023
On Tue, 30 May 2023 10:48:10 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:
>> This is a backport for parity with 11.0.20-oracle.
>>
>> Did not apply cleanly. Conflicts in one hunk in Security.java. Manual resolution was obvious.
>>
>> Tests (GHA and SAP internal) passed. Review pending.
>> Manual execution of new test fails without the fix, succeeds with the fix applied.
>>
>> Reviews are very much appreciated.
>
> Lutz Schmidt has updated the pull request incrementally with one additional commit since the last revision:
>
> JDK-8155246 remove accidentally committed temp files
LGTM. Thanks for backporting. I found one minor difference: The original change adds one newline at the end of test/jdk/java/security/Security/override.props.
-------------
Marked as reviewed by mdoerr (Reviewer).
PR Review: https://git.openjdk.org/jdk11u-dev/pull/1903#pullrequestreview-1454980565
More information about the jdk-updates-dev
mailing list