[jdk11u-dev] RFR: 8217237: HttpClient does not deal well with multi-valued WWW-Authenticate challenge headers
Olga Mikhaltsova
omikhaltcova at openjdk.org
Mon Jun 5 16:26:18 UTC 2023
On Fri, 2 Jun 2023 08:08:05 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:
>> I'd like to backport JDK-8217237 to jdk11u in order to fix the same issue.
>> The original patch applies cleanly.
>> Tested as follow: `make run-test TEST=test/jdk/java/net/httpclient`
>
> Hi,
> the test you ran is only a basic sanity test that your fix is working.
> In general, in a backport, you have to test a lot to assure you don't break existing coding!
> If I backport issues, I run tier1, 2, 3, 4 of jdk, langtools, hotspot and jaxp on linux(s390, ppc64le, aarch64, x86_64), windows_x86_64 and mac (x86_64, aarch64), the jck tests on these platforms, benchmarks as rennaisance and some larger applications.
> GHA-actions and running the new/changed tests are only minimal mandatory tests!
Hi @GoeLin,
Azul testing is done without regression.
However, such testing still seems to me a bit redundant in relation to this change, since the fix affects the specific limited area and it's platform-independent. It could be limited to the test-group jdk:tier2_part3 imho.
-------------
PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1916#issuecomment-1577105668
More information about the jdk-updates-dev
mailing list