[jdk17u-dev] RFR: 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE [v2]

Tue Jun 13 14:39:48 UTC 2023

On Tue, 13 Jun 2023 08:48:58 GMT, Frederic Thevenet <fthevenet at openjdk.org> wrote:

>> Hi,
>> 
>> This is a backport of JDK-8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE
>> 
>> Original patch does not apply cleanly to 17u as one of the modified file `src/jdk.jfr/share/classes/jdk/jfr/internal/util/ValueFormatter.java` does not exit prior to 21. Changes to other files apply cleanly.
>> 
>> GHA tests are enabled and amended to include `test/jdk/jdk/jfr` in, addition to what's in the default configuration.
>> 
>> Thanks.
>
> Frederic Thevenet has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert "Added jfr test suite to GHA workflow"
>   
>   This reverts commit 608da2d0131a8f1246cf1b8290ada671fc70c32f.

[ValueFormatter.java](https://github.com/openjdk/jdk/commit/a1ab377d995dce4d636b908e96bd168dc3a9f3e5#diff-92129c25f421457539b76d9df74cdd34a12d8afd07e53612859e2edeee2c5758) got introduced with [JDK-8306703](https://bugs.openjdk.org/browse/JDK-8306703). which is JDK 21+ only (and shouldn't get backported). OK.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/1423#pullrequestreview-1477344902