[jdk17u-dev] RFR: 8309959: JFR: Display N/A for missing data amount

Severin Gehwolf sgehwolf at openjdk.org
Wed Jun 14 14:38:11 UTC 2023


On Wed, 14 Jun 2023 13:45:36 GMT, Frederic Thevenet <fthevenet at openjdk.org> wrote:

> This is a backport of [JDK-8309959](https://bugs.openjdk.org/browse/JDK-8309959): JFR: Display N/A for missing data amount.
> 
> It is a follow up to the backport of [JDK-8309550](): jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE
> 
> NB: [ValueFormatter.java](https://github.com/openjdk/jdk/commit/a1ab377d995dce4d636b908e96bd168dc3a9f3e5#diff-92129c25f421457539b76d9df74cdd34a12d8afd07e53612859e2edeee2c5758) that is changed in the original commit  got introduced with [JDK-8306703](https://bugs.openjdk.org/browse/JDK-8306703). which is JDK 21+ only and shouldn't get backported.
> 
> A run of the Jdk_jfr test suite via GHA is available here: https://github.com/fthevenet/jdk17u-dev/actions/runs/5267901714
> 
> Thanks

LGTM

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/1438#pullrequestreview-1479629078


More information about the jdk-updates-dev mailing list