[jdk17u-dev] RFR: 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE [v2]

[Frederic Thevenet]

On Tue, 13 Jun 2023 08:48:58 GMT, Frederic Thevenet <fthevenet at openjdk.org> wrote:

>> Hi,
>> 
>> This is a backport of JDK-8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE
>> 
>> Original patch does not apply cleanly to 17u as one of the modified file `src/jdk.jfr/share/classes/jdk/jfr/internal/util/ValueFormatter.java` does not exit prior to 21. Changes to other files apply cleanly.
>> 
>> GHA tests are enabled and amended to include `test/jdk/jdk/jfr` in, addition to what's in the default configuration.
>> 
>> Thanks.
>
> Frederic Thevenet has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert "Added jfr test suite to GHA workflow"
>   
>   This reverts commit 608da2d0131a8f1246cf1b8290ada671fc70c32f.

The macos-aarch64 debug build failed with the following:

2023-06-13T14:15:18.3093140Z === Output from failing command(s) repeated here ===
2023-06-13T14:15:18.3111260Z * For target jdk_modules_java.desktop__the.java.desktop_batch:
2023-06-13T14:15:18.3158380Z Connection attempt failed: Connection refused
2023-06-13T14:15:18.3158690Z Connection attempt failed: Connection refused
2023-06-13T14:15:18.3158970Z Connection attempt failed: Connection refused
2023-06-13T14:15:18.3159190Z Giving up
2023-06-13T14:15:18.3159460Z IOException caught during compilation: Could not connect to server


I believe this is infrastructure related: I have re-triggered the failing task to verify this is indeed the case.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1423#issuecomment-1593213715