[jdk17u-dev] RFR: 8271707: migrate tests to use jdk.test.whitebox.WhiteBox

[Martin Doerr]

On Wed, 14 Jun 2023 05:33:22 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> I backport this for parity with 17.0.8-oracle.
> 
> I had to resolve a row of files, also quite some test are just not in 17.
> I grepped through the tests and fixed all remaining occurances, too.
> 
> Here the files I resolved:
> test/hotspot/jtreg/compiler/allocation/TestFailedAllocationBadGraph.java
> Already fixed.
> 
> test/hotspot/jtreg/compiler/c2/irTests/TestSuperwordFailsUnrolling.java
> Fixed.
> 
> Tests not in 17, patch skipped:
> test/hotspot/jtreg/compiler/ciReplay/TestDumpReplayCommandLine.java
> test/hotspot/jtreg/compiler/ciReplay/TestInlining.java
> test/hotspot/jtreg/compiler/ciReplay/TestLambdas.java
> test/hotspot/jtreg/compiler/ciReplay/TestNoClassFile.java
> test/hotspot/jtreg/compiler/ciReplay/TestUnresolvedClasses.java
> test/hotspot/jtreg/compiler/jvmci/compilerToVM/IterateFramesNative.java
> test/hotspot/jtreg/compiler/rangechecks/TestLongRangeCheck.java
> test/hotspot/jtreg/compiler/regalloc/TestC2IntPressure.java
> test/hotspot/jtreg/compiler/vectorization/runner/ArrayCopyTest.java
> test/hotspot/jtreg/compiler/vectorization/runner/ArrayIndexFillTest.java
> test/hotspot/jtreg/compiler/vectorization/runner/ArrayInvariantFillTest.java
> test/hotspot/jtreg/compiler/vectorization/runner/ArrayShiftOpTest.java
> test/hotspot/jtreg/compiler/vectorization/runner/ArrayTypeConvertTest.java
> test/hotspot/jtreg/compiler/vectorization/runner/ArrayUnsafeOpTest.java
> test/hotspot/jtreg/compiler/vectorization/runner/BasicBooleanOpTest.java
> test/hotspot/jtreg/compiler/vectorization/runner/BasicByteOpTest.java
> test/hotspot/jtreg/compiler/vectorization/runner/BasicCharOpTest.java
> test/hotspot/jtreg/compiler/vectorization/runner/BasicDoubleOpTest.java
> test/hotspot/jtreg/compiler/vectorization/runner/BasicFloatOpTest.java
> test/hotspot/jtreg/compiler/vectorization/runner/BasicIntOpTest.java
> test/hotspot/jtreg/compiler/vectorization/runner/BasicLongOpTest.java
> test/hotspot/jtreg/compiler/vectorization/runner/BasicShortOpTest.java
> test/hotspot/jtreg/compiler/vectorization/runner/LoopArrayIndexComputeTest.java
> test/hotspot/jtreg/compiler/vectorization/runner/LoopCombinedOpTest.java
> test/hotspot/jtreg/compiler/vectorization/runner/LoopControlFlowTest.java
> test/hotspot/jtreg/compiler/vectorization/runner/LoopLiveOutNodesTest.java
> test/hotspot/jtreg/compiler/vectorization/runner/LoopRangeStrideTest.java
> test/hotspot/jtreg/compiler/vectorization/runner/LoopReductionOpTest.java
> test/hotspot/jtreg/compiler/vectorization/runner/MultipleLoopsTest.java
> test/hotspot/jtreg/compiler/vectorization/runner/StripMinedLo...

LGTM. Huge change, but complexity is not very high. Thanks for the detailed description and for splitting backport and new adaptations into 2 commits.

test/hotspot/jtreg/runtime/cds/appcds/customLoader/SameNameInTwoLoadersTest.java line 57:

> 55: 
> 56:         useWbParam = "-Xbootclasspath/a:" +
> 57:             JarBuilder.build(true, "WhiteBox", "jdk/test/whitebox/WhiteBox");;

New code has only one ';'. Feel free to remove one (accept new code). Not required.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/1434#pullrequestreview-1481765627
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1434#discussion_r1231130440