[jdk11u-dev] RFR: 8023980: JCE doesn't provide any class to handle RSA private key in PKCS#1

[Matthias Baesken]

On Thu, 15 Jun 2023 12:54:33 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> I backport this for parity with 11.0.20-oracle.
> 
> I had to resolve RSAPrivateCrtKeyImpl.java.
> Besides context, newKey() is refactored in 11 because
> 8271199: Mutual TLS handshake fails signing client certificate with c...
> is already backported.
> 
> TestKeyFactory.java
> manual resolve. Some of the edits are already there (in testPrivate()).
> They probably came with 8254717.

Looks okay to me.
I noticed that
src/java.base/share/classes/sun/security/rsa/RSAPrivateCrtKeyImpl.java
public static RSAPrivateKey newKey(KeyType type, String format, byte[] encoded) 
The
case "PKCS#8"
differs from the change in head, but it seems to be okay as it is, but maybe you want to check it again if the diff is really wanted.

-------------

Marked as reviewed by mbaesken (Reviewer).

PR Review: https://git.openjdk.org/jdk11u-dev/pull/1946#pullrequestreview-1482896098