[jdk17u-dev] RFR: 8272586: emit abstract machine code in hs-err logs

[Matthias Baesken]

On Thu, 15 Jun 2023 16:57:40 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

> Backport of JDK-8272568 with follow-up fixes (see Commits).
> 
> This PR contains the following commits:
> 1. [JDK-8272586](https://bugs.openjdk.org/browse/JDK-8272586): emit abstract machine code in hs-err logs
> This is the main part. Almost clean. Code move had to be done manually because `JavaThread::cast(t)` was introduced after JDK17. (JDK17 uses `t->as_Java_thread()`.)
> 2. [JDK-8275031](https://bugs.openjdk.org/browse/JDK-8275031): runtime/ErrorHandling/MachCodeFramesInErrorFile.java fails when hsdis is present
> Small fix. Clean.
> 3. [JDK-8277102](https://bugs.openjdk.org/browse/JDK-8277102): Dubious PrintCompilation output
> Basically reverts the timestamp change. Clean.
> 
> I'm planning to backport the other follow-up changes separately:
> 1. [JDK-8274986](https://bugs.openjdk.org/browse/JDK-8274986): max code printed in hs-err logs should be configurable
> Clean but replacement of `JavaThread::cast` is needed.
> 2. [JDK-8283056](https://bugs.openjdk.org/browse/JDK-8283056): show abstract machine code in hs-err for all VM crashes
> Clean.
> 
> The feature greatly helps analyzing VM crashes.

Marked as reviewed by mbaesken (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk17u-dev/pull/1446#pullrequestreview-1486234382