[jdk17u-dev] RFR: 8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27)

Matthias Baesken mbaesken at openjdk.org
Fri Jun 23 11:05:11 UTC 2023


On Thu, 22 Jun 2023 14:34:18 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

> Backport of [JDK-8229147](https://bugs.openjdk.org/browse/JDK-8229147). It's basically clean. There are only differences in the removed code and comments:
> 
> 
> < -GetMinStack _get_minstack_func = nullptr;
> ---
>> -GetMinStack _get_minstack_func = NULL;
> 
> 
> 
> < -                       _get_minstack_func == nullptr ? "failed" : "succeeded");
> ---
>> -                       _get_minstack_func == NULL ? "failed" : "succeeded");
> 
> 
> 
> < -  // In glibc versions prior to 2.27 the guard size mechanism
> ---
>> -  // In glibc versions prior to 2.7 the guard size mechanism
> 
> 
> 
> < -  // stack_size by the size of the guard pages to mimic proper
> ---
>> -  // stack_size by the size of the guard pages to mimick proper

Marked as reviewed by mbaesken (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk17u-dev/pull/1489#pullrequestreview-1494931805


More information about the jdk-updates-dev mailing list