[jdk17u-dev] RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v2]

[Aleksey Shipilev]

On Fri, 23 Jun 2023 13:48:54 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Remove one line more
>>  - Merge branch 'master' into JDK-8305425-thread-is-alive
>>  - Adjust comment: drop the mention of non-existent FieldHolder
>>  - Touchups to minimize the difference
>>  - Backport 35cb303a2c0c8b32de257c02e012a1928a6b4594
>
> src/hotspot/share/prims/jvm.cpp line 2979:
> 
>> 2977: 
>> 2978: 
>> 2979: 
> 
> Seems like we should better remove one empty line more (like original change).

Right! Fixed in new commit.

> src/java.base/share/classes/java/lang/Thread.java line 166:
> 
>> 164:      * non-zero when the thread is started, and reset to zero when the thread terminates.
>> 165:      * A non-zero value indicates this thread isAlive().
>> 166:      */
> 
> Shortened comment. Ok.

Yes. Mostly because FieldHolder is not in JDK 17, so mentioning it would be confusing, IMO.

-------------

PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1425#discussion_r1239898519
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1425#discussion_r1239898964