[jdk17u-dev] RFR: 8301074: Replace NULL with nullptr in share/opto/

Martin Doerr mdoerr at openjdk.org
Tue Jun 27 15:19:19 UTC 2023


On Mon, 26 Jun 2023 10:18:22 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> A lot of hunks were rejected. I replaced all remaining NULL with sed help.
> Then I checked for unwanted differences between the original patch and this one.
> E.g. in comments the change uses null, but not NULL or nullptr.
> I kept NULL in code that is not touched in the original change. 
> I do this to simplify later backports, not to clean up the code. 
> And code not touched in the original change is subject to a further
> change that is not yet backported. Leaving NULL here might simplify
> a potential backport here.
> 
> There are 3 commits:
> 1) what could be applied clean.
> 2) what I changed with sed
> 3) Cleanups: my manual edits.

Ok. The outcome of the sed script looks good. The manual edits may be a bit arbitrary, but I have nothing to complain about. Seems like to Copyright year changes were done in the original change as well. The change may help further integrations and further nullptr changes can be done later.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/1499#pullrequestreview-1501195564


More information about the jdk-updates-dev mailing list