[jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v5]

[Fei Yang]

On Tue, 27 Jun 2023 08:39:42 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - Merge branch 'master' into jep422-17u-backport
>>  - 8285630: Fix a configure error in RISC-V cross build
>>  - Adds back commit ef86ea2842b1a204834291d9d6665bfcd7b75fbc
>>  - Merge branch 'master' into jep422-17u-backport
>>  - Merge branch 'master' into jep422-17u-backport
>>  - 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051
>>  - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport
>>  - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport
>>  - 8276799: Implementation of JEP 422: Linux/RISC-V Port
>
> src/hotspot/share/c1/c1_LIR.hpp line 1695:
> 
>> 1693: };
>> 1694: 
>> 1695: #ifdef RISCV
> 
> Would you be able not to move this code? Leave it in place, so that diff is cleaner?

Hi, I am afraid that this has to come after class definition of `LIR_Op2` as class `LIR_OpBranch` extends public `LIR_Op2` for RISC-V. Otherwise, I got compile errors like:

In file included from /home/fyang/jdk17u-dev-fork/src/hotspot/share/c1/c1_Instruction.hpp:29,
                 from /home/fyang/jdk17u-dev-fork/src/hotspot/share/c1/c1_LIRGenerator.hpp:29,
                 from /home/fyang/jdk17u-dev-fork/src/hotspot/share/gc/shared/c1/barrierSetC1.cpp:27:
/home/fyang/jdk17u-dev-fork/src/hotspot/share/c1/c1_LIR.hpp:1427:28: error: invalid use of incomplete type 'class LIR_Op2'
 1427 | class LIR_OpBranch: public LIR_Op2 {
      |                            ^~~~~~~
/home/fyang/jdk17u-dev-fork/src/hotspot/share/c1/c1_LIR.hpp:868:10: note: forward declaration of 'class LIR_Op2'
  868 | class    LIR_Op2;
      |          ^~~~~~~

-------------

PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1427#discussion_r1244722733