[jdk11u-dev] RFR: 8244078: ProcessTools executeTestJvm and createJavaProcessBuilder have inconsistent handling of test.*.opts [v3]

[Lutz Schmidt]

On Thu, 29 Jun 2023 12:48:17 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> I backport this for parity with 11.0.20-oracle.
>> 
>> A row of files are not in 11 or have been moved. 
>> Some trivial resolves were necessary.
>> An extra commit fixes the remaining occurances.
>> 
>> test/hotspot/jtreg/compiler/graalunit/common/GraalUnitTestLauncher.java
>> Context
>> 
>> not in 11: test/hotspot/jtreg/gc/logging/TestMetaSpaceLog.java
>> not in 11: test/hotspot/jtreg/gc/nvdimm/TestAllocateOldGenAt.java
>> not in 11: test/hotspot/jtreg/gc/nvdimm/TestAllocateOldGenAtError.java
>> not in 11: test/hotspot/jtreg/gc/nvdimm/TestAllocateOldGenAtMultiple.java
>> not in 11: test/hotspot/jtreg/gc/nvdimm/TestHumongousObjectsOnNvdimm.java
>> not in 11: test/hotspot/jtreg/gc/nvdimm/TestOldObjectsOnNvdimm.java
>> not in 11: test/hotspot/jtreg/gc/nvdimm/TestYoungObjectsOnDram.java
>> 
>> test/hotspot/jtreg/runtime/7162488/TestUnrecognizedVmOption.java
>> Later change undoes this, and is already backported (8247741). Skipped.
>> 
>> not in 11: test/hotspot/jtreg/runtime/InvocationTests/invocationC1Tests.java
>> not in 11: test/hotspot/jtreg/runtime/InvocationTests/invocationGraalTests.java
>> not in 11: test/hotspot/jtreg/runtime/InvocationTests/invokeinterfaceTests.java
>> not in 11: test/hotspot/jtreg/runtime/InvocationTests/invokespecialTests.java
>> not in 11: test/hotspot/jtreg/runtime/InvocationTests/invokevirtualTests.java
>> 
>> not in 11: test/hotspot/jtreg/runtime/cds/SharedArchiveFile.java
>> not in 11: test/hotspot/jtreg/runtime/cds/appcds/DumpClassList.java
>> not in 11: test/hotspot/jtreg/runtime/cds/appcds/GraalWithLimitedMetaspace.java
>> not in 11: test/hotspot/jtreg/runtime/cds/appcds/TestCommon.java
>> not in 11: test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/DynamicArchiveTestBase.java
>> not in 11: test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/NoClassToArchive.java
>> not in 11: test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/SharedStringsBasic.java
>> not in 11: test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/SysDictCrash.java
>> 
>> test/hotspot/jtreg/runtime/handshake/HandshakeTransitionTest.java
>> Context
>> 
>> test/hotspot/jtreg/serviceability/logging/TestLogRotation.java
>> Extra empty line.
>> 
>> test/hotspot/jtreg/serviceability/sa/TestJmapCore.java
>> Context.
>> 
>> not in 11: test/jdk/java/lang/RuntimeTests/shutdown/ShutdownInterruptedMain.java
>> not in 11: test/jdk/jdk/jfr/api/consumer/streaming/TestCrossProcessStreaming.java
>> not in 11: test/jdk/jdk/jfr/api/consumer/streaming/TestProcess.java
>> not in 11: test/jdk/jdk/jfr/event/runtime/...
>
> Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Needed corrections

LGTM.
In the future, we may want to think twice before we backport enhancements with such widespread reach.

-------------

Marked as reviewed by lucy (Reviewer).

PR Review: https://git.openjdk.org/jdk11u-dev/pull/2000#pullrequestreview-1507010095