From duke at openjdk.org Wed Mar 1 06:26:24 2023 From: duke at openjdk.org (PoojaDP-23) Date: Wed, 1 Mar 2023 06:26:24 GMT Subject: [jdk11u-dev] RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers In-Reply-To: References: Message-ID: On Wed, 15 Feb 2023 13:37:34 GMT, Dalibor Topic wrote: >> This is a backport request and this fix is a dependency for [8293562](https://github.com/openjdk/jdk/commit/03f25a9c6924430ec4063b801b2b6ca55b9067c9). >> >> This is a fix that upgrades the old HTTP and HTTPS legacy stack to use virtual-thread friendly locking instead of synchronized monitors. >> >> We have removed @java.io.serial in AuthenticationInfo.java since the serial.class file not located. > > Hi, please send an e-mail to Dalibor.Topic at oracle.com so that I can mark your account as verified in Skara. @robilad - Earlier Workflows aren't being run on this forked repository because it was not enabled. Now I have enabled the workflow but still tests are not running on my fork. Could you please let me know what action needs to be done by myside? Thanks ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1710 From mbaesken at openjdk.org Wed Mar 1 07:49:17 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 1 Mar 2023 07:49:17 GMT Subject: [jdk11u-dev] RFR: 8235448: code cleanup in SSLContextImpl.java [v2] In-Reply-To: References: Message-ID: <6QD26z17wrah7CVHeSkIj9twC4coSGBnlAg92b5w1C8=.b1491add-7529-48f2-bd7a-845dfe97b204@github.com> On Tue, 28 Feb 2023 11:56:44 GMT, Goetz Lindenmaier wrote: >> I backport this as preparation for 8190492. >> >> I had to resolve, because in 11 FIPS support is still implemented. But it's trivial cut&paste. > > Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport baebce3d2f996cf2731be8c5d387e709f1213d30 Marked as reviewed by mbaesken (Reviewer). ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1781 From clanger at openjdk.org Wed Mar 1 08:16:23 2023 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 1 Mar 2023 08:16:23 GMT Subject: [jdk11u-dev] RFR: JDK-8302000: [11u] A subtle race condition during jdk11u build [v3] In-Reply-To: References: <1qnQp8MoGgnKOpFrSVc7zSMW_gZdoyKknq7vuyUbB44=.769b3d76-c7ea-4d66-a4af-8d914aa5aae7@github.com> Message-ID: On Tue, 28 Feb 2023 01:08:51 GMT, Kumar Srinivasan wrote: >> Hi, >> >> **This is to fix issue caused by:** >> JDK-8257679: Improved unix compatibility layer in Windows build (winenv) >> Please refer to JDK-8302000 for the evaluation of how the above causes the race condition. >> >> The changes below are in an effort to make the existing jdk11u source more robust and closer to the upstream code. >> >> **Initial Spp.java changes:** >> JDK-8215445: Enable building for Windows in WSL >> https://github.com/openjdk/jdk/compare/88b95f05706..46eb26b692a >> >> _Note: Too large to be back-ported, only changes for Spp.java associated build logic >> changes needs to be back-ported manually._ >> >> **Required additional make logic adjustments required for Spp.java changes:** >> JDK-8218460: https://github.com/openjdk/jdk/compare/1fcbd0cd0dc..f380787a41e >> >> _Note: patch does not apply cleanly and all the changes have to be applied manually._ >> >> **Optional, Spp.java Improvements:** >> JDK-8223347: Integration of Vector API (Incubator) >> https://github.com/openjdk/jdk/compare/386e7e8b733..0c99b192588 >> >> _Note: Clearly the entire commit is totally inapplicable to jdk11u, since it is an Incubator feature, >> however small improvement to Spp.java can be back-ported manually, in an effort to bring jdk11u >> sources closer to upstream_ >> >> If the above solutions are not acceptable, then I could add parenthesis to the ExecutWithLog call-sites, however >> this will further diverge the jdk11u code base from upstream. >> >> If none of the above solutions are acceptable then I recommend the jdk11u maintainers assign JDK-8302000 to >> the author of JDK-8257679 and have them remove the ExecuteWithLog additions. >> >> I personally have tested the fix using tier1 and tier2 regression testing on both Windows and Linux. > > Kumar Srinivasan has updated the pull request incrementally with one additional commit since the last revision: > > JDK-8302000: A subtle race condition during jdk11u build - 002 SAP nightlies passed. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1774 From clanger at openjdk.org Wed Mar 1 08:18:17 2023 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 1 Mar 2023 08:18:17 GMT Subject: [jdk11u-dev] RFR: 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption [v4] In-Reply-To: References: Message-ID: On Tue, 28 Feb 2023 19:47:56 GMT, Scott Gibbons wrote: >> Backporting because this change results in ~3x performance improvement in AES-CTR. >> >> Risk is low. Tested with tier1 and benchmark. >> >> The PR does not backport cleanly. The buffer name was changed, but functionally remains the same. > > Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision: > > Fixed bad merge Hm after your merges the resulting change looks incorrect. ------------- Changes requested by clanger (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1780 From clanger at openjdk.org Wed Mar 1 08:34:18 2023 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 1 Mar 2023 08:34:18 GMT Subject: [jdk11u-dev] RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers In-Reply-To: References: Message-ID: On Wed, 15 Feb 2023 13:37:34 GMT, Dalibor Topic wrote: >> This is a backport request and this fix is a dependency for [8293562](https://github.com/openjdk/jdk/commit/03f25a9c6924430ec4063b801b2b6ca55b9067c9). >> >> This is a fix that upgrades the old HTTP and HTTPS legacy stack to use virtual-thread friendly locking instead of synchronized monitors. >> >> We have removed @java.io.serial in AuthenticationInfo.java since the serial.class file not located. > > Hi, please send an e-mail to Dalibor.Topic at oracle.com so that I can mark your account as verified in Skara. > @robilad - Earlier Workflows aren't being run on this forked repository because it was not enabled. Now I have enabled the workflow but still tests are not running on my fork. Could you please let me know what action needs to be done by myside? Thanks Hi @PoojaDP-23, I guess the easiest way to get current GHA checks is to merge your branch with current master of [jdk11u-dev](https://github.com/openjdk/jdk11u-dev) and push it. This will trigger a run with the most current code. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1710 From goetz at openjdk.org Wed Mar 1 09:39:05 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 1 Mar 2023 09:39:05 GMT Subject: [jdk11u-dev] RFR: 8303432: Bump update version for OpenJDK: jdk-11.0.20 Message-ID: The version bump needed for 11.0.20 ------------- Commit messages: - 8303432: Bump update version for OpenJDK: jdk-11.0.20 Changes: https://git.openjdk.org/jdk11u-dev/pull/1785/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1785&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303432 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1785.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1785/head:pull/1785 PR: https://git.openjdk.org/jdk11u-dev/pull/1785 From goetz at openjdk.org Wed Mar 1 09:43:04 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 1 Mar 2023 09:43:04 GMT Subject: [jdk17u-dev] RFR: 8303433: Bump update version for OpenJDK: jdk-17.0.8 Message-ID: The required version bump for 17.0.8 ------------- Commit messages: - 8303433: Bump update version for OpenJDK: jdk-17.0.8 Changes: https://git.openjdk.org/jdk17u-dev/pull/1194/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1194&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303433 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1194.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1194/head:pull/1194 PR: https://git.openjdk.org/jdk17u-dev/pull/1194 From goetz at openjdk.org Wed Mar 1 13:00:07 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 1 Mar 2023 13:00:07 GMT Subject: [jdk17u-dev] RFR: 8048190: NoClassDefFoundError omits original ExceptionInInitializerError Message-ID: <49dejqOFd_BCsxLBjuDHcBMOcmWUQXxs1YYsusCqZlA=.30ef5cd0-0f3e-4b41-9fb8-a47d93179021@github.com> I backport this for parity with 17.0.7-oracle. I had to adapt the declaration of _initialization_error_table because "8270061: Change parameter order of ResourceHashtable" is not in 17. ------------- Commit messages: - Backport 464e874a5c6b46fcc729227764d07feb1801314d Changes: https://git.openjdk.org/jdk17u-dev/pull/1195/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1195&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8048190 Stats: 263 lines in 9 files changed: 250 ins; 3 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1195.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1195/head:pull/1195 PR: https://git.openjdk.org/jdk17u-dev/pull/1195 From duke at openjdk.org Wed Mar 1 13:26:56 2023 From: duke at openjdk.org (Stewart X Addison) Date: Wed, 1 Mar 2023 13:26:56 GMT Subject: [jdk11u] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 Message-ID: <4AHs2pGtXOaEt-npiiVqOddqqBM0O_x2hobpVIrQJHc=.778309fc-350e-4975-a1d8-5642f5c738e5@github.com> Backporting zlib 1.2.13 from JDK17u due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) Verified on Windows which is generally the only platform I use which uses bundled zlib. This makes the `zlib` directory in the source identical to the one for JDK17u so should not cause any problems. I'll look at the feasibility of doing the same to JDK8 too. ------------- Commit messages: - Backport 6042c6b9bbacbff1bd47f087f0f19646a20eef97 Changes: https://git.openjdk.org/jdk11u/pull/69/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u&pr=69&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295530 Stats: 11195 lines in 24 files changed: 9975 ins; 274 del; 946 mod Patch: https://git.openjdk.org/jdk11u/pull/69.diff Fetch: git fetch https://git.openjdk.org/jdk11u pull/69/head:pull/69 PR: https://git.openjdk.org/jdk11u/pull/69 From duke at openjdk.org Wed Mar 1 13:37:16 2023 From: duke at openjdk.org (Stewart X Addison) Date: Wed, 1 Mar 2023 13:37:16 GMT Subject: [jdk11u] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 In-Reply-To: <4AHs2pGtXOaEt-npiiVqOddqqBM0O_x2hobpVIrQJHc=.778309fc-350e-4975-a1d8-5642f5c738e5@github.com> References: <4AHs2pGtXOaEt-npiiVqOddqqBM0O_x2hobpVIrQJHc=.778309fc-350e-4975-a1d8-5642f5c738e5@github.com> Message-ID: On Wed, 1 Mar 2023 13:19:20 GMT, Stewart X Addison wrote: > Backporting zlib 1.2.13 from JDK17u due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) > Verified on Windows which is generally the only platform I use which uses bundled zlib. This makes the `zlib` directory in the source identical to the one for JDK17u so should not cause any problems. I'll look at the feasibility of doing the same to JDK8 too. Cancelling as it's not targetted at the dev branch. ------------- PR: https://git.openjdk.org/jdk11u/pull/69 From duke at openjdk.org Wed Mar 1 13:37:17 2023 From: duke at openjdk.org (Stewart X Addison) Date: Wed, 1 Mar 2023 13:37:17 GMT Subject: [jdk11u] Withdrawn: 8295530: Update Zlib Data Compression Library to Version 1.2.13 In-Reply-To: <4AHs2pGtXOaEt-npiiVqOddqqBM0O_x2hobpVIrQJHc=.778309fc-350e-4975-a1d8-5642f5c738e5@github.com> References: <4AHs2pGtXOaEt-npiiVqOddqqBM0O_x2hobpVIrQJHc=.778309fc-350e-4975-a1d8-5642f5c738e5@github.com> Message-ID: On Wed, 1 Mar 2023 13:19:20 GMT, Stewart X Addison wrote: > Backporting zlib 1.2.13 from JDK17u due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) > Verified on Windows which is generally the only platform I use which uses bundled zlib. This makes the `zlib` directory in the source identical to the one for JDK17u so should not cause any problems. I'll look at the feasibility of doing the same to JDK8 too. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u/pull/69 From zzambers at openjdk.org Wed Mar 1 14:09:16 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 1 Mar 2023 14:09:16 GMT Subject: [jdk11u-dev] RFR: 8289301: P11Cipher should not throw out of bounds exception during padding Message-ID: Fix for possible OOB exception by P11Cipher. Backported from [jdk17u-dev](https://github.com/openjdk/jdk17u-dev/commit/2f7e673f521a707d7be7b83efe73df2010d36206). Testing: [Passed jdk_security.](https://github.com/zzambers/jdk-tester/actions/runs/4293705819) ------------- Commit messages: - Backport 2f7e673f521a707d7be7b83efe73df2010d36206 Changes: https://git.openjdk.org/jdk11u-dev/pull/1786/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1786&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289301 Stats: 124 lines in 2 files changed: 117 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1786.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1786/head:pull/1786 PR: https://git.openjdk.org/jdk11u-dev/pull/1786 From goetz at openjdk.org Wed Mar 1 14:47:23 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 1 Mar 2023 14:47:23 GMT Subject: [jdk11u-dev] Integrated: 8235448: code cleanup in SSLContextImpl.java In-Reply-To: References: Message-ID: On Tue, 28 Feb 2023 09:23:31 GMT, Goetz Lindenmaier wrote: > I backport this as preparation for 8190492. > > I had to resolve, because in 11 FIPS support is still implemented. But it's trivial cut&paste. This pull request has now been integrated. Changeset: 15bdc4dc Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/15bdc4dcc49b51b95ffe97cae552f5db09860441 Stats: 77 lines in 1 file changed: 32 ins; 42 del; 3 mod 8235448: code cleanup in SSLContextImpl.java Reviewed-by: mbaesken Backport-of: baebce3d2f996cf2731be8c5d387e709f1213d30 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1781 From goetz at openjdk.org Wed Mar 1 14:49:17 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 1 Mar 2023 14:49:17 GMT Subject: [jdk11u-dev] Integrated: 8290197: test/jdk/java/nio/file/Files/probeContentType/Basic.java fails on some systems for the ".rar" extension In-Reply-To: References: Message-ID: On Tue, 28 Feb 2023 14:38:09 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.19-oracle. This pull request has now been integrated. Changeset: bd9c2fb3 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/bd9c2fb38532014b4896569d43f7ba2c2ab42bd7 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8290197: test/jdk/java/nio/file/Files/probeContentType/Basic.java fails on some systems for the ".rar" extension Backport-of: 44fb92e2aa8a708b94c568e3d39217cb4c39f6bf ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1783 From goetz at openjdk.org Wed Mar 1 14:50:11 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 1 Mar 2023 14:50:11 GMT Subject: [jdk17u-dev] Integrated: 8290197: test/jdk/java/nio/file/Files/probeContentType/Basic.java fails on some systems for the ".rar" extension In-Reply-To: References: Message-ID: On Tue, 28 Feb 2023 14:36:20 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. This pull request has now been integrated. Changeset: 7b967bf6 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/7b967bf66f37a671c7db3e0e25e5e00ffdc1c5f8 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8290197: test/jdk/java/nio/file/Files/probeContentType/Basic.java fails on some systems for the ".rar" extension Backport-of: 44fb92e2aa8a708b94c568e3d39217cb4c39f6bf ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1189 From erikj at openjdk.org Wed Mar 1 14:57:29 2023 From: erikj at openjdk.org (Erik Joelsson) Date: Wed, 1 Mar 2023 14:57:29 GMT Subject: [jdk11u-ri] Integrated: 8223464: Improve version string for Oracle CI builds In-Reply-To: References: Message-ID: On Tue, 28 Feb 2023 20:43:18 GMT, Erik Joelsson wrote: > Backport the Oracle CI version modifications needed to promote from CI builds. The patch is almost clean. Since the RI release will never go through an early access stage, the default $PRE string is set to empty instead of ea. > > Will followup with https://bugs.openjdk.org/browse/JDK-8223627. This pull request has now been integrated. Changeset: 4cb8f625 Author: Erik Joelsson URL: https://git.openjdk.org/jdk11u-ri/commit/4cb8f625fd3208796db4830dedc9f3d679fb1521 Stats: 12 lines in 2 files changed: 9 ins; 2 del; 1 mod 8223464: Improve version string for Oracle CI builds Reviewed-by: lancea Backport-of: 9e2784b24f633ab93fdae218c3266b1bde6f5bca ------------- PR: https://git.openjdk.org/jdk11u-ri/pull/6 From goetz at openjdk.org Wed Mar 1 15:03:54 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 1 Mar 2023 15:03:54 GMT Subject: [jdk11u-dev] RFR: 8190492: Remove SSLv2Hello and SSLv3 from default enabled TLS protocols Message-ID: I backport this for parity with 11.0.19-oracle. At least we found the corresponding CSR, the backport seems to be closed. I had to adapt the code as 11 implements FIPS. ------------- Commit messages: - Backport 5fc46f3c50a4b04808f1741a3f6e7a768b206cef Changes: https://git.openjdk.org/jdk11u-dev/pull/1787/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1787&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8190492 Stats: 226 lines in 13 files changed: 60 ins; 17 del; 149 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1787.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1787/head:pull/1787 PR: https://git.openjdk.org/jdk11u-dev/pull/1787 From erikj at openjdk.org Wed Mar 1 15:04:43 2023 From: erikj at openjdk.org (Erik Joelsson) Date: Wed, 1 Mar 2023 15:04:43 GMT Subject: [jdk11u-ri] RFR: 8223627: jdk-13+20 bundle name contains null instead of ea [v2] In-Reply-To: References: Message-ID: > Clean backport of followup fix for https://bugs.openjdk.org/browse/JDK-8223464. Erik Joelsson has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-ri/pull/7/files - new: https://git.openjdk.org/jdk11u-ri/pull/7/files/a509b5bf..a509b5bf Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-ri&pr=7&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-ri&pr=7&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-ri/pull/7.diff Fetch: git fetch https://git.openjdk.org/jdk11u-ri pull/7/head:pull/7 PR: https://git.openjdk.org/jdk11u-ri/pull/7 From erikj at openjdk.org Wed Mar 1 15:17:01 2023 From: erikj at openjdk.org (Erik Joelsson) Date: Wed, 1 Mar 2023 15:17:01 GMT Subject: [jdk11u-ri] RFR: 8223627: jdk-13+20 bundle name contains null instead of ea [v3] In-Reply-To: References: Message-ID: > Clean backport of followup fix for https://bugs.openjdk.org/browse/JDK-8223464. Erik Joelsson has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into JDK-8223627-ea - JDK-8223627 - JDK-8236589 ------------- Changes: - all: https://git.openjdk.org/jdk11u-ri/pull/7/files - new: https://git.openjdk.org/jdk11u-ri/pull/7/files/a509b5bf..06d990f4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-ri&pr=7&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-ri&pr=7&range=01-02 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-ri/pull/7.diff Fetch: git fetch https://git.openjdk.org/jdk11u-ri pull/7/head:pull/7 PR: https://git.openjdk.org/jdk11u-ri/pull/7 From erikj at openjdk.org Wed Mar 1 15:17:02 2023 From: erikj at openjdk.org (Erik Joelsson) Date: Wed, 1 Mar 2023 15:17:02 GMT Subject: [jdk11u-ri] Integrated: 8223627: jdk-13+20 bundle name contains null instead of ea In-Reply-To: References: Message-ID: On Tue, 28 Feb 2023 21:02:22 GMT, Erik Joelsson wrote: > Clean backport of followup fix for https://bugs.openjdk.org/browse/JDK-8223464. This pull request has now been integrated. Changeset: 9cedc07c Author: Erik Joelsson URL: https://git.openjdk.org/jdk11u-ri/commit/9cedc07c939e13c65558743888708c52cbabf7eb Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8223627: jdk-13+20 bundle name contains null instead of ea Reviewed-by: lancea Backport-of: d8f7a41216789c62d518c4fe33f0fab051a4cf7a ------------- PR: https://git.openjdk.org/jdk11u-ri/pull/7 From duke at openjdk.org Wed Mar 1 15:21:42 2023 From: duke at openjdk.org (Stewart X Addison) Date: Wed, 1 Mar 2023 15:21:42 GMT Subject: [jdk11u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 Message-ID: Backporting zlib 1.2.13 from JDK17u due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) Tested on Windows which is generally the only platform I use which uses bundled zlib. This makes the `zlib` directory in the source identical to the one for JDK17u so should not cause any problems. I'll look at the feasibility of doing the same on JDK8 too. Reviewed-by: alanb, jpai ------------- Commit messages: - 8295530: Update Zlib Data Compression Library to Version 1.2.13 Changes: https://git.openjdk.org/jdk11u-dev/pull/1788/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1788&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295530 Stats: 11195 lines in 24 files changed: 9975 ins; 274 del; 946 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1788.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1788/head:pull/1788 PR: https://git.openjdk.org/jdk11u-dev/pull/1788 From phh at openjdk.org Wed Mar 1 17:03:26 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 1 Mar 2023 17:03:26 GMT Subject: [jdk17u-dev] RFR: 8048190: NoClassDefFoundError omits original ExceptionInInitializerError In-Reply-To: <49dejqOFd_BCsxLBjuDHcBMOcmWUQXxs1YYsusCqZlA=.30ef5cd0-0f3e-4b41-9fb8-a47d93179021@github.com> References: <49dejqOFd_BCsxLBjuDHcBMOcmWUQXxs1YYsusCqZlA=.30ef5cd0-0f3e-4b41-9fb8-a47d93179021@github.com> Message-ID: On Wed, 1 Mar 2023 12:54:11 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. > > I had to adapt the declaration of _initialization_error_table because "8270061: Change parameter order of ResourceHashtable" is not in 17. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/1195 From mikael at openjdk.org Wed Mar 1 18:10:51 2023 From: mikael at openjdk.org (Mikael Vidstedt) Date: Wed, 1 Mar 2023 18:10:51 GMT Subject: [jdk20u] RFR: 8303412: Update linux_x64-to-linux_aarch64 cross compilation devkit at Oracle Message-ID: Backporting fix from mainline. Did not apply cleanly because a neighboring line had been changed. ------------- Commit messages: - Backport 65da2c5d2dfea30e7d00b8f907f7abb5f6f887df Changes: https://git.openjdk.org/jdk20u/pull/10/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=10&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303412 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk20u/pull/10.diff Fetch: git fetch https://git.openjdk.org/jdk20u pull/10/head:pull/10 PR: https://git.openjdk.org/jdk20u/pull/10 From sgibbons at openjdk.org Wed Mar 1 19:09:45 2023 From: sgibbons at openjdk.org (Scott Gibbons) Date: Wed, 1 Mar 2023 19:09:45 GMT Subject: [jdk11u-dev] RFR: 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption [v5] In-Reply-To: References: Message-ID: > Backporting because this change results in ~3x performance improvement in AES-CTR. > > Risk is low. Tested with tier1 and benchmark. > > The PR does not backport cleanly. The buffer name was changed, but functionally remains the same. Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision: Fix initialization of offset ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1780/files - new: https://git.openjdk.org/jdk11u-dev/pull/1780/files/6d375967..a4a93c50 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1780&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1780&range=03-04 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1780.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1780/head:pull/1780 PR: https://git.openjdk.org/jdk11u-dev/pull/1780 From phh at openjdk.org Wed Mar 1 20:30:18 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 1 Mar 2023 20:30:18 GMT Subject: [jdk11u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 In-Reply-To: References: Message-ID: On Wed, 1 Mar 2023 15:12:34 GMT, Stewart X Addison wrote: > Backporting zlib 1.2.13 from JDK17u due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) > Tested on Windows which is generally the only platform I use which uses bundled zlib. This makes the `zlib` directory in the source identical to the one for JDK17u so should not cause any problems. I'll look at the feasibility of doing the same on JDK8 too. > > Reviewed-by: alanb, jpai What did your testing consist of? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1788 From phh at openjdk.org Wed Mar 1 20:37:41 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 1 Mar 2023 20:37:41 GMT Subject: [jdk11u-dev] RFR: 8190492: Remove SSLv2Hello and SSLv3 from default enabled TLS protocols In-Reply-To: References: Message-ID: On Wed, 1 Mar 2023 14:55:25 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.19-oracle. At least we found the corresponding CSR, the backport seems to be closed. > > I had to adapt the code as 11 implements FIPS. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1787 From goetz at openjdk.org Wed Mar 1 21:17:18 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 1 Mar 2023 21:17:18 GMT Subject: [jdk17u-dev] RFR: 8048190: NoClassDefFoundError omits original ExceptionInInitializerError In-Reply-To: <49dejqOFd_BCsxLBjuDHcBMOcmWUQXxs1YYsusCqZlA=.30ef5cd0-0f3e-4b41-9fb8-a47d93179021@github.com> References: <49dejqOFd_BCsxLBjuDHcBMOcmWUQXxs1YYsusCqZlA=.30ef5cd0-0f3e-4b41-9fb8-a47d93179021@github.com> Message-ID: On Wed, 1 Mar 2023 12:54:11 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. > > I had to adapt the declaration of _initialization_error_table because "8270061: Change parameter order of ResourceHashtable" is not in 17. Pre submit failure: Error: make: Failed to download resource "make_bottle_manifest" infra problem, unrelated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1195 From goetz at openjdk.org Wed Mar 1 21:23:44 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 1 Mar 2023 21:23:44 GMT Subject: [jdk17u-dev] RFR: 8048190: NoClassDefFoundError omits original ExceptionInInitializerError [v2] In-Reply-To: <49dejqOFd_BCsxLBjuDHcBMOcmWUQXxs1YYsusCqZlA=.30ef5cd0-0f3e-4b41-9fb8-a47d93179021@github.com> References: <49dejqOFd_BCsxLBjuDHcBMOcmWUQXxs1YYsusCqZlA=.30ef5cd0-0f3e-4b41-9fb8-a47d93179021@github.com> Message-ID: > I backport this for parity with 17.0.7-oracle. > > I had to adapt the declaration of _initialization_error_table because "8270061: Change parameter order of ResourceHashtable" is not in 17. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into goetz_backport_8048190 - Backport 464e874a5c6b46fcc729227764d07feb1801314d ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1195/files - new: https://git.openjdk.org/jdk17u-dev/pull/1195/files/4cee8df5..d799bbfb Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1195&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1195&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1195.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1195/head:pull/1195 PR: https://git.openjdk.org/jdk17u-dev/pull/1195 From duke at openjdk.org Wed Mar 1 22:18:29 2023 From: duke at openjdk.org (Autumn Capasso) Date: Wed, 1 Mar 2023 22:18:29 GMT Subject: [jdk11u-dev] Withdrawn: 8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles In-Reply-To: References: Message-ID: On Thu, 2 Feb 2023 02:58:48 GMT, Autumn Capasso wrote: > Clean backport [JDK-8264299](https://bugs.openjdk.org/browse/JDK-8264299) This backport is part of the 28 backport Accessibility series [JDK-8152350](https://bugs.openjdk.org/browse/JDK-8152350). This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1704 From sgibbons at openjdk.org Wed Mar 1 22:20:15 2023 From: sgibbons at openjdk.org (Scott Gibbons) Date: Wed, 1 Mar 2023 22:20:15 GMT Subject: [jdk11u-dev] RFR: 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption In-Reply-To: References: Message-ID: On Tue, 28 Feb 2023 15:22:26 GMT, Christoph Langer wrote: >> Noob here - what is GHA? > >> Noob here - what is GHA? > > GHA= GitHub Actions. You have to enable it in your [repository fork](https://github.com/asgibbons/jdk11u-dev/actions). Then you will also be able to trigger the run for your PR branch. @RealCLanger - Sorry for the churn. I had a slight mixup in the myriad of JDK trees I'm concurrently maintaining. I fixed the issue and manual testing along with tier1 testing have successfully completed. Please review and approve if this is acceptable. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1780 From duke at openjdk.org Wed Mar 1 23:04:32 2023 From: duke at openjdk.org (Autumn Capasso) Date: Wed, 1 Mar 2023 23:04:32 GMT Subject: [jdk11u-dev] RFR: 8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles Message-ID: backport JDK-8264299 This backport is part of the 28 backport Accessibility series JDK-8152350. Commented out line 61 of commoneComponentAccesssibilty.m untill backoport JDK-8262981 is reworked and submitted Slider and AWT components all tested using UI and work. ------------- Commit messages: - Backport 6c107fdff289cc553df12ee10b0c8002b84059b2 Changes: https://git.openjdk.org/jdk11u-dev/pull/1791/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1791&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8264299 Stats: 368 lines in 7 files changed: 246 ins; 121 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1791.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1791/head:pull/1791 PR: https://git.openjdk.org/jdk11u-dev/pull/1791 From mbaesken at openjdk.org Thu Mar 2 10:37:24 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 2 Mar 2023 10:37:24 GMT Subject: [jdk11u-dev] RFR: 8190492: Remove SSLv2Hello and SSLv3 from default enabled TLS protocols In-Reply-To: References: Message-ID: On Wed, 1 Mar 2023 14:55:25 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.19-oracle. At least we found the corresponding CSR, the backport seems to be closed. > > I had to adapt the code as 11 implements FIPS. Marked as reviewed by mbaesken (Reviewer). Hi G?tz , looks like there is a comment missing in SSLContextImpl.java (last part of the diffs in the file) // default server protocols Otherwise looks okay . ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1787 From duke at openjdk.org Thu Mar 2 11:46:21 2023 From: duke at openjdk.org (Stewart X Addison) Date: Thu, 2 Mar 2023 11:46:21 GMT Subject: [jdk11u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 In-Reply-To: References: Message-ID: On Wed, 1 Mar 2023 20:27:53 GMT, Paul Hohensee wrote: >> Backporting zlib 1.2.13 from JDK17u due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) >> Tested on Windows which is generally the only platform I use which uses bundled zlib. This makes the `zlib` directory in the source identical to the one for JDK17u so should not cause any problems. I'll look at the feasibility of doing the same on JDK8 too. >> >> Reviewed-by: alanb, jpai > > What did your testing consist of? @phohensee I've run through the tier1 tests on Windows ([results here](https://ci.adoptium.net/job/Test_openjdk11_hs_sanity.openjdk_x86-64_windows/729/testReport/)) plus verified with some of the compression related tests from the TCK. Since this is likely to be relatively low risk and is already in 17 and we typically build without the in-tree zlib on other platforms I felt that was adequate. If you want me to run more exhaustive testing let me know. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1788 From phh at openjdk.org Thu Mar 2 14:02:20 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 2 Mar 2023 14:02:20 GMT Subject: [jdk11u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 In-Reply-To: References: Message-ID: <60djLj_74jARQeK4LOEITbzAOi26S6ecF2dBE0Aim6c=.572acba3-52bf-49e6-b637-9a63fa84cf4b@github.com> On Wed, 1 Mar 2023 15:12:34 GMT, Stewart X Addison wrote: > Backporting zlib 1.2.13 from JDK17u due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) > Tested on Windows which is generally the only platform I use which uses bundled zlib. This makes the `zlib` directory in the source identical to the one for JDK17u so should not cause any problems. I'll look at the feasibility of doing the same on JDK8 too. > > Reviewed-by: alanb, jpai Thanks for the test details. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1788 From phh at openjdk.org Thu Mar 2 16:33:39 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 2 Mar 2023 16:33:39 GMT Subject: [jdk11u-dev] RFR: 8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles In-Reply-To: References: Message-ID: On Wed, 1 Mar 2023 22:57:02 GMT, Autumn Capasso wrote: > backport JDK-8264299 This backport is part of the 28 backport Accessibility series JDK-8152350. Commented out line 61 of commoneComponentAccesssibilty.m untill backoport JDK-8262981 is reworked and submitted Slider and AWT components all tested using UI and work. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1791 From mbaesken at openjdk.org Thu Mar 2 16:48:13 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 2 Mar 2023 16:48:13 GMT Subject: [jdk11u-dev] RFR: 8299520: TestPrintXML.java output error messages in case compare fails In-Reply-To: <-CFh1m2FsxiztxHPCGqB6EOTocdoT3ALOVxfh7VnIaw=.2080aaaf-12fd-406c-8cff-7d80368faee3@github.com> References: <-CFh1m2FsxiztxHPCGqB6EOTocdoT3ALOVxfh7VnIaw=.2080aaaf-12fd-406c-8cff-7d80368faee3@github.com> Message-ID: On Fri, 24 Feb 2023 08:26:29 GMT, Matthias Baesken wrote: > 8299520: TestPrintXML.java output error messages in case compare fails unrelated error in pre submit linux-x64 test , getting apache-ant-1.10.8-bin.zip failed for some reason. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1770 From mbaesken at openjdk.org Thu Mar 2 16:48:14 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 2 Mar 2023 16:48:14 GMT Subject: [jdk11u-dev] Integrated: 8299520: TestPrintXML.java output error messages in case compare fails In-Reply-To: <-CFh1m2FsxiztxHPCGqB6EOTocdoT3ALOVxfh7VnIaw=.2080aaaf-12fd-406c-8cff-7d80368faee3@github.com> References: <-CFh1m2FsxiztxHPCGqB6EOTocdoT3ALOVxfh7VnIaw=.2080aaaf-12fd-406c-8cff-7d80368faee3@github.com> Message-ID: On Fri, 24 Feb 2023 08:26:29 GMT, Matthias Baesken wrote: > 8299520: TestPrintXML.java output error messages in case compare fails This pull request has now been integrated. Changeset: 2405ca61 Author: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/2405ca61a3179d5f8f4d3ce60ca878c82f33cc07 Stats: 12 lines in 1 file changed: 11 ins; 0 del; 1 mod 8299520: TestPrintXML.java output error messages in case compare fails Backport-of: ea25a561c57cba63c5581aefa21f92ffd7386244 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1770 From ccheung at openjdk.org Thu Mar 2 17:10:16 2023 From: ccheung at openjdk.org (Calvin Cheung) Date: Thu, 2 Mar 2023 17:10:16 GMT Subject: [jdk20u] RFR: 8278965: crash in SymbolTable::do_lookup Message-ID: Other than a minor conflict in systemDictionary.cpp, the backport is the same as the original fix. ------------- Commit messages: - Backport 582b943439488a0f43482b67c0bc0d4975bf4023 Changes: https://git.openjdk.org/jdk20u/pull/11/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=11&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8278965 Stats: 120 lines in 3 files changed: 117 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk20u/pull/11.diff Fetch: git fetch https://git.openjdk.org/jdk20u pull/11/head:pull/11 PR: https://git.openjdk.org/jdk20u/pull/11 From fparain at openjdk.org Thu Mar 2 17:35:28 2023 From: fparain at openjdk.org (Frederic Parain) Date: Thu, 2 Mar 2023 17:35:28 GMT Subject: [jdk20u] RFR: 8278965: crash in SymbolTable::do_lookup In-Reply-To: References: Message-ID: <1wCjI1DO3aWi1MN6mPWrDakgIpipF3oSC-gMupnSTLg=.819a0c7e-e3a9-4e1d-84eb-c7bef90af1b2@github.com> On Thu, 2 Mar 2023 17:02:39 GMT, Calvin Cheung wrote: > Other than a minor conflict in systemDictionary.cpp, the backport is the same as the original fix. Looks good to me. ------------- Marked as reviewed by fparain (Committer). PR: https://git.openjdk.org/jdk20u/pull/11 From ccheung at openjdk.org Thu Mar 2 17:49:17 2023 From: ccheung at openjdk.org (Calvin Cheung) Date: Thu, 2 Mar 2023 17:49:17 GMT Subject: [jdk20u] RFR: 8278965: crash in SymbolTable::do_lookup In-Reply-To: <1wCjI1DO3aWi1MN6mPWrDakgIpipF3oSC-gMupnSTLg=.819a0c7e-e3a9-4e1d-84eb-c7bef90af1b2@github.com> References: <1wCjI1DO3aWi1MN6mPWrDakgIpipF3oSC-gMupnSTLg=.819a0c7e-e3a9-4e1d-84eb-c7bef90af1b2@github.com> Message-ID: <5VXoeqHKKKERotc5mII-Xd1hO_NDSvM14qTaRqktY3g=.e986251f-841e-40db-a6c4-100e202a29a3@github.com> On Thu, 2 Mar 2023 17:32:20 GMT, Frederic Parain wrote: >> Other than a minor conflict in systemDictionary.cpp, the backport is the same as the original fix. > > Looks good to me. Thanks @fparain for the review. ------------- PR: https://git.openjdk.org/jdk20u/pull/11 From phh at openjdk.org Thu Mar 2 18:38:17 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 2 Mar 2023 18:38:17 GMT Subject: [jdk11u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 In-Reply-To: References: Message-ID: On Wed, 1 Mar 2023 15:12:34 GMT, Stewart X Addison wrote: > Backporting zlib 1.2.13 from JDK17u due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) > Tested on Windows which is generally the only platform I use which uses bundled zlib. This makes the `zlib` directory in the source identical to the one for JDK17u so should not cause any problems. I'll look at the feasibility of doing the same on JDK8 too. > > Reviewed-by: alanb, jpai Tagged the JBS issue. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1788 From phh at openjdk.org Thu Mar 2 18:44:20 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 2 Mar 2023 18:44:20 GMT Subject: [jdk11u-dev] RFR: 8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles In-Reply-To: References: Message-ID: On Wed, 1 Mar 2023 22:57:02 GMT, Autumn Capasso wrote: > backport JDK-8264299 This backport is part of the 28 backport Accessibility series JDK-8152350. Commented out line 61 of commoneComponentAccesssibilty.m until backoport JDK-8262981 is reworked and built a slider and other GUIs and components and manually tested the UI with Accessibility functions. Tagged the JBS issue. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1791 From ccheung at openjdk.org Thu Mar 2 19:14:18 2023 From: ccheung at openjdk.org (Calvin Cheung) Date: Thu, 2 Mar 2023 19:14:18 GMT Subject: [jdk20u] Integrated: 8278965: crash in SymbolTable::do_lookup In-Reply-To: References: Message-ID: On Thu, 2 Mar 2023 17:02:39 GMT, Calvin Cheung wrote: > Other than a minor conflict in systemDictionary.cpp, the backport is the same as the original fix. This pull request has now been integrated. Changeset: f33f25ff Author: Calvin Cheung URL: https://git.openjdk.org/jdk20u/commit/f33f25ff6915a0626b53bec8b2629f3fca335887 Stats: 120 lines in 3 files changed: 117 ins; 1 del; 2 mod 8278965: crash in SymbolTable::do_lookup Reviewed-by: fparain Backport-of: 582b943439488a0f43482b67c0bc0d4975bf4023 ------------- PR: https://git.openjdk.org/jdk20u/pull/11 From goetz at openjdk.org Thu Mar 2 19:43:31 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 2 Mar 2023 19:43:31 GMT Subject: [jdk17u-dev] RFR: 8284767: Create an automated test for JDK-4422535 In-Reply-To: References: Message-ID: On Tue, 28 Feb 2023 17:48:15 GMT, Goetz Lindenmaier wrote: > I backport this test fix for parity with 17.0.8-oracle to 17.0.7. Pre-submit failure: Ubuntu download failed: Err:24 https://packages.microsoft.com/ubuntu/20.04/prod focal/main arm64 Packages Hash Sum mismatch and ant download sh][ERROR] wget exited with exit code 4 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1191 From goetz at openjdk.org Thu Mar 2 19:45:11 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 2 Mar 2023 19:45:11 GMT Subject: [jdk17u-dev] RFR: 8284524: Create an automated test for JDK-4422362 In-Reply-To: References: Message-ID: On Tue, 28 Feb 2023 17:53:53 GMT, Goetz Lindenmaier wrote: > I backport this test fix for parity with 17.0.8-oracle to 17.0.7. Pre-submit failure: unrelated. test report generation failed: ash: ./.github/scripts/gen-test-results.sh: No such file or directory ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1192 From goetz at openjdk.org Thu Mar 2 19:46:21 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 2 Mar 2023 19:46:21 GMT Subject: [jdk17u-dev] RFR: 8289511: Improve test coverage for XPath Axes: child In-Reply-To: References: Message-ID: On Tue, 28 Feb 2023 17:56:19 GMT, Goetz Lindenmaier wrote: > I backport this test fix for parity with 17.0.8-oracle to 17.0.7. Pre-submit failure: unrelated. ant download failed: wget exited with exit code 4 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1193 From goetz at openjdk.org Thu Mar 2 19:47:28 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 2 Mar 2023 19:47:28 GMT Subject: [jdk17u-dev] RFR: 8048190: NoClassDefFoundError omits original ExceptionInInitializerError [v2] In-Reply-To: References: <49dejqOFd_BCsxLBjuDHcBMOcmWUQXxs1YYsusCqZlA=.30ef5cd0-0f3e-4b41-9fb8-a47d93179021@github.com> Message-ID: On Wed, 1 Mar 2023 21:23:44 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 17.0.7-oracle. >> >> I had to adapt the declaration of _initialization_error_table because "8270061: Change parameter order of ResourceHashtable" is not in 17. > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into goetz_backport_8048190 > - Backport 464e874a5c6b46fcc729227764d07feb1801314d Restarted tests passed. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1195 From goetz at openjdk.org Thu Mar 2 20:00:07 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 2 Mar 2023 20:00:07 GMT Subject: [jdk11u-dev] RFR: 8190492: Remove SSLv2Hello and SSLv3 from default enabled TLS protocols [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.19-oracle. At least we found the corresponding CSR, the backport seems to be closed. > > I had to adapt the code as 11 implements FIPS. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Add missing comment ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1787/files - new: https://git.openjdk.org/jdk11u-dev/pull/1787/files/cfd8d3d1..433e769b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1787&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1787&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1787.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1787/head:pull/1787 PR: https://git.openjdk.org/jdk11u-dev/pull/1787 From goetz at openjdk.org Thu Mar 2 20:00:09 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 2 Mar 2023 20:00:09 GMT Subject: [jdk11u-dev] RFR: 8190492: Remove SSLv2Hello and SSLv3 from default enabled TLS protocols In-Reply-To: References: Message-ID: On Wed, 1 Mar 2023 14:55:25 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.19-oracle. At least we found the corresponding CSR, the backport seems to be closed. > > I had to adapt the code as 11 implements FIPS. Thanks for catching this and thanks for the reviews! ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1787 From mikael at openjdk.org Thu Mar 2 20:03:54 2023 From: mikael at openjdk.org (Mikael Vidstedt) Date: Thu, 2 Mar 2023 20:03:54 GMT Subject: [jdk20u] Integrated: 8303412: Update linux_x64-to-linux_aarch64 cross compilation devkit at Oracle In-Reply-To: References: Message-ID: <64Fct5orR85X1CpMoJdxZdXmPDSlT8rQnNbrUqUe3Z0=.3c1e0992-4b80-4eea-973c-c5e3145c2dba@github.com> On Wed, 1 Mar 2023 18:03:24 GMT, Mikael Vidstedt wrote: > Backporting fix from mainline. Did not apply cleanly because a neighboring line had been changed. This pull request has now been integrated. Changeset: f290c97d Author: Mikael Vidstedt URL: https://git.openjdk.org/jdk20u/commit/f290c97d124c6946a7231b8476ea4684f1ba0514 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8303412: Update linux_x64-to-linux_aarch64 cross compilation devkit at Oracle Backport-of: 65da2c5d2dfea30e7d00b8f907f7abb5f6f887df ------------- PR: https://git.openjdk.org/jdk20u/pull/10 From ccheung at openjdk.org Thu Mar 2 21:46:59 2023 From: ccheung at openjdk.org (Calvin Cheung) Date: Thu, 2 Mar 2023 21:46:59 GMT Subject: [jdk20u] RFR: 8301123: Enable Symbol refcounting underflow checks in PRODUCT Message-ID: 8301123: Enable Symbol refcounting underflow checks in PRODUCT ------------- Commit messages: - Backport fccf818972f15bc4f69ce9566b5cd4b7e7777107 Changes: https://git.openjdk.org/jdk20u/pull/12/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=12&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8301123 Stats: 14 lines in 2 files changed: 7 ins; 6 del; 1 mod Patch: https://git.openjdk.org/jdk20u/pull/12.diff Fetch: git fetch https://git.openjdk.org/jdk20u pull/12/head:pull/12 PR: https://git.openjdk.org/jdk20u/pull/12 From ccheung at openjdk.org Thu Mar 2 21:54:19 2023 From: ccheung at openjdk.org (Calvin Cheung) Date: Thu, 2 Mar 2023 21:54:19 GMT Subject: [jdk20u] Integrated: 8301123: Enable Symbol refcounting underflow checks in PRODUCT In-Reply-To: References: Message-ID: <45zvjo9ElaKO95O9Axb8khSw5ztwRqYHscm-JszFPl0=.c004f96a-59c3-4baa-b783-212fb3d5d420@github.com> On Thu, 2 Mar 2023 21:39:41 GMT, Calvin Cheung wrote: > 8301123: Enable Symbol refcounting underflow checks in PRODUCT This pull request has now been integrated. Changeset: 16a3d7bb Author: Calvin Cheung URL: https://git.openjdk.org/jdk20u/commit/16a3d7bb6ec2fe248657980335d4dfaa0350ee9e Stats: 14 lines in 2 files changed: 7 ins; 6 del; 1 mod 8301123: Enable Symbol refcounting underflow checks in PRODUCT Backport-of: fccf818972f15bc4f69ce9566b5cd4b7e7777107 ------------- PR: https://git.openjdk.org/jdk20u/pull/12 From sviswanathan at openjdk.org Thu Mar 2 22:10:32 2023 From: sviswanathan at openjdk.org (Sandhya Viswanathan) Date: Thu, 2 Mar 2023 22:10:32 GMT Subject: [jdk11u-dev] RFR: 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption [v5] In-Reply-To: References: Message-ID: On Wed, 1 Mar 2023 19:09:45 GMT, Scott Gibbons wrote: >> Backporting because this change results in ~3x performance improvement in AES-CTR. >> >> Risk is low. Tested with tier1 and benchmark. >> >> The PR does not backport cleanly. The buffer name was changed, but functionally remains the same. > > Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision: > > Fix initialization of offset @ascarpino Could you please help review this backport CR? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1780 From tsteele at openjdk.org Fri Mar 3 00:45:08 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Fri, 3 Mar 2023 00:45:08 GMT Subject: [jdk20u] RFR: 8303186: Missing Classpath exception from Continuation.c Message-ID: Hi all, This pull request contains a backport of commit [dc08216f](https://github.com/openjdk/jdk/commit/dc08216f0ef55970c96df43bcc86ebd5792d486e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Tyler Steele on 2 Mar 2023 and was reviewed by David Holmes and Jaikiran Pai. I recognize that we are in the RC stage of jdk20 release. I'd like to include this change in the first release of jdk20, as it probably should have happened in jdk19. It isn't a code change, so the risk is quite low. Thanks! ------------- Commit messages: - Backport dc08216f0ef55970c96df43bcc86ebd5792d486e Changes: https://git.openjdk.org/jdk20u/pull/13/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=13&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303186 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk20u/pull/13.diff Fetch: git fetch https://git.openjdk.org/jdk20u pull/13/head:pull/13 PR: https://git.openjdk.org/jdk20u/pull/13 From goetz at openjdk.org Fri Mar 3 07:36:31 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 3 Mar 2023 07:36:31 GMT Subject: [jdk11u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 In-Reply-To: References: Message-ID: On Thu, 2 Mar 2023 11:43:03 GMT, Stewart X Addison wrote: >> What did your testing consist of? > > @phohensee I've run through the tier1 tests on Windows ([results here](https://ci.adoptium.net/job/Test_openjdk11_hs_sanity.openjdk_x86-64_windows/729/testReport/)) plus verified with some of the compression related tests from the TCK. > Since this is likely to be relatively low risk and is already in 17 and we typically build without the in-tree zlib on other platforms I felt that was adequate. If you want me to run more exhaustive testing let me know. @sxa, please only integrate if you have the fix-yes label on the JBS issue. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1788 From duke at openjdk.org Fri Mar 3 07:39:21 2023 From: duke at openjdk.org (PoojaDP-23) Date: Fri, 3 Mar 2023 07:39:21 GMT Subject: [jdk11u-dev] RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers In-Reply-To: References: Message-ID: <0HPcptk412jl9JYujVcOkxle35pgWjlVTnbQC9oUC6Y=.7fe2f59f-499e-4137-a812-ecdd86d94542@github.com> On Wed, 1 Mar 2023 08:31:06 GMT, Christoph Langer wrote: >> Hi, please send an e-mail to Dalibor.Topic at oracle.com so that I can mark your account as verified in Skara. > >> @robilad - Earlier Workflows aren't being run on this forked repository because it was not enabled. Now I have enabled the workflow but still tests are not running on my fork. Could you please let me know what action needs to be done by myside? Thanks > > Hi @PoojaDP-23, > I guess the easiest way to get current GHA checks is to merge your branch with current master of [jdk11u-dev](https://github.com/openjdk/jdk11u-dev) and push it. This will trigger a run with the most current code. @RealCLanger - Could you please review the backport PR? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1710 From goetz at openjdk.org Fri Mar 3 08:48:57 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 3 Mar 2023 08:48:57 GMT Subject: [jdk17u-dev] Integrated: 8048190: NoClassDefFoundError omits original ExceptionInInitializerError In-Reply-To: <49dejqOFd_BCsxLBjuDHcBMOcmWUQXxs1YYsusCqZlA=.30ef5cd0-0f3e-4b41-9fb8-a47d93179021@github.com> References: <49dejqOFd_BCsxLBjuDHcBMOcmWUQXxs1YYsusCqZlA=.30ef5cd0-0f3e-4b41-9fb8-a47d93179021@github.com> Message-ID: On Wed, 1 Mar 2023 12:54:11 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. > > I had to adapt the declaration of _initialization_error_table because "8270061: Change parameter order of ResourceHashtable" is not in 17. This pull request has now been integrated. Changeset: bf513540 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/bf513540298f7e36a57de767e6fadfdb03d7ea57 Stats: 263 lines in 9 files changed: 250 ins; 3 del; 10 mod 8048190: NoClassDefFoundError omits original ExceptionInInitializerError Reviewed-by: phh Backport-of: 464e874a5c6b46fcc729227764d07feb1801314d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1195 From goetz at openjdk.org Fri Mar 3 08:52:33 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 3 Mar 2023 08:52:33 GMT Subject: [jdk11u-dev] Integrated: 8190492: Remove SSLv2Hello and SSLv3 from default enabled TLS protocols In-Reply-To: References: Message-ID: On Wed, 1 Mar 2023 14:55:25 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.19-oracle. At least we found the corresponding CSR, the backport seems to be closed. > > I had to adapt the code as 11 implements FIPS. This pull request has now been integrated. Changeset: de6d2c9b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/de6d2c9bd565a5f95a2dc82b79261f80bfa722d8 Stats: 227 lines in 13 files changed: 61 ins; 17 del; 149 mod 8190492: Remove SSLv2Hello and SSLv3 from default enabled TLS protocols Reviewed-by: phh, mbaesken Backport-of: 5fc46f3c50a4b04808f1741a3f6e7a768b206cef ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1787 From goetz at openjdk.org Fri Mar 3 08:54:23 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 3 Mar 2023 08:54:23 GMT Subject: [jdk17u-dev] Integrated: 8210927: JDB tests do not update source path after doing a redefine class In-Reply-To: <-beyZiQCbtl18CiQi5WKqwovZ7l7nU9M9rp8HFjvxJQ=.b685a92a-cc5c-4a89-9684-010eb1f5aa68@github.com> References: <-beyZiQCbtl18CiQi5WKqwovZ7l7nU9M9rp8HFjvxJQ=.b685a92a-cc5c-4a89-9684-010eb1f5aa68@github.com> Message-ID: On Tue, 28 Feb 2023 17:44:15 GMT, Goetz Lindenmaier wrote: > I backport this test fix for parity with 17.0.8-oracle to 17.0.7. This pull request has now been integrated. Changeset: 181a7bb3 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/181a7bb31d515ea44439d782db3846d7f209a4ba Stats: 18 lines in 3 files changed: 8 ins; 0 del; 10 mod 8210927: JDB tests do not update source path after doing a redefine class Backport-of: 61ac53f6e5a149c6ec68a8df43106e72bfd1ebb2 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1190 From goetz at openjdk.org Fri Mar 3 08:55:29 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 3 Mar 2023 08:55:29 GMT Subject: [jdk17u-dev] Integrated: 8284767: Create an automated test for JDK-4422535 In-Reply-To: References: Message-ID: On Tue, 28 Feb 2023 17:48:15 GMT, Goetz Lindenmaier wrote: > I backport this test fix for parity with 17.0.8-oracle to 17.0.7. This pull request has now been integrated. Changeset: fd93a6af Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/fd93a6afd871bcf804b5df1ea24fff788aa45b3a Stats: 76 lines in 1 file changed: 76 ins; 0 del; 0 mod 8284767: Create an automated test for JDK-4422535 Backport-of: 5ae4320921b15dcc198d0c71416cd46e5b5c2f85 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1191 From goetz at openjdk.org Fri Mar 3 09:01:20 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 3 Mar 2023 09:01:20 GMT Subject: [jdk17u-dev] Integrated: 8284524: Create an automated test for JDK-4422362 In-Reply-To: References: Message-ID: On Tue, 28 Feb 2023 17:53:53 GMT, Goetz Lindenmaier wrote: > I backport this test fix for parity with 17.0.8-oracle to 17.0.7. This pull request has now been integrated. Changeset: ca049ec2 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/ca049ec2c6e37abcd389c98c15acac699c6d8447 Stats: 71 lines in 1 file changed: 71 ins; 0 del; 0 mod 8284524: Create an automated test for JDK-4422362 Backport-of: b9de0a7556f7be2c6afc6bb41bfa0339b639ff88 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1192 From goetz at openjdk.org Fri Mar 3 09:06:22 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 3 Mar 2023 09:06:22 GMT Subject: [jdk17u-dev] Integrated: 8289511: Improve test coverage for XPath Axes: child In-Reply-To: References: Message-ID: <4pyaJNzPO3zK3POwysjlIt6W8px1528rNPq4Q35VGTc=.af6b060c-8fe9-4701-a727-d86d487d7edc@github.com> On Tue, 28 Feb 2023 17:56:19 GMT, Goetz Lindenmaier wrote: > I backport this test fix for parity with 17.0.8-oracle to 17.0.7. This pull request has now been integrated. Changeset: 9b054a1f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/9b054a1fafe546495dd209fa927b56ecb3bbc1ca Stats: 237 lines in 1 file changed: 237 ins; 0 del; 0 mod 8289511: Improve test coverage for XPath Axes: child Backport-of: cfe9026fe0506488cc0f0557299cfa585811d194 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1193 From duke at openjdk.org Fri Mar 3 15:15:24 2023 From: duke at openjdk.org (Stewart X Addison) Date: Fri, 3 Mar 2023 15:15:24 GMT Subject: [jdk11u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 In-Reply-To: References: Message-ID: On Fri, 3 Mar 2023 07:33:28 GMT, Goetz Lindenmaier wrote: >> @phohensee I've run through the tier1 tests on Windows ([results here](https://ci.adoptium.net/job/Test_openjdk11_hs_sanity.openjdk_x86-64_windows/729/testReport/)) plus verified with some of the compression related tests from the TCK. >> Since this is likely to be relatively low risk and is already in 17 and we typically build without the in-tree zlib on other platforms I felt that was adequate. If you want me to run more exhaustive testing let me know. > > @sxa, please only integrate if you have the fix-yes label on the JBS issue. @GoeLin Do I need to re-trigger the `integrate` now that [JDK-8295530](https://bugs.openjdk.org/browse/JDK-8295530) has `jdk11u-fix-yes` on it? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1788 From duke at openjdk.org Fri Mar 3 15:23:22 2023 From: duke at openjdk.org (Stewart X Addison) Date: Fri, 3 Mar 2023 15:23:22 GMT Subject: [jdk11u-dev] Integrated: 8295530: Update Zlib Data Compression Library to Version 1.2.13 In-Reply-To: References: Message-ID: On Wed, 1 Mar 2023 15:12:34 GMT, Stewart X Addison wrote: > Backporting zlib 1.2.13 from JDK17u due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) > Tested on Windows which is generally the only platform I use which uses bundled zlib. This makes the `zlib` directory in the source identical to the one for JDK17u so should not cause any problems. I'll look at the feasibility of doing the same on JDK8 too. > > Reviewed-by: alanb, jpai This pull request has now been integrated. Changeset: 125cf5ab Author: Lance Andersen Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/125cf5ab2b85ab8cbadf164504902d86aec64449 Stats: 11195 lines in 24 files changed: 9975 ins; 274 del; 946 mod 8295530: Update Zlib Data Compression Library to Version 1.2.13 Reviewed-by: phh Backport-of: 6042c6b9bbacbff1bd47f087f0f19646a20eef97 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1788 From sgehwolf at openjdk.org Fri Mar 3 15:41:14 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 Mar 2023 15:41:14 GMT Subject: [jdk11u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 In-Reply-To: References: Message-ID: <_fIQJy2XBXzEZFeIKNAwXUkP8okfPmyQ4p2IGXWTuco=.0ee964d6-9856-47f9-b149-ad0f38aba1d7@github.com> On Fri, 3 Mar 2023 15:12:49 GMT, Stewart X Addison wrote: > Do I need to re-trigger the `integrate` now that [JDK-8295530](https://bugs.openjdk.org/browse/JDK-8295530) has `jdk11u-fix-yes` on it? Stating the obvious: no. :) But next time please only issue `/integrate` after `jdk11u-fix-yes` is present. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1788 From tsteele at openjdk.org Fri Mar 3 17:46:21 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Fri, 3 Mar 2023 17:46:21 GMT Subject: [jdk20u] RFR: 8303186: Missing Classpath exception from Continuation.c In-Reply-To: References: Message-ID: On Fri, 3 Mar 2023 00:37:39 GMT, Tyler Steele wrote: > Hi all, > > This pull request contains a backport of commit [dc08216f](https://github.com/openjdk/jdk/commit/dc08216f0ef55970c96df43bcc86ebd5792d486e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Tyler Steele on 2 Mar 2023 and was reviewed by David Holmes and Jaikiran Pai. > > I recognize that we are in the RC stage of jdk20 release. I'd like to include this change in the first release of jdk20, as it probably should have happened in jdk19. It isn't a code change, so the risk is quite low. > > Thanks! Received approval on the issue to: ------------- PR: https://git.openjdk.org/jdk20u/pull/13 From ksrini at openjdk.org Fri Mar 3 18:01:29 2023 From: ksrini at openjdk.org (Kumar Srinivasan) Date: Fri, 3 Mar 2023 18:01:29 GMT Subject: [jdk11u-dev] Integrated: JDK-8302000: [11u] A subtle race condition during jdk11u build In-Reply-To: <1qnQp8MoGgnKOpFrSVc7zSMW_gZdoyKknq7vuyUbB44=.769b3d76-c7ea-4d66-a4af-8d914aa5aae7@github.com> References: <1qnQp8MoGgnKOpFrSVc7zSMW_gZdoyKknq7vuyUbB44=.769b3d76-c7ea-4d66-a4af-8d914aa5aae7@github.com> Message-ID: On Fri, 24 Feb 2023 17:04:39 GMT, Kumar Srinivasan wrote: > Hi, > > **This is to fix issue caused by:** > JDK-8257679: Improved unix compatibility layer in Windows build (winenv) > Please refer to JDK-8302000 for the evaluation of how the above causes the race condition. > > The changes below are in an effort to make the existing jdk11u source more robust and closer to the upstream code. > > **Initial Spp.java changes:** > JDK-8215445: Enable building for Windows in WSL > https://github.com/openjdk/jdk/compare/88b95f05706..46eb26b692a > > _Note: Too large to be back-ported, only changes for Spp.java associated build logic > changes needs to be back-ported manually._ > > **Required additional make logic adjustments required for Spp.java changes:** > JDK-8218460: https://github.com/openjdk/jdk/compare/1fcbd0cd0dc..f380787a41e > > _Note: patch does not apply cleanly and all the changes have to be applied manually._ > > **Optional, Spp.java Improvements:** > JDK-8223347: Integration of Vector API (Incubator) > https://github.com/openjdk/jdk/compare/386e7e8b733..0c99b192588 > > _Note: Clearly the entire commit is totally inapplicable to jdk11u, since it is an Incubator feature, > however small improvement to Spp.java can be back-ported manually, in an effort to bring jdk11u > sources closer to upstream_ > > If the above solutions are not acceptable, then I could add parenthesis to the ExecutWithLog call-sites, however > this will further diverge the jdk11u code base from upstream. > > If none of the above solutions are acceptable then I recommend the jdk11u maintainers assign JDK-8302000 to > the author of JDK-8257679 and have them remove the ExecuteWithLog additions. > > I personally have tested the fix using tier1 and tier2 regression testing on both Windows and Linux. This pull request has now been integrated. Changeset: 915ac570 Author: Kumar Srinivasan URL: https://git.openjdk.org/jdk11u-dev/commit/915ac570b54aa820adf474ab5046e17007601f4e Stats: 68 lines in 10 files changed: 32 ins; 1 del; 35 mod 8302000: [11u] A subtle race condition during jdk11u build 8218460: Test generation scripts do not invoke stream preprocessor correctly Reviewed-by: clanger ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1774 From duke at openjdk.org Fri Mar 3 18:47:36 2023 From: duke at openjdk.org (Autumn Capasso) Date: Fri, 3 Mar 2023 18:47:36 GMT Subject: [jdk11u-dev] Integrated: 8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles In-Reply-To: References: Message-ID: On Wed, 1 Mar 2023 22:57:02 GMT, Autumn Capasso wrote: > backport JDK-8264299 This backport is part of the 28 backport Accessibility series JDK-8152350. Commented out line 61 of commoneComponentAccesssibilty.m until backoport JDK-8262981 is reworked and built a slider and other GUIs and components and manually tested the UI with Accessibility functions. This pull request has now been integrated. Changeset: 8a726afc Author: Autumn808 Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/8a726afcdf653bf3fe7ba6ed3419732edf625b11 Stats: 368 lines in 7 files changed: 246 ins; 121 del; 1 mod 8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles Reviewed-by: phh Backport-of: 6c107fdff289cc553df12ee10b0c8002b84059b2 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1791 From duke at openjdk.org Fri Mar 3 23:13:12 2023 From: duke at openjdk.org (Autumn Capasso) Date: Fri, 3 Mar 2023 23:13:12 GMT Subject: [jdk11u-dev] Withdrawn: 8267066: New NSAccessibility peers should return they roles and subroles directly In-Reply-To: References: Message-ID: <75jKr7maY5FyOLVck4wf7mcx7oESM3-4zZp9LF3mXQk=.a8cbfa03-2a47-441f-9a0d-8af5c45d6085@github.com> On Tue, 7 Feb 2023 17:54:13 GMT, Autumn Capasso wrote: > This Backport was clean and needed to implement NSAccessibility peers needs to have their roles and subroles to be told directly instead of relying on the property map stored in JavaComponentAccessibility. This backport is being added to the series of 28 Accessibility backports [JDK-8152350](https://bugs.openjdk.org/browse/JDK-8152350). This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1711 From clanger at openjdk.org Sun Mar 5 12:11:12 2023 From: clanger at openjdk.org (Christoph Langer) Date: Sun, 5 Mar 2023 12:11:12 GMT Subject: [jdk11u-dev] RFR: 8220093: Change to GCC 8.2 for building on Linux at Oracle Message-ID: This is a backport of [JDK-8220093](https://bugs.openjdk.org/browse/JDK-8220093). The motivation for doing it is that configure output will then show same output as in higher releases for the used linker. E.g. `configure: Using gcc linker version 2.36.1 [GNU ld (GNU Binutils) 2.36.1]` vs `configure: Using gcc linker version 8.5.0 [collect2 version 8.5.0]` One can then deduct the version of binutils used. I had to make a few modifications. In toolchain.m4, [JDK-8257679](https://bugs.openjdk.org/browse/JDK-8257679) was already present so I had to make the hunk fit. The other adaptations are in jib-profiles.js which is not relevant to OpenJDK because it's used internally at Oracle only and some improvements to the devkit build scripts. ------------- Commit messages: - 8220093: Change to GCC 8.2 for building on Linux at Oracle Changes: https://git.openjdk.org/jdk11u-dev/pull/1792/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1792&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8220093 Stats: 107 lines in 5 files changed: 82 ins; 7 del; 18 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1792.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1792/head:pull/1792 PR: https://git.openjdk.org/jdk11u-dev/pull/1792 From stuefe at openjdk.org Sun Mar 5 16:38:14 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Sun, 5 Mar 2023 16:38:14 GMT Subject: [jdk11u-dev] RFR: 8220093: Change to GCC 8.2 for building on Linux at Oracle In-Reply-To: References: Message-ID: On Sun, 5 Mar 2023 12:03:52 GMT, Christoph Langer wrote: > This is a backport of [JDK-8220093](https://bugs.openjdk.org/browse/JDK-8220093). The motivation for doing it is that configure output will then show same output as in higher releases for the used linker. E.g. > > `configure: Using gcc linker version 2.36.1 [GNU ld (GNU Binutils) 2.36.1]` > > vs > > `configure: Using gcc linker version 8.5.0 [collect2 version 8.5.0]` > > One can then deduct the version of binutils used. > > I had to make a few modifications. In toolchain.m4, [JDK-8257679](https://bugs.openjdk.org/browse/JDK-8257679) was already present so I had to make the hunk fit. The other adaptations are in jib-profiles.js which is not relevant to OpenJDK because it's used internally at Oracle only and some improvements to the devkit build scripts. There is a hunk missing (Tools.gmk 370ff) ? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1792 From clanger at openjdk.org Sun Mar 5 16:54:15 2023 From: clanger at openjdk.org (Christoph Langer) Date: Sun, 5 Mar 2023 16:54:15 GMT Subject: [jdk11u-dev] RFR: 8220093: Change to GCC 8.2 for building on Linux at Oracle In-Reply-To: References: Message-ID: <3sO1wVaEKlPGrI3hVfqgM507uOR9wrcz3WZ63HKslW4=.b93b514d-67b5-4aa2-8767-adbca921bc65@github.com> On Sun, 5 Mar 2023 16:35:18 GMT, Thomas Stuefe wrote: > There is a hunk missing (Tools.gmk 370ff) ? True. I should have explained my reasoning here: I didn't dare to change the devkit build logic from `--enable-gold` to `--enable-gold=default` as we had seen issues with compatibility by that change which makes the build use the gold linker then. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1792 From clanger at openjdk.org Sun Mar 5 21:21:16 2023 From: clanger at openjdk.org (Christoph Langer) Date: Sun, 5 Mar 2023 21:21:16 GMT Subject: [jdk11u-dev] RFR: 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption [v5] In-Reply-To: References: Message-ID: The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. ---------------------------------------------------------------------- On Wed, 1 Mar 2023 19:09:45 GMT, Scott Gibbons wrote: >> Backporting because this change results in ~3x performance improvement in AES-CTR. >> >> Risk is low. Tested with tier1 and benchmark. >> >> The PR does not backport cleanly. The buffer name was changed, but functionally remains the same. > > Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision: > > Fix initialization of offset I had a closer look now. Overall it seems ok. Could you maybe rename outWithPadding to internalOutput? That would bring the code closer to head and seems the more logical name for the buffer. Thanks. src/java.base/share/classes/com/sun/crypto/provider/CipherCore.java line 959: > 957: } > 958: // copy the result into user-supplied output buffer > 959: if(outWithPadding != null) { Please add a space after `if` ------------- Changes requested by clanger (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1780 From clanger at openjdk.org Sun Mar 5 21:25:14 2023 From: clanger at openjdk.org (Christoph Langer) Date: Sun, 5 Mar 2023 21:25:14 GMT Subject: [jdk11u-dev] RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers In-Reply-To: References: Message-ID: On Wed, 1 Mar 2023 08:31:06 GMT, Christoph Langer wrote: >> Hi, please send an e-mail to Dalibor.Topic at oracle.com so that I can mark your account as verified in Skara. > >> @robilad - Earlier Workflows aren't being run on this forked repository because it was not enabled. Now I have enabled the workflow but still tests are not running on my fork. Could you please let me know what action needs to be done by myside? Thanks > > Hi @PoojaDP-23, > I guess the easiest way to get current GHA checks is to merge your branch with current master of [jdk11u-dev](https://github.com/openjdk/jdk11u-dev) and push it. This will trigger a run with the most current code. > @RealCLanger - Could you please review the backport PR? I can have a look. But please do a merge with master before and by that, trigger GHA. Thanks. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1710 From jbechberger at openjdk.org Mon Mar 6 08:06:29 2023 From: jbechberger at openjdk.org (Johannes Bechberger) Date: Mon, 6 Mar 2023 08:06:29 GMT Subject: [jdk17u] RFR: 8302320: AsyncGetCallTrace obtains too few frames in sanity test Message-ID: <-0Ey_ggxTbVFQde-CT2zNx3pz46ASeBzKgFNMBH86IY=.19f8fbed-9fe4-4d3e-87d3-739c1f8f1eff@github.com> Extended the AsyncGetCallTrace and fixed an issue with interpreter frames. ------------- Commit messages: - Backport db483a38a815f85bd9668749674b5f0f6e4b27b4 Changes: https://git.openjdk.org/jdk17u/pull/366/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=366&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8302320 Stats: 39 lines in 2 files changed: 36 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u/pull/366.diff Fetch: git fetch https://git.openjdk.org/jdk17u pull/366/head:pull/366 PR: https://git.openjdk.org/jdk17u/pull/366 From jbechberger at openjdk.org Mon Mar 6 08:10:32 2023 From: jbechberger at openjdk.org (Johannes Bechberger) Date: Mon, 6 Mar 2023 08:10:32 GMT Subject: [jdk17u] Withdrawn: 8302320: AsyncGetCallTrace obtains too few frames in sanity test In-Reply-To: <-0Ey_ggxTbVFQde-CT2zNx3pz46ASeBzKgFNMBH86IY=.19f8fbed-9fe4-4d3e-87d3-739c1f8f1eff@github.com> References: <-0Ey_ggxTbVFQde-CT2zNx3pz46ASeBzKgFNMBH86IY=.19f8fbed-9fe4-4d3e-87d3-739c1f8f1eff@github.com> Message-ID: <3P02YjXe6mx4U_3kug1CC1lvMY-7dpIS_MGajpq4mVE=.460e99b3-2c0c-4c4c-a0f3-4441caf45939@github.com> On Mon, 6 Mar 2023 07:58:36 GMT, Johannes Bechberger wrote: > Extended the AsyncGetCallTrace and fixed an issue with interpreter frames. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u/pull/366 From jbechberger at openjdk.org Mon Mar 6 08:20:14 2023 From: jbechberger at openjdk.org (Johannes Bechberger) Date: Mon, 6 Mar 2023 08:20:14 GMT Subject: [jdk17u-dev] RFR: 8302320: AsyncGetCallTrace obtains too few frames in sanity test Message-ID: Extended the AsyncGetCallTrace and fixed an issue with interpreter frames. ------------- Commit messages: - Backport db483a38a815f85bd9668749674b5f0f6e4b27b4 Changes: https://git.openjdk.org/jdk17u-dev/pull/1197/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1197&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8302320 Stats: 39 lines in 2 files changed: 36 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1197.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1197/head:pull/1197 PR: https://git.openjdk.org/jdk17u-dev/pull/1197 From sgibbons at openjdk.org Mon Mar 6 15:40:08 2023 From: sgibbons at openjdk.org (Scott Gibbons) Date: Mon, 6 Mar 2023 15:40:08 GMT Subject: [jdk11u-dev] RFR: 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption [v6] In-Reply-To: References: Message-ID: > Backporting because this change results in ~3x performance improvement in AES-CTR. > > Risk is low. Tested with tier1 and benchmark. > > The PR does not backport cleanly. The buffer name was changed, but functionally remains the same. Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision: Address review comment ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1780/files - new: https://git.openjdk.org/jdk11u-dev/pull/1780/files/a4a93c50..9b07d2be Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1780&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1780&range=04-05 Stats: 8 lines in 1 file changed: 0 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1780.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1780/head:pull/1780 PR: https://git.openjdk.org/jdk11u-dev/pull/1780 From sgibbons at openjdk.org Mon Mar 6 15:59:05 2023 From: sgibbons at openjdk.org (Scott Gibbons) Date: Mon, 6 Mar 2023 15:59:05 GMT Subject: [jdk11u-dev] RFR: 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption [v7] In-Reply-To: References: Message-ID: <93mpH3x185Tc3l9gJdUDE6QsuCkbMpmKYlU18im5xPI=.a6fd26f0-2c31-444a-856c-1e12abc2fdd5@github.com> The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. ---------------------------------------------------------------------- > Backporting because this change results in ~3x performance improvement in AES-CTR. > > Risk is low. Tested with tier1 and benchmark. > > The PR does not backport cleanly. The buffer name was changed, but functionally remains the same. Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision: Address review comment ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1780/files - new: https://git.openjdk.org/jdk11u-dev/pull/1780/files/9b07d2be..9b7ef4a1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1780&range=06 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1780&range=05-06 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1780.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1780/head:pull/1780 PR: https://git.openjdk.org/jdk11u-dev/pull/1780 From clanger at openjdk.org Mon Mar 6 15:59:08 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 6 Mar 2023 15:59:08 GMT Subject: [jdk11u-dev] RFR: 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption [v6] In-Reply-To: References: Message-ID: On Mon, 6 Mar 2023 15:40:08 GMT, Scott Gibbons wrote: >> Backporting because this change results in ~3x performance improvement in AES-CTR. >> >> Risk is low. Tested with tier1 and benchmark. >> >> The PR does not backport cleanly. The buffer name was changed, but functionally remains the same. > > Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision: > > Address review comment Changes requested by clanger (Reviewer). ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1780 From clanger at openjdk.org Mon Mar 6 15:59:14 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 6 Mar 2023 15:59:14 GMT Subject: [jdk11u-dev] RFR: 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption [v5] In-Reply-To: References: Message-ID: On Wed, 1 Mar 2023 19:09:45 GMT, Scott Gibbons wrote: >> Backporting because this change results in ~3x performance improvement in AES-CTR. >> >> Risk is low. Tested with tier1 and benchmark. >> >> The PR does not backport cleanly. The buffer name was changed, but functionally remains the same. > > Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision: > > Fix initialization of offset src/java.base/share/classes/com/sun/crypto/provider/CipherCore.java line 971: > 969: private void endDoFinal() { > 970: buffered = 0; > 971: diffBlocksize = blockSize; Here the variable should remain outWithPadding. src/java.base/share/classes/com/sun/crypto/provider/CipherCore.java line 973: > 971: diffBlocksize = blockSize; > 972: if (cipherMode != ECB_MODE) { > 973: cipher.reset(); Same here. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1780 From clanger at openjdk.org Mon Mar 6 17:08:08 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 6 Mar 2023 17:08:08 GMT Subject: [jdk11u-dev] RFR: 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption [v7] In-Reply-To: <93mpH3x185Tc3l9gJdUDE6QsuCkbMpmKYlU18im5xPI=.a6fd26f0-2c31-444a-856c-1e12abc2fdd5@github.com> References: <93mpH3x185Tc3l9gJdUDE6QsuCkbMpmKYlU18im5xPI=.a6fd26f0-2c31-444a-856c-1e12abc2fdd5@github.com> Message-ID: On Mon, 6 Mar 2023 15:59:05 GMT, Scott Gibbons wrote: >> Backporting because this change results in ~3x performance improvement in AES-CTR. >> >> Risk is low. Tested with tier1 and benchmark. >> >> The PR does not backport cleanly. The buffer name was changed, but functionally remains the same. > > Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision: > > Address review comment Thanks. This looks good. I'll run it through SAP'S nightlies and will hopefully approve tomorrow when no regressions spotted. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1780 From sgibbons at openjdk.org Mon Mar 6 17:33:14 2023 From: sgibbons at openjdk.org (Scott Gibbons) Date: Mon, 6 Mar 2023 17:33:14 GMT Subject: [jdk11u-dev] RFR: 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption [v7] In-Reply-To: References: <93mpH3x185Tc3l9gJdUDE6QsuCkbMpmKYlU18im5xPI=.a6fd26f0-2c31-444a-856c-1e12abc2fdd5@github.com> Message-ID: On Mon, 6 Mar 2023 17:04:03 GMT, Christoph Langer wrote: >> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision: >> >> Address review comment > > Thanks. This looks good. I'll run it through SAP'S nightlies and will hopefully approve tomorrow when no regressions spotted. Thank you very much @RealCLanger ! ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1780 From ascarpino at openjdk.org Mon Mar 6 19:08:22 2023 From: ascarpino at openjdk.org (Anthony Scarpino) Date: Mon, 6 Mar 2023 19:08:22 GMT Subject: [jdk11u-dev] RFR: 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption [v7] In-Reply-To: <93mpH3x185Tc3l9gJdUDE6QsuCkbMpmKYlU18im5xPI=.a6fd26f0-2c31-444a-856c-1e12abc2fdd5@github.com> References: <93mpH3x185Tc3l9gJdUDE6QsuCkbMpmKYlU18im5xPI=.a6fd26f0-2c31-444a-856c-1e12abc2fdd5@github.com> Message-ID: On Mon, 6 Mar 2023 15:59:05 GMT, Scott Gibbons wrote: >> Backporting because this change results in ~3x performance improvement in AES-CTR. >> >> Risk is low. Tested with tier1 and benchmark. >> >> The PR does not backport cleanly. The buffer name was changed, but functionally remains the same. > > Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision: > > Address review comment The backport looks consistent with what was put in recent releases. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1780 From ascarpino at openjdk.org Mon Mar 6 19:36:45 2023 From: ascarpino at openjdk.org (Anthony Scarpino) Date: Mon, 6 Mar 2023 19:36:45 GMT Subject: [jdk11u-dev] RFR: 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption [v7] In-Reply-To: <93mpH3x185Tc3l9gJdUDE6QsuCkbMpmKYlU18im5xPI=.a6fd26f0-2c31-444a-856c-1e12abc2fdd5@github.com> References: <93mpH3x185Tc3l9gJdUDE6QsuCkbMpmKYlU18im5xPI=.a6fd26f0-2c31-444a-856c-1e12abc2fdd5@github.com> Message-ID: <_Jo_3FLQo1axYkK6UXXY5D1E0tZuI8vMdtoa56bgp_g=.6cde07f6-b779-4f13-b098-d19c60925267@github.com> On Mon, 6 Mar 2023 15:59:05 GMT, Scott Gibbons wrote: >> Backporting because this change results in ~3x performance improvement in AES-CTR. >> >> Risk is low. Tested with tier1 and benchmark. >> >> The PR does not backport cleanly. The buffer name was changed, but functionally remains the same. > > Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision: > > Address review comment Something that should be verified is that this doesn't expose failed auth tag decrypted GCM data or other GCM decryption. There maybe some unexpected differences as this change was after GCM separated from CipherCore in 17. I believe GCM still uses CipherCore in 11. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1780 From sgibbons at openjdk.org Mon Mar 6 21:30:22 2023 From: sgibbons at openjdk.org (Scott Gibbons) Date: Mon, 6 Mar 2023 21:30:22 GMT Subject: [jdk11u-dev] RFR: 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption [v7] In-Reply-To: <_Jo_3FLQo1axYkK6UXXY5D1E0tZuI8vMdtoa56bgp_g=.6cde07f6-b779-4f13-b098-d19c60925267@github.com> References: <93mpH3x185Tc3l9gJdUDE6QsuCkbMpmKYlU18im5xPI=.a6fd26f0-2c31-444a-856c-1e12abc2fdd5@github.com> <_Jo_3FLQo1axYkK6UXXY5D1E0tZuI8vMdtoa56bgp_g=.6cde07f6-b779-4f13-b098-d19c60925267@github.com> Message-ID: On Mon, 6 Mar 2023 19:33:27 GMT, Anthony Scarpino wrote: >> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision: >> >> Address review comment > > Something that should be verified is that this doesn't expose failed auth tag decrypted GCM data or other GCM decryption. There maybe some unexpected differences as this change was after GCM separated from CipherCore in 17. I believe GCM still uses CipherCore in 11. Thanks, @ascarpino. Are there any tests I can run to verify that no GCM data have been exposed? It appears to me that there's one place where decrypted data could be leaked (ShortBufferException), but this is the same in newer versions. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1780 From clanger at openjdk.org Tue Mar 7 08:02:32 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 7 Mar 2023 08:02:32 GMT Subject: [jdk11u-dev] RFR: 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption [v7] In-Reply-To: <93mpH3x185Tc3l9gJdUDE6QsuCkbMpmKYlU18im5xPI=.a6fd26f0-2c31-444a-856c-1e12abc2fdd5@github.com> References: <93mpH3x185Tc3l9gJdUDE6QsuCkbMpmKYlU18im5xPI=.a6fd26f0-2c31-444a-856c-1e12abc2fdd5@github.com> Message-ID: <18-_L1w8ntokVTF9JvWACjaBG1WXtYBrOQab1slPw2I=.634b4c04-84cd-49cf-967b-4dcafe3fd504@github.com> On Mon, 6 Mar 2023 15:59:05 GMT, Scott Gibbons wrote: >> Backporting because this change results in ~3x performance improvement in AES-CTR. >> >> Risk is low. Tested with tier1 and benchmark. >> >> The PR does not backport cleanly. The buffer name was changed, but functionally remains the same. > > Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision: > > Address review comment Looks good from my perspective now. SAP tests passed. Can't say anything to the GCM topic brought up by @ascarpino, though. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1780 From mbaesken at openjdk.org Tue Mar 7 08:29:32 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 7 Mar 2023 08:29:32 GMT Subject: [jdk11u-dev] RFR: 8220093: Change to GCC 8.2 for building on Linux at Oracle In-Reply-To: References: Message-ID: <00LhFA55LLExvB1q2biSALySy6fhgXBI3D9jUyGo4KA=.9c4b9e9d-9224-4764-b783-5502d3179f07@github.com> On Sun, 5 Mar 2023 12:03:52 GMT, Christoph Langer wrote: > This is a backport of [JDK-8220093](https://bugs.openjdk.org/browse/JDK-8220093). The motivation for doing it is that configure output will then show same output as in higher releases for the used linker. E.g. > > `configure: Using gcc linker version 2.36.1 [GNU ld (GNU Binutils) 2.36.1]` > > vs > > `configure: Using gcc linker version 8.5.0 [collect2 version 8.5.0]` > > One can then deduct the version of binutils used. > > I had to make a few modifications. In toolchain.m4, [JDK-8257679](https://bugs.openjdk.org/browse/JDK-8257679) was already present so I had to make the hunk fit. The other adaptations are in jib-profiles.js which is not relevant to OpenJDK because it's used internally at Oracle only and some improvements to the devkit build scripts. looks good to me, but maybe someone from Oracle should comment on the make/conf/jib-profiles.js change ------------- Marked as reviewed by mbaesken (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1792 From rmarchenko at openjdk.org Tue Mar 7 14:32:12 2023 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Tue, 7 Mar 2023 14:32:12 GMT Subject: [jdk11u-dev] RFR: 8297437: javadoc cannot link to old docs (with old style anchors) Message-ID: Backporting JDK-8297437 to 11u for parity, because there are still scenarios for 11u when docs being generated are linked to external old-style anchors docs. No tier1 regressions. The tests from "test/langtools/jdk/javadoc" are passed, except jdk/javadoc/doclet/testIOException/TestIOException.java - it fails on master as well. Refactoring was made in Links.java to avoid duplicating function code. ------------- Commit messages: - Tests fixing - Refactoring - Backport 15a14884013a975707008f648b8e4864e16006ed Changes: https://git.openjdk.org/jdk11u-dev/pull/1794/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1794&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297437 Stats: 141 lines in 6 files changed: 80 ins; 37 del; 24 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1794.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1794/head:pull/1794 PR: https://git.openjdk.org/jdk11u-dev/pull/1794 From rrich at openjdk.org Tue Mar 7 16:32:50 2023 From: rrich at openjdk.org (Richard Reingruber) Date: Tue, 7 Mar 2023 16:32:50 GMT Subject: [jdk11u-dev] RFR: 8303432: Bump update version for OpenJDK: jdk-11.0.20 In-Reply-To: References: Message-ID: <9GR5UlFI-9WPYX7ZvSnZ_mLKgwEFrORiP4D7VYijeW8=.a8cf9c69-212c-4211-8597-eacd0cfe4c20@github.com> On Wed, 1 Mar 2023 09:32:51 GMT, Goetz Lindenmaier wrote: > The version bump needed for 11.0.20 Marked as reviewed by rrich (Reviewer). ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1785 From rrich at openjdk.org Tue Mar 7 16:34:55 2023 From: rrich at openjdk.org (Richard Reingruber) Date: Tue, 7 Mar 2023 16:34:55 GMT Subject: [jdk17u-dev] RFR: 8303433: Bump update version for OpenJDK: jdk-17.0.8 In-Reply-To: References: Message-ID: <52Y3HivWL0RgC_c85QILpzdxmar354Ei2V7f3TYc5rM=.19c249e5-63f7-4f85-83bf-ce0c7bc1ea7b@github.com> On Wed, 1 Mar 2023 09:37:49 GMT, Goetz Lindenmaier wrote: > The required version bump for 17.0.8 Marked as reviewed by rrich (Reviewer). ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1194 From vkempik at openjdk.org Tue Mar 7 16:57:30 2023 From: vkempik at openjdk.org (Vladimir Kempik) Date: Tue, 7 Mar 2023 16:57:30 GMT Subject: [jdk11u-dev] RFR: 8220093: Change to GCC 8.2 for building on Linux at Oracle In-Reply-To: <00LhFA55LLExvB1q2biSALySy6fhgXBI3D9jUyGo4KA=.9c4b9e9d-9224-4764-b783-5502d3179f07@github.com> References: <00LhFA55LLExvB1q2biSALySy6fhgXBI3D9jUyGo4KA=.9c4b9e9d-9224-4764-b783-5502d3179f07@github.com> Message-ID: On Tue, 7 Mar 2023 08:26:51 GMT, Matthias Baesken wrote: > looks good to me, but maybe someone from Oracle should comment on the make/conf/jib-profiles.js change It's wrong way. jib-profiles.js is used internally in oracle. Oracle has their own branch of 11u, and not building from **open**jdk11u Therefore jib-profiles.js change should be dropped from the backport as it has no reason to go into **open**jdk11u ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1792 From sgibbons at openjdk.org Tue Mar 7 19:23:20 2023 From: sgibbons at openjdk.org (Scott Gibbons) Date: Tue, 7 Mar 2023 19:23:20 GMT Subject: [jdk11u-dev] RFR: 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption [v7] In-Reply-To: <_Jo_3FLQo1axYkK6UXXY5D1E0tZuI8vMdtoa56bgp_g=.6cde07f6-b779-4f13-b098-d19c60925267@github.com> References: <93mpH3x185Tc3l9gJdUDE6QsuCkbMpmKYlU18im5xPI=.a6fd26f0-2c31-444a-856c-1e12abc2fdd5@github.com> <_Jo_3FLQo1axYkK6UXXY5D1E0tZuI8vMdtoa56bgp_g=.6cde07f6-b779-4f13-b098-d19c60925267@github.com> Message-ID: On Mon, 6 Mar 2023 19:33:27 GMT, Anthony Scarpino wrote: >> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision: >> >> Address review comment > > Something that should be verified is that this doesn't expose failed auth tag decrypted GCM data or other GCM decryption. There maybe some unexpected differences as this change was after GCM separated from CipherCore in 17. I believe GCM still uses CipherCore in 11. @ascarpino I have been looking to see whether any data could be potentially leaked as a result of my change and cannot envision such a scenario. It appears to me that my change is functionally identical to what it would be without the change. Can you please provide more details? Thanks. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1780 From goetz at openjdk.org Tue Mar 7 20:34:08 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 7 Mar 2023 20:34:08 GMT Subject: [jdk11u-dev] Integrated: 8303432: Bump update version for OpenJDK: jdk-11.0.20 In-Reply-To: References: Message-ID: <4Zn6BH6A78zK4GXKpqcj-C7-Y3UNK0MDob2pfHys8PE=.8d3fd604-e749-470d-aa96-8ee036c12b18@github.com> On Wed, 1 Mar 2023 09:32:51 GMT, Goetz Lindenmaier wrote: > The version bump needed for 11.0.20 This pull request has now been integrated. Changeset: 0748e2ab Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/0748e2abf322a0648c10a268d3d6198ddc24028d Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8303432: Bump update version for OpenJDK: jdk-11.0.20 Reviewed-by: rrich ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1785 From goetz at openjdk.org Tue Mar 7 20:49:28 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 7 Mar 2023 20:49:28 GMT Subject: [jdk17u-dev] Integrated: 8303433: Bump update version for OpenJDK: jdk-17.0.8 In-Reply-To: References: Message-ID: On Wed, 1 Mar 2023 09:37:49 GMT, Goetz Lindenmaier wrote: > The required version bump for 17.0.8 This pull request has now been integrated. Changeset: 1cad49bc Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/1cad49bcd9ea70b3e02ce150e409177eab8851dd Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8303433: Bump update version for OpenJDK: jdk-17.0.8 Reviewed-by: rrich ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1194 From clanger at openjdk.org Tue Mar 7 21:53:47 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 7 Mar 2023 21:53:47 GMT Subject: [jdk11u-dev] RFR: 8220093: Change to GCC 8.2 for building on Linux at Oracle In-Reply-To: References: <00LhFA55LLExvB1q2biSALySy6fhgXBI3D9jUyGo4KA=.9c4b9e9d-9224-4764-b783-5502d3179f07@github.com> Message-ID: On Tue, 7 Mar 2023 16:54:47 GMT, Vladimir Kempik wrote: > > looks good to me, but maybe someone from Oracle should comment on the make/conf/jib-profiles.js change > > It's wrong way. > > jib-profiles.js is used internally in oracle. > > Oracle has their own branch of 11u, and not building from **open**jdk11u Therefore jib-profiles.js change should be dropped from the backport as it has no reason to go into **open**jdk11u I'd say it doesn't matter. As I stated above, it is not relevant in OpenJDK. I can however drop the changes to the file. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1792 From duke at openjdk.org Wed Mar 8 04:42:26 2023 From: duke at openjdk.org (duke) Date: Wed, 8 Mar 2023 04:42:26 GMT Subject: [jdk11u-dev] Withdrawn: 8219705: Wrong media-type for a given serialization method In-Reply-To: References: Message-ID: The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. ---------------------------------------------------------------------- On Fri, 18 Nov 2022 22:55:06 GMT, Tyler Steele wrote: > See comments in https://github.com/openjdk/jdk11u-dev/pull/1530 > > This backport requires a review. It is not marked clean because it does not make the change to jaxp/TEST.ROOT from the original commit. I kept the version bumped by https://github.com/openjdk/jdk11u-dev/commit/00d94836393b0fc0e7136aef379af0726778e0f0. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1531 From tsteele at openjdk.org Wed Mar 8 04:50:04 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Wed, 8 Mar 2023 04:50:04 GMT Subject: [jdk11u-dev] RFR: 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML [v2] In-Reply-To: References: Message-ID: > See comments in https://github.com/openjdk/jdk11u-dev/pull/1530. > > This backport requires a review. It is not marked clean because it does not change the `@LastModified` dates in several places. In all cases, these dates were newer in the current version of jdk11u-dev. In a similar vein, this change adds to a newer list of bug ids in one place. Tyler Steele has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1532/files - new: https://git.openjdk.org/jdk11u-dev/pull/1532/files/a5bcb19e..a5bcb19e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1532&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1532&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1532.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1532/head:pull/1532 PR: https://git.openjdk.org/jdk11u-dev/pull/1532 From serb at openjdk.org Wed Mar 8 10:40:20 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 8 Mar 2023 10:40:20 GMT Subject: [jdk20u] RFR: 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id Message-ID: The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. ---------------------------------------------------------------------- Hi all, This pull request contains a backport of commit [cfb0a25a](https://github.com/openjdk/jdk/commit/cfb0a25a4ee1a9cebd88c84fa622c46fe1c89bae) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Naoto Sato on 6 Mar 2023 and was reviewed by Iris Clark, Jaikiran Pai, Roger Riggs and Lance Andersen. Thanks! ------------- Commit messages: - Backport cfb0a25a4ee1a9cebd88c84fa622c46fe1c89bae Changes: https://git.openjdk.org/jdk20u/pull/14/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=14&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303440 Stats: 81 lines in 2 files changed: 79 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk20u/pull/14.diff Fetch: git fetch https://git.openjdk.org/jdk20u pull/14/head:pull/14 PR: https://git.openjdk.org/jdk20u/pull/14 From serb at openjdk.org Wed Mar 8 10:41:04 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 8 Mar 2023 10:41:04 GMT Subject: [jdk17u-dev] RFR: 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id Message-ID: The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. ---------------------------------------------------------------------- Hi all, This pull request contains a backport of commit [cfb0a25a](https://github.com/openjdk/jdk/commit/cfb0a25a4ee1a9cebd88c84fa622c46fe1c89bae) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Naoto Sato on 6 Mar 2023 and was reviewed by Iris Clark, Jaikiran Pai, Roger Riggs and Lance Andersen. Thanks! ------------- Commit messages: - Backport cfb0a25a4ee1a9cebd88c84fa622c46fe1c89bae Changes: https://git.openjdk.org/jdk17u-dev/pull/1198/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1198&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303440 Stats: 81 lines in 2 files changed: 79 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1198.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1198/head:pull/1198 PR: https://git.openjdk.org/jdk17u-dev/pull/1198 From serb at openjdk.org Wed Mar 8 10:41:12 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 8 Mar 2023 10:41:12 GMT Subject: [jdk11u-dev] RFR: 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id Message-ID: Hi all, This pull request contains a backport of commit [cfb0a25a](https://github.com/openjdk/jdk/commit/cfb0a25a4ee1a9cebd88c84fa622c46fe1c89bae) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Naoto Sato on 6 Mar 2023 and was reviewed by Iris Clark, Jaikiran Pai, Roger Riggs and Lance Andersen. Thanks! ------------- Commit messages: - Backport cfb0a25a4ee1a9cebd88c84fa622c46fe1c89bae Changes: https://git.openjdk.org/jdk11u-dev/pull/1793/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1793&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303440 Stats: 81 lines in 2 files changed: 79 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1793.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1793/head:pull/1793 PR: https://git.openjdk.org/jdk11u-dev/pull/1793 From duke at openjdk.org Wed Mar 8 11:55:08 2023 From: duke at openjdk.org (Ravali Yatham) Date: Wed, 8 Mar 2023 11:55:08 GMT Subject: [jdk17u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message Message-ID: Added specific class loader object to proxy IllegalArgumentException from which the class was not visible The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 ------------- Commit messages: - Backport 9f9d678591e02ecaeae7b81eeefb0ba41c7b4dae Changes: https://git.openjdk.org/jdk17u-dev/pull/1199/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1199&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8302791 Stats: 16 lines in 4 files changed: 15 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1199.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1199/head:pull/1199 PR: https://git.openjdk.org/jdk17u-dev/pull/1199 From rhalade at openjdk.org Wed Mar 8 21:33:07 2023 From: rhalade at openjdk.org (Rajan Halade) Date: Wed, 8 Mar 2023 21:33:07 GMT Subject: [jdk20u] RFR: 8282201: Consider removal of expiry check in VerifyCACerts.java test Message-ID: Fix to 20u CPU else test would fail in June 2023 ------------- Commit messages: - Backport 5b43804b7988ea4abd6458fba0a042b7bd6d9cb8 Changes: https://git.openjdk.org/jdk20u/pull/16/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=16&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282201 Stats: 47 lines in 1 file changed: 16 ins; 15 del; 16 mod Patch: https://git.openjdk.org/jdk20u/pull/16.diff Fetch: git fetch https://git.openjdk.org/jdk20u pull/16/head:pull/16 PR: https://git.openjdk.org/jdk20u/pull/16 From serb at openjdk.org Thu Mar 9 08:58:08 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 9 Mar 2023 08:58:08 GMT Subject: [jdk20u] RFR: 8303102: jcmd: ManagementAgent.status truncates the text longer than O_BUFLEN Message-ID: Hi all, This pull request contains a backport of commit [a43931b7](https://github.com/openjdk/jdk/commit/a43931b79cb25d218e8f9b4d4f3a106f59cb2d37) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 26 Feb 2023 and was reviewed by David Holmes. Thanks! ------------- Commit messages: - Backport a43931b79cb25d218e8f9b4d4f3a106f59cb2d37 Changes: https://git.openjdk.org/jdk20u/pull/15/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=15&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303102 Stats: 4 lines in 2 files changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk20u/pull/15.diff Fetch: git fetch https://git.openjdk.org/jdk20u pull/15/head:pull/15 PR: https://git.openjdk.org/jdk20u/pull/15 From serb at openjdk.org Thu Mar 9 08:58:24 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 9 Mar 2023 08:58:24 GMT Subject: [jdk11u-dev] RFR: 8303102: jcmd: ManagementAgent.status truncates the text longer than O_BUFLEN Message-ID: Hi all, This pull request contains a backport of commit [a43931b7](https://github.com/openjdk/jdk/commit/a43931b79cb25d218e8f9b4d4f3a106f59cb2d37) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 26 Feb 2023 and was reviewed by David Holmes. Thanks! ------------- Commit messages: - Backport a43931b79cb25d218e8f9b4d4f3a106f59cb2d37 Changes: https://git.openjdk.org/jdk11u-dev/pull/1795/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1795&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303102 Stats: 4 lines in 2 files changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1795.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1795/head:pull/1795 PR: https://git.openjdk.org/jdk11u-dev/pull/1795 From serb at openjdk.org Thu Mar 9 08:58:12 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 9 Mar 2023 08:58:12 GMT Subject: [jdk17u-dev] RFR: 8303102: jcmd: ManagementAgent.status truncates the text longer than O_BUFLEN Message-ID: <97XeHzFVop7YvQYHiYIKP2zXh6x7cYBwnRMEjuBeiXs=.ca85c142-fc81-417e-a879-efdc4f8fff93@github.com> Hi all, This pull request contains a backport of commit [a43931b7](https://github.com/openjdk/jdk/commit/a43931b79cb25d218e8f9b4d4f3a106f59cb2d37) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 26 Feb 2023 and was reviewed by David Holmes. Thanks! ------------- Commit messages: - Backport a43931b79cb25d218e8f9b4d4f3a106f59cb2d37 Changes: https://git.openjdk.org/jdk17u-dev/pull/1196/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1196&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303102 Stats: 4 lines in 2 files changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1196.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1196/head:pull/1196 PR: https://git.openjdk.org/jdk17u-dev/pull/1196 From zzambers at openjdk.org Thu Mar 9 13:00:23 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Thu, 9 Mar 2023 13:00:23 GMT Subject: [jdk11u-dev] RFR: 8293232: Fix race condition in pkcs11 SessionManager Message-ID: Backport - fix for race condition in pkcs11 SessionManager. Clean. Passed [jdk_security](https://github.com/zzambers/jdk-tester/actions/runs/4347091189/jobs/7593974147) tests. ------------- Commit messages: - Backport 67f31bb90b62fafc71e18c4c10e0f7e1b6896dc4 Changes: https://git.openjdk.org/jdk11u-dev/pull/1797/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1797&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293232 Stats: 7 lines in 1 file changed: 5 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1797.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1797/head:pull/1797 PR: https://git.openjdk.org/jdk11u-dev/pull/1797 From zzambers at openjdk.org Thu Mar 9 13:00:26 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Thu, 9 Mar 2023 13:00:26 GMT Subject: [jdk11u-dev] RFR: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary Message-ID: The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. ---------------------------------------------------------------------- Backport fixing SSLSocket, not to use workaround with user_canceled alert for TLS 1.3 close, when not necessary, as it causes problems with gnutls client. Clean. Passed [jdk_security](https://github.com/zzambers/jdk-tester/actions/runs/4347121530/jobs/7594040836) tests. ------------- Commit messages: - Backport eef3c9605e2d75fc5724118fd0140b7844daa6e8 Changes: https://git.openjdk.org/jdk11u-dev/pull/1796/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1796&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282600 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1796.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1796/head:pull/1796 PR: https://git.openjdk.org/jdk11u-dev/pull/1796 From sgibbons at openjdk.org Thu Mar 9 15:48:50 2023 From: sgibbons at openjdk.org (Scott Gibbons) Date: Thu, 9 Mar 2023 15:48:50 GMT Subject: [jdk11u-dev] RFR: 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption [v7] In-Reply-To: <93mpH3x185Tc3l9gJdUDE6QsuCkbMpmKYlU18im5xPI=.a6fd26f0-2c31-444a-856c-1e12abc2fdd5@github.com> References: <93mpH3x185Tc3l9gJdUDE6QsuCkbMpmKYlU18im5xPI=.a6fd26f0-2c31-444a-856c-1e12abc2fdd5@github.com> Message-ID: On Mon, 6 Mar 2023 15:59:05 GMT, Scott Gibbons wrote: >> Backporting because this change results in ~3x performance improvement in AES-CTR. >> >> Risk is low. Tested with tier1 and benchmark. >> >> The PR does not backport cleanly. The buffer name was changed, but functionally remains the same. > > Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision: > > Address review comment I believe there is no additional risk to data leakage as the result of this change, so I'm proposing integration. Thanks. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1780 From robm at openjdk.org Thu Mar 9 16:02:30 2023 From: robm at openjdk.org (Rob McKenna) Date: Thu, 9 Mar 2023 16:02:30 GMT Subject: [jdk20u] RFR: JDK-8303906: Update jdk20u fix version to 20.0.2 Message-ID: Update the jdk20u jcheck fix version ------------- Commit messages: - JDK-8303906: Update jdk20u fix version to 20.0.2 Changes: https://git.openjdk.org/jdk20u/pull/17/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=17&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303906 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk20u/pull/17.diff Fetch: git fetch https://git.openjdk.org/jdk20u pull/17/head:pull/17 PR: https://git.openjdk.org/jdk20u/pull/17 From coffeys at openjdk.org Thu Mar 9 16:12:57 2023 From: coffeys at openjdk.org (Sean Coffey) Date: Thu, 9 Mar 2023 16:12:57 GMT Subject: [jdk20u] RFR: JDK-8303906: Update jdk20u fix version to 20.0.2 In-Reply-To: References: Message-ID: On Thu, 9 Mar 2023 15:52:43 GMT, Rob McKenna wrote: > Update the jdk20u jcheck fix version assuming DEFAULT_VERSION_DATE get's updated by another PR ------------- Marked as reviewed by coffeys (Reviewer). PR: https://git.openjdk.org/jdk20u/pull/17 From robm at openjdk.org Thu Mar 9 16:23:48 2023 From: robm at openjdk.org (Rob McKenna) Date: Thu, 9 Mar 2023 16:23:48 GMT Subject: [jdk20u] Integrated: JDK-8303906: Update jdk20u fix version to 20.0.2 In-Reply-To: References: Message-ID: On Thu, 9 Mar 2023 15:52:43 GMT, Rob McKenna wrote: > Update the jdk20u jcheck fix version This pull request has now been integrated. Changeset: 0f4bb872 Author: Rob McKenna URL: https://git.openjdk.org/jdk20u/commit/0f4bb872f541e66b5b0d1339d370274fe1a8297b Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8303906: Update jdk20u fix version to 20.0.2 Reviewed-by: coffeys ------------- PR: https://git.openjdk.org/jdk20u/pull/17 From duke at openjdk.org Fri Mar 10 08:44:31 2023 From: duke at openjdk.org (Ravali Yatham) Date: Fri, 10 Mar 2023 08:44:31 GMT Subject: [jdk17u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. ---------------------------------------------------------------------- On Wed, 8 Mar 2023 11:47:56 GMT, Ravali Yatham wrote: > Added specific class loader object to proxy IllegalArgumentException from which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 > > OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 @mlchung - Please kindly review the back-ported PR. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1199 From zzambers at openjdk.org Fri Mar 10 09:08:35 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Fri, 10 Mar 2023 09:08:35 GMT Subject: [jdk11u-dev] Integrated: 8293815: P11PSSSignature.engineUpdate should not print debug messages during normal operation In-Reply-To: References: Message-ID: On Tue, 28 Feb 2023 13:05:12 GMT, Zdenek Zambersky wrote: > Backport from [17u-dev](https://github.com/openjdk/jdk17u-dev/commit/17438250773d086b5db0480152942799e7accf60) fixing debug messages printed by P11PSSSignature class during normal operation. > > Testing: > Passed [jdk_security](https://github.com/zzambers/jdk-tester/actions/runs/4285612546/jobs/7464123202). This pull request has now been integrated. Changeset: 80615a6f Author: Zdenek Zambersky Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/80615a6f39bf8929908804ce3f9f5c6d4b3f2864 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8293815: P11PSSSignature.engineUpdate should not print debug messages during normal operation Backport-of: 17438250773d086b5db0480152942799e7accf60 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1782 From zzambers at openjdk.org Fri Mar 10 09:10:29 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Fri, 10 Mar 2023 09:10:29 GMT Subject: [jdk11u-dev] Integrated: 8289301: P11Cipher should not throw out of bounds exception during padding In-Reply-To: References: Message-ID: On Wed, 1 Mar 2023 14:02:25 GMT, Zdenek Zambersky wrote: > Fix for possible OOB exception by P11Cipher. Backported from [jdk17u-dev](https://github.com/openjdk/jdk17u-dev/commit/2f7e673f521a707d7be7b83efe73df2010d36206). > > Testing: > [Passed jdk_security.](https://github.com/zzambers/jdk-tester/actions/runs/4293705819) This pull request has now been integrated. Changeset: 7d899197 Author: Zdenek Zambersky Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/7d8991978bbe1cc03ba2386f5e699239ba47934c Stats: 124 lines in 2 files changed: 117 ins; 0 del; 7 mod 8289301: P11Cipher should not throw out of bounds exception during padding Backport-of: 2f7e673f521a707d7be7b83efe73df2010d36206 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1786 From clanger at openjdk.org Fri Mar 10 09:20:22 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 10 Mar 2023 09:20:22 GMT Subject: [jdk11u-dev] RFR: 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption [v7] In-Reply-To: <93mpH3x185Tc3l9gJdUDE6QsuCkbMpmKYlU18im5xPI=.a6fd26f0-2c31-444a-856c-1e12abc2fdd5@github.com> References: <93mpH3x185Tc3l9gJdUDE6QsuCkbMpmKYlU18im5xPI=.a6fd26f0-2c31-444a-856c-1e12abc2fdd5@github.com> Message-ID: On Mon, 6 Mar 2023 15:59:05 GMT, Scott Gibbons wrote: >> Backporting because this change results in ~3x performance improvement in AES-CTR. >> >> Risk is low. Tested with tier1 and benchmark. >> >> The PR does not backport cleanly. The buffer name was changed, but functionally remains the same. > > Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision: > > Address review comment > I believe there is no additional risk to data leakage as the result of this change, so I'm proposing integration. Thanks. > > /integrate ok ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1780 From sgibbons at openjdk.org Fri Mar 10 09:23:25 2023 From: sgibbons at openjdk.org (Scott Gibbons) Date: Fri, 10 Mar 2023 09:23:25 GMT Subject: [jdk11u-dev] Integrated: 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption In-Reply-To: References: Message-ID: <_2rvpJ6dtjT7SQ7mME726sYxFLyLWopLZmij_uPlQbM=.49d983ff-1c68-4567-b2fc-94ea3008e4dc@github.com> On Mon, 27 Feb 2023 17:58:21 GMT, Scott Gibbons wrote: > Backporting because this change results in ~3x performance improvement in AES-CTR. > > Risk is low. Tested with tier1 and benchmark. > > The PR does not backport cleanly. The buffer name was changed, but functionally remains the same. This pull request has now been integrated. Changeset: 479ddb6e Author: Scott Gibbons Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/479ddb6e5cb5b6227206a4a01afad8db025cdc53 Stats: 16 lines in 1 file changed: 6 ins; 0 del; 10 mod 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption Reviewed-by: clanger Backport-of: 409382ba4b43bf48ed0086020dd20641effd35b6 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1780 From tsteele at openjdk.org Fri Mar 10 09:27:22 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Fri, 10 Mar 2023 09:27:22 GMT Subject: [jdk20u] Integrated: 8303186: Missing Classpath exception from Continuation.c In-Reply-To: References: Message-ID: On Fri, 3 Mar 2023 00:37:39 GMT, Tyler Steele wrote: > Hi all, > > This pull request contains a backport of commit [dc08216f](https://github.com/openjdk/jdk/commit/dc08216f0ef55970c96df43bcc86ebd5792d486e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Tyler Steele on 2 Mar 2023 and was reviewed by David Holmes and Jaikiran Pai. > > I recognize that we are in the RC stage of jdk20 release. I'd like to include this change in the first release of jdk20, as it probably should have happened in jdk19. It isn't a code change, so the risk is quite low. > > Thanks! This pull request has now been integrated. Changeset: 5bd23fde Author: Tyler Steele Committer: Christoph Langer URL: https://git.openjdk.org/jdk20u/commit/5bd23fde1eb0cbcb1df458be04787b597043aec5 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8303186: Missing Classpath exception from Continuation.c Backport-of: dc08216f0ef55970c96df43bcc86ebd5792d486e ------------- PR: https://git.openjdk.org/jdk20u/pull/13 From vkempik at openjdk.org Fri Mar 10 11:14:12 2023 From: vkempik at openjdk.org (Vladimir Kempik) Date: Fri, 10 Mar 2023 11:14:12 GMT Subject: [jdk17u-dev] RFR: 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures Message-ID: Clean backport, helps weak and slow platforms to have stable test results ------------- Commit messages: - Backport 6e6202c14d0f6dd26369f21883ff317057aa469f Changes: https://git.openjdk.org/jdk17u-dev/pull/1200/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1200&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292407 Stats: 951 lines in 45 files changed: 800 ins; 0 del; 151 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1200.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1200/head:pull/1200 PR: https://git.openjdk.org/jdk17u-dev/pull/1200 From vkempik at openjdk.org Fri Mar 10 13:03:25 2023 From: vkempik at openjdk.org (Vladimir Kempik) Date: Fri, 10 Mar 2023 13:03:25 GMT Subject: [jdk17u-dev] RFR: 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures In-Reply-To: References: Message-ID: On Fri, 10 Mar 2023 11:06:00 GMT, Vladimir Kempik wrote: > Clean backport, helps weak and slow platforms to have stable test results Windows debug build tests failure is infra issue and unrelated ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1200 From mchung at openjdk.org Fri Mar 10 18:11:16 2023 From: mchung at openjdk.org (Mandy Chung) Date: Fri, 10 Mar 2023 18:11:16 GMT Subject: [jdk17u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: On Wed, 8 Mar 2023 11:47:56 GMT, Ravali Yatham wrote: > Added specific class loader object to proxy IllegalArgumentException from which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 > > OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 Is this a clean backport? ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1199 From duke at openjdk.org Fri Mar 10 18:51:29 2023 From: duke at openjdk.org (Autumn Capasso) Date: Fri, 10 Mar 2023 18:51:29 GMT Subject: [jdk11u-dev] Withdrawn: 8264290: Create implementation for NSAccessibilityComponentGroup protocol peer In-Reply-To: <2JtYskB8iinBtJICdw97NDWSmYza7FIE8iyepdoUeG8=.cc5b55d0-0f39-4c84-8344-9d877a9788de@github.com> References: <2JtYskB8iinBtJICdw97NDWSmYza7FIE8iyepdoUeG8=.cc5b55d0-0f39-4c84-8344-9d877a9788de@github.com> Message-ID: <2gJe76nyD-UpaQhuv9vkeWe2QwtUR4FB0Mtcb0hGDtA=.8e11e460-049e-4540-bdd4-ff12d13d43ea@github.com> On Thu, 2 Feb 2023 03:02:42 GMT, Autumn Capasso wrote: > This Backport is clean [JDK-8264290](https://bugs.openjdk.org/browse/JDK-8264290). Tested and built locally. Part of 28 part Accessibility series [JDK-8152350](https://bugs.openjdk.org/browse/JDK-8152350). This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1705 From mchung at openjdk.org Fri Mar 10 19:04:17 2023 From: mchung at openjdk.org (Mandy Chung) Date: Fri, 10 Mar 2023 19:04:17 GMT Subject: [jdk17u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: On Wed, 8 Mar 2023 11:47:56 GMT, Ravali Yatham wrote: > Added specific class loader object to proxy IllegalArgumentException from which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 > > OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 Marked as reviewed by mchung (Reviewer). ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1199 From manc at openjdk.org Fri Mar 10 20:44:24 2023 From: manc at openjdk.org (Man Cao) Date: Fri, 10 Mar 2023 20:44:24 GMT Subject: [jdk20u] RFR: 8303937: Corrupted heap dumps due to missing retries for os::write() Message-ID: No conflict backporting to 20u. I'll need a sponsor to help pushing it. ------------- Commit messages: - Backport bf16b5b9880eb89b283006db090dce4346aa877b Changes: https://git.openjdk.org/jdk20u/pull/18/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=18&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303937 Stats: 7 lines in 1 file changed: 4 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk20u/pull/18.diff Fetch: git fetch https://git.openjdk.org/jdk20u pull/18/head:pull/18 PR: https://git.openjdk.org/jdk20u/pull/18 From duke at openjdk.org Fri Mar 10 21:13:44 2023 From: duke at openjdk.org (Autumn Capasso) Date: Fri, 10 Mar 2023 21:13:44 GMT Subject: [jdk11u-dev] Withdrawn: 8264304: Create implementation for NSAccessibilityToolbar protocol peer In-Reply-To: References: Message-ID: On Fri, 3 Feb 2023 01:32:34 GMT, Autumn Capasso wrote: > Clean backport [JDK-8264304](https://bugs.openjdk.org/browse/JDK-8264304). Part of 28 Accessibility backport https://bugs.openjdk.org/browse/JDK-8152350. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1706 From duke at openjdk.org Fri Mar 10 21:28:39 2023 From: duke at openjdk.org (Autumn Capasso) Date: Fri, 10 Mar 2023 21:28:39 GMT Subject: [jdk11u-dev] RFR: 8264290: Create implementation for NSAccessibilityComponentGroup protocol peer Message-ID: <2pBjo9uNaKMVQ3WZbiY23ZDHfrvzpxBtnRAZnIrzVtk=.9baa415a-1c20-42d8-8867-98b24c6e2753@github.com> This backport is part of the 28 backport Accessibility series JDK-8152350. Commented out line 61 of commoneComponentAccesssibilty.m until backport JDK-8262981 is reworked. ------------- Commit messages: - Merge branch 'master' into JDK-8264290 - Backport f07dcf471c160e09fbc748124998923e7d453e66 Changes: https://git.openjdk.org/jdk11u-dev/pull/1799/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1799&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8264290 Stats: 64 lines in 3 files changed: 60 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1799.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1799/head:pull/1799 PR: https://git.openjdk.org/jdk11u-dev/pull/1799 From manc at openjdk.org Fri Mar 10 21:29:36 2023 From: manc at openjdk.org (Man Cao) Date: Fri, 10 Mar 2023 21:29:36 GMT Subject: [jdk17u-dev] RFR: 8303937: Corrupted heap dumps due to missing retries for os::write() Message-ID: https://bugs.openjdk.org/browse/JDK-8303937 fixes a real bug that causes heap dump corruption. Trivial merge conflict, resolved by removing (ssize_t) cast before os::write(). I'll need a sponsor to help push this into 17u-dev. ------------- Commit messages: - Backport bf16b5b9880eb89b283006db090dce4346aa877b Changes: https://git.openjdk.org/jdk17u-dev/pull/1201/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1201&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303937 Stats: 7 lines in 1 file changed: 4 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1201.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1201/head:pull/1201 PR: https://git.openjdk.org/jdk17u-dev/pull/1201 From duke at openjdk.org Fri Mar 10 21:30:36 2023 From: duke at openjdk.org (Autumn Capasso) Date: Fri, 10 Mar 2023 21:30:36 GMT Subject: [jdk11u-dev] RFR: 8264304: Create implementation for NSAccessibilityToolbar protocol peer Message-ID: This backport is part of the 28 backport Accessibility series JDK-8152350. ------------- Commit messages: - Merge branch 'master' into JDK-8264304 - Backport 4d26f22b9adcf7cecca5316348ef670ac2dbc365 - Backport f07dcf471c160e09fbc748124998923e7d453e66 Changes: https://git.openjdk.org/jdk11u-dev/pull/1800/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1800&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8264304 Stats: 104 lines in 5 files changed: 98 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1800.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1800/head:pull/1800 PR: https://git.openjdk.org/jdk11u-dev/pull/1800 From manc at openjdk.org Fri Mar 10 22:04:18 2023 From: manc at openjdk.org (Man Cao) Date: Fri, 10 Mar 2023 22:04:18 GMT Subject: [jdk11u-dev] RFR: 8303937: Corrupted heap dumps due to missing retries for os::write() Message-ID: https://bugs.openjdk.org/browse/JDK-8303937 fixes a real bug that causes heap dump corruption. This bug was introduced into 11.0.14u. Trivial merge conflict, resolved by removing (ssize_t) cast before os::write(). I'll need a sponsor to help push this into 11u-dev. ------------- Commit messages: - Backport bf16b5b9880eb89b283006db090dce4346aa877b Changes: https://git.openjdk.org/jdk11u-dev/pull/1801/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1801&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303937 Stats: 8 lines in 1 file changed: 4 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1801.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1801/head:pull/1801 PR: https://git.openjdk.org/jdk11u-dev/pull/1801 From phh at openjdk.org Fri Mar 10 22:46:18 2023 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 10 Mar 2023 22:46:18 GMT Subject: [jdk11u-dev] RFR: 8264290: Create implementation for NSAccessibilityComponentGroup protocol peer In-Reply-To: <2pBjo9uNaKMVQ3WZbiY23ZDHfrvzpxBtnRAZnIrzVtk=.9baa415a-1c20-42d8-8867-98b24c6e2753@github.com> References: <2pBjo9uNaKMVQ3WZbiY23ZDHfrvzpxBtnRAZnIrzVtk=.9baa415a-1c20-42d8-8867-98b24c6e2753@github.com> Message-ID: On Fri, 10 Mar 2023 21:01:44 GMT, Autumn Capasso wrote: > This backport is part of the 28 backport Accessibility series JDK-8152350. Commented out line 61 of commoneComponentAccesssibilty.m until backport JDK-8262981 is reworked. Clean except for the context difference in CommonComponentAccessibility.m. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1799 From duke at openjdk.org Sat Mar 11 08:59:43 2023 From: duke at openjdk.org (Autumn Capasso) Date: Sat, 11 Mar 2023 08:59:43 GMT Subject: [jdk11u-dev] Withdrawn: 8264304: Create implementation for NSAccessibilityToolbar protocol peer In-Reply-To: References: Message-ID: On Fri, 10 Mar 2023 21:14:07 GMT, Autumn Capasso wrote: > This backport is part of the 28 backport Accessibility series JDK-8152350. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1800 From duke at openjdk.org Mon Mar 13 04:08:29 2023 From: duke at openjdk.org (Ravali Yatham) Date: Mon, 13 Mar 2023 04:08:29 GMT Subject: [jdk17u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: On Fri, 10 Mar 2023 18:08:45 GMT, Mandy Chung wrote: > Is this a clean backport? @mlchung I've resolved merge conflicts and back-ported required changes. I've issued the integrate command. Now it is ready to be sponsored. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1199 From vkempik at openjdk.org Mon Mar 13 07:26:39 2023 From: vkempik at openjdk.org (Vladimir Kempik) Date: Mon, 13 Mar 2023 07:26:39 GMT Subject: [jdk17u-dev] Integrated: 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures In-Reply-To: References: Message-ID: On Fri, 10 Mar 2023 11:06:00 GMT, Vladimir Kempik wrote: > Clean backport, helps weak and slow platforms to have stable test results This pull request has now been integrated. Changeset: 1ad9e684 Author: Vladimir Kempik URL: https://git.openjdk.org/jdk17u-dev/commit/1ad9e6843ab54dbd16631474969986c1de87dd9b Stats: 951 lines in 45 files changed: 800 ins; 0 del; 151 mod 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures Backport-of: 6e6202c14d0f6dd26369f21883ff317057aa469f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1200 From goetz at openjdk.org Mon Mar 13 07:27:28 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 13 Mar 2023 07:27:28 GMT Subject: [jdk17u-dev] RFR: 8303937: Corrupted heap dumps due to missing retries for os::write() In-Reply-To: References: Message-ID: On Fri, 10 Mar 2023 21:06:18 GMT, Man Cao wrote: > https://bugs.openjdk.org/browse/JDK-8303937 fixes a real bug that causes heap dump corruption. > > Trivial merge conflict, resolved by removing (ssize_t) cast before os::write(). > > I'll need a sponsor to help push this into 17u-dev. Review missing. Risk assessment missing. Please follow instructions! ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1201 From goetz at openjdk.org Mon Mar 13 07:29:39 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 13 Mar 2023 07:29:39 GMT Subject: [jdk11u-dev] RFR: 8220093: Change to GCC 8.2 for building on Linux at Oracle In-Reply-To: References: Message-ID: On Sun, 5 Mar 2023 12:03:52 GMT, Christoph Langer wrote: > This is a backport of [JDK-8220093](https://bugs.openjdk.org/browse/JDK-8220093). The motivation for doing it is that configure output will then show same output as in higher releases for the used linker. E.g. > > `configure: Using gcc linker version 2.36.1 [GNU ld (GNU Binutils) 2.36.1]` > > vs > > `configure: Using gcc linker version 8.5.0 [collect2 version 8.5.0]` > > One can then deduct the version of binutils used. > > I had to make a few modifications. In toolchain.m4, [JDK-8257679](https://bugs.openjdk.org/browse/JDK-8257679) was already present so I had to make the hunk fit. The other adaptations are in jib-profiles.js which is not relevant to OpenJDK because it's used internally at Oracle only and some improvements to the devkit build scripts. Why are the tests failing? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1792 From duke at openjdk.org Mon Mar 13 07:45:26 2023 From: duke at openjdk.org (Ravali Yatham) Date: Mon, 13 Mar 2023 07:45:26 GMT Subject: [jdk11u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message Message-ID: Added specific class loader object to proxy IllegalArgumentException from which the class was not visible The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 ------------- Commit messages: - Backport 9f9d678591e02ecaeae7b81eeefb0ba41c7b4dae Changes: https://git.openjdk.org/jdk11u-dev/pull/1802/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1802&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8302791 Stats: 18 lines in 4 files changed: 17 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1802.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1802/head:pull/1802 PR: https://git.openjdk.org/jdk11u-dev/pull/1802 From clanger at openjdk.org Mon Mar 13 07:53:33 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 13 Mar 2023 07:53:33 GMT Subject: [jdk11u-dev] RFR: 8220093: Change to GCC 8.2 for building on Linux at Oracle In-Reply-To: References: Message-ID: On Mon, 13 Mar 2023 07:26:35 GMT, Goetz Lindenmaier wrote: > Why are the tests failing? Probably nothing to do with my change - I've retriggered. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1792 From duke at openjdk.org Mon Mar 13 07:58:35 2023 From: duke at openjdk.org (Ravali Yatham) Date: Mon, 13 Mar 2023 07:58:35 GMT Subject: [jdk11u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: On Mon, 13 Mar 2023 07:37:53 GMT, Ravali Yatham wrote: > Added specific class loader object to proxy IllegalArgumentException from which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 > > OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 @mlchung - Could you kindly review the back-ported PR for jdk11? I've imported JavaLangAccess, SharedSecrets packages and also created a reference JLA to an object of type JavaLangAccess. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1802 From clanger at openjdk.org Mon Mar 13 08:00:10 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 13 Mar 2023 08:00:10 GMT Subject: [jdk11u-dev] RFR: 8220093: Change to GCC 8.2 for building on Linux at Oracle [v2] In-Reply-To: References: Message-ID: > This is a backport of [JDK-8220093](https://bugs.openjdk.org/browse/JDK-8220093). The motivation for doing it is that configure output will then show same output as in higher releases for the used linker. E.g. > > `configure: Using gcc linker version 2.36.1 [GNU ld (GNU Binutils) 2.36.1]` > > vs > > `configure: Using gcc linker version 8.5.0 [collect2 version 8.5.0]` > > One can then deduct the version of binutils used. > > I had to make a few modifications. In toolchain.m4, [JDK-8257679](https://bugs.openjdk.org/browse/JDK-8257679) was already present so I had to make the hunk fit. The other adaptations are in jib-profiles.js which is not relevant to OpenJDK because it's used internally at Oracle only and some improvements to the devkit build scripts. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into 8220093 - 8220093: Change to GCC 8.2 for building on Linux at Oracle Reviewed-by: tbell ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1792/files - new: https://git.openjdk.org/jdk11u-dev/pull/1792/files/5c375ac1..284fdd82 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1792&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1792&range=00-01 Stats: 147 lines in 6 files changed: 123 ins; 0 del; 24 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1792.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1792/head:pull/1792 PR: https://git.openjdk.org/jdk11u-dev/pull/1792 From clanger at openjdk.org Mon Mar 13 08:11:33 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 13 Mar 2023 08:11:33 GMT Subject: [jdk17u-dev] RFR: 8303937: Corrupted heap dumps due to missing retries for os::write() In-Reply-To: References: Message-ID: <1zpTFGYujkzRQoOOJU_VyGRdqDLkqT46pEdSOC0Wc3Y=.82f3f29b-e26e-41a0-8618-3a27fc78f7cf@github.com> On Fri, 10 Mar 2023 21:06:18 GMT, Man Cao wrote: > https://bugs.openjdk.org/browse/JDK-8303937 fixes a real bug that causes heap dump corruption. > > Trivial merge conflict, resolved by removing (ssize_t) cast before os::write(). > > I'll need a sponsor to help push this into 17u-dev. @caoman Can you please enable & run GitHub actions? Thanks. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1201 From clanger at openjdk.org Mon Mar 13 08:13:33 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 13 Mar 2023 08:13:33 GMT Subject: [jdk11u-dev] RFR: 8303937: Corrupted heap dumps due to missing retries for os::write() In-Reply-To: References: Message-ID: On Fri, 10 Mar 2023 21:57:34 GMT, Man Cao wrote: > https://bugs.openjdk.org/browse/JDK-8303937 fixes a real bug that causes heap dump corruption. This bug was introduced into 11.0.14u. > > Trivial merge conflict, resolved by removing (ssize_t) cast before os::write(). > > I'll need a sponsor to help push this into 11u-dev. LGTM! Thanks for spotting, fixing and backporting. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1801 From clanger at openjdk.org Mon Mar 13 08:18:32 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 13 Mar 2023 08:18:32 GMT Subject: [jdk17u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: On Mon, 13 Mar 2023 04:05:18 GMT, Ravali Yatham wrote: > > Is this a clean backport? > > @mlchung I've resolved merge conflicts and back-ported required changes. I've issued the integrate command. Now it is ready to be sponsored. @yathamravali For OpenJDK updates that is not sufficient and you must not integrate before obtaining maintainer's approval. Please follow the process documented at https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1199 From duke at openjdk.org Mon Mar 13 09:53:38 2023 From: duke at openjdk.org (Ravali Yatham) Date: Mon, 13 Mar 2023 09:53:38 GMT Subject: [jdk17u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: On Wed, 8 Mar 2023 11:47:56 GMT, Ravali Yatham wrote: > Added specific class loader object to proxy IllegalArgumentException from which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 > > OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 `/integrate` ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1199 From duke at openjdk.org Mon Mar 13 10:17:50 2023 From: duke at openjdk.org (Ravali Yatham) Date: Mon, 13 Mar 2023 10:17:50 GMT Subject: [jdk17u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: On Mon, 13 Mar 2023 08:15:14 GMT, Christoph Langer wrote: >>> Is this a clean backport? >> >> @mlchung I've resolved merge conflicts and back-ported required changes. I've issued the integrate command. Now it is ready to be sponsored. > >> > Is this a clean backport? >> >> @mlchung I've resolved merge conflicts and back-ported required changes. I've issued the integrate command. Now it is ready to be sponsored. > > @yathamravali For OpenJDK updates that is not sufficient and you must not integrate before obtaining maintainer's approval. Please follow the process documented at https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix @RealCLanger - Thanks for the info. Could see you on [maintainers list](https://wiki.openjdk.org/display/JDKUpdates/JDK11u). Could you please review this PR. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1199 From duke at openjdk.org Mon Mar 13 10:17:54 2023 From: duke at openjdk.org (Ravali Yatham) Date: Mon, 13 Mar 2023 10:17:54 GMT Subject: [jdk17u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: On Wed, 8 Mar 2023 11:47:56 GMT, Ravali Yatham wrote: > Added specific class loader object to proxy IllegalArgumentException from which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 > > OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 @backwaterred - Tyler, Could you please add the ifix request labels in JBS issue? ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1199 From duke at openjdk.org Mon Mar 13 10:18:53 2023 From: duke at openjdk.org (Ravali Yatham) Date: Mon, 13 Mar 2023 10:18:53 GMT Subject: [jdk11u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: <7x8LWIagJEYz-PkOeI77j8wBWHgQzX3DKHYiTxw3jHA=.55d42431-7c7f-4dda-918a-846f0f4ef149@github.com> On Mon, 13 Mar 2023 07:37:53 GMT, Ravali Yatham wrote: > Added specific class loader object to proxy IllegalArgumentException from which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 > > OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 @backwaterred - Could you please add `jdk11u-fix-request` to JBS issue? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1802 From serb at openjdk.org Mon Mar 13 10:28:28 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 13 Mar 2023 10:28:28 GMT Subject: [jdk17u-dev] Integrated: 8270859: Post JEP 411 refactoring: client libs with maximum covering > 10K In-Reply-To: References: Message-ID: On Thu, 9 Feb 2023 02:50:41 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [90cd2fa1](https://github.com/openjdk/jdk/commit/90cd2fa16458dcc3e36171fa4bf21f26bc92b168) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Weijun Wang on 27 Jul 2021 and was reviewed by Sergey Bylokhov. > Thanks! This pull request has now been integrated. Changeset: c118b0e9 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u-dev/commit/c118b0e9c835fdec7c0e5ac743d70d4cbda15ad5 Stats: 283 lines in 22 files changed: 147 ins; 98 del; 38 mod 8270859: Post JEP 411 refactoring: client libs with maximum covering > 10K Backport-of: 90cd2fa16458dcc3e36171fa4bf21f26bc92b168 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1148 From mbaesken at openjdk.org Mon Mar 13 12:16:14 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 13 Mar 2023 12:16:14 GMT Subject: [jdk20u] RFR: 8300692: GCC 12 reports some compiler warnings in bundled freetype Message-ID: 8300692: GCC 12 reports some compiler warnings in bundled freetype ------------- Commit messages: - Backport a6c2a2ae79be6810dca55b13bfc8a7625f25d48d Changes: https://git.openjdk.org/jdk20u/pull/19/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=19&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8300692 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk20u/pull/19.diff Fetch: git fetch https://git.openjdk.org/jdk20u pull/19/head:pull/19 PR: https://git.openjdk.org/jdk20u/pull/19 From phh at openjdk.org Mon Mar 13 12:26:35 2023 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 13 Mar 2023 12:26:35 GMT Subject: [jdk11u-dev] RFR: 8264290: Create implementation for NSAccessibilityComponentGroup protocol peer In-Reply-To: <2pBjo9uNaKMVQ3WZbiY23ZDHfrvzpxBtnRAZnIrzVtk=.9baa415a-1c20-42d8-8867-98b24c6e2753@github.com> References: <2pBjo9uNaKMVQ3WZbiY23ZDHfrvzpxBtnRAZnIrzVtk=.9baa415a-1c20-42d8-8867-98b24c6e2753@github.com> Message-ID: On Fri, 10 Mar 2023 21:01:44 GMT, Autumn Capasso wrote: > This backport is part of the 28 backport Accessibility series JDK-8152350. Commented out line 61 of commoneComponentAccesssibilty.m until backport JDK-8262981 is reworked. Tagged the JBS issue. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1799 From tsteele at openjdk.org Mon Mar 13 14:07:54 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Mon, 13 Mar 2023 14:07:54 GMT Subject: [jdk11u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: <7x8LWIagJEYz-PkOeI77j8wBWHgQzX3DKHYiTxw3jHA=.55d42431-7c7f-4dda-918a-846f0f4ef149@github.com> References: <7x8LWIagJEYz-PkOeI77j8wBWHgQzX3DKHYiTxw3jHA=.55d42431-7c7f-4dda-918a-846f0f4ef149@github.com> Message-ID: On Mon, 13 Mar 2023 10:16:23 GMT, Ravali Yatham wrote: >> Added specific class loader object to proxy IllegalArgumentException from which the class was not visible >> >> The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 >> >> OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 > > @backwaterred - Could you please add `jdk11u-fix-request` to JBS issue? Hi @yathamravali, we typically wait for the PR to be reviewed or marked clean before adding that label (though I'm not sure it says that in the backporting document explicitly). I also see that testing is not enabled in your fork of jdk11u-dev. Please enable it so the tests can run. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1802 From zzambers at openjdk.org Mon Mar 13 14:15:18 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 13 Mar 2023 14:15:18 GMT Subject: [jdk11u-dev] Integrated: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary In-Reply-To: References: Message-ID: On Thu, 9 Mar 2023 12:48:40 GMT, Zdenek Zambersky wrote: > Backport fixing SSLSocket, not to use workaround with user_canceled alert for TLS 1.3 close, when not necessary, as it causes problems with gnutls client. > > Clean. Passed [jdk_security](https://github.com/zzambers/jdk-tester/actions/runs/4347121530/jobs/7594040836) tests. This pull request has now been integrated. Changeset: e80528bf Author: Zdenek Zambersky Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/e80528bf2bd1c87fc1394dd32015281ac6652363 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary Backport-of: eef3c9605e2d75fc5724118fd0140b7844daa6e8 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1796 From zzambers at openjdk.org Mon Mar 13 14:16:23 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 13 Mar 2023 14:16:23 GMT Subject: [jdk11u-dev] Integrated: 8293232: Fix race condition in pkcs11 SessionManager In-Reply-To: References: Message-ID: On Thu, 9 Mar 2023 12:51:30 GMT, Zdenek Zambersky wrote: > Backport - fix for race condition in pkcs11 SessionManager. > > Clean. Passed [jdk_security](https://github.com/zzambers/jdk-tester/actions/runs/4347091189/jobs/7593974147) tests. This pull request has now been integrated. Changeset: 939741c0 Author: Zdenek Zambersky Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/939741c0a0a4a5ce2c68d14b15e1f42563bc653d Stats: 7 lines in 1 file changed: 5 ins; 0 del; 2 mod 8293232: Fix race condition in pkcs11 SessionManager Backport-of: 67f31bb90b62fafc71e18c4c10e0f7e1b6896dc4 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1797 From mchung at openjdk.org Mon Mar 13 17:29:38 2023 From: mchung at openjdk.org (Mandy Chung) Date: Mon, 13 Mar 2023 17:29:38 GMT Subject: [jdk11u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: On Mon, 13 Mar 2023 07:37:53 GMT, Ravali Yatham wrote: > Added specific class loader object to proxy IllegalArgumentException from which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 > > OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 Marked as reviewed by mchung (Reviewer). ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1802 From rhalade at openjdk.org Mon Mar 13 18:22:01 2023 From: rhalade at openjdk.org (Rajan Halade) Date: Mon, 13 Mar 2023 18:22:01 GMT Subject: [jdk20u] Integrated: 8282201: Consider removal of expiry check in VerifyCACerts.java test In-Reply-To: References: Message-ID: On Wed, 8 Mar 2023 21:21:47 GMT, Rajan Halade wrote: > Fix to 20u CPU else test would fail in June 2023 This pull request has now been integrated. Changeset: 173a3210 Author: Rajan Halade URL: https://git.openjdk.org/jdk20u/commit/173a3210ba353fb2f7fee4d67cc05d3fff458ea2 Stats: 47 lines in 1 file changed: 16 ins; 15 del; 16 mod 8282201: Consider removal of expiry check in VerifyCACerts.java test Backport-of: 5b43804b7988ea4abd6458fba0a042b7bd6d9cb8 ------------- PR: https://git.openjdk.org/jdk20u/pull/16 From serb at openjdk.org Mon Mar 13 18:47:37 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 13 Mar 2023 18:47:37 GMT Subject: [jdk20u] Integrated: 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id In-Reply-To: References: Message-ID: On Mon, 6 Mar 2023 18:56:12 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [cfb0a25a](https://github.com/openjdk/jdk/commit/cfb0a25a4ee1a9cebd88c84fa622c46fe1c89bae) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Naoto Sato on 6 Mar 2023 and was reviewed by Iris Clark, Jaikiran Pai, Roger Riggs and Lance Andersen. > Thanks! This pull request has now been integrated. Changeset: d44789c3 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk20u/commit/d44789c3318776f2a691aef1a337a233bbf5bea4 Stats: 81 lines in 2 files changed: 79 ins; 0 del; 2 mod 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id Backport-of: cfb0a25a4ee1a9cebd88c84fa622c46fe1c89bae ------------- PR: https://git.openjdk.org/jdk20u/pull/14 From serb at openjdk.org Mon Mar 13 18:58:52 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 13 Mar 2023 18:58:52 GMT Subject: [jdk17u-dev] Integrated: 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id In-Reply-To: References: Message-ID: On Mon, 6 Mar 2023 18:44:23 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [cfb0a25a](https://github.com/openjdk/jdk/commit/cfb0a25a4ee1a9cebd88c84fa622c46fe1c89bae) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Naoto Sato on 6 Mar 2023 and was reviewed by Iris Clark, Jaikiran Pai, Roger Riggs and Lance Andersen. > Thanks! This pull request has now been integrated. Changeset: b087032f Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u-dev/commit/b087032f9b26b9756da9f5dc368b1b564c9c5048 Stats: 81 lines in 2 files changed: 79 ins; 0 del; 2 mod 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id Backport-of: cfb0a25a4ee1a9cebd88c84fa622c46fe1c89bae ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1198 From serb at openjdk.org Mon Mar 13 19:09:42 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 13 Mar 2023 19:09:42 GMT Subject: [jdk11u-dev] Integrated: 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id In-Reply-To: References: Message-ID: On Mon, 6 Mar 2023 18:49:45 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [cfb0a25a](https://github.com/openjdk/jdk/commit/cfb0a25a4ee1a9cebd88c84fa622c46fe1c89bae) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Naoto Sato on 6 Mar 2023 and was reviewed by Iris Clark, Jaikiran Pai, Roger Riggs and Lance Andersen. > Thanks! This pull request has now been integrated. Changeset: c6f00859 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk11u-dev/commit/c6f00859fd555968e2c93d0633c82854a5fb5b8e Stats: 81 lines in 2 files changed: 79 ins; 0 del; 2 mod 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id Backport-of: cfb0a25a4ee1a9cebd88c84fa622c46fe1c89bae ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1793 From naoto at openjdk.org Mon Mar 13 19:36:10 2023 From: naoto at openjdk.org (Naoto Sato) Date: Mon, 13 Mar 2023 19:36:10 GMT Subject: [jdk11u-ri] Integrated: 8301401: Allow additional characters for GB18030-2022 support In-Reply-To: References: Message-ID: On Wed, 22 Feb 2023 22:56:56 GMT, Naoto Sato wrote: > Please review the changes to the Reference Implementation of the proposed Maintenance Release of the Java SE 11 (https://mail.openjdk.org/pipermail/jdk-updates-dev/2023-February/020724.html). The RI contains a portion of previously released Maintenance Release 1 of the Java SE 11 (Unicode Characters) updates as well. (https://jcp.org/aboutJava/communityprocess/maintenance/jsr384/jsr384-mr1-changes.html#s3) This pull request has now been integrated. Changeset: 0a700c6c Author: Naoto Sato URL: https://git.openjdk.org/jdk11u-ri/commit/0a700c6c3d150ed375c113b31b8e6185cbe57ae6 Stats: 385 lines in 8 files changed: 366 ins; 2 del; 17 mod 8301401: Allow additional characters for GB18030-2022 support Co-authored-by: Justin Lu Reviewed-by: lancea, iris, alanb ------------- PR: https://git.openjdk.org/jdk11u-ri/pull/2 From jlu at openjdk.org Mon Mar 13 20:03:40 2023 From: jlu at openjdk.org (Justin Lu) Date: Mon, 13 Mar 2023 20:03:40 GMT Subject: [jdk11u-ri] Integrated: 8285497: Add system property for Java SE specification maintenance version In-Reply-To: References: Message-ID: On Thu, 23 Feb 2023 00:18:48 GMT, Justin Lu wrote: > This PR adds the system property: _java.specification.maintenance.version_ with a value of 2. This change is done towards the Reference Implementation of the proposed Java SE 11 Maintenance Release 2 (https://mail.openjdk.org/pipermail/jdk8u-dev/2023-February/016710.html). This pull request has now been integrated. Changeset: e5ac7a1b Author: Justin Lu Committer: Naoto Sato URL: https://git.openjdk.org/jdk11u-ri/commit/e5ac7a1b7e8df1e56a7e78bba6a2b9ed7fc297f1 Stats: 23 lines in 4 files changed: 20 ins; 0 del; 3 mod 8285497: Add system property for Java SE specification maintenance version Reviewed-by: lancea, darcy, naoto, iris, clanger Backport-of: 59ef76a365eafe40d8d68b4d5e028f0e731abd01 ------------- PR: https://git.openjdk.org/jdk11u-ri/pull/5 From clanger at openjdk.org Mon Mar 13 20:27:20 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 13 Mar 2023 20:27:20 GMT Subject: [jdk11u-dev] RFR: 8220093: Change to GCC 8.2 for building on Linux at Oracle In-Reply-To: References: Message-ID: On Mon, 13 Mar 2023 07:50:48 GMT, Christoph Langer wrote: > > Why are the tests failing? > > Probably nothing to do with my change - I've retriggered. OK, still failing tests but this time others. That's all GHA wag. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1792 From manc at openjdk.org Mon Mar 13 21:26:47 2023 From: manc at openjdk.org (Man Cao) Date: Mon, 13 Mar 2023 21:26:47 GMT Subject: [jdk17u-dev] RFR: 8303937: Corrupted heap dumps due to missing retries for os::write() [v2] In-Reply-To: References: Message-ID: > https://bugs.openjdk.org/browse/JDK-8303937 fixes a real bug that causes heap dump corruption. > > Trivial merge conflict, resolved by removing (ssize_t) cast before os::write(). > > I'll need a sponsor to help push this into 17u-dev. Man Cao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: Backport bf16b5b9880eb89b283006db090dce4346aa877b ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1201/files - new: https://git.openjdk.org/jdk17u-dev/pull/1201/files/d52e4fd4..96b061a0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1201&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1201&range=00-01 Stats: 1315 lines in 69 files changed: 1026 ins; 98 del; 191 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1201.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1201/head:pull/1201 PR: https://git.openjdk.org/jdk17u-dev/pull/1201 From manc at openjdk.org Tue Mar 14 01:35:18 2023 From: manc at openjdk.org (Man Cao) Date: Tue, 14 Mar 2023 01:35:18 GMT Subject: [jdk17u-dev] RFR: 8303937: Corrupted heap dumps due to missing retries for os::write() [v2] In-Reply-To: References: Message-ID: On Mon, 13 Mar 2023 21:26:47 GMT, Man Cao wrote: >> https://bugs.openjdk.org/browse/JDK-8303937 fixes a real bug that causes heap dump corruption. >> >> Trivial merge conflict, resolved by removing (ssize_t) cast before os::write(). >> >> I'll need a sponsor to help push this into 17u-dev. > > Man Cao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > Backport bf16b5b9880eb89b283006db090dce4346aa877b Thanks all! Apology for missing the tests and risk assessment. I enabled GitHub actions and all tier1 tests passed. (I used `git rebase` and `git push -f` to trigger a run for GitHub actions. Probably should have used `git merge`.) I updated the "Fix request" comments to include risk assessment and tests on https://bugs.openjdk.org/browse/JDK-8303937, and also added back `jdk11u-fix-request` and `jdk17u-fix-request` tags. Let me know if I missed anything else. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1201 From clanger at openjdk.org Tue Mar 14 07:53:41 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 14 Mar 2023 07:53:41 GMT Subject: [jdk17u-dev] RFR: 8303937: Corrupted heap dumps due to missing retries for os::write() [v2] In-Reply-To: References: Message-ID: On Mon, 13 Mar 2023 21:26:47 GMT, Man Cao wrote: >> https://bugs.openjdk.org/browse/JDK-8303937 fixes a real bug that causes heap dump corruption. >> >> Trivial merge conflict, resolved by removing (ssize_t) cast before os::write(). >> >> I'll need a sponsor to help push this into 17u-dev. > > Man Cao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport bf16b5b9880eb89b283006db090dce4346aa877b Looks good. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/1201 From aturbanov at openjdk.org Tue Mar 14 09:14:16 2023 From: aturbanov at openjdk.org (Andrey Turbanov) Date: Tue, 14 Mar 2023 09:14:16 GMT Subject: [jdk11u-dev] RFR: 8232853: AuthenticationFilter.Cache::remove may throw ConcurrentModificationException Message-ID: <_a8JEplcWd5jMCVn2v8wnLl0yO7wnMh4em1DyKhgWGE=.46bdf83f-cad1-435d-892f-2d7f7a3dccbc@github.com> Hi all, This pull request contains a backport of commit [d948bfd5](https://github.com/openjdk/jdk/commit/d948bfd58406cb9b73c6fc4c50728647a5cdf6b5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Original patch have changed a bit in the test code only, due to different package of `SimpleSSLContext`. Testing: Linux x86_64, `tier1`, `jdk/java/net/httpclient` ------------- Commit messages: - Backport d948bfd58406cb9b73c6fc4c50728647a5cdf6b5 Changes: https://git.openjdk.org/jdk11u-dev/pull/1803/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1803&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8232853 Stats: 309 lines in 2 files changed: 306 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1803.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1803/head:pull/1803 PR: https://git.openjdk.org/jdk11u-dev/pull/1803 From duke at openjdk.org Tue Mar 14 22:05:52 2023 From: duke at openjdk.org (Autumn Capasso) Date: Tue, 14 Mar 2023 22:05:52 GMT Subject: [jdk11u-dev] RFR: 8264304: Create implementation for NSAccessibilityToolbar protocol peer Message-ID: This backport is part of the 28 backport Accessibility series JDK-8152350. Commented out line 61 of commoneComponentAccesssibilty.m until backport JDK-8262981 is reworked. ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1799 Commit messages: - Merge branch 'pr/1799' into JDK-8264304 - Backport 4d26f22b9adcf7cecca5316348ef670ac2dbc365 - Backport f07dcf471c160e09fbc748124998923e7d453e66 Changes: https://git.openjdk.org/jdk11u-dev/pull/1804/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1804&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8264304 Stats: 43 lines in 3 files changed: 40 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1804.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1804/head:pull/1804 PR: https://git.openjdk.org/jdk11u-dev/pull/1804 From manc at google.com Wed Mar 15 01:39:15 2023 From: manc at google.com (Man Cao) Date: Tue, 14 Mar 2023 18:39:15 -0700 Subject: [jdk17u-dev] RFR: 8303937: Corrupted heap dumps due to missing retries for os::write() [v2] In-Reply-To: References: Message-ID: Could anyone help sponsor my backports to JDK 11u, 17u and 20? https://github.com/openjdk/jdk20u/pull/18 https://github.com/openjdk/jdk17u-dev/pull/1201 https://github.com/openjdk/jdk11u-dev/pull/1801 -Man On Tue, Mar 14, 2023 at 12:54?AM Christoph Langer wrote: > On Mon, 13 Mar 2023 21:26:47 GMT, Man Cao wrote: > > >> https://bugs.openjdk.org/browse/JDK-8303937 fixes a real bug that > causes heap dump corruption. > >> > >> Trivial merge conflict, resolved by removing (ssize_t) cast before > os::write(). > >> > >> I'll need a sponsor to help push this into 17u-dev. > > > > Man Cao has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains one commit: > > > > Backport bf16b5b9880eb89b283006db090dce4346aa877b > > Looks good. > > ------------- > > Marked as reviewed by clanger (Reviewer). > > PR: https://git.openjdk.org/jdk17u-dev/pull/1201 > -------------- next part -------------- An HTML attachment was scrubbed... URL: From manc at openjdk.org Wed Mar 15 06:39:26 2023 From: manc at openjdk.org (Man Cao) Date: Wed, 15 Mar 2023 06:39:26 GMT Subject: [jdk20u] Integrated: 8303937: Corrupted heap dumps due to missing retries for os::write() In-Reply-To: References: Message-ID: On Fri, 10 Mar 2023 20:36:56 GMT, Man Cao wrote: > No conflict backporting to 20u. I'll need a sponsor to help pushing it. This pull request has now been integrated. Changeset: e7e1b5fd Author: Man Cao Committer: David Holmes URL: https://git.openjdk.org/jdk20u/commit/e7e1b5fd0d040935d4a1ece260519374f95b5e3e Stats: 7 lines in 1 file changed: 4 ins; 0 del; 3 mod 8303937: Corrupted heap dumps due to missing retries for os::write() Backport-of: bf16b5b9880eb89b283006db090dce4346aa877b ------------- PR: https://git.openjdk.org/jdk20u/pull/18 From goetz at openjdk.org Wed Mar 15 07:14:22 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 15 Mar 2023 07:14:22 GMT Subject: [jdk11u-dev] RFR: 8264290: Create implementation for NSAccessibilityComponentGroup protocol peer In-Reply-To: <2pBjo9uNaKMVQ3WZbiY23ZDHfrvzpxBtnRAZnIrzVtk=.9baa415a-1c20-42d8-8867-98b24c6e2753@github.com> References: <2pBjo9uNaKMVQ3WZbiY23ZDHfrvzpxBtnRAZnIrzVtk=.9baa415a-1c20-42d8-8867-98b24c6e2753@github.com> Message-ID: <0WpX1YiR4vEs46pFdEKZVzbSAruXCgVdxx2eovotSAk=.4a58139b-25c4-49fb-9de5-2d4262ecd89d@github.com> On Fri, 10 Mar 2023 21:01:44 GMT, Autumn Capasso wrote: > This backport is part of the 28 backport Accessibility series JDK-8152350. Commented out line 61 of commoneComponentAccesssibilty.m until backport JDK-8262981 is reworked. Hi @autumn808 @phohensee you say you had to work around 8262981. What stops that change from being pushed? Can't you move the CSR to proposed? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1799 From duke at openjdk.org Wed Mar 15 07:15:37 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Wed, 15 Mar 2023 07:15:37 GMT Subject: [jdk11u-dev] RFR: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence Message-ID: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> I would like to backport JDK-8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence. The original patch does not apply cleanly to 11u. Because the original patch has switch expressions which can not be used in 11u, and it has the Class jdk.javadoc.internal.doclets.formats.html.HtmlOptions which is not defined in 11u. There is no risk, because the logic around the changes is the same as jdk17. I confirmed the following test and all langtool tests. test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java Could anyone review the fix please? ------------- Commit messages: - Merge branch 'openjdk:master' into 8259530 - Backport e9f3e325c274f19b0f6eceea2367708e3be689e9 Changes: https://git.openjdk.org/jdk11u-dev/pull/1805/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1805&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8259530 Stats: 288 lines in 11 files changed: 281 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1805.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1805/head:pull/1805 PR: https://git.openjdk.org/jdk11u-dev/pull/1805 From manc at openjdk.org Wed Mar 15 07:19:35 2023 From: manc at openjdk.org (Man Cao) Date: Wed, 15 Mar 2023 07:19:35 GMT Subject: [jdk17u-dev] Integrated: 8303937: Corrupted heap dumps due to missing retries for os::write() In-Reply-To: References: Message-ID: On Fri, 10 Mar 2023 21:06:18 GMT, Man Cao wrote: > https://bugs.openjdk.org/browse/JDK-8303937 fixes a real bug that causes heap dump corruption. > > Trivial merge conflict, resolved by removing (ssize_t) cast before os::write(). > > I'll need a sponsor to help push this into 17u-dev. This pull request has now been integrated. Changeset: bc79161e Author: Man Cao Committer: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/bc79161e25c256d41650325f5e26e426c703ae6c Stats: 7 lines in 1 file changed: 4 ins; 0 del; 3 mod 8303937: Corrupted heap dumps due to missing retries for os::write() Reviewed-by: clanger Backport-of: bf16b5b9880eb89b283006db090dce4346aa877b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1201 From manc at openjdk.org Wed Mar 15 07:20:35 2023 From: manc at openjdk.org (Man Cao) Date: Wed, 15 Mar 2023 07:20:35 GMT Subject: [jdk11u-dev] Integrated: 8303937: Corrupted heap dumps due to missing retries for os::write() In-Reply-To: References: Message-ID: On Fri, 10 Mar 2023 21:57:34 GMT, Man Cao wrote: > https://bugs.openjdk.org/browse/JDK-8303937 fixes a real bug that causes heap dump corruption. This bug was introduced into 11.0.14u. > > Trivial merge conflict, resolved by removing (ssize_t) cast before os::write(). > > I'll need a sponsor to help push this into 11u-dev. This pull request has now been integrated. Changeset: 97809afd Author: Man Cao Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/97809afd1c1f02999a6509c92dae149ab8d02168 Stats: 8 lines in 1 file changed: 4 ins; 0 del; 4 mod 8303937: Corrupted heap dumps due to missing retries for os::write() Reviewed-by: clanger Backport-of: bf16b5b9880eb89b283006db090dce4346aa877b ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1801 From clanger at openjdk.org Wed Mar 15 07:21:28 2023 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 15 Mar 2023 07:21:28 GMT Subject: [jdk11u-dev] Integrated: 8220093: Change to GCC 8.2 for building on Linux at Oracle In-Reply-To: References: Message-ID: On Sun, 5 Mar 2023 12:03:52 GMT, Christoph Langer wrote: > This is a backport of [JDK-8220093](https://bugs.openjdk.org/browse/JDK-8220093). The motivation for doing it is that configure output will then show same output as in higher releases for the used linker. E.g. > > `configure: Using gcc linker version 2.36.1 [GNU ld (GNU Binutils) 2.36.1]` > > vs > > `configure: Using gcc linker version 8.5.0 [collect2 version 8.5.0]` > > One can then deduct the version of binutils used. > > I had to make a few modifications. In toolchain.m4, [JDK-8257679](https://bugs.openjdk.org/browse/JDK-8257679) was already present so I had to make the hunk fit. The other adaptations are in jib-profiles.js which is not relevant to OpenJDK because it's used internally at Oracle only and some improvements to the devkit build scripts. This pull request has now been integrated. Changeset: b8ac68db Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/b8ac68dbdb8a57a2db9f333500ae8b74fef192fb Stats: 107 lines in 5 files changed: 82 ins; 7 del; 18 mod 8220093: Change to GCC 8.2 for building on Linux at Oracle Reviewed-by: mbaesken Backport-of: 290bfe5f4c912eae745e2a6a346d019ebe74b342 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1792 From jbechberger at openjdk.org Wed Mar 15 10:34:29 2023 From: jbechberger at openjdk.org (Johannes Bechberger) Date: Wed, 15 Mar 2023 10:34:29 GMT Subject: [jdk17u-dev] Integrated: 8302320: AsyncGetCallTrace obtains too few frames in sanity test In-Reply-To: References: Message-ID: On Mon, 6 Mar 2023 08:12:47 GMT, Johannes Bechberger wrote: > Extended the AsyncGetCallTrace and fixed an issue with interpreter frames. This pull request has now been integrated. Changeset: 4baaa110 Author: Johannes Bechberger Committer: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/4baaa110d6135adfb8e4c7ca9a0bef60ea93598c Stats: 39 lines in 2 files changed: 36 ins; 0 del; 3 mod 8302320: AsyncGetCallTrace obtains too few frames in sanity test Backport-of: db483a38a815f85bd9668749674b5f0f6e4b27b4 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1197 From mbaesken at openjdk.org Wed Mar 15 12:19:20 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 15 Mar 2023 12:19:20 GMT Subject: [jdk17u-dev] RFR: 8303354: addCertificatesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return Message-ID: 8303354: addCertificatesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return ------------- Commit messages: - Backport b51ea4204eaa18687e7712e87cdc92efbddfcb5b Changes: https://git.openjdk.org/jdk17u-dev/pull/1202/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1202&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303354 Stats: 24 lines in 1 file changed: 17 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1202.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1202/head:pull/1202 PR: https://git.openjdk.org/jdk17u-dev/pull/1202 From mbaesken at openjdk.org Wed Mar 15 13:34:38 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 15 Mar 2023 13:34:38 GMT Subject: [jdk11u-dev] RFR: 8294548: Problem list SA core file tests on macosx-x64 due to JDK-8294316 In-Reply-To: References: Message-ID: On Tue, 28 Feb 2023 14:43:19 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.19-oracle. > > These fail in our CI too, sometimes. LGTM ------------- Marked as reviewed by mbaesken (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1784 From duke at openjdk.org Wed Mar 15 16:25:54 2023 From: duke at openjdk.org (Autumn Capasso) Date: Wed, 15 Mar 2023 16:25:54 GMT Subject: [jdk11u-dev] Integrated: 8264290: Create implementation for NSAccessibilityComponentGroup protocol peer In-Reply-To: <2pBjo9uNaKMVQ3WZbiY23ZDHfrvzpxBtnRAZnIrzVtk=.9baa415a-1c20-42d8-8867-98b24c6e2753@github.com> References: <2pBjo9uNaKMVQ3WZbiY23ZDHfrvzpxBtnRAZnIrzVtk=.9baa415a-1c20-42d8-8867-98b24c6e2753@github.com> Message-ID: On Fri, 10 Mar 2023 21:01:44 GMT, Autumn Capasso wrote: > This backport is part of the 28 backport Accessibility series JDK-8152350. Commented out line 61 of commoneComponentAccesssibilty.m until backport JDK-8262981 is reworked. This pull request has now been integrated. Changeset: dd642123 Author: Autumn Capasso <34965675+Autumn808 at users.noreply.github.com> Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/dd6421231d05b5e1e70a1bc0c9df613bb55c8947 Stats: 64 lines in 3 files changed: 60 ins; 0 del; 4 mod 8264290: Create implementation for NSAccessibilityComponentGroup protocol peer Reviewed-by: phh Backport-of: f07dcf471c160e09fbc748124998923e7d453e66 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1799 From abakhtin at openjdk.org Wed Mar 15 16:43:04 2023 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 15 Mar 2023 16:43:04 GMT Subject: [jdk17u-dev] RFR: 8303809: Dispose context in SPNEGO NegotiatorImpl Message-ID: Almost clean backport of JDK-8303809 NegotiatorImpl is merged manually because of no JDK-8282632 in 17u - difference in IOException initialization sun/security/jgss sun/security/krb5 sun/net/www/protocol/http tests passed successfully ------------- Commit messages: - Backport 10f16746254ce62031f40ffb0f49f22e81cbe631 Changes: https://git.openjdk.org/jdk17u-dev/pull/1203/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1203&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303809 Stats: 70 lines in 5 files changed: 70 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1203.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1203/head:pull/1203 PR: https://git.openjdk.org/jdk17u-dev/pull/1203 From duke at openjdk.org Wed Mar 15 16:58:18 2023 From: duke at openjdk.org (Autumn Capasso) Date: Wed, 15 Mar 2023 16:58:18 GMT Subject: [jdk11u-dev] RFR: 8264304: Create implementation for NSAccessibilityToolbar protocol peer [v2] In-Reply-To: References: Message-ID: > This backport is part of the 28 backport Accessibility series JDK-8152350. Commented out line 61 of commoneComponentAccesssibilty.m until backport JDK-8262981 is reworked. Autumn Capasso has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: - Merge branch 'pr/1799' into JDK-8264304 - Merge branch 'master' into JDK-8264290 - Backport f07dcf471c160e09fbc748124998923e7d453e66 - Backport 4d26f22b9adcf7cecca5316348ef670ac2dbc365 - Backport f07dcf471c160e09fbc748124998923e7d453e66 ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1804/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1804&range=01 Stats: 106 lines in 5 files changed: 100 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1804.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1804/head:pull/1804 PR: https://git.openjdk.org/jdk11u-dev/pull/1804 From duke at openjdk.org Wed Mar 15 17:09:24 2023 From: duke at openjdk.org (Autumn Capasso) Date: Wed, 15 Mar 2023 17:09:24 GMT Subject: [jdk11u-dev] RFR: 8264290: Create implementation for NSAccessibilityComponentGroup protocol peer In-Reply-To: <2pBjo9uNaKMVQ3WZbiY23ZDHfrvzpxBtnRAZnIrzVtk=.9baa415a-1c20-42d8-8867-98b24c6e2753@github.com> References: <2pBjo9uNaKMVQ3WZbiY23ZDHfrvzpxBtnRAZnIrzVtk=.9baa415a-1c20-42d8-8867-98b24c6e2753@github.com> Message-ID: On Fri, 10 Mar 2023 21:01:44 GMT, Autumn Capasso wrote: > This backport is part of the 28 backport Accessibility series JDK-8152350. Commented out line 61 of commoneComponentAccesssibilty.m until backport JDK-8262981 is reworked. > Hi @Autumn808 @phohensee you say you had to work around 8262981. What stops that change from being pushed? Can't you move the CSR to proposed? @GoeLin we didn?t see a CSR for the Oracle backport, so we believe they adopted a different approach which we?re figuring out how to duplicate. The CSR looks like it changes a public interface, which would in theory require a JDK 11 update JSR. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1799 From duke at openjdk.org Wed Mar 15 18:43:31 2023 From: duke at openjdk.org (Autumn Capasso) Date: Wed, 15 Mar 2023 18:43:31 GMT Subject: [jdk11u-dev] RFR: 8263420: Incorrect function name in NSAccessibilityStaticText native peer implementation Message-ID: This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components. ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1804 Commit messages: - Backport d896246a117a929b2d34463168095497c95ee601 - Backport 4d26f22b9adcf7cecca5316348ef670ac2dbc365 Changes: https://git.openjdk.org/jdk11u-dev/pull/1806/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1806&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8263420 Stats: 43 lines in 5 files changed: 38 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1806.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1806/head:pull/1806 PR: https://git.openjdk.org/jdk11u-dev/pull/1806 From duke at openjdk.org Wed Mar 15 20:39:28 2023 From: duke at openjdk.org (Autumn Capasso) Date: Wed, 15 Mar 2023 20:39:28 GMT Subject: [jdk11u-dev] RFR: 8264304: Create implementation for NSAccessibilityToolbar protocol peer [v3] In-Reply-To: References: Message-ID: > This backport is part of the 28 backport Accessibility series JDK-8152350. Commented out line 61 of commoneComponentAccesssibilty.m until backport JDK-8262981 is reworked. Autumn Capasso has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - Merge branch 'master' into JDK-8264304 - Merge branch 'pr/1799' into JDK-8264304 - Merge branch 'master' into JDK-8264290 - Backport f07dcf471c160e09fbc748124998923e7d453e66 - Backport 4d26f22b9adcf7cecca5316348ef670ac2dbc365 - Backport f07dcf471c160e09fbc748124998923e7d453e66 ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1804/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1804&range=02 Stats: 43 lines in 3 files changed: 40 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1804.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1804/head:pull/1804 PR: https://git.openjdk.org/jdk11u-dev/pull/1804 From phh at openjdk.org Wed Mar 15 20:39:28 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 15 Mar 2023 20:39:28 GMT Subject: [jdk11u-dev] RFR: 8264304: Create implementation for NSAccessibilityToolbar protocol peer [v3] In-Reply-To: References: Message-ID: On Wed, 15 Mar 2023 20:35:16 GMT, Autumn Capasso wrote: >> This backport is part of the 28 backport Accessibility series JDK-8152350. Commented out line 61 of commoneComponentAccesssibilty.m until backport JDK-8262981 is reworked. > > Autumn Capasso has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: > > - Merge branch 'master' into JDK-8264304 > - Merge branch 'pr/1799' into JDK-8264304 > - Merge branch 'master' into JDK-8264290 > - Backport f07dcf471c160e09fbc748124998923e7d453e66 > - Backport 4d26f22b9adcf7cecca5316348ef670ac2dbc365 > - Backport f07dcf471c160e09fbc748124998923e7d453e66 Looks clean. Reviewed. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1804 From phh at openjdk.org Wed Mar 15 20:39:30 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 15 Mar 2023 20:39:30 GMT Subject: [jdk11u-dev] RFR: 8264304: Create implementation for NSAccessibilityToolbar protocol peer [v2] In-Reply-To: References: Message-ID: On Wed, 15 Mar 2023 16:58:18 GMT, Autumn Capasso wrote: >> This backport is part of the 28 backport Accessibility series JDK-8152350. Commented out line 61 of commoneComponentAccesssibilty.m until backport JDK-8262981 is reworked. > > Autumn Capasso has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: > > - Merge branch 'pr/1799' into JDK-8264304 > - Merge branch 'master' into JDK-8264290 > - Backport f07dcf471c160e09fbc748124998923e7d453e66 > - Backport 4d26f22b9adcf7cecca5316348ef670ac2dbc365 > - Backport f07dcf471c160e09fbc748124998923e7d453e66 Tagged the JBS issue. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1804 From phh at openjdk.org Wed Mar 15 21:03:31 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 15 Mar 2023 21:03:31 GMT Subject: [jdk11u-dev] RFR: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence In-Reply-To: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> References: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> Message-ID: <2Sf3ykAUuWEtzPThmHBFbqDvXs-jUoalOj3g9h75um4=.a37668da-2ac1-4a79-b5ff-e8dd0c332c9f@github.com> On Wed, 15 Mar 2023 07:06:55 GMT, Kimura Yukihiro wrote: > I would like to backport > JDK-8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence. > The original patch does not apply cleanly to 11u. > Because the original patch has switch expressions which can not be used in 11u, > and it has the Class jdk.javadoc.internal.doclets.formats.html.HtmlOptions which is not defined in 11u. > There is no risk, because the logic around the changes is the same as jdk17. > I confirmed the following test and all langtool tests. > test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java > > Could anyone review the fix please? In HtmlConfiguration.java, why not make legalNotices private and add the legalNotices() accessor as in the original commit? ------------- Changes requested by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1805 From phh at openjdk.org Wed Mar 15 22:02:30 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 15 Mar 2023 22:02:30 GMT Subject: [jdk11u-dev] RFR: 8232853: AuthenticationFilter.Cache::remove may throw ConcurrentModificationException In-Reply-To: <_a8JEplcWd5jMCVn2v8wnLl0yO7wnMh4em1DyKhgWGE=.46bdf83f-cad1-435d-892f-2d7f7a3dccbc@github.com> References: <_a8JEplcWd5jMCVn2v8wnLl0yO7wnMh4em1DyKhgWGE=.46bdf83f-cad1-435d-892f-2d7f7a3dccbc@github.com> Message-ID: On Tue, 14 Mar 2023 09:04:29 GMT, Andrey Turbanov wrote: > Hi all, > This pull request contains a backport of commit [d948bfd5](https://github.com/openjdk/jdk/commit/d948bfd58406cb9b73c6fc4c50728647a5cdf6b5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > Original patch have changed a bit in the test code only, due to different package of `SimpleSSLContext`. > Testing: Linux x86_64, `tier1`, `jdk/java/net/httpclient` Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1803 From duke at openjdk.org Thu Mar 16 04:01:32 2023 From: duke at openjdk.org (Autumn Capasso) Date: Thu, 16 Mar 2023 04:01:32 GMT Subject: [jdk11u-dev] RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly Message-ID: This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components. ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1806 Commit messages: - Backport JDK-8267066 Changes: https://git.openjdk.org/jdk11u-dev/pull/1807/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1807&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8267066 Stats: 107 lines in 24 files changed: 76 ins; 0 del; 31 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1807.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1807/head:pull/1807 PR: https://git.openjdk.org/jdk11u-dev/pull/1807 From duke at openjdk.org Thu Mar 16 04:44:43 2023 From: duke at openjdk.org (Autumn Capasso) Date: Thu, 16 Mar 2023 04:44:43 GMT Subject: [jdk11u-dev] RFR: 8264302: Create implementation for Accessibility native peer for Splitpane java role Message-ID: This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components. ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1807 Commit messages: - Backport 45e05970bcee842f98eeeef054f574ccf4b43fad Changes: https://git.openjdk.org/jdk11u-dev/pull/1808/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1808&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8264302 Stats: 42 lines in 3 files changed: 39 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1808.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1808/head:pull/1808 PR: https://git.openjdk.org/jdk11u-dev/pull/1808 From duke at openjdk.org Thu Mar 16 05:08:17 2023 From: duke at openjdk.org (Autumn Capasso) Date: Thu, 16 Mar 2023 05:08:17 GMT Subject: [jdk11u-dev] RFR: 8264305: Create implementation for native accessibility peer for Statusbar java role Message-ID: This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components. ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1808 Commit messages: - Backport 3025f05970ede82c6f67a0434e33b27205e10130 Changes: https://git.openjdk.org/jdk11u-dev/pull/1809/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1809&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8264305 Stats: 41 lines in 3 files changed: 39 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1809.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1809/head:pull/1809 PR: https://git.openjdk.org/jdk11u-dev/pull/1809 From goetz at openjdk.org Thu Mar 16 08:25:45 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 16 Mar 2023 08:25:45 GMT Subject: [jdk17u-dev] RFR: 8292301: [REDO v2] C2 crash when allocating array of size too large Message-ID: I had to resolve three files: src/hotspot/share/opto/callnode.cpp AllocateArrayNode::Ideal could not be deleted automatically. The patch removes igvn->add_input_to(phase->C->root(), halt); but 11 has phase->C->root()->add_req(halt); Just deleted anyways. src/hotspot/share/opto/loopopts.cpp In the source, clone_loop() has been refactored. The patch touches code moved to finish_clone_loop(). The very same code is in clone_loop() in 17. Moved hunk there. src/hotspot/share/opto/phaseX.cpp Just placement of a comment. ------------- Commit messages: - Backport 1ea0d6b424c263590fd145913280a180d7ce5fe1 Changes: https://git.openjdk.org/jdk17u-dev/pull/1204/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1204&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292301 Stats: 502 lines in 19 files changed: 394 ins; 67 del; 41 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1204.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1204/head:pull/1204 PR: https://git.openjdk.org/jdk17u-dev/pull/1204 From duke at openjdk.org Thu Mar 16 09:02:28 2023 From: duke at openjdk.org (Ravali Yatham) Date: Thu, 16 Mar 2023 09:02:28 GMT Subject: [jdk11u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: On Mon, 13 Mar 2023 07:37:53 GMT, Ravali Yatham wrote: > Added specific class loader object to proxy IllegalArgumentException from which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 > > OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 Tagging maintainers https://wiki.openjdk.org/display/JDKUpdates/JDK11u for review - @GoeLin @theRealAph @RealCLanger @jerboaa Could one of you kindly review this PR? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1802 From duke at openjdk.org Thu Mar 16 09:04:41 2023 From: duke at openjdk.org (Ravali Yatham) Date: Thu, 16 Mar 2023 09:04:41 GMT Subject: [jdk17u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: On Wed, 8 Mar 2023 11:47:56 GMT, Ravali Yatham wrote: > Added specific class loader object to proxy IllegalArgumentException from which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 > > OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 Tagging maintainers([Maintainers list](https://wiki.openjdk.org/display/JDKUpdates/JDK+17u)) for review @GoeLin @theRealAph @RealCLanger @gnu-andrew @jerboaa Could one of you kindly review this PR? ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1199 From clanger at openjdk.org Thu Mar 16 09:26:32 2023 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 16 Mar 2023 09:26:32 GMT Subject: [jdk17u-dev] RFR: 8301050: Detect Xen Virtualization on Linux aarch64 In-Reply-To: References: Message-ID: On Wed, 15 Feb 2023 15:15:55 GMT, Matthias Baesken wrote: > Backport of 8301050 Looks good. Any explanation why it didn't apply cleanly? ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/1174 From sgehwolf at openjdk.org Thu Mar 16 09:45:22 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 16 Mar 2023 09:45:22 GMT Subject: [jdk17u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: On Thu, 16 Mar 2023 09:01:32 GMT, Ravali Yatham wrote: >> Added specific class loader object to proxy IllegalArgumentException from which the class was not visible >> >> The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 >> >> OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 > > Tagging maintainers([Maintainers list](https://wiki.openjdk.org/display/JDKUpdates/JDK+17u)) for review @GoeLin @theRealAph @RealCLanger @gnu-andrew @jerboaa > > Could one of you kindly review this PR? @yathamravali Please enable GHA testing on your fork. As for approval, that's currently done on the associated bug. See https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1199 From sgehwolf at openjdk.org Thu Mar 16 09:52:20 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 16 Mar 2023 09:52:20 GMT Subject: [jdk17u-dev] RFR: 8292301: [REDO v2] C2 crash when allocating array of size too large In-Reply-To: References: Message-ID: On Thu, 16 Mar 2023 08:16:50 GMT, Goetz Lindenmaier wrote: > I had to resolve three files: > src/hotspot/share/opto/callnode.cpp > AllocateArrayNode::Ideal could not be deleted automatically. > The patch removes igvn->add_input_to(phase->C->root(), halt); > but 11 has phase->C->root()->add_req(halt); > Just deleted anyways. > > src/hotspot/share/opto/loopopts.cpp > In the source, clone_loop() has been refactored. > The patch touches code moved to finish_clone_loop(). > The very same code is in clone_loop() in 17. Moved > hunk there. > > src/hotspot/share/opto/phaseX.cpp > Just placement of a comment. @rwestrel Hi! Could you please help review this? Thanks! ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1204 From duke at openjdk.org Thu Mar 16 09:52:25 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Thu, 16 Mar 2023 09:52:25 GMT Subject: [jdk11u-dev] RFR: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence In-Reply-To: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> References: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> Message-ID: On Wed, 15 Mar 2023 07:06:55 GMT, Kimura Yukihiro wrote: > I would like to backport > JDK-8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence. > The original patch does not apply cleanly to 11u. > Because the original patch has switch expressions which can not be used in 11u, > and it has the Class jdk.javadoc.internal.doclets.formats.html.HtmlOptions which is not defined in 11u. > There is no risk, because the logic around the changes is the same as jdk17. > I confirmed the following test and all langtool tests. > test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java > > Could anyone review the fix please? Hello Paul, Thank you for your advice. In HtmlConfiguration.java, all variables for command line options are defined as public variable. For instance helpfile, stylesheetfile or createindex. Should all variables make private, including legalnotices? Thanks, Kimura Yukihiro ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1805 From sgehwolf at openjdk.org Thu Mar 16 09:56:31 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 16 Mar 2023 09:56:31 GMT Subject: [jdk11u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: On Mon, 13 Mar 2023 07:37:53 GMT, Ravali Yatham wrote: > Added specific class loader object to proxy IllegalArgumentException from which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 > > OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 As mentioned in the 17u-dev PR, approval/disapproval is done on the bug via `jdkXXu-fix-yes` or `jdkXXu-fix-no`. In the JDK 11 case, please wait until 17 backport is in. Also please merge master and push so as to trigger GHA testing (or trigger it manually on your fork via the actions tab on github) ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1802 From roland at openjdk.org Thu Mar 16 10:05:21 2023 From: roland at openjdk.org (Roland Westrelin) Date: Thu, 16 Mar 2023 10:05:21 GMT Subject: [jdk17u-dev] RFR: 8292301: [REDO v2] C2 crash when allocating array of size too large In-Reply-To: References: Message-ID: On Thu, 16 Mar 2023 08:16:50 GMT, Goetz Lindenmaier wrote: > I had to resolve three files: > src/hotspot/share/opto/callnode.cpp > AllocateArrayNode::Ideal could not be deleted automatically. > The patch removes igvn->add_input_to(phase->C->root(), halt); > but 11 has phase->C->root()->add_req(halt); > Just deleted anyways. > > src/hotspot/share/opto/loopopts.cpp > In the source, clone_loop() has been refactored. > The patch touches code moved to finish_clone_loop(). > The very same code is in clone_loop() in 17. Moved > hunk there. > > src/hotspot/share/opto/phaseX.cpp > Just placement of a comment. Looks good to me. ------------- Marked as reviewed by roland (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/1204 From duke at openjdk.org Thu Mar 16 10:15:31 2023 From: duke at openjdk.org (Ravali Yatham) Date: Thu, 16 Mar 2023 10:15:31 GMT Subject: [jdk17u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: <-ivwvrw1_fpAI02g1falAtfGS1B51zxYgZDoKq48ObE=.caf8790c-753b-4353-9f53-5cb2f8cbce5c@github.com> On Thu, 16 Mar 2023 09:42:37 GMT, Severin Gehwolf wrote: >> Tagging maintainers([Maintainers list](https://wiki.openjdk.org/display/JDKUpdates/JDK+17u)) for review @GoeLin @theRealAph @RealCLanger @gnu-andrew @jerboaa >> >> Could one of you kindly review this PR? > > @yathamravali Please enable GHA testing on your fork. As for approval, that's currently done on the associated bug. See https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix @jerboaa - I've already enabled them from Actions tab in my fork. Is that the one or am I missing something here? ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1199 From sgehwolf at openjdk.org Thu Mar 16 10:21:37 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 16 Mar 2023 10:21:37 GMT Subject: [jdk17u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: <-ivwvrw1_fpAI02g1falAtfGS1B51zxYgZDoKq48ObE=.caf8790c-753b-4353-9f53-5cb2f8cbce5c@github.com> References: <-ivwvrw1_fpAI02g1falAtfGS1B51zxYgZDoKq48ObE=.caf8790c-753b-4353-9f53-5cb2f8cbce5c@github.com> Message-ID: On Thu, 16 Mar 2023 10:12:39 GMT, Ravali Yatham wrote: >> @yathamravali Please enable GHA testing on your fork. As for approval, that's currently done on the associated bug. See https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix > > @jerboaa - I've already enabled them from Actions tab in my fork. Is that the one or am I missing something here? @yathamravali OK. It doesn't show it as being run here. Could you please merge the master branch and push and see if a test run gets scheduled here: https://github.com/yathamravali/jdk17u-dev/actions ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1199 From duke at openjdk.org Thu Mar 16 10:32:23 2023 From: duke at openjdk.org (Ravali Yatham) Date: Thu, 16 Mar 2023 10:32:23 GMT Subject: [jdk17u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: <-ivwvrw1_fpAI02g1falAtfGS1B51zxYgZDoKq48ObE=.caf8790c-753b-4353-9f53-5cb2f8cbce5c@github.com> Message-ID: On Thu, 16 Mar 2023 10:18:16 GMT, Severin Gehwolf wrote: >> @jerboaa - I've already enabled them from Actions tab in my fork. Is that the one or am I missing something here? > > @yathamravali OK. It doesn't show it as being run here. Could you please merge the master branch and push and see if a test run gets scheduled here: https://github.com/yathamravali/jdk17u-dev/actions @jerboaa - Performed below steps git merge master git checkout master git merge AddClassLoader_Proxy-backport-9f9d678 git push origin master Don't see any test runs scheduled under actions tab. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1199 From duke at openjdk.org Thu Mar 16 10:45:31 2023 From: duke at openjdk.org (Ravali Yatham) Date: Thu, 16 Mar 2023 10:45:31 GMT Subject: [jdk17u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: On Wed, 8 Mar 2023 11:47:56 GMT, Ravali Yatham wrote: > Added specific class loader object to proxy IllegalArgumentException from which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 > > OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 I've manually triggered, could see here https://github.com/yathamravali/jdk17u-dev/actions/workflows/main.yml ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1199 From sgehwolf at openjdk.org Thu Mar 16 11:29:28 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 16 Mar 2023 11:29:28 GMT Subject: [jdk17u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: <-ivwvrw1_fpAI02g1falAtfGS1B51zxYgZDoKq48ObE=.caf8790c-753b-4353-9f53-5cb2f8cbce5c@github.com> Message-ID: <9rcHUVfsZPkijVNIRo84KVnfrkuVUlhkl1pzQyoTVzI=.6421ba9f-119b-47a4-a080-62d1749909c0@github.com> On Thu, 16 Mar 2023 10:18:16 GMT, Severin Gehwolf wrote: >> @jerboaa - I've already enabled them from Actions tab in my fork. Is that the one or am I missing something here? > > @yathamravali OK. It doesn't show it as being run here. Could you please merge the master branch and push and see if a test run gets scheduled here: https://github.com/yathamravali/jdk17u-dev/actions > @jerboaa - Performed below steps > > ``` > git merge master > git checkout master > git merge AddClassLoader_Proxy-backport-9f9d678 > git push origin master > ``` > > Don't see any test runs scheduled under actions tab. The sequence of commands should be something like this: git checkout master git pull https://github.com/openjdk/jdk17u-dev master git checkout AddClassLoader_Proxy-backport-9f9d678 git merge master git push origin HEAD ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1199 From mbaesken at openjdk.org Thu Mar 16 12:23:19 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 16 Mar 2023 12:23:19 GMT Subject: [jdk17u-dev] RFR: 8303576: addIdentitiesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return Message-ID: 8303576: addIdentitiesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return ------------- Commit messages: - Backport a7e308ab6e5dba7df790840d29fc7edbf3af2e24 Changes: https://git.openjdk.org/jdk17u-dev/pull/1205/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1205&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303576 Stats: 7 lines in 1 file changed: 5 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1205.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1205/head:pull/1205 PR: https://git.openjdk.org/jdk17u-dev/pull/1205 From mbaesken at openjdk.org Thu Mar 16 13:07:30 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 16 Mar 2023 13:07:30 GMT Subject: [jdk17u-dev] RFR: 8303949: gcc10 warning Linux ppc64le - note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5 Message-ID: Backport of 8303949 ------------- Commit messages: - Backport a32ee5dd8b5d0b65b39d7a3f8bedc7c099987f6f Changes: https://git.openjdk.org/jdk17u-dev/pull/1206/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1206&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303949 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1206.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1206/head:pull/1206 PR: https://git.openjdk.org/jdk17u-dev/pull/1206 From phh at openjdk.org Thu Mar 16 16:06:50 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 16 Mar 2023 16:06:50 GMT Subject: [jdk17u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: <2jwaWSZoLrHeuUWiCvh0ze_8vtAlzkpzLhe-GxJddZs=.172550e0-3265-4005-8cc2-821614f38335@github.com> On Wed, 8 Mar 2023 11:47:56 GMT, Ravali Yatham wrote: > Added specific class loader object to proxy IllegalArgumentException from which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 > > OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 Lgtm. Tagged the JBS issue. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/1199 From phh at openjdk.org Thu Mar 16 16:10:23 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 16 Mar 2023 16:10:23 GMT Subject: [jdk11u-dev] RFR: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence In-Reply-To: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> References: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> Message-ID: <82P33QcR_X4Lh5F2m1HDI7753--47VZyYjr8WDbAMrY=.e8310f9b-6ae5-4b35-8620-1a68aa6f8eb4@github.com> On Wed, 15 Mar 2023 07:06:55 GMT, Kimura Yukihiro wrote: > I would like to backport > JDK-8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence. > The original patch does not apply cleanly to 11u. > Because the original patch has switch expressions which can not be used in 11u, > and it has the Class jdk.javadoc.internal.doclets.formats.html.HtmlOptions which is not defined in 11u. > There is no risk, because the logic around the changes is the same as jdk17. > I confirmed the following test and all langtool tests. > test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java > > Could anyone review the fix please? You're correct. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1805 From clanger at openjdk.org Thu Mar 16 16:56:13 2023 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 16 Mar 2023 16:56:13 GMT Subject: [jdk11u-dev] RFR: 8263420: Incorrect function name in NSAccessibilityStaticText native peer implementation In-Reply-To: References: Message-ID: On Wed, 15 Mar 2023 18:36:58 GMT, Autumn Capasso wrote: > This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components. Hi @Autumn808, why do you make this one a dependent PR on #1804? I think this could go on its own. Just rebase your branch to a master branch where you cherry-pick your commit https://github.com/Autumn808/jdk11u-dev/commit/d896246a117a929b2d34463168095497c95ee601 on. OTOH, you might just integrate #1804 now since I have it approved. Then merge master into this PR. Cheers Christoph ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1806 From clanger at openjdk.org Thu Mar 16 17:20:18 2023 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 16 Mar 2023 17:20:18 GMT Subject: [jdk11u-dev] RFR: 8265486: ProblemList javax/sound/midi/Sequencer/Recording.java on macosx-aarch64 Message-ID: Backport done for Oracle Parity. Simple backport of a problem list entry. I had to resolve because 11u still has Solaris. ------------- Commit messages: - Backport ab2240741cfc7d10f012c1d588a92cf6f94e1de6 Changes: https://git.openjdk.org/jdk11u-dev/pull/1810/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1810&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8265486 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1810.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1810/head:pull/1810 PR: https://git.openjdk.org/jdk11u-dev/pull/1810 From phh at openjdk.org Thu Mar 16 18:21:50 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 16 Mar 2023 18:21:50 GMT Subject: [jdk11u-dev] RFR: 8265486: ProblemList javax/sound/midi/Sequencer/Recording.java on macosx-aarch64 In-Reply-To: References: Message-ID: <_MQ5xuE568mN84dihQ7Z3hOaFEzPcrMTq_c8GCy7OZY=.60c17195-50c2-406a-9016-a7e54d4a5a50@github.com> On Thu, 16 Mar 2023 17:09:17 GMT, Christoph Langer wrote: > Backport done for Oracle Parity. > > Simple backport of a problem list entry. I had to resolve because 11u still has Solaris. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1810 From duke at openjdk.org Thu Mar 16 18:32:08 2023 From: duke at openjdk.org (Autumn Capasso) Date: Thu, 16 Mar 2023 18:32:08 GMT Subject: [jdk11u-dev] Integrated: 8264304: Create implementation for NSAccessibilityToolbar protocol peer In-Reply-To: References: Message-ID: <8D5db5-jTPmwIqtQPiVxGm7dhUZ8nzC1vSWD08hg8Hk=.fa6b341c-772d-4637-8ec1-c8b4d76a476b@github.com> On Tue, 14 Mar 2023 21:58:19 GMT, Autumn Capasso wrote: > This backport is part of the 28 backport Accessibility series JDK-8152350. Commented out line 61 of commoneComponentAccesssibilty.m until backport JDK-8262981 is reworked. This pull request has now been integrated. Changeset: 41ad0479 Author: Autumn Capasso <34965675+Autumn808 at users.noreply.github.com> Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/41ad04794edd5e6b00e0beb1604d34edfbc3ff81 Stats: 43 lines in 3 files changed: 40 ins; 0 del; 3 mod 8264304: Create implementation for NSAccessibilityToolbar protocol peer Reviewed-by: phh Backport-of: 4d26f22b9adcf7cecca5316348ef670ac2dbc365 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1804 From duke at openjdk.org Thu Mar 16 19:03:15 2023 From: duke at openjdk.org (Autumn Capasso) Date: Thu, 16 Mar 2023 19:03:15 GMT Subject: [jdk11u-dev] RFR: 8263420: Incorrect function name in NSAccessibilityStaticText native peer implementation [v2] In-Reply-To: References: Message-ID: > This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components. Autumn Capasso has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1806/files - new: https://git.openjdk.org/jdk11u-dev/pull/1806/files/19a9eafc..19a9eafc Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1806&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1806&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1806.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1806/head:pull/1806 PR: https://git.openjdk.org/jdk11u-dev/pull/1806 From duke at openjdk.org Thu Mar 16 19:16:09 2023 From: duke at openjdk.org (Autumn Capasso) Date: Thu, 16 Mar 2023 19:16:09 GMT Subject: [jdk11u-dev] RFR: 8263420: Incorrect function name in NSAccessibilityStaticText native peer implementation [v3] In-Reply-To: References: Message-ID: > This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components. Autumn Capasso has updated the pull request incrementally with one additional commit since the last revision: Backport d86f91642d7dcf829b8093ebed336d4386bff67a ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1806/files - new: https://git.openjdk.org/jdk11u-dev/pull/1806/files/19a9eafc..f18c8ee8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1806&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1806&range=01-02 Stats: 134 lines in 3 files changed: 121 ins; 12 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1806.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1806/head:pull/1806 PR: https://git.openjdk.org/jdk11u-dev/pull/1806 From duke at openjdk.org Thu Mar 16 19:26:25 2023 From: duke at openjdk.org (Autumn Capasso) Date: Thu, 16 Mar 2023 19:26:25 GMT Subject: [jdk11u-dev] RFR: 8263420: Incorrect function name in NSAccessibilityStaticText native peer implementation [v4] In-Reply-To: References: Message-ID: <7MCG0XKvBmRwCiNGl1D94imR_HRzTS_P6RlCiLC0NT8=.127445c2-443b-47c2-94b8-aab7f29d3dc1@github.com> > This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components. Autumn Capasso has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8263420: Incorrect function name in NSAccessibilityStaticText native peer implementation Reviewed-by: kizune (cherry picked from commit d896246a117a929b2d34463168095497c95ee601) ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1806/files - new: https://git.openjdk.org/jdk11u-dev/pull/1806/files/f18c8ee8..691fc4d5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1806&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1806&range=02-03 Stats: 289 lines in 6 files changed: 6 ins; 283 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1806.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1806/head:pull/1806 PR: https://git.openjdk.org/jdk11u-dev/pull/1806 From phh at openjdk.org Thu Mar 16 19:28:43 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 16 Mar 2023 19:28:43 GMT Subject: [jdk11u-dev] RFR: 8263420: Incorrect function name in NSAccessibilityStaticText native peer implementation [v3] In-Reply-To: References: Message-ID: On Thu, 16 Mar 2023 19:16:09 GMT, Autumn Capasso wrote: >> This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components. > > Autumn Capasso has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available. Tagged the JBS issue. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1806 From duke at openjdk.org Thu Mar 16 19:51:54 2023 From: duke at openjdk.org (Autumn Capasso) Date: Thu, 16 Mar 2023 19:51:54 GMT Subject: [jdk11u-dev] RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly [v2] In-Reply-To: References: Message-ID: > This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components. Autumn Capasso has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1807/files - new: https://git.openjdk.org/jdk11u-dev/pull/1807/files/c9787abf..c9787abf Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1807&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1807&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1807.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1807/head:pull/1807 PR: https://git.openjdk.org/jdk11u-dev/pull/1807 From phh at openjdk.org Thu Mar 16 21:25:10 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 16 Mar 2023 21:25:10 GMT Subject: [jdk11u-dev] RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly [v2] In-Reply-To: References: Message-ID: On Thu, 16 Mar 2023 19:51:54 GMT, Autumn Capasso wrote: >> This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components. > > Autumn Capasso has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. Because 8262981 hasn't yet been backported, this PR adds an updated-to-8267066 version of SliderAccessibilty.h and leaves out the change to a not-yet-existent SliderAccessibility.m. This is imo fine, but note that the eventual 8262981 backport will have to take into account this PR's creation of SliderAccessibility.h. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1807 From clanger at openjdk.org Thu Mar 16 21:34:23 2023 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 16 Mar 2023 21:34:23 GMT Subject: [jdk11u-dev] RFR: 8264290: Create implementation for NSAccessibilityComponentGroup protocol peer In-Reply-To: References: <2pBjo9uNaKMVQ3WZbiY23ZDHfrvzpxBtnRAZnIrzVtk=.9baa415a-1c20-42d8-8867-98b24c6e2753@github.com> Message-ID: <1U_xXSeqruaA-JAUnbOBmziEy_QQRx9fyNH4yFLKXdY=.71c62efe-51e5-418a-b57c-1619d758a725@github.com> On Wed, 15 Mar 2023 17:05:48 GMT, Autumn Capasso wrote: > > Hi @Autumn808 @phohensee you say you had to work around 8262981. What stops that change from being pushed? Can't you move the CSR to proposed? > > @GoeLin we didn?t see a CSR for the Oracle backport, so we believe they adopted a different approach which we?re figuring out how to duplicate. The CSR looks like it changes a public interface, which would in theory require a JDK 11 update JSR. Right, interface changes can't be backported. Looking at the change 8262981, you could probably just backport the native code to keep the codebase even. Would you mind doing that? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1799 From duke at openjdk.org Thu Mar 16 21:35:27 2023 From: duke at openjdk.org (Ravali Yatham) Date: Thu, 16 Mar 2023 21:35:27 GMT Subject: [jdk17u-dev] Integrated: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: <0UoKR_E32UN2XfheFH3tpObIO_ahV2hD1SjGpX_EmRc=.5df98b4c-c919-45ca-a0d2-6fa449cd632b@github.com> On Wed, 8 Mar 2023 11:47:56 GMT, Ravali Yatham wrote: > Added specific class loader object to proxy IllegalArgumentException from which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 > > OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 This pull request has now been integrated. Changeset: c6805e64 Author: Ravali Yatham Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/c6805e643faf3776bb1779fe6f045e7a20a220de Stats: 16 lines in 4 files changed: 15 ins; 0 del; 1 mod 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message Reviewed-by: mchung, phh Backport-of: 9f9d678591e02ecaeae7b81eeefb0ba41c7b4dae ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1199 From duke at openjdk.org Thu Mar 16 21:37:06 2023 From: duke at openjdk.org (Autumn Capasso) Date: Thu, 16 Mar 2023 21:37:06 GMT Subject: [jdk11u-dev] Integrated: 8263420: Incorrect function name in NSAccessibilityStaticText native peer implementation In-Reply-To: References: Message-ID: On Wed, 15 Mar 2023 18:36:58 GMT, Autumn Capasso wrote: > This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components. This pull request has now been integrated. Changeset: 4b5fdd88 Author: Pankaj Bansal Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/4b5fdd885489a0307936a069d0f738165fbf9903 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8263420: Incorrect function name in NSAccessibilityStaticText native peer implementation Backport-of: d896246a117a929b2d34463168095497c95ee601 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1806 From duke at openjdk.org Fri Mar 17 00:49:53 2023 From: duke at openjdk.org (Autumn Capasso) Date: Fri, 17 Mar 2023 00:49:53 GMT Subject: [jdk11u-dev] RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly [v3] In-Reply-To: References: Message-ID: > This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components. Autumn Capasso has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport JDK-8267066 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1807/files - new: https://git.openjdk.org/jdk11u-dev/pull/1807/files/c9787abf..5d85ac52 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1807&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1807&range=01-02 Stats: 25 lines in 7 files changed: 0 ins; 16 del; 9 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1807.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1807/head:pull/1807 PR: https://git.openjdk.org/jdk11u-dev/pull/1807 From duke at openjdk.org Fri Mar 17 01:05:28 2023 From: duke at openjdk.org (Autumn Capasso) Date: Fri, 17 Mar 2023 01:05:28 GMT Subject: [jdk11u-dev] RFR: 8264302: Create implementation for Accessibility native peer for Splitpane java role [v2] In-Reply-To: References: Message-ID: > This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components. Autumn Capasso has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1808/files - new: https://git.openjdk.org/jdk11u-dev/pull/1808/files/b6ea4f64..b6ea4f64 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1808&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1808&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1808.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1808/head:pull/1808 PR: https://git.openjdk.org/jdk11u-dev/pull/1808 From duke at openjdk.org Fri Mar 17 03:44:24 2023 From: duke at openjdk.org (Ravali Yatham) Date: Fri, 17 Mar 2023 03:44:24 GMT Subject: [jdk11u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: <_HaEuPh-iJxptah9bSyHlMbU9XP2nrYxbxb8qQF2sD4=.f695b614-1f11-4648-a466-ea331a191000@github.com> On Thu, 16 Mar 2023 09:54:25 GMT, Severin Gehwolf wrote: >> Added specific class loader object to proxy IllegalArgumentException from which the class was not visible >> >> The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 >> >> OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 > > Also please merge master and push so as to trigger GHA testing (or trigger it manually on your fork via the actions tab on github) @jerboaa - Thanks for your inputs. Triggered GHA testing manually and JDK17 back port is pushed. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1802 From clanger at openjdk.org Fri Mar 17 07:04:27 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 17 Mar 2023 07:04:27 GMT Subject: [jdk11u-dev] RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly [v3] In-Reply-To: References: Message-ID: On Fri, 17 Mar 2023 00:49:53 GMT, Autumn Capasso wrote: >> This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components. > > Autumn Capasso has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport JDK-8267066 @Autumn808, could you rebase it to current master? Meanwhile 8264290 was integrated and changes to e.g. src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/GroupAccessibility.m would look different then, I guess. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1807 From goetz at openjdk.org Fri Mar 17 07:26:31 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 17 Mar 2023 07:26:31 GMT Subject: [jdk11u-dev] Integrated: 8294548: Problem list SA core file tests on macosx-x64 due to JDK-8294316 In-Reply-To: References: Message-ID: On Tue, 28 Feb 2023 14:43:19 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.19-oracle. > > These fail in our CI too, sometimes. This pull request has now been integrated. Changeset: 362c2e3e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/362c2e3ee3bc568c6f74d774138350796d11aecc Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod 8294548: Problem list SA core file tests on macosx-x64 due to JDK-8294316 Reviewed-by: mbaesken Backport-of: 545ded1a82baf62ef551b2be2a08ee29ab5d9311 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1784 From goetz at openjdk.org Fri Mar 17 07:54:30 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 17 Mar 2023 07:54:30 GMT Subject: [jdk11u] RFR: 8304389: [11u] Crash on Windows in C2 compiled code after 8248238 and 8218431 Message-ID: ? 8218431 A required fix to avoid regression in 11.0.19. See JBS issue. ------------- Commit messages: - 8304389: [11u] Crash on Windows in C2 compiled code after 8248238 and 8218431 Changes: https://git.openjdk.org/jdk11u/pull/70/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u&pr=70&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304389 Stats: 4 lines in 1 file changed: 1 ins; 3 del; 0 mod Patch: https://git.openjdk.org/jdk11u/pull/70.diff Fetch: git fetch https://git.openjdk.org/jdk11u pull/70/head:pull/70 PR: https://git.openjdk.org/jdk11u/pull/70 From mbaesken at openjdk.org Fri Mar 17 08:09:34 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 17 Mar 2023 08:09:34 GMT Subject: [jdk17u-dev] Integrated: 8301050: Detect Xen Virtualization on Linux aarch64 In-Reply-To: References: Message-ID: <_sgjuZpTHeLtVdHEl8EoSs5hylEAR2q6EY1h5aeqakM=.9eeb1c7f-2056-4aa4-be75-3ac876b01985@github.com> On Wed, 15 Feb 2023 15:15:55 GMT, Matthias Baesken wrote: > Backport of 8301050 This pull request has now been integrated. Changeset: fba6dd8b Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/fba6dd8b454d14b0ae6ce84587c1e4f0358f115d Stats: 30 lines in 2 files changed: 17 ins; 2 del; 11 mod 8301050: Detect Xen Virtualization on Linux aarch64 Reviewed-by: clanger Backport-of: 11804b246e8643a3465b9549794ccfb24ccd8fc5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1174 From mbaesken at openjdk.org Fri Mar 17 08:09:35 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 17 Mar 2023 08:09:35 GMT Subject: [jdk17u-dev] Integrated: 8303354: addCertificatesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return In-Reply-To: References: Message-ID: On Wed, 15 Mar 2023 12:11:49 GMT, Matthias Baesken wrote: > 8303354: addCertificatesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return This pull request has now been integrated. Changeset: c0056825 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/c00568255be4fef9183ee9650775702efff43d43 Stats: 24 lines in 1 file changed: 17 ins; 0 del; 7 mod 8303354: addCertificatesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return Backport-of: b51ea4204eaa18687e7712e87cdc92efbddfcb5b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1202 From mbaesken at openjdk.org Fri Mar 17 08:21:19 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 17 Mar 2023 08:21:19 GMT Subject: [jdk17u-dev] RFR: 8303949: gcc10 warning Linux ppc64le - note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5 In-Reply-To: References: Message-ID: <2bzq4IowHbgsZcMlgq0mj-dh2AEHGj_h5vzBtRRR--k=.5490b5ba-5e16-44c0-a48a-cc06ad116ae3@github.com> On Thu, 16 Mar 2023 13:01:03 GMT, Matthias Baesken wrote: > Backport of 8303949 Hi Paul, thanks for the review ! ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1206 From mbaesken at openjdk.org Fri Mar 17 09:25:53 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 17 Mar 2023 09:25:53 GMT Subject: [jdk17u-dev] RFR: 8303575: adjust Xen handling on Linux aarch64 Message-ID: . ------------- Commit messages: - Backport 8eaf84f09476b08ed421efe74d7554e2b29bc5a7 Changes: https://git.openjdk.org/jdk17u-dev/pull/1207/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1207&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303575 Stats: 13 lines in 3 files changed: 5 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1207.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1207/head:pull/1207 PR: https://git.openjdk.org/jdk17u-dev/pull/1207 From clanger at openjdk.org Fri Mar 17 11:40:12 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 17 Mar 2023 11:40:12 GMT Subject: [jdk11u-dev] Integrated: 8265486: ProblemList javax/sound/midi/Sequencer/Recording.java on macosx-aarch64 In-Reply-To: References: Message-ID: On Thu, 16 Mar 2023 17:09:17 GMT, Christoph Langer wrote: > Backport done for Oracle Parity. > > Simple backport of a problem list entry. I had to resolve because 11u still has Solaris. This pull request has now been integrated. Changeset: be64682e Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/be64682e2995e7999b9b1b46a04a67b9f807d84a Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8265486: ProblemList javax/sound/midi/Sequencer/Recording.java on macosx-aarch64 Reviewed-by: phh Backport-of: ab2240741cfc7d10f012c1d588a92cf6f94e1de6 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1810 From phh at openjdk.org Fri Mar 17 12:24:33 2023 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 17 Mar 2023 12:24:33 GMT Subject: [jdk11u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: On Mon, 13 Mar 2023 07:37:53 GMT, Ravali Yatham wrote: > Added specific class loader object to proxy IllegalArgumentException from which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 > > OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 Clean backport from 17u, except added missing definition of JLA in Proxy.java. Lgtm. Tagged the JBS issue ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1802 From aturbanov at openjdk.org Fri Mar 17 13:42:33 2023 From: aturbanov at openjdk.org (Andrey Turbanov) Date: Fri, 17 Mar 2023 13:42:33 GMT Subject: [jdk11u-dev] RFR: 8232853: AuthenticationFilter.Cache::remove may throw ConcurrentModificationException In-Reply-To: <_a8JEplcWd5jMCVn2v8wnLl0yO7wnMh4em1DyKhgWGE=.46bdf83f-cad1-435d-892f-2d7f7a3dccbc@github.com> References: <_a8JEplcWd5jMCVn2v8wnLl0yO7wnMh4em1DyKhgWGE=.46bdf83f-cad1-435d-892f-2d7f7a3dccbc@github.com> Message-ID: <2fHcokBzVosVYwGypqPff8lzMvQhYcJpg-PcqCDmETg=.8fe50480-6a5a-4f46-beb0-6fdb4d03ce97@github.com> On Tue, 14 Mar 2023 09:04:29 GMT, Andrey Turbanov wrote: > Hi all, > This pull request contains a backport of commit [d948bfd5](https://github.com/openjdk/jdk/commit/d948bfd58406cb9b73c6fc4c50728647a5cdf6b5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > Original patch have changed a bit in the test code only, due to different package of `SimpleSSLContext`. > Testing: Linux x86_64, `tier1`, `jdk/java/net/httpclient` Should I type `integrate` in the comment? Or bots will take of this PR? https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix doesn't specify last steps. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1803 From duke at openjdk.org Fri Mar 17 14:09:38 2023 From: duke at openjdk.org (Ravali Yatham) Date: Fri, 17 Mar 2023 14:09:38 GMT Subject: [jdk11u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: <63UQjurCUgoxrPi3c5WkBYBtlFE4dALEIlSA2ezOO7I=.29005d45-4cd9-4530-8575-f4456d8c807a@github.com> On Fri, 17 Mar 2023 12:21:48 GMT, Paul Hohensee wrote: >> Added specific class loader object to proxy IllegalArgumentException from which the class was not visible >> >> The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 >> >> OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 > > Tagged the JBS issue Thanks @phohensee for reviewing. Issued `/integrate` , now is ready to be sponsored ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1802 From mbaesken at openjdk.org Fri Mar 17 15:38:22 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 17 Mar 2023 15:38:22 GMT Subject: [jdk20u] Integrated: 8300692: GCC 12 reports some compiler warnings in bundled freetype In-Reply-To: References: Message-ID: On Mon, 13 Mar 2023 12:08:14 GMT, Matthias Baesken wrote: > 8300692: GCC 12 reports some compiler warnings in bundled freetype This pull request has now been integrated. Changeset: 5138f5a9 Author: Matthias Baesken URL: https://git.openjdk.org/jdk20u/commit/5138f5a964471c3ef37716fe46fa158322133b9f Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8300692: GCC 12 reports some compiler warnings in bundled freetype Backport-of: a6c2a2ae79be6810dca55b13bfc8a7625f25d48d ------------- PR: https://git.openjdk.org/jdk20u/pull/19 From honkar at openjdk.org Fri Mar 17 16:43:42 2023 From: honkar at openjdk.org (Harshitha Onkar) Date: Fri, 17 Mar 2023 16:43:42 GMT Subject: [jdk20u] RFR: 8301998: Update HarfBuzz to 7.0.1 Message-ID: Backport of HarfBuzz v7.0.1 changes commit#[fc104420d8](https://github.com/openjdk/jdk/commit/f5c8b68c1c4d8bdbf4838aafdcd657fc104420d8) ------------- Commit messages: - 8301998: Update HarfBuzz to 7.0.1 Changes: https://git.openjdk.org/jdk20u/pull/20/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=20&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8301998 Stats: 41619 lines in 271 files changed: 24532 ins; 11231 del; 5856 mod Patch: https://git.openjdk.org/jdk20u/pull/20.diff Fetch: git fetch https://git.openjdk.org/jdk20u pull/20/head:pull/20 PR: https://git.openjdk.org/jdk20u/pull/20 From duke at openjdk.org Fri Mar 17 16:52:17 2023 From: duke at openjdk.org (Autumn Capasso) Date: Fri, 17 Mar 2023 16:52:17 GMT Subject: [jdk11u-dev] RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly [v3] In-Reply-To: References: Message-ID: On Fri, 17 Mar 2023 07:02:06 GMT, Christoph Langer wrote: > @Autumn808, could you rebase it to current master? Meanwhile 8264290 was integrated and changes to e.g. src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/GroupAccessibility.m would look different then, I guess. Will do, Thank you ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1807 From honkar at openjdk.org Fri Mar 17 17:21:08 2023 From: honkar at openjdk.org (Harshitha Onkar) Date: Fri, 17 Mar 2023 17:21:08 GMT Subject: [jdk20u] Integrated: 8301998: Update HarfBuzz to 7.0.1 In-Reply-To: References: Message-ID: <4BvVDeR3nnpacfZdf5fKoExeefKmsRidSFqd_UTLeqQ=.0de1de6a-ffdf-48e9-bd94-90dc6f6ffddf@github.com> On Fri, 17 Mar 2023 16:33:43 GMT, Harshitha Onkar wrote: > This is a backport of HarfBuzz v7.0.1 changes commit#[fc104420d8](https://github.com/openjdk/jdk/commit/f5c8b68c1c4d8bdbf4838aafdcd657fc104420d8) and the original PR#[12913](https://github.com/openjdk/jdk/pull/12913) This pull request has now been integrated. Changeset: cc4b7e65 Author: Harshitha Onkar Committer: Phil Race URL: https://git.openjdk.org/jdk20u/commit/cc4b7e65cddc3e8deb077e84a6e15b3a391eff77 Stats: 41619 lines in 271 files changed: 24532 ins; 11231 del; 5856 mod 8301998: Update HarfBuzz to 7.0.1 Backport-of: f5c8b68c1c4d8bdbf4838aafdcd657fc104420d8 ------------- PR: https://git.openjdk.org/jdk20u/pull/20 From phh at openjdk.org Fri Mar 17 17:44:36 2023 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 17 Mar 2023 17:44:36 GMT Subject: [jdk11u-dev] RFR: 8232853: AuthenticationFilter.Cache::remove may throw ConcurrentModificationException In-Reply-To: <_a8JEplcWd5jMCVn2v8wnLl0yO7wnMh4em1DyKhgWGE=.46bdf83f-cad1-435d-892f-2d7f7a3dccbc@github.com> References: <_a8JEplcWd5jMCVn2v8wnLl0yO7wnMh4em1DyKhgWGE=.46bdf83f-cad1-435d-892f-2d7f7a3dccbc@github.com> Message-ID: On Tue, 14 Mar 2023 09:04:29 GMT, Andrey Turbanov wrote: > Hi all, > This pull request contains a backport of commit [d948bfd5](https://github.com/openjdk/jdk/commit/d948bfd58406cb9b73c6fc4c50728647a5cdf6b5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > Original patch have changed a bit in the test code only, due to different package of `SimpleSSLContext`. > Testing: Linux x86_64, `tier1`, `jdk/java/net/httpclient` The backport has been approved (i.e., the JBS issue has the jdk11u-fix-yes label), so now you can add a "/integrate" comment. If you're a Committer, that's it. If not, a Committer has to sponsor the commit, typically the reviewer. In this case, that's me, so I'd sponsor by adding a "/sponsor" comment after you add "/integrate". ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1803 From phh at openjdk.org Fri Mar 17 18:02:05 2023 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 17 Mar 2023 18:02:05 GMT Subject: [jdk11u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: On Mon, 13 Mar 2023 07:37:53 GMT, Ravali Yatham wrote: > Added specific class loader object to proxy IllegalArgumentException from which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 > > OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 I tagged the issue with an approval request (added jdk11u-fix-request label), have to wait for a maintainer to approve before integrating. In the future, please wait until maintainer approval before adding "/integrate". ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1802 From duke at openjdk.org Fri Mar 17 18:07:37 2023 From: duke at openjdk.org (Autumn Capasso) Date: Fri, 17 Mar 2023 18:07:37 GMT Subject: [jdk11u-dev] RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly [v4] In-Reply-To: References: Message-ID: > This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components. Autumn Capasso has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport JDK-8267066 ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1807/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1807&range=03 Stats: 187 lines in 24 files changed: 158 ins; 0 del; 29 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1807.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1807/head:pull/1807 PR: https://git.openjdk.org/jdk11u-dev/pull/1807 From duke at openjdk.org Fri Mar 17 18:11:25 2023 From: duke at openjdk.org (Autumn Capasso) Date: Fri, 17 Mar 2023 18:11:25 GMT Subject: [jdk11u-dev] RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly [v3] In-Reply-To: References: Message-ID: <0sDGR1a8tR6HnUutbt21hLUrXN0qUKp3YY6fro3jzsM=.24256bae-8748-48ef-8f03-114cc5488ee2@github.com> On Fri, 17 Mar 2023 16:49:57 GMT, Autumn Capasso wrote: > @Autumn808, could you rebase it to current master? Meanwhile 8264290 was integrated and changes to e.g. src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/GroupAccessibility.m would look different then, I guess. It should be rebased now. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1807 From aturbanov at openjdk.org Fri Mar 17 18:21:11 2023 From: aturbanov at openjdk.org (Andrey Turbanov) Date: Fri, 17 Mar 2023 18:21:11 GMT Subject: [jdk11u-dev] Integrated: 8232853: AuthenticationFilter.Cache::remove may throw ConcurrentModificationException In-Reply-To: <_a8JEplcWd5jMCVn2v8wnLl0yO7wnMh4em1DyKhgWGE=.46bdf83f-cad1-435d-892f-2d7f7a3dccbc@github.com> References: <_a8JEplcWd5jMCVn2v8wnLl0yO7wnMh4em1DyKhgWGE=.46bdf83f-cad1-435d-892f-2d7f7a3dccbc@github.com> Message-ID: On Tue, 14 Mar 2023 09:04:29 GMT, Andrey Turbanov wrote: > Hi all, > This pull request contains a backport of commit [d948bfd5](https://github.com/openjdk/jdk/commit/d948bfd58406cb9b73c6fc4c50728647a5cdf6b5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > Original patch have changed a bit in the test code only, due to different package of `SimpleSSLContext`. > Testing: Linux x86_64, `tier1`, `jdk/java/net/httpclient` This pull request has now been integrated. Changeset: 1ab86935 Author: Andrey Turbanov Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/1ab869358a9747291465130ca8a476a2f7893d40 Stats: 309 lines in 2 files changed: 306 ins; 0 del; 3 mod 8232853: AuthenticationFilter.Cache::remove may throw ConcurrentModificationException Change implementation to use iterator instead of plain LinkedList Reviewed-by: phh Backport-of: d948bfd58406cb9b73c6fc4c50728647a5cdf6b5 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1803 From clanger at openjdk.org Fri Mar 17 18:43:07 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 17 Mar 2023 18:43:07 GMT Subject: [jdk11u-dev] RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly [v3] In-Reply-To: <0sDGR1a8tR6HnUutbt21hLUrXN0qUKp3YY6fro3jzsM=.24256bae-8748-48ef-8f03-114cc5488ee2@github.com> References: <0sDGR1a8tR6HnUutbt21hLUrXN0qUKp3YY6fro3jzsM=.24256bae-8748-48ef-8f03-114cc5488ee2@github.com> Message-ID: <_sdWL-aI4emFTm7NdyG07SO4zi_n1s2oCBrYIlgjmuE=.9f2fb6da-6543-45e4-9c8e-4abd875bc52f@github.com> On Fri, 17 Mar 2023 18:08:12 GMT, Autumn Capasso wrote: > > @Autumn808, could you rebase it to current master? Meanwhile 8264290 was integrated and changes to e.g. src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/GroupAccessibility.m would look different then, I guess. > > It should be rebased now. Hm, it isn't. Your branch https://github.com/Autumn808/jdk11u-dev/commits/JDK-8267066 is lacking the latest 8 or so commits. Especially https://github.com/openjdk/jdk11u-dev/commit/dd6421231d05b5e1e70a1bc0c9df613bb55c8947 and [8264304: Create implementation for NSAccessibilityToolbar protocol peer](https://github.com/openjdk/jdk11u-dev/commit/41ad04794edd5e6b00e0beb1604d34edfbc3ff81) are missing. You should fetch https://github.com/openjdk/jdk11u-dev/commit/1ab869358a9747291465130ca8a476a2f7893d40 and rebase to that commit. Anyway, I'm wondering why GitHub does not show a merge conflict here. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1807 From duke at openjdk.org Fri Mar 17 18:57:21 2023 From: duke at openjdk.org (duke) Date: Fri, 17 Mar 2023 18:57:21 GMT Subject: [jdk11u-dev] Withdrawn: 8245246: Deprecate -profile option in javac In-Reply-To: References: Message-ID: On Tue, 17 Jan 2023 10:39:35 GMT, Shruthi wrote: > OpenJDK PR : https://github.com/openjdk/jdk/pull/11226 > OpenJDK bug : https://bugs.openjdk.org/browse/JDK-8245246 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1665 From duke at openjdk.org Fri Mar 17 18:59:14 2023 From: duke at openjdk.org (duke) Date: Fri, 17 Mar 2023 18:59:14 GMT Subject: [jdk11u-dev] Withdrawn: 8187697: Cleanup: irrelevant code in OutputPropertiesFactory In-Reply-To: References: Message-ID: <60krfcFAr1iGCzlOGvJNzReS6wSeJYWdb9oAjRyYpS8=.68f9d436-a6a5-419c-9af3-735b8257a891@github.com> On Fri, 18 Nov 2022 22:36:43 GMT, Tyler Steele wrote: > This is part of an effort to backport the following 3 commits. > > 1. https://github.com/openjdk/jdk/commit/08a370a8a56b129c9b1a812648261fe3ae8d7ea5 > 2. https://github.com/openjdk/jdk/commit/b238aef18d56ad87ab954e3ceac797c234b3f3bf > 3. https://github.com/openjdk/jdk/commit/5c12a30062a3c661f4a862eeb66b6ca18875bab4 > > This PR cleans up code in OutputPropertiesFactory--adding changes which are then modifies by 2. Change 2, adds a test file, and makes further modifications for the fix in 3. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1530 From duke at openjdk.org Fri Mar 17 19:11:28 2023 From: duke at openjdk.org (Autumn Capasso) Date: Fri, 17 Mar 2023 19:11:28 GMT Subject: [jdk11u-dev] RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly [v5] In-Reply-To: References: Message-ID: > This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components. Autumn Capasso has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport JDK-8267066 ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1807/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1807&range=04 Stats: 89 lines in 18 files changed: 66 ins; 0 del; 23 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1807.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1807/head:pull/1807 PR: https://git.openjdk.org/jdk11u-dev/pull/1807 From clanger at openjdk.org Fri Mar 17 19:12:05 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 17 Mar 2023 19:12:05 GMT Subject: [jdk11u-dev] RFR: 8262981: Create implementation for NSAccessibilitySlider protocol Message-ID: I propose to backport JDK-8262981 in a way that does not require a CSR. Just integrate the native code but don't touch the Java interface of javax.swing.JSlider. ------------- Commit messages: - Backport 9d669c912d3977027f321a5e6b7f045ca2ce9482 Changes: https://git.openjdk.org/jdk11u-dev/pull/1811/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1811&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8262981 Stats: 8 lines in 3 files changed: 0 ins; 2 del; 6 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1811.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1811/head:pull/1811 PR: https://git.openjdk.org/jdk11u-dev/pull/1811 From duke at openjdk.org Fri Mar 17 19:22:24 2023 From: duke at openjdk.org (duke) Date: Fri, 17 Mar 2023 19:22:24 GMT Subject: [jdk17u-dev] Withdrawn: 8299158: Improve MD5 intrinsic on AArch64 In-Reply-To: References: Message-ID: On Thu, 5 Jan 2023 06:49:24 GMT, Yi-Fan Tsai wrote: > This change is nearly clean. 17u uses macro and tip uses functions. > > TestMD5Intrinsics and TestMD5MultiBlockIntrinsics are tested with [the patch](https://github.com/openjdk/jdk/pull/10954). > > Similar performance improvement is observed. > > baseline > > Benchmark (digesterName) (length) (provider) Mode Cnt Score Error Units > MessageDigests.digest md5 64 DEFAULT thrpt 50 2987.994 ? 3.246 ops/ms > MessageDigests.digest md5 1024 DEFAULT thrpt 50 370.344 ? 0.683 ops/ms > MessageDigests.digest md5 16384 DEFAULT thrpt 50 24.773 ? 0.038 ops/ms > MessageDigests.getAndDigest md5 64 DEFAULT thrpt 50 2543.829 ? 3.060 ops/ms > MessageDigests.getAndDigest md5 1024 DEFAULT thrpt 50 364.196 ? 0.319 ops/ms > MessageDigests.getAndDigest md5 16384 DEFAULT thrpt 50 24.741 ? 0.021 ops/ms > > > optimized > > Benchmark (digesterName) (length) (provider) Mode Cnt Score Error Units > MessageDigests.digest md5 64 DEFAULT thrpt 50 3671.576 ? 2.780 ops/ms > MessageDigests.digest md5 1024 DEFAULT thrpt 50 462.163 ? 0.724 ops/ms > MessageDigests.digest md5 16384 DEFAULT thrpt 50 31.137 ? 0.058 ops/ms > MessageDigests.getAndDigest md5 64 DEFAULT thrpt 50 3015.830 ? 4.608 ops/ms > MessageDigests.getAndDigest md5 1024 DEFAULT thrpt 50 453.550 ? 0.263 ops/ms > MessageDigests.getAndDigest md5 16384 DEFAULT thrpt 50 31.039 ? 0.006 ops/ms This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1037 From duke at openjdk.org Fri Mar 17 19:25:09 2023 From: duke at openjdk.org (duke) Date: Fri, 17 Mar 2023 19:25:09 GMT Subject: [jdk17u-dev] Withdrawn: 8269821: Remove is-queue-active check in inner loop of write_ref_array_pre_work In-Reply-To: <1cQ1Yc_NFDqnGl69lEPvAHePsK-XVVmcMves-8zcSv0=.25162874-26ec-470e-b1a7-01adf6632abf@github.com> References: <1cQ1Yc_NFDqnGl69lEPvAHePsK-XVVmcMves-8zcSv0=.25162874-26ec-470e-b1a7-01adf6632abf@github.com> Message-ID: On Mon, 21 Nov 2022 09:50:31 GMT, Aleksey Shipilev wrote: > Clean backport to improve G1 performance and provide grounds for next backports. > > @tschatzl, do you want to ack this? > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1` > - [x] Linux x86_64 fastdebug `tier2` This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/905 From duke at openjdk.org Fri Mar 17 19:31:21 2023 From: duke at openjdk.org (Autumn Capasso) Date: Fri, 17 Mar 2023 19:31:21 GMT Subject: [jdk11u-dev] RFR: 8264302: Create implementation for Accessibility native peer for Splitpane java role [v3] In-Reply-To: References: Message-ID: > This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components. Autumn Capasso has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport 45e05970bcee842f98eeeef054f574ccf4b43fad ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1808/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1808&range=02 Stats: 43 lines in 3 files changed: 39 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1808.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1808/head:pull/1808 PR: https://git.openjdk.org/jdk11u-dev/pull/1808 From duke at openjdk.org Fri Mar 17 19:50:10 2023 From: duke at openjdk.org (Autumn Capasso) Date: Fri, 17 Mar 2023 19:50:10 GMT Subject: [jdk11u-dev] RFR: 8264305: Create implementation for native accessibility peer for Statusbar java role [v2] In-Reply-To: References: Message-ID: > This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components. Autumn Capasso has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1809/files - new: https://git.openjdk.org/jdk11u-dev/pull/1809/files/7441b1d9..7441b1d9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1809&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1809&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1809.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1809/head:pull/1809 PR: https://git.openjdk.org/jdk11u-dev/pull/1809 From clanger at openjdk.org Fri Mar 17 19:56:09 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 17 Mar 2023 19:56:09 GMT Subject: [jdk11u-dev] RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly [v5] In-Reply-To: References: Message-ID: <5f-H3xZjD0ejYxnJzaXQCPwyttKEG3x-KQmhSn620q8=.67e0b01c-9c48-4159-af2d-e2077c382199@github.com> On Fri, 17 Mar 2023 19:11:28 GMT, Autumn Capasso wrote: >> This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components. > > Autumn Capasso has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > Backport JDK-8267066 OK, this looks better now. However, I'm missing the hunks in the following files, compared to the original change: src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/GroupAccessibility.h src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/GroupAccessibility.m src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/SliderAccessibility.h src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/SliderAccessibility.m src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/StaticTextAccessibility.h src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/StaticTextAccessibility.m src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/ToolbarAccessibility.h src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/ToolbarAccessibility.m Regarding SliderAccessibility, I guess we need to backport the native parts of JDK-8262981 first. For that, would you mind reviewing my PR https://github.com/openjdk/jdk11u-dev/pull/1811? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1807 From duke at openjdk.org Fri Mar 17 20:06:31 2023 From: duke at openjdk.org (Autumn Capasso) Date: Fri, 17 Mar 2023 20:06:31 GMT Subject: [jdk11u-dev] RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly [v5] In-Reply-To: References: Message-ID: On Fri, 17 Mar 2023 19:11:28 GMT, Autumn Capasso wrote: >> This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components. > > Autumn Capasso has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport JDK-8267066 > OK, this looks better now. However, I'm missing the hunks in the following files, compared to the original change: > > src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/GroupAccessibility.h src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/GroupAccessibility.m > > src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/SliderAccessibility.h src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/SliderAccessibility.m > > src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/StaticTextAccessibility.h src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/StaticTextAccessibility.m > > src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/ToolbarAccessibility.h src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/ToolbarAccessibility.m > > Regarding SliderAccessibility, I guess we need to backport the native parts of JDK-8262981 first. For that, would you mind reviewing my PR #1811? Will take a look, Thank you ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1807 From clanger at openjdk.org Fri Mar 17 20:11:07 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 17 Mar 2023 20:11:07 GMT Subject: [jdk11u-dev] RFR: 8262981: Create implementation for NSAccessibilitySlider protocol In-Reply-To: References: Message-ID: On Fri, 17 Mar 2023 19:05:20 GMT, Christoph Langer wrote: > I propose to backport JDK-8262981 in a way that does not require a CSR. Just integrate the native code but don't touch the Java interface of javax.swing.JSlider. @Autumn808 @phohensee Would you mind reviewing this one (and integrating into your patch bulk)? Thx ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1811 From clanger at openjdk.org Fri Mar 17 20:12:02 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 17 Mar 2023 20:12:02 GMT Subject: [jdk11u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: On Mon, 13 Mar 2023 07:37:53 GMT, Ravali Yatham wrote: > Added specific class loader object to proxy IllegalArgumentException from which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 > > OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 Approved it. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1802 From clanger at openjdk.org Fri Mar 17 20:12:06 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 17 Mar 2023 20:12:06 GMT Subject: [jdk11u-dev] RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly [v5] In-Reply-To: References: Message-ID: On Fri, 17 Mar 2023 19:11:28 GMT, Autumn Capasso wrote: >> This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components. > > Autumn Capasso has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport JDK-8267066 You could make this a dependent PR of #1811 (until that one is in) ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1807 From duke at openjdk.org Fri Mar 17 20:12:04 2023 From: duke at openjdk.org (Ravali Yatham) Date: Fri, 17 Mar 2023 20:12:04 GMT Subject: [jdk11u-dev] Integrated: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: <5lkdLUCjNYnEepHan3OOL_2BoxrH3VUj6BRfGPxtPl0=.85209cb0-9314-4789-8842-e60ccf6f9fb7@github.com> On Mon, 13 Mar 2023 07:37:53 GMT, Ravali Yatham wrote: > Added specific class loader object to proxy IllegalArgumentException from which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 > > OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 This pull request has now been integrated. Changeset: f4776fe1 Author: Ravali Yatham Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/f4776fe17f6a84d2a6fe54d32ba844c65300369a Stats: 18 lines in 4 files changed: 17 ins; 0 del; 1 mod 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message Reviewed-by: mchung, phh Backport-of: 9f9d678591e02ecaeae7b81eeefb0ba41c7b4dae ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1802 From duke at openjdk.org Fri Mar 17 20:31:23 2023 From: duke at openjdk.org (Autumn Capasso) Date: Fri, 17 Mar 2023 20:31:23 GMT Subject: [jdk11u-dev] RFR: 8262981: Create implementation for NSAccessibilitySlider protocol In-Reply-To: References: Message-ID: On Fri, 17 Mar 2023 19:05:20 GMT, Christoph Langer wrote: > I propose to backport JDK-8262981 in a way that does not require a CSR. Just integrate the native code but don't touch the Java interface of javax.swing.JSlider. I think this is a great fix to avoid CSR and unblock the series of backports. ------------- Marked as reviewed by Autumn808 at github.com (no known OpenJDK username). PR: https://git.openjdk.org/jdk11u-dev/pull/1811 From duke at openjdk.org Fri Mar 17 20:33:53 2023 From: duke at openjdk.org (Autumn Capasso) Date: Fri, 17 Mar 2023 20:33:53 GMT Subject: [jdk11u-dev] RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly [v6] In-Reply-To: References: Message-ID: > This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components. Autumn Capasso has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Merge branch 'pr/1811' into JDK-8267066 - Backport JDK-8267066 - 8232853: AuthenticationFilter.Cache::remove may throw ConcurrentModificationException Change implementation to use iterator instead of plain LinkedList Reviewed-by: phh Backport-of: d948bfd58406cb9b73c6fc4c50728647a5cdf6b5 ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1807/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1807&range=05 Stats: 364 lines in 20 files changed: 336 ins; 2 del; 26 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1807.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1807/head:pull/1807 PR: https://git.openjdk.org/jdk11u-dev/pull/1807 From duke at openjdk.org Fri Mar 17 20:33:56 2023 From: duke at openjdk.org (Autumn Capasso) Date: Fri, 17 Mar 2023 20:33:56 GMT Subject: [jdk11u-dev] RFR: 8267066: New NSAccessibility peers should return they roles and subroles directly [v5] In-Reply-To: References: Message-ID: On Fri, 17 Mar 2023 20:08:59 GMT, Christoph Langer wrote: > You could make this a dependent PR of #1811 (until that one is in) I updated the PR to use 1811. Thank you for working on this and for your help. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1807 From clanger at openjdk.org Fri Mar 17 20:42:40 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 17 Mar 2023 20:42:40 GMT Subject: [jdk11u-dev] RFR: 8262981: Create implementation for NSAccessibilitySlider protocol [v2] In-Reply-To: References: Message-ID: > I propose to backport JDK-8262981 in a way that does not require a CSR. Just integrate the native code but don't touch the Java interface of javax.swing.JSlider. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport 9d669c912d3977027f321a5e6b7f045ca2ce9482 ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1811/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1811&range=01 Stats: 8 lines in 3 files changed: 0 ins; 2 del; 6 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1811.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1811/head:pull/1811 PR: https://git.openjdk.org/jdk11u-dev/pull/1811 From phh at openjdk.org Fri Mar 17 20:42:40 2023 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 17 Mar 2023 20:42:40 GMT Subject: [jdk11u-dev] RFR: 8262981: Create implementation for NSAccessibilitySlider protocol [v2] In-Reply-To: References: Message-ID: On Fri, 17 Mar 2023 20:39:14 GMT, Christoph Langer wrote: >> I propose to backport JDK-8262981 in a way that does not require a CSR. Just integrate the native code but don't touch the Java interface of javax.swing.JSlider. > > Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport 9d669c912d3977027f321a5e6b7f045ca2ce9482 Works for me. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1811 From clanger at openjdk.org Fri Mar 17 21:06:09 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 17 Mar 2023 21:06:09 GMT Subject: [jdk17u-dev] RFR: 8257856: Make ClassFileVersionsTest.java robust to JDK version updates Message-ID: <0cEZ4IOXtgJwHT2pys-ZMtrruPWqDppmydT5nHsVPrQ=.73f17e1f-f99e-492c-a8f8-f82596600988@github.com> Backport JDK-8257856 for Oracle parity. Test update is not exactly needed in a backport release because no Java version update will occur there. However, it's good to have the same test code base in all releases. ------------- Commit messages: - Backport 8b042d14b78c66b50495d0d8b559ca3f6744d806 Changes: https://git.openjdk.org/jdk17u-dev/pull/1208/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1208&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8257856 Stats: 66 lines in 1 file changed: 11 ins; 15 del; 40 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1208.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1208/head:pull/1208 PR: https://git.openjdk.org/jdk17u-dev/pull/1208 From serb at openjdk.org Fri Mar 17 21:35:27 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 17 Mar 2023 21:35:27 GMT Subject: [jdk11u-dev] RFR: 8262981: Create implementation for NSAccessibilitySlider protocol [v2] In-Reply-To: References: Message-ID: On Fri, 17 Mar 2023 20:42:40 GMT, Christoph Langer wrote: >> I propose to backport JDK-8262981 in a way that does not require a CSR. Just integrate the native code but don't touch the Java interface of javax.swing.JSlider. > > Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > Backport 9d669c912d3977027f321a5e6b7f045ca2ce9482 src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/SliderAccessibility.m line 52: > 50: - (BOOL)accessibilityPerformDecrement > 51: { > 52: return [self performAccessibleAction:DECREMENT]; This method should upcall the java part of the patch, and may throw an exception if we will skip it. I think we should include the java part but make it private, then re-implement this next code path to call it: accessibilityPerformDecrement->performAccessibleAction:->CAccessibility#doAccessibleAction()->JSlider ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1811 From dlong at openjdk.org Fri Mar 17 22:55:27 2023 From: dlong at openjdk.org (Dean Long) Date: Fri, 17 Mar 2023 22:55:27 GMT Subject: [jdk11u] RFR: 8304389: [11u] Crash on Windows in C2 compiled code after 8248238 and 8218431 In-Reply-To: References: Message-ID: <6wl9lOm2XukXAj5dHxc6PEgodERfIeZKVwm7z7qdPso=.0b7efc51-078e-40a0-9344-1cbc15357d97@github.com> On Fri, 17 Mar 2023 07:47:44 GMT, Goetz Lindenmaier wrote: > ? 8218431 > > A required fix to avoid regression in 11.0.19. See JBS issue. It sounds like the real problem is the #ifdef _WIN64 in x86_64.ad. If that code is wrong for 64-bit Windows, shouldn't it be removed? ------------- Changes requested by dlong (Committer). PR: https://git.openjdk.org/jdk11u/pull/70 From duke at openjdk.org Sat Mar 18 01:28:33 2023 From: duke at openjdk.org (duke) Date: Sat, 18 Mar 2023 01:28:33 GMT Subject: [jdk17u-dev] Withdrawn: 8278146: G1: Rework VM_G1Concurrent VMOp to clearly identify it as pause In-Reply-To: References: Message-ID: On Mon, 21 Nov 2022 14:55:47 GMT, Aleksey Shipilev wrote: > Clean backport to improve detailed VM diagnostics. > > @tschatzl, are you good with this in 17u? > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1` This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/910 From duke at openjdk.org Sat Mar 18 12:17:18 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Sat, 18 Mar 2023 12:17:18 GMT Subject: [jdk11u-dev] RFR: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence [v2] In-Reply-To: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> References: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> Message-ID: <3pGMfXR4pvCj4F-_62rYom0Cm0-DDICgZwjCbsV_Sdo=.e05cbaff-1ebd-45cc-9d52-041e866fa7fd@github.com> > I would like to backport > JDK-8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence. > The original patch does not apply cleanly to 11u. > Because the original patch has switch expressions which can not be used in 11u, > and it has the Class jdk.javadoc.internal.doclets.formats.html.HtmlOptions which is not defined in 11u. > There is no risk, because the logic around the changes is the same as jdk17. > I confirmed the following test and all langtool tests. > test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java > > Could anyone review the fix please? Kimura Yukihiro has updated the pull request incrementally with three additional commits since the last revision: - Merge branch '8259530' of https://github.com/yukikimmura/jdk11u-dev into 8259530 - Merge branch 'master' into 8259530 - Backport e9f3e325c274f19b0f6eceea2367708e3be689e9 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1805/files - new: https://git.openjdk.org/jdk11u-dev/pull/1805/files/2fa82df1..32a28dff Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1805&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1805&range=00-01 Stats: 274 lines in 14 files changed: 165 ins; 0 del; 109 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1805.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1805/head:pull/1805 PR: https://git.openjdk.org/jdk11u-dev/pull/1805 From duke at openjdk.org Sat Mar 18 13:09:31 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Sat, 18 Mar 2023 13:09:31 GMT Subject: [jdk11u-dev] RFR: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence [v2] In-Reply-To: <3pGMfXR4pvCj4F-_62rYom0Cm0-DDICgZwjCbsV_Sdo=.e05cbaff-1ebd-45cc-9d52-041e866fa7fd@github.com> References: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> <3pGMfXR4pvCj4F-_62rYom0Cm0-DDICgZwjCbsV_Sdo=.e05cbaff-1ebd-45cc-9d52-041e866fa7fd@github.com> Message-ID: On Sat, 18 Mar 2023 12:17:18 GMT, Kimura Yukihiro wrote: >> I would like to backport >> JDK-8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence. >> The original patch does not apply cleanly to 11u. >> Because the original patch has switch expressions which can not be used in 11u, >> and it has the Class jdk.javadoc.internal.doclets.formats.html.HtmlOptions which is not defined in 11u. >> There is no risk, because the logic around the changes is the same as jdk17. >> I confirmed the following test and all langtool tests. >> test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java >> >> Could anyone review the fix please? > > Kimura Yukihiro has updated the pull request incrementally with three additional commits since the last revision: > > - Merge branch '8259530' of https://github.com/yukikimmura/jdk11u-dev into 8259530 > - Merge branch 'master' into 8259530 > - Backport e9f3e325c274f19b0f6eceea2367708e3be689e9 In the case of 17u, variables about javadoc options are defined as PRIVATE variable in HtmlOptions.java and BaseOptions.java On the other hand, variables about configurations are defined as PUBLIC variable in HtmlConfiguration.java and BaseConfiguration.java In the case of 11u, both variables about options and configurations are defined as public variables in HtmlConfiguration.java and BaseConfiguration.java I changed variables about javadoc options to private variables according to the latest JDK. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1805 From clanger at openjdk.org Sat Mar 18 21:19:33 2023 From: clanger at openjdk.org (Christoph Langer) Date: Sat, 18 Mar 2023 21:19:33 GMT Subject: [jdk11u-dev] RFR: 8262981: Create implementation for NSAccessibilitySlider protocol [v2] In-Reply-To: References: Message-ID: <8nyy21ZrVXfxHNtW5aAbZ5H0qfVVNj1sch66Q-dRiuE=.0bf3fde1-ab8b-46d9-8f96-44e135c557f3@github.com> On Fri, 17 Mar 2023 21:32:31 GMT, Sergey Bylokhov wrote: >> Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: >> >> Backport 9d669c912d3977027f321a5e6b7f045ca2ce9482 > > src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/SliderAccessibility.m line 52: > >> 50: - (BOOL)accessibilityPerformDecrement >> 51: { >> 52: return [self performAccessibleAction:DECREMENT]; > > This method should upcall the java part of the patch, and may throw an exception if we will skip it. > > I think we should include the java part but make it private, then re-implement this next code path to call it: > accessibilityPerformDecrement->performAccessibleAction:->CAccessibility#doAccessibleAction()->JSlider You're right, that's a good catch. We'll need to rework that. performAccessibleAction, however, will expect an AccessibleAction, so we need to do this differently, if we can't implement this interface in JSlider. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1811 From mdoerr at openjdk.org Mon Mar 20 11:29:36 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 20 Mar 2023 11:29:36 GMT Subject: [jdk17u-dev] RFR: 8292301: [REDO v2] C2 crash when allocating array of size too large In-Reply-To: References: Message-ID: On Thu, 16 Mar 2023 08:16:50 GMT, Goetz Lindenmaier wrote: > I had to resolve three files: > src/hotspot/share/opto/callnode.cpp > AllocateArrayNode::Ideal could not be deleted automatically. > The patch removes igvn->add_input_to(phase->C->root(), halt); > but 11 has phase->C->root()->add_req(halt); > Just deleted anyways. > > src/hotspot/share/opto/loopopts.cpp > In the source, clone_loop() has been refactored. > The patch touches code moved to finish_clone_loop(). > The very same code is in clone_loop() in 17. Moved > hunk there. > > src/hotspot/share/opto/phaseX.cpp > Just placement of a comment. Thanks for the detailed description! Backport looks correct to me. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/1204 From duke at openjdk.org Mon Mar 20 13:41:14 2023 From: duke at openjdk.org (PoojaDP-23) Date: Mon, 20 Mar 2023 13:41:14 GMT Subject: [jdk11u-dev] RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers In-Reply-To: References: Message-ID: On Sun, 5 Mar 2023 21:22:03 GMT, Christoph Langer wrote: >>> @robilad - Earlier Workflows aren't being run on this forked repository because it was not enabled. Now I have enabled the workflow but still tests are not running on my fork. Could you please let me know what action needs to be done by myside? Thanks >> >> Hi @PoojaDP-23, >> I guess the easiest way to get current GHA checks is to merge your branch with current master of [jdk11u-dev](https://github.com/openjdk/jdk11u-dev) and push it. This will trigger a run with the most current code. > >> @RealCLanger - Could you please review the backport PR? > > I can have a look. But please do a merge with master before and by that, trigger GHA. Thanks. @RealCLanger - I have triggered GHA for my branch and master. Is that ok or do I need to merge and trigger GHA. Could you pls confirm on this? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1710 From mbaesken at openjdk.org Mon Mar 20 13:41:57 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 20 Mar 2023 13:41:57 GMT Subject: [jdk17u-dev] RFR: 8303822: gtestMain should give more helpful output Message-ID: . ------------- Commit messages: - Backport 0f26d09da881b1dfedfc0dcaff46fc169fa1f020 Changes: https://git.openjdk.org/jdk17u-dev/pull/1209/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1209&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303822 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1209.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1209/head:pull/1209 PR: https://git.openjdk.org/jdk17u-dev/pull/1209 From mbaesken at openjdk.org Mon Mar 20 13:43:05 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 20 Mar 2023 13:43:05 GMT Subject: [jdk17u-dev] Integrated: 8303949: gcc10 warning Linux ppc64le - note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5 In-Reply-To: References: Message-ID: On Thu, 16 Mar 2023 13:01:03 GMT, Matthias Baesken wrote: > Backport of 8303949 This pull request has now been integrated. Changeset: 752494f3 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/752494f31e5366e2592fec2b940e30fb11ac3e81 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8303949: gcc10 warning Linux ppc64le - note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5 Reviewed-by: phh Backport-of: a32ee5dd8b5d0b65b39d7a3f8bedc7c099987f6f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1206 From mbaesken at openjdk.org Mon Mar 20 14:04:04 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 20 Mar 2023 14:04:04 GMT Subject: [jdk11u-dev] RFR: 8300205: Swing test bug8078268 make latch timeout configurable Message-ID: 8300205: Swing test bug8078268 make latch timeout configurable ------------- Commit messages: - Backport e82dc6935b5f575a53fcba9c96767cee1b535cb8 Changes: https://git.openjdk.org/jdk11u-dev/pull/1812/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1812&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8300205 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1812.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1812/head:pull/1812 PR: https://git.openjdk.org/jdk11u-dev/pull/1812 From mbaesken at openjdk.org Mon Mar 20 14:31:42 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 20 Mar 2023 14:31:42 GMT Subject: [jdk11u-dev] RFR: 8301170: perfMemory_windows.cpp add free_security_attr to early returns Message-ID: . ------------- Commit messages: - Backport 3330f9c2ad508fdb9100a2400abdd3366342dde1 Changes: https://git.openjdk.org/jdk11u-dev/pull/1813/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1813&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8301170 Stats: 11 lines in 1 file changed: 5 ins; 4 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1813.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1813/head:pull/1813 PR: https://git.openjdk.org/jdk11u-dev/pull/1813 From mbaesken at openjdk.org Mon Mar 20 14:42:22 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 20 Mar 2023 14:42:22 GMT Subject: [jdk17u-dev] RFR: 8304063: tools/jpackage/share/AppLauncherEnvTest.java fails when checking LD_LIBRARY_PATH Message-ID: 8304063: tools/jpackage/share/AppLauncherEnvTest.java fails when checking LD_LIBRARY_PATH ------------- Commit messages: - Backport ebac7eec8e5923c66a80cbd66e79c354f30a07a3 Changes: https://git.openjdk.org/jdk17u-dev/pull/1210/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1210&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304063 Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1210.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/1210/head:pull/1210 PR: https://git.openjdk.org/jdk17u-dev/pull/1210 From goetz at openjdk.org Mon Mar 20 15:30:47 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 20 Mar 2023 15:30:47 GMT Subject: [jdk11u] RFR: 8304389: [11u] Crash on Windows in C2 compiled code after 8248238 and 8218431 In-Reply-To: <6wl9lOm2XukXAj5dHxc6PEgodERfIeZKVwm7z7qdPso=.0b7efc51-078e-40a0-9344-1cbc15357d97@github.com> References: <6wl9lOm2XukXAj5dHxc6PEgodERfIeZKVwm7z7qdPso=.0b7efc51-078e-40a0-9344-1cbc15357d97@github.com> Message-ID: On Fri, 17 Mar 2023 22:53:04 GMT, Dean Long wrote: >> ? 8218431 >> >> A required fix to avoid regression in 11.0.19. See JBS issue. > > It sounds like the real problem is the #ifdef _WIN64 in x86_64.ad. If that code is wrong for 64-bit Windows, shouldn't it be removed? Hi @dean-long I am not yet completely sure what is really wrong. The point is that the test only crashes in 11 since we enabled the #ifdef by accident. It is enabled in 16+, too, but going back all the way to starting development of 16 we don't have a single crash in that code. In 11, it is 100% reproducible. So I assumed there is another part missing that should be backported, too. As release of 11.0.19 is coming up, I first want to undo the change in 11 to avoid the regression. ------------- PR: https://git.openjdk.org/jdk11u/pull/70 From goetz at openjdk.org Mon Mar 20 19:05:10 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 20 Mar 2023 19:05:10 GMT Subject: [jdk11u] RFR: 8304389: [11u] Crash on Windows in C2 compiled code after 8248238 and 8218431 In-Reply-To: References: Message-ID: On Fri, 17 Mar 2023 07:47:44 GMT, Goetz Lindenmaier wrote: > ? 8218431 > > A required fix to avoid regression in 11.0.19. See JBS issue. Actually, the configuration leading to errors exactly implements the calling conventions as speified here https://learn.microsoft.com/en-us/cpp/build/x64-calling-convention?view=msvc-170#callercallee-saved-registers . The other configuration, doing more save-on-call, is always correct, but inefficient in case the registers are also saved-on-entry. In that case the registers are saved twice. This is the configuration established by this change again. ------------- PR Comment: https://git.openjdk.org/jdk11u/pull/70#issuecomment-1476780664 From phh at openjdk.org Mon Mar 20 22:32:57 2023 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 20 Mar 2023 22:32:57 GMT Subject: [jdk17u-dev] RFR: 8278834: Error "Cannot read field "sym" because "this.lvar[od]" is null" when compiling In-Reply-To: <2rJnEjqxO8J0PJR-pqc9ns37tQQZJOL82saXnIY3uQU=.5b29e609-8d6e-4f01-af13-4af2ce6ace6a@github.com> References: <2rJnEjqxO8J0PJR-pqc9ns37tQQZJOL82saXnIY3uQU=.5b29e609-8d6e-4f01-af13-4af2ce6ace6a@github.com> Message-ID: On Wed, 1 Feb 2023 01:11:30 GMT, Glavo wrote: > 8278834: Error "Cannot read field "sym" because "this.lvar[od]" is null" when compiling Re-tagged the JBS issue. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1141#issuecomment-1477028759 From dlong at openjdk.org Tue Mar 21 00:07:48 2023 From: dlong at openjdk.org (Dean Long) Date: Tue, 21 Mar 2023 00:07:48 GMT Subject: [jdk11u] RFR: 8304389: [11u] Crash on Windows in C2 compiled code after 8248238 and 8218431 In-Reply-To: References: Message-ID: <9fIx-I2-gs2XZXaxiaUovA4iy9OF3dBeOc3ZhGFURt8=.f4dbd71c-fba5-46d3-9457-441bb81f8167@github.com> On Fri, 17 Mar 2023 07:47:44 GMT, Goetz Lindenmaier wrote: > ? 8218431 > > A required fix to avoid regression in 11.0.19. See JBS issue. There is probably some x64 code that is assuming Linux ABI for RSI and RDI, so it breaks when trying to use the Windows ABI. And the _WIN64 ABI settings in x86_64.ad may be effectively dead code that was never tested because of the makefile issue that never defined _WIN64 for adlc before. ------------- PR Comment: https://git.openjdk.org/jdk11u/pull/70#issuecomment-1477108733 From dlong at openjdk.org Tue Mar 21 00:23:45 2023 From: dlong at openjdk.org (Dean Long) Date: Tue, 21 Mar 2023 00:23:45 GMT Subject: [jdk11u] RFR: 8304389: [11u] Crash on Windows in C2 compiled code after 8248238 and 8218431 In-Reply-To: References: Message-ID: On Fri, 17 Mar 2023 07:47:44 GMT, Goetz Lindenmaier wrote: > ? 8218431 > > A required fix to avoid regression in 11.0.19. See JBS issue. Nevermind, I think you're right, these _WIN64 ABI settings have been enabled in C2 since jdk16, so it's not clear why there is a problem only in 11u. ------------- PR Comment: https://git.openjdk.org/jdk11u/pull/70#issuecomment-1477121573 From dlong at openjdk.org Tue Mar 21 00:59:48 2023 From: dlong at openjdk.org (Dean Long) Date: Tue, 21 Mar 2023 00:59:48 GMT Subject: [jdk11u] RFR: 8304389: [11u] Crash on Windows in C2 compiled code after 8248238 and 8218431 In-Reply-To: References: Message-ID: On Mon, 20 Mar 2023 19:01:06 GMT, Goetz Lindenmaier wrote: >> ? 8218431 >> >> A required fix to avoid regression in 11.0.19. See JBS issue. > > Actually, the configuration leading to errors exactly implements the calling conventions as speified here https://learn.microsoft.com/en-us/cpp/build/x64-calling-convention?view=msvc-170#callercallee-saved-registers . > > The other configuration, doing more save-on-call, is always correct, but inefficient in case the registers are also saved-on-entry. In that case the registers are saved twice. This is the configuration established by this change again. @GoeLin, after more consideration, your fix does seem safest. However, it might help to have a comment explaining why that change has been disabled. So it might be better to comment out that .gmk logic rather than delete it. ------------- PR Comment: https://git.openjdk.org/jdk11u/pull/70#issuecomment-1477141080 From duke at openjdk.org Tue Mar 21 06:35:39 2023 From: duke at openjdk.org (PoojaDP-23) Date: Tue, 21 Mar 2023 06:35:39 GMT Subject: [jdk11u-dev] RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers [v2] In-Reply-To: References: Message-ID: <_Poe83YbaW6Y1O4f0W4H6b2TIQ57JwunxBuGGy_IekU=.c3a21245-0648-4fa0-84ee-bfef0431c06f@github.com> > This is a backport request and this fix is a dependency for [8293562](https://github.com/openjdk/jdk/commit/03f25a9c6924430ec4063b801b2b6ca55b9067c9). > > This is a fix that upgrades the old HTTP and HTTPS legacy stack to use virtual-thread friendly locking instead of synchronized monitors. > > We have removed @java.io.serial in AuthenticationInfo.java since the serial.class file not located. PoojaDP-23 has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'master' into jdk11-keepalive - address whitespace error Signed-off-by: Pooja.D.P - address compilation error @java.io.Serial Signed-off-by: Pooja.D.P - Backport 65393a093c6a43a0bd8ff9f79c29c3bc5756104f Signed-off-by: Pooja.D.P ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1710/files - new: https://git.openjdk.org/jdk11u-dev/pull/1710/files/822d883f..8084ffc4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1710&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1710&range=00-01 Stats: 18329 lines in 250 files changed: 14986 ins; 1345 del; 1998 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1710.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1710/head:pull/1710 PR: https://git.openjdk.org/jdk11u-dev/pull/1710 From goetz at openjdk.org Tue Mar 21 07:25:49 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 21 Mar 2023 07:25:49 GMT Subject: [jdk11u] RFR: 8304389: [11u] Crash on Windows in C2 compiled code after 8248238 and 8218431 In-Reply-To: References: Message-ID: <9AY81p0XajR-f0Kew2ToallcN24JEpHSwS917v81Qq8=.7cbd9d3d-8ee9-46f2-869a-79e9ff802668@github.com> On Tue, 21 Mar 2023 00:56:41 GMT, Dean Long wrote: >> Actually, the configuration leading to errors exactly implements the calling conventions as speified here https://learn.microsoft.com/en-us/cpp/build/x64-calling-convention?view=msvc-170#callercallee-saved-registers . >> >> The other configuration, doing more save-on-call, is always correct, but inefficient in case the registers are also saved-on-entry. In that case the registers are saved twice. This is the configuration established by this change again. > > @GoeLin, after more consideration, your fix does seem safest. However, it might help to have a comment explaining why that change has been disabled. So it might be better to comment out that .gmk logic rather than delete it. Hi @dean-long, if I comment it out, it is no more set on aarch64. I can add a comment pointing to this bug though. But maybe it is better to fiddle with the ad file as you say. In case a later backport brings new #ifdef _WIN64 coding to the ad files. Currently, the problematic switch is the only occurance. By the way, as I said in the JBS issue, I think the change making the difference in 16 is "[JDK-8256205](https://bugs.openjdk.org/browse/JDK-8256205): Simplify compiler calling convention handling" ------------- PR Comment: https://git.openjdk.org/jdk11u/pull/70#issuecomment-1477378708 From dlong at openjdk.org Tue Mar 21 07:39:57 2023 From: dlong at openjdk.org (Dean Long) Date: Tue, 21 Mar 2023 07:39:57 GMT Subject: [jdk11u] RFR: 8304389: [11u] Crash on Windows in C2 compiled code after 8248238 and 8218431 In-Reply-To: References: Message-ID: On Fri, 17 Mar 2023 07:47:44 GMT, Goetz Lindenmaier wrote: > ? 8218431 > > A required fix to avoid regression in 11.0.19. See JBS issue. Yes, you need _WIN64 set for windows-aarch64 even if you comment out or remove the isTargetCpuBits block. My concern with just changing just the .ad file is there are other uses of #ifdef _WIN64 in x86 .hpp header files that adlc files might include directly or indirectly. To me JDK-8256205 just looks like a refactoring. I don't see how it would change the calling convention. ------------- PR Comment: https://git.openjdk.org/jdk11u/pull/70#issuecomment-1477389338 From goetz at openjdk.org Tue Mar 21 07:51:41 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 21 Mar 2023 07:51:41 GMT Subject: [jdk11u] RFR: 8304389: [11u] Crash on Windows in C2 compiled code after 8248238 and 8218431 [v2] In-Reply-To: References: Message-ID: > ? 8218431 > > A required fix to avoid regression in 11.0.19. See JBS issue. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Move fix to better place. Add comment with bugId ------------- Changes: - all: https://git.openjdk.org/jdk11u/pull/70/files - new: https://git.openjdk.org/jdk11u/pull/70/files/9d16d6f2..fc3c38f8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u&pr=70&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u&pr=70&range=00-01 Stats: 5 lines in 2 files changed: 3 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u/pull/70.diff Fetch: git fetch https://git.openjdk.org/jdk11u.git pull/70/head:pull/70 PR: https://git.openjdk.org/jdk11u/pull/70 From goetz at openjdk.org Tue Mar 21 07:52:48 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 21 Mar 2023 07:52:48 GMT Subject: [jdk11u] RFR: 8304389: [11u] Crash on Windows in C2 compiled code after 8248238 and 8218431 In-Reply-To: References: Message-ID: On Fri, 17 Mar 2023 07:47:44 GMT, Goetz Lindenmaier wrote: > ? 8218431 > > A required fix to avoid regression in 11.0.19. See JBS issue. Hi I pushed a new change. #if 0 is not supported by adlc, therefore #ifdef WRONG > My concern with just changing just the .ad file is there are other uses of #ifdef _WIN64 in x86 .hpp header files that adlc files might include directly or indirectly. adlc reads the ad file, evaluates the _WIN64, swallows it and outputs C++ files without that define. The C++ build compiling the generated files has _WIN64 set anyways, already before the trouble we look at here. ------------- PR Comment: https://git.openjdk.org/jdk11u/pull/70#issuecomment-1477399647 From goetz at openjdk.org Tue Mar 21 08:07:28 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 21 Mar 2023 08:07:28 GMT Subject: [jdk11u] RFR: 8304389: [11u] Crash on Windows in C2 compiled code after 8248238 and 8218431 [v3] In-Reply-To: References: Message-ID: > ? 8218431 > > A required fix to avoid regression in 11.0.19. See JBS issue. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Rename define ------------- Changes: - all: https://git.openjdk.org/jdk11u/pull/70/files - new: https://git.openjdk.org/jdk11u/pull/70/files/fc3c38f8..798a6fb4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u&pr=70&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u&pr=70&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u/pull/70.diff Fetch: git fetch https://git.openjdk.org/jdk11u.git pull/70/head:pull/70 PR: https://git.openjdk.org/jdk11u/pull/70 From dlong at openjdk.org Tue Mar 21 08:07:32 2023 From: dlong at openjdk.org (Dean Long) Date: Tue, 21 Mar 2023 08:07:32 GMT Subject: [jdk11u] RFR: 8304389: [11u] Crash on Windows in C2 compiled code after 8248238 and 8218431 [v2] In-Reply-To: References: Message-ID: On Tue, 21 Mar 2023 07:51:41 GMT, Goetz Lindenmaier wrote: >> ? 8218431 >> >> A required fix to avoid regression in 11.0.19. See JBS issue. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Move fix to better place. Add comment with bugId OK, this looks reasonable. Instead of #ifdef WRONG, how about something like #ifdef DISABLED instead? I suggest filing a separate bug/RFE to investigate the reason for the crash. Finally, please get a 2nd review. ------------- Marked as reviewed by dlong (Committer). PR Review: https://git.openjdk.org/jdk11u/pull/70#pullrequestreview-1349863571 From mbaesken at openjdk.org Tue Mar 21 08:19:55 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 21 Mar 2023 08:19:55 GMT Subject: [jdk17u-dev] Integrated: 8304063: tools/jpackage/share/AppLauncherEnvTest.java fails when checking LD_LIBRARY_PATH In-Reply-To: References: Message-ID: On Mon, 20 Mar 2023 14:34:20 GMT, Matthias Baesken wrote: > 8304063: tools/jpackage/share/AppLauncherEnvTest.java fails when checking LD_LIBRARY_PATH This pull request has now been integrated. Changeset: 15674a93 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/15674a933e74b1c809e5f8e5682719287f7cfbc4 Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod 8304063: tools/jpackage/share/AppLauncherEnvTest.java fails when checking LD_LIBRARY_PATH Backport-of: ebac7eec8e5923c66a80cbd66e79c354f30a07a3 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1210 From duke at openjdk.org Tue Mar 21 10:01:54 2023 From: duke at openjdk.org (Alexey Pavlyutkin) Date: Tue, 21 Mar 2023 10:01:54 GMT Subject: [jdk17u-dev] RFR: 8303861: Error handling step timeouts should never be blocked by OnError and others Message-ID: <730ucoXu-4KUen0gWatw3KopcWrfKaRO2Ie2kxo0vAY=.cfd9e6b0-28f5-4b2d-92f3-60d5d59f4b7c@github.com> Hi, here is backport of JDK-8303861. The patch fixes error reporting timeout processing for the case when a user specifies OnError hook. Before the patch in this case JVM just ignored timeout and therefore WatcherThread could not break malloc() deadlock in error reporting routine. If fact original patch applied without a scratch but there is a little conflict in the baselines, so the backport is not clean. Verification/regression (amd64/LTS20.04): test/hotspot/jtreg/runtime/ErrorHandling (includes updated test) ------------- Commit messages: - Backport a00f5d24d3824e3ab84208401a967efe0e7bf88e Changes: https://git.openjdk.org/jdk17u-dev/pull/1211/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1211&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303861 Stats: 95 lines in 3 files changed: 58 ins; 1 del; 36 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1211.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1211/head:pull/1211 PR: https://git.openjdk.org/jdk17u-dev/pull/1211 From mdoerr at openjdk.org Tue Mar 21 13:31:13 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 21 Mar 2023 13:31:13 GMT Subject: [jdk11u] RFR: 8304389: [11u] Crash on Windows in C2 compiled code after 8248238 and 8218431 [v3] In-Reply-To: References: Message-ID: On Tue, 21 Mar 2023 08:07:28 GMT, Goetz Lindenmaier wrote: >> ? 8218431 >> >> A required fix to avoid regression in 11.0.19. See JBS issue. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Rename define Ok. There seems to be code which clobbers at least RSI in 11u. Having the caller preserve these registers over runtime calls looks like a feasible workaround. I think this is a good fix for the 11u release. I'd use `#if 0` instead of checking for `DISABLED`. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk11u/pull/70#pullrequestreview-1350463777 From goetz at openjdk.org Tue Mar 21 14:19:54 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 21 Mar 2023 14:19:54 GMT Subject: [jdk11u] RFR: 8304389: [11u] Crash on Windows in C2 compiled code after 8248238 and 8218431 [v3] In-Reply-To: References: Message-ID: On Tue, 21 Mar 2023 08:07:28 GMT, Goetz Lindenmaier wrote: >> ? 8218431 >> >> A required fix to avoid regression in 11.0.19. See JBS issue. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Rename define Hi Martin, adlc implements checking #ifdef. It can not parse #if. Therefore, as I stated above, #if 0 is not working. Thanks for your review! ------------- PR Comment: https://git.openjdk.org/jdk11u/pull/70#issuecomment-1477920049 From goetz at openjdk.org Tue Mar 21 14:45:58 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 21 Mar 2023 14:45:58 GMT Subject: [jdk11u] Integrated: 8304389: [11u] Crash on Windows in C2 compiled code after 8248238 and 8218431 In-Reply-To: References: Message-ID: On Fri, 17 Mar 2023 07:47:44 GMT, Goetz Lindenmaier wrote: > ? 8218431 > > A required fix to avoid regression in 11.0.19. See JBS issue. This pull request has now been integrated. Changeset: f1c92b47 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u/commit/f1c92b472d03e3387237cc4d7c6401310cf86f19 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8304389: [11u] Crash on Windows in C2 compiled code after 8248238 and 8218431 Reviewed-by: dlong, mdoerr ------------- PR: https://git.openjdk.org/jdk11u/pull/70 From mdoerr at openjdk.org Tue Mar 21 15:13:49 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 21 Mar 2023 15:13:49 GMT Subject: [jdk11u] RFR: 8304389: [11u] Crash on Windows in C2 compiled code after 8248238 and 8218431 [v3] In-Reply-To: References: Message-ID: On Tue, 21 Mar 2023 08:07:28 GMT, Goetz Lindenmaier wrote: >> ? 8218431 >> >> A required fix to avoid regression in 11.0.19. See JBS issue. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Rename define This fix is also missing in 11u: https://bugs.openjdk.org/browse/JDK-8254252 ------------- PR Comment: https://git.openjdk.org/jdk11u/pull/70#issuecomment-1478013130 From mbaesken at openjdk.org Tue Mar 21 15:31:10 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 21 Mar 2023 15:31:10 GMT Subject: [jdk11u-dev] RFR: 8215575: C2 crash: assert(get_instanceKlass()->is_loaded()) failed: must be at least loaded Message-ID: . ------------- Commit messages: - Backport cab9667f411b363c8b68dc17fc85a397c8c3aeb6 Changes: https://git.openjdk.org/jdk11u-dev/pull/1814/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1814&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8215575 Stats: 20 lines in 3 files changed: 7 ins; 8 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1814.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1814/head:pull/1814 PR: https://git.openjdk.org/jdk11u-dev/pull/1814 From mbaesken at openjdk.org Tue Mar 21 15:53:56 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 21 Mar 2023 15:53:56 GMT Subject: [jdk17u-dev] RFR: 8257856: Make ClassFileVersionsTest.java robust to JDK version updates In-Reply-To: <0cEZ4IOXtgJwHT2pys-ZMtrruPWqDppmydT5nHsVPrQ=.73f17e1f-f99e-492c-a8f8-f82596600988@github.com> References: <0cEZ4IOXtgJwHT2pys-ZMtrruPWqDppmydT5nHsVPrQ=.73f17e1f-f99e-492c-a8f8-f82596600988@github.com> Message-ID: <2nnrtRMSihtBN7wjsf_r5wzBV2lGt1As-_NjQQFSTSY=.b8fdbc9d-c51d-4908-8f95-22afe0acf54e@github.com> On Fri, 17 Mar 2023 20:59:10 GMT, Christoph Langer wrote: > Backport JDK-8257856 for Oracle parity. Test update is not exactly needed in a backport release because no Java version update will occur there. However, it's good to have the same test code base in all releases. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1208#pullrequestreview-1350817857 From goetz at openjdk.org Tue Mar 21 16:04:47 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 21 Mar 2023 16:04:47 GMT Subject: [jdk17u-dev] Integrated: 8292301: [REDO v2] C2 crash when allocating array of size too large In-Reply-To: References: Message-ID: <9g23CJiHMZr7HC775Esxk1u5hvMQUCRdKR-5bCK_P-s=.7655074a-eb4d-4345-8679-e76c2f385a47@github.com> On Thu, 16 Mar 2023 08:16:50 GMT, Goetz Lindenmaier wrote: > I had to resolve three files: > src/hotspot/share/opto/callnode.cpp > AllocateArrayNode::Ideal could not be deleted automatically. > The patch removes igvn->add_input_to(phase->C->root(), halt); > but 11 has phase->C->root()->add_req(halt); > Just deleted anyways. > > src/hotspot/share/opto/loopopts.cpp > In the source, clone_loop() has been refactored. > The patch touches code moved to finish_clone_loop(). > The very same code is in clone_loop() in 17. Moved > hunk there. > > src/hotspot/share/opto/phaseX.cpp > Just placement of a comment. This pull request has now been integrated. Changeset: cc170c7b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/cc170c7b1756ecb42f9540836261b7f7018da5cb Stats: 502 lines in 19 files changed: 394 ins; 67 del; 41 mod 8292301: [REDO v2] C2 crash when allocating array of size too large Reviewed-by: roland, mdoerr Backport-of: 1ea0d6b424c263590fd145913280a180d7ce5fe1 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1204 From rrich at openjdk.org Tue Mar 21 16:16:45 2023 From: rrich at openjdk.org (Richard Reingruber) Date: Tue, 21 Mar 2023 16:16:45 GMT Subject: [jdk11u-dev] RFR: 8215575: C2 crash: assert(get_instanceKlass()->is_loaded()) failed: must be at least loaded In-Reply-To: References: Message-ID: On Tue, 21 Mar 2023 15:22:57 GMT, Matthias Baesken wrote: > . Looks good. Cheers, Richard. ------------- Marked as reviewed by rrich (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1814#pullrequestreview-1350891292 From goetz at openjdk.org Tue Mar 21 19:29:33 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 21 Mar 2023 19:29:33 GMT Subject: [jdk17u-dev] RFR: 8268288: jdk/jfr/api/consumer/streaming/TestOutOfProcessMigration.java fails with "Error: ShouldNotReachHere()" Message-ID: I backport this for parity with 17.0.8-oracle. ------------- Commit messages: - Backport 0a0909263194032ae7d8348484e3638f84090233 Changes: https://git.openjdk.org/jdk17u-dev/pull/1212/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1212&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8268288 Stats: 28 lines in 1 file changed: 11 ins; 11 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1212.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1212/head:pull/1212 PR: https://git.openjdk.org/jdk17u-dev/pull/1212 From phh at openjdk.org Tue Mar 21 21:08:45 2023 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 21 Mar 2023 21:08:45 GMT Subject: [jdk17u-dev] RFR: 8303861: Error handling step timeouts should never be blocked by OnError and others In-Reply-To: <730ucoXu-4KUen0gWatw3KopcWrfKaRO2Ie2kxo0vAY=.cfd9e6b0-28f5-4b2d-92f3-60d5d59f4b7c@github.com> References: <730ucoXu-4KUen0gWatw3KopcWrfKaRO2Ie2kxo0vAY=.cfd9e6b0-28f5-4b2d-92f3-60d5d59f4b7c@github.com> Message-ID: On Tue, 21 Mar 2023 09:53:49 GMT, Alexey Pavlyutkin wrote: > Hi, here is backport of JDK-8303861. The patch fixes error reporting timeout processing for the case when a user specifies OnError hook. Before the patch in this case JVM just ignored timeout and therefore WatcherThread could not break malloc() deadlock in error reporting routine. > > If fact original patch applied without a scratch but there is a little conflict in the baselines, so the backport is not clean. > > Verification/regression (amd64/LTS20.04): test/hotspot/jtreg/runtime/ErrorHandling (includes updated test) Ltgm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1211#pullrequestreview-1351383311 From kvn at openjdk.org Tue Mar 21 21:54:05 2023 From: kvn at openjdk.org (Vladimir Kozlov) Date: Tue, 21 Mar 2023 21:54:05 GMT Subject: [jdk20u] RFR: 8302976: C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter Message-ID: Backport [JDK-8302976](https://bugs.openjdk.org/browse/JDK-8302976) "C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter". Backport did not apply cleanly because of `NULL` to `nullptr` changes in JDK 21. And because these intrinsics were implemented for RISC-V port only in JDK 21 and I have to exclude corresponding changes from backport. The fix was pushed into JDK 21 two weeks ago. No issues were found since then. ------------- Commit messages: - Backport 8cfd74f76afc9e5d50c52104fef9974784718dd4 Changes: https://git.openjdk.org/jdk20u/pull/21/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=21&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8302976 Stats: 1358 lines in 43 files changed: 1213 ins; 104 del; 41 mod Patch: https://git.openjdk.org/jdk20u/pull/21.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/21/head:pull/21 PR: https://git.openjdk.org/jdk20u/pull/21 From kvn at openjdk.org Tue Mar 21 22:01:47 2023 From: kvn at openjdk.org (Vladimir Kozlov) Date: Tue, 21 Mar 2023 22:01:47 GMT Subject: [jdk20u] RFR: 8302976: C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter In-Reply-To: References: Message-ID: On Tue, 21 Mar 2023 21:46:36 GMT, Vladimir Kozlov wrote: > Backport [JDK-8302976](https://bugs.openjdk.org/browse/JDK-8302976) "C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter". > > Backport did not apply cleanly because of `NULL` to `nullptr` changes in JDK 21. And because these intrinsics were implemented for RISC-V port only in JDK 21 and I have to exclude corresponding changes from backport. > > The fix was pushed into JDK 21 two weeks ago. No issues were found since then. @iwanowww, @jatin-bhateja, @sviswa7 please review this backport. Changes: removed RISC-V changes and resolved merge conflicts without changes to new code (surrounding code uses `nullptr` in JDK 21 vs `NULL` in JDK 20u). ------------- PR Comment: https://git.openjdk.org/jdk20u/pull/21#issuecomment-1478643569 From mbaesken at openjdk.org Wed Mar 22 08:23:54 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 22 Mar 2023 08:23:54 GMT Subject: [jdk11u-dev] RFR: 8215575: C2 crash: assert(get_instanceKlass()->is_loaded()) failed: must be at least loaded In-Reply-To: References: Message-ID: On Tue, 21 Mar 2023 15:22:57 GMT, Matthias Baesken wrote: > . Hi Richard, thanks for the review ! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1814#issuecomment-1479089553 From goetz at openjdk.org Wed Mar 22 08:21:07 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 22 Mar 2023 08:21:07 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master Message-ID: Merge build tag 11.0.19+6 from jdk11u to jdk11u-dev ------------- Commit messages: - Merge - 8304389: [11u] Crash on Windows in C2 compiled code after 8248238 and 8218431 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk11u-dev/pull/1816/files Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1816.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1816/head:pull/1816 PR: https://git.openjdk.org/jdk11u-dev/pull/1816 From goetz at openjdk.org Wed Mar 22 08:36:43 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 22 Mar 2023 08:36:43 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master [v2] In-Reply-To: References: Message-ID: <6x1TY5tjOXt-6NZTN2Bgd-G9h84n-ZXSN2SB3UgJxvI=.f603304b-d2c8-4b5b-8b78-efaa52ea2003@github.com> > Merge build tag 11.0.19+6 from jdk11u to jdk11u-dev Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revision: - Merge - 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message Reviewed-by: mchung, phh Backport-of: 9f9d678591e02ecaeae7b81eeefb0ba41c7b4dae - 8232853: AuthenticationFilter.Cache::remove may throw ConcurrentModificationException Change implementation to use iterator instead of plain LinkedList Reviewed-by: phh Backport-of: d948bfd58406cb9b73c6fc4c50728647a5cdf6b5 - 8265486: ProblemList javax/sound/midi/Sequencer/Recording.java on macosx-aarch64 Reviewed-by: phh Backport-of: ab2240741cfc7d10f012c1d588a92cf6f94e1de6 - 8294548: Problem list SA core file tests on macosx-x64 due to JDK-8294316 Reviewed-by: mbaesken Backport-of: 545ded1a82baf62ef551b2be2a08ee29ab5d9311 - 8263420: Incorrect function name in NSAccessibilityStaticText native peer implementation Backport-of: d896246a117a929b2d34463168095497c95ee601 - 8264304: Create implementation for NSAccessibilityToolbar protocol peer Reviewed-by: phh Backport-of: 4d26f22b9adcf7cecca5316348ef670ac2dbc365 - 8264290: Create implementation for NSAccessibilityComponentGroup protocol peer Reviewed-by: phh Backport-of: f07dcf471c160e09fbc748124998923e7d453e66 - 8220093: Change to GCC 8.2 for building on Linux at Oracle Reviewed-by: mbaesken Backport-of: 290bfe5f4c912eae745e2a6a346d019ebe74b342 - 8303937: Corrupted heap dumps due to missing retries for os::write() Reviewed-by: clanger Backport-of: bf16b5b9880eb89b283006db090dce4346aa877b - ... and 7 more: https://git.openjdk.org/jdk11u-dev/compare/7993e792...e0f2e70c ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1816/files - new: https://git.openjdk.org/jdk11u-dev/pull/1816/files/e0f2e70c..e0f2e70c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1816&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1816&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1816.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1816/head:pull/1816 PR: https://git.openjdk.org/jdk11u-dev/pull/1816 From goetz at openjdk.org Wed Mar 22 08:36:46 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 22 Mar 2023 08:36:46 GMT Subject: [jdk11u-dev] Integrated: Merge jdk11u:master In-Reply-To: References: Message-ID: On Wed, 22 Mar 2023 08:12:31 GMT, Goetz Lindenmaier wrote: > Merge build tag 11.0.19+6 from jdk11u to jdk11u-dev This pull request has now been integrated. Changeset: ab51b151 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/ab51b151a0d34f47eaa24ccf86743ea66dfbd599 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Merge ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1816 From stuefe at openjdk.org Wed Mar 22 11:19:55 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 22 Mar 2023 11:19:55 GMT Subject: [jdk17u-dev] RFR: 8303861: Error handling step timeouts should never be blocked by OnError and others In-Reply-To: <730ucoXu-4KUen0gWatw3KopcWrfKaRO2Ie2kxo0vAY=.cfd9e6b0-28f5-4b2d-92f3-60d5d59f4b7c@github.com> References: <730ucoXu-4KUen0gWatw3KopcWrfKaRO2Ie2kxo0vAY=.cfd9e6b0-28f5-4b2d-92f3-60d5d59f4b7c@github.com> Message-ID: On Tue, 21 Mar 2023 09:53:49 GMT, Alexey Pavlyutkin wrote: > Hi, here is backport of JDK-8303861. The patch fixes error reporting timeout processing for the case when a user specifies OnError hook. Before the patch in this case JVM just ignored timeout and therefore WatcherThread could not break malloc() deadlock in error reporting routine. > > If fact original patch applied without a scratch but there is a little conflict in the baselines, so the backport is not clean. > > Verification/regression (amd64/LTS20.04): test/hotspot/jtreg/runtime/ErrorHandling (includes updated test) LGTM ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1211#pullrequestreview-1352324900 From clanger at openjdk.org Wed Mar 22 11:45:57 2023 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 22 Mar 2023 11:45:57 GMT Subject: [jdk17u-dev] RFR: 8303575: adjust Xen handling on Linux aarch64 In-Reply-To: References: Message-ID: On Fri, 17 Mar 2023 09:18:19 GMT, Matthias Baesken wrote: > . Marked as reviewed by clanger (Reviewer). Looks correct. ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1207#pullrequestreview-1352362672 PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1207#issuecomment-1479407352 From mbaesken at openjdk.org Wed Mar 22 11:56:49 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 22 Mar 2023 11:56:49 GMT Subject: [jdk17u-dev] RFR: 8303575: adjust Xen handling on Linux aarch64 In-Reply-To: References: Message-ID: On Fri, 17 Mar 2023 09:18:19 GMT, Matthias Baesken wrote: > . Hi Christoph, thanks for the review ! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1207#issuecomment-1479418949 From mbaesken at openjdk.org Wed Mar 22 12:42:42 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 22 Mar 2023 12:42:42 GMT Subject: [jdk17u-dev] RFR: 8300042: Improve CPU related JFR events descriptions Message-ID: <8Lept_4Ft1NyRKm51I0hCVXXQWcCerK32qJDZRmDG3k=.3bcbe82b-a7de-45d9-b768-99cba9bba847@github.com> 8300042: Improve CPU related JFR events descriptions ------------- Commit messages: - Backport e326b86d37cec3b395b88598cf30ce4239732a15 Changes: https://git.openjdk.org/jdk17u-dev/pull/1214/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1214&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8300042 Stats: 9 lines in 1 file changed: 6 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1214.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1214/head:pull/1214 PR: https://git.openjdk.org/jdk17u-dev/pull/1214 From mbaesken at openjdk.org Wed Mar 22 13:12:53 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 22 Mar 2023 13:12:53 GMT Subject: [jdk17u-dev] Integrated: 8303576: addIdentitiesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return In-Reply-To: References: Message-ID: <-qn-dtcz7nHodSSbjJ5O3k2Dk6cG6t-PonJqeTCmB4U=.8a2237ab-0416-45b0-bb23-83b5c5ccd7d5@github.com> On Thu, 16 Mar 2023 12:16:26 GMT, Matthias Baesken wrote: > 8303576: addIdentitiesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return This pull request has now been integrated. Changeset: 3b64bdea Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/3b64bdeaba38beee93e240d9b3f236dd160e4425 Stats: 7 lines in 1 file changed: 5 ins; 0 del; 2 mod 8303576: addIdentitiesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return Backport-of: a7e308ab6e5dba7df790840d29fc7edbf3af2e24 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1205 From mbaesken at openjdk.org Wed Mar 22 14:33:59 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 22 Mar 2023 14:33:59 GMT Subject: [jdk11u-dev] RFR: 8301170: perfMemory_windows.cpp add free_security_attr to early returns In-Reply-To: References: Message-ID: On Mon, 20 Mar 2023 14:23:59 GMT, Matthias Baesken wrote: > . Except COPYRIGHT year info it is a clean backport. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1813#issuecomment-1479672851 From iris.clark at oracle.com Wed Mar 22 16:31:49 2023 From: iris.clark at oracle.com (Iris Clark) Date: Wed, 22 Mar 2023 16:31:49 +0000 Subject: JSR 337 (Java SE 8) MR 5 and JSR 384 (Java SE 11) MR 2 posted to jcp.org Message-ID: Maintenance Review 5 of JSR 337 and Maintenance Review 2 of JSR 384 which include changes to support GB 18030-2022 [0,1] have been posted to jcp.org: https://jcp.org/en/jsr/detail?id=337 https://jcp.org/en/jsr/detail?id=384 The review periods end 19 Apr and the ballots begin shortly thereafter. Thanks, Iris [0]:?https://mail.openjdk.org/pipermail/jdk8u-dev/2023-February/016710.html [1]: https://mail.openjdk.org/pipermail/jdk-updates-dev/2023-February/020724.html From thartmann at openjdk.org Wed Mar 22 17:55:47 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 22 Mar 2023 17:55:47 GMT Subject: [jdk20u] RFR: 8302976: C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter In-Reply-To: References: Message-ID: <-gqQAc37v2kpZwbV213JPj2zxO8UYDre3LbVh4fWDLQ=.49a160a1-6ddd-40fb-8000-c4f0dc306edd@github.com> On Tue, 21 Mar 2023 21:46:36 GMT, Vladimir Kozlov wrote: > Backport [JDK-8302976](https://bugs.openjdk.org/browse/JDK-8302976) "C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter". > > Backport did not apply cleanly because of `NULL` to `nullptr` changes in JDK 21. And because these intrinsics were implemented for RISC-V port only in JDK 21 and I have to exclude corresponding changes from backport. > > The fix was pushed into JDK 21 two weeks ago. No issues were found since then. Looks good. ------------- Marked as reviewed by thartmann (Reviewer). PR Review: https://git.openjdk.org/jdk20u/pull/21#pullrequestreview-1353181773 From vlivanov at openjdk.org Wed Mar 22 17:52:01 2023 From: vlivanov at openjdk.org (Vladimir Ivanov) Date: Wed, 22 Mar 2023 17:52:01 GMT Subject: [jdk20u] RFR: 8302976: C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter In-Reply-To: References: Message-ID: On Tue, 21 Mar 2023 21:46:36 GMT, Vladimir Kozlov wrote: > Backport [JDK-8302976](https://bugs.openjdk.org/browse/JDK-8302976) "C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter". > > Backport did not apply cleanly because of `NULL` to `nullptr` changes in JDK 21. And because these intrinsics were implemented for RISC-V port only in JDK 21 and I have to exclude corresponding changes from backport. > > The fix was pushed into JDK 21 two weeks ago. No issues were found since then. Looks good. ------------- Marked as reviewed by vlivanov (Reviewer). PR Review: https://git.openjdk.org/jdk20u/pull/21#pullrequestreview-1353176100 From kvn at openjdk.org Wed Mar 22 18:10:30 2023 From: kvn at openjdk.org (Vladimir Kozlov) Date: Wed, 22 Mar 2023 18:10:30 GMT Subject: [jdk20u] RFR: 8302976: C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter In-Reply-To: References: Message-ID: <9me0o-xKyy94YxWAYGgRMOmYQPDfaHzbizvEylyMXkY=.3f3d8749-b398-4a13-a1ac-79e5747c32e0@github.com> On Tue, 21 Mar 2023 21:46:36 GMT, Vladimir Kozlov wrote: > Backport [JDK-8302976](https://bugs.openjdk.org/browse/JDK-8302976) "C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter". > > Backport did not apply cleanly because of `NULL` to `nullptr` changes in JDK 21. And because these intrinsics were implemented for RISC-V port only in JDK 21 and I have to exclude corresponding changes from backport. > > The fix was pushed into JDK 21 two weeks ago. No issues were found since then. Thank you, Vladimir and Tobias. ------------- PR Comment: https://git.openjdk.org/jdk20u/pull/21#issuecomment-1480035108 From kvn at openjdk.org Wed Mar 22 18:15:03 2023 From: kvn at openjdk.org (Vladimir Kozlov) Date: Wed, 22 Mar 2023 18:15:03 GMT Subject: [jdk20u] Integrated: 8302976: C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter In-Reply-To: References: Message-ID: On Tue, 21 Mar 2023 21:46:36 GMT, Vladimir Kozlov wrote: > Backport [JDK-8302976](https://bugs.openjdk.org/browse/JDK-8302976) "C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter". > > Backport did not apply cleanly because of `NULL` to `nullptr` changes in JDK 21. And because these intrinsics were implemented for RISC-V port only in JDK 21 and I have to exclude corresponding changes from backport. > > The fix was pushed into JDK 21 two weeks ago. No issues were found since then. This pull request has now been integrated. Changeset: 59a3f4f4 Author: Vladimir Kozlov URL: https://git.openjdk.org/jdk20u/commit/59a3f4f4b19f8ebaf7ef6d59a15846acbb225e36 Stats: 1358 lines in 43 files changed: 1213 ins; 104 del; 41 mod 8302976: C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter Reviewed-by: vlivanov, thartmann Backport-of: 8cfd74f76afc9e5d50c52104fef9974784718dd4 ------------- PR: https://git.openjdk.org/jdk20u/pull/21 From serb at openjdk.org Wed Mar 22 22:03:46 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 22 Mar 2023 22:03:46 GMT Subject: [jdk20u] RFR: 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError Message-ID: Hi all, This pull request contains a backport of commit [78b1686c](https://github.com/openjdk/jdk/commit/78b1686c150aeaa29c5d969b70c9c42c872246a2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 12 Jan 2023 and was reviewed by Alexey Ivanov and Tejesh R. Thanks! ------------- Commit messages: - Backport 78b1686c150aeaa29c5d969b70c9c42c872246a2 Changes: https://git.openjdk.org/jdk20u/pull/22/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=22&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8227257 Stats: 88 lines in 4 files changed: 82 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk20u/pull/22.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/22/head:pull/22 PR: https://git.openjdk.org/jdk20u/pull/22 From duke at openjdk.org Thu Mar 23 06:47:58 2023 From: duke at openjdk.org (PoojaDP-23) Date: Thu, 23 Mar 2023 06:47:58 GMT Subject: [jdk11u-dev] RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers In-Reply-To: References: Message-ID: On Sun, 5 Mar 2023 21:22:03 GMT, Christoph Langer wrote: >>> @robilad - Earlier Workflows aren't being run on this forked repository because it was not enabled. Now I have enabled the workflow but still tests are not running on my fork. Could you please let me know what action needs to be done by myside? Thanks >> >> Hi @PoojaDP-23, >> I guess the easiest way to get current GHA checks is to merge your branch with current master of [jdk11u-dev](https://github.com/openjdk/jdk11u-dev) and push it. This will trigger a run with the most current code. > >> @RealCLanger - Could you please review the backport PR? > > I can have a look. But please do a merge with master before and by that, trigger GHA. Thanks. @RealCLanger - Could you please review the PR? because customer dependent on this fix. Thanks ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1710#issuecomment-1480677612 From serb at openjdk.org Thu Mar 23 07:02:52 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 23 Mar 2023 07:02:52 GMT Subject: [jdk17u-dev] RFR: 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError Message-ID: <5j0GJu25foD_HhIKQ6kqCMEtxEuYqWsun58lgvrtsvg=.2aeb5d32-3706-45e0-9764-82732da35df3@github.com> Hi all, This pull request contains a backport of commit [78b1686c](https://github.com/openjdk/jdk/commit/78b1686c150aeaa29c5d969b70c9c42c872246a2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 12 Jan 2023 and was reviewed by Alexey Ivanov and Tejesh R. Thanks! ------------- Commit messages: - Backport 78b1686c150aeaa29c5d969b70c9c42c872246a2 Changes: https://git.openjdk.org/jdk17u-dev/pull/1213/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1213&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8227257 Stats: 88 lines in 4 files changed: 82 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1213.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1213/head:pull/1213 PR: https://git.openjdk.org/jdk17u-dev/pull/1213 From goetz at openjdk.org Thu Mar 23 08:01:02 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 23 Mar 2023 08:01:02 GMT Subject: [jdk17u-dev] RFR: 8278834: Error "Cannot read field "sym" because "this.lvar[od]" is null" when compiling In-Reply-To: References: <2rJnEjqxO8J0PJR-pqc9ns37tQQZJOL82saXnIY3uQU=.5b29e609-8d6e-4f01-af13-4af2ce6ace6a@github.com> Message-ID: On Wed, 1 Feb 2023 23:20:30 GMT, Glavo wrote: >> Thank you for the info. The langtools tier1 tests would be the right ones to use. These are run as part of pre-submit testing, which should be configured on your repo (click on "Details" on the left of Pre-submit test status". Also, did the backport fix the crash? I assume it did, but that needs to be stated. I've tagged the JBS issue on your behalf. > >> Thank you for the info. The langtools tier1 tests would be the right ones to use. These are run as part of pre-submit testing, which should be configured on your repo (click on "Details" on the left of Pre-submit test status". Also, did the backport fix the crash? I assume it did, but that needs to be stated. I've tagged the JBS issue on your behalf. > > I ran and passed the pre-submit test. @Glavo, can you please merge head so that thye pre submit tests run? Click on you branch at the top, then on "Sync fork". ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1141#issuecomment-1480741042 From goetz at openjdk.org Thu Mar 23 08:04:50 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 23 Mar 2023 08:04:50 GMT Subject: [jdk17u-dev] RFR: 8303822: gtestMain should give more helpful output In-Reply-To: References: Message-ID: On Mon, 20 Mar 2023 13:34:12 GMT, Matthias Baesken wrote: > . What is wrong with the Pre-submit tests? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1209#issuecomment-1480745721 From duke at openjdk.org Thu Mar 23 08:30:21 2023 From: duke at openjdk.org (Glavo) Date: Thu, 23 Mar 2023 08:30:21 GMT Subject: [jdk17u-dev] RFR: 8278834: Error "Cannot read field "sym" because "this.lvar[od]" is null" when compiling [v2] In-Reply-To: <2rJnEjqxO8J0PJR-pqc9ns37tQQZJOL82saXnIY3uQU=.5b29e609-8d6e-4f01-af13-4af2ce6ace6a@github.com> References: <2rJnEjqxO8J0PJR-pqc9ns37tQQZJOL82saXnIY3uQU=.5b29e609-8d6e-4f01-af13-4af2ce6ace6a@github.com> Message-ID: > 8278834: Error "Cannot read field "sym" because "this.lvar[od]" is null" when compiling Glavo has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into JDK-8278834 - Backport be0538d7c8e2cbfa599dbcb4c5c69533678a8421 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1141/files - new: https://git.openjdk.org/jdk17u-dev/pull/1141/files/07e9fe40..2dd0fa2b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1141&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1141&range=00-01 Stats: 11883 lines in 292 files changed: 9184 ins; 826 del; 1873 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1141.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1141/head:pull/1141 PR: https://git.openjdk.org/jdk17u-dev/pull/1141 From duke at openjdk.org Thu Mar 23 08:30:21 2023 From: duke at openjdk.org (Glavo) Date: Thu, 23 Mar 2023 08:30:21 GMT Subject: [jdk17u-dev] RFR: 8278834: Error "Cannot read field "sym" because "this.lvar[od]" is null" when compiling In-Reply-To: References: <2rJnEjqxO8J0PJR-pqc9ns37tQQZJOL82saXnIY3uQU=.5b29e609-8d6e-4f01-af13-4af2ce6ace6a@github.com> Message-ID: On Wed, 1 Feb 2023 23:20:30 GMT, Glavo wrote: >> Thank you for the info. The langtools tier1 tests would be the right ones to use. These are run as part of pre-submit testing, which should be configured on your repo (click on "Details" on the left of Pre-submit test status". Also, did the backport fix the crash? I assume it did, but that needs to be stated. I've tagged the JBS issue on your behalf. > >> Thank you for the info. The langtools tier1 tests would be the right ones to use. These are run as part of pre-submit testing, which should be configured on your repo (click on "Details" on the left of Pre-submit test status". Also, did the backport fix the crash? I assume it did, but that needs to be stated. I've tagged the JBS issue on your behalf. > > I ran and passed the pre-submit test. > @Glavo, can you please merge head so that thye pre submit tests run? Click on you branch at the top, then on "Sync fork". Okay. I've been busy with some other things lately, so didn't work on this PR. I'll run the tests later. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1141#issuecomment-1480770894 From mbaesken at openjdk.org Thu Mar 23 08:36:50 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 23 Mar 2023 08:36:50 GMT Subject: [jdk17u-dev] RFR: 8303822: gtestMain should give more helpful output In-Reply-To: References: Message-ID: On Thu, 23 Mar 2023 08:01:57 GMT, Goetz Lindenmaier wrote: > What is wrong with the Pre-submit tests? some sysroot stuff for linux s390 cross compile failed. In general, it is "wrong" with those tests that they are unstable/unreliable and overloaded. Not very usable recently (because of tons of such false positives ). ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1209#issuecomment-1480780170 From mbaesken at openjdk.org Thu Mar 23 08:41:58 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 23 Mar 2023 08:41:58 GMT Subject: [jdk11u-dev] Integrated: 8300205: Swing test bug8078268 make latch timeout configurable In-Reply-To: References: Message-ID: On Mon, 20 Mar 2023 13:55:02 GMT, Matthias Baesken wrote: > 8300205: Swing test bug8078268 make latch timeout configurable This pull request has now been integrated. Changeset: 1516012e Author: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/1516012ebcdffe7a3ce5c0465008d6045d5b6d68 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod 8300205: Swing test bug8078268 make latch timeout configurable Backport-of: e82dc6935b5f575a53fcba9c96767cee1b535cb8 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1812 From mbaesken at openjdk.org Thu Mar 23 08:51:51 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 23 Mar 2023 08:51:51 GMT Subject: [jdk17u-dev] Integrated: 8300042: Improve CPU related JFR events descriptions In-Reply-To: <8Lept_4Ft1NyRKm51I0hCVXXQWcCerK32qJDZRmDG3k=.3bcbe82b-a7de-45d9-b768-99cba9bba847@github.com> References: <8Lept_4Ft1NyRKm51I0hCVXXQWcCerK32qJDZRmDG3k=.3bcbe82b-a7de-45d9-b768-99cba9bba847@github.com> Message-ID: On Wed, 22 Mar 2023 12:35:31 GMT, Matthias Baesken wrote: > 8300042: Improve CPU related JFR events descriptions This pull request has now been integrated. Changeset: 8a2425d3 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/8a2425d35d215fc7b17f0d05f003d9bc5dc9c04c Stats: 9 lines in 1 file changed: 6 ins; 0 del; 3 mod 8300042: Improve CPU related JFR events descriptions Backport-of: e326b86d37cec3b395b88598cf30ce4239732a15 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1214 From mbaesken at openjdk.org Thu Mar 23 09:01:48 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 23 Mar 2023 09:01:48 GMT Subject: [jdk17u-dev] Integrated: 8303575: adjust Xen handling on Linux aarch64 In-Reply-To: References: Message-ID: On Fri, 17 Mar 2023 09:18:19 GMT, Matthias Baesken wrote: > . This pull request has now been integrated. Changeset: 04e337cd Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/04e337cdb9dad721dc6f126f99378f7073fffb55 Stats: 13 lines in 3 files changed: 5 ins; 0 del; 8 mod 8303575: adjust Xen handling on Linux aarch64 Reviewed-by: clanger Backport-of: 8eaf84f09476b08ed421efe74d7554e2b29bc5a7 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1207 From mbaesken at openjdk.org Thu Mar 23 08:56:55 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 23 Mar 2023 08:56:55 GMT Subject: [jdk11u-dev] Integrated: 8215575: C2 crash: assert(get_instanceKlass()->is_loaded()) failed: must be at least loaded In-Reply-To: References: Message-ID: <-vjcxlgfN8kqQd1vtIPNvs7WEgGv60JEHq8uDUeFr1M=.df83825c-b4fe-4a1a-a420-0b5a0a373fb9@github.com> On Tue, 21 Mar 2023 15:22:57 GMT, Matthias Baesken wrote: > . This pull request has now been integrated. Changeset: 386addf9 Author: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/386addf9054029fd37301736438dfa7ce4b43d9d Stats: 20 lines in 3 files changed: 7 ins; 8 del; 5 mod 8215575: C2 crash: assert(get_instanceKlass()->is_loaded()) failed: must be at least loaded Set InstanceKlass::loaded before adding classes to the subklass list, which can be read concurrently by the compiler. Reviewed-by: rrich Backport-of: cab9667f411b363c8b68dc17fc85a397c8c3aeb6 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1814 From clanger at openjdk.org Thu Mar 23 09:28:56 2023 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 23 Mar 2023 09:28:56 GMT Subject: [jdk11u-dev] RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers In-Reply-To: References: Message-ID: On Thu, 23 Mar 2023 06:45:30 GMT, PoojaDP-23 wrote: >>> @RealCLanger - Could you please review the backport PR? >> >> I can have a look. But please do a merge with master before and by that, trigger GHA. Thanks. > > @RealCLanger - Could you please review the PR? Thanks Hi @PoojaDP-23, when looking at the scope of this backport and its successor, [JDK-8293562](https://github.com/openjdk/jdk/commit/03f25a9c6924430ec4063b801b2b6ca55b9067c9), which I've understood is what you actually want to fix, I'm a bit concerned whether this is appropriate as a backport to JDK11. After all, it completely reworks the locking in the HTTP client and we can't be sure what side effects this might cause in other productive usages. It might even unveil issues that have not been discovered in head. So, could you go back and give some more explanation what kind of bug you want to fix in 11u? Maybe we can find a less intrusive fix that could also differ from OpenJDK upstream? Maybe JDK-8293562 can be adapted for 11u without this one? Thanks Christoph ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1710#issuecomment-1480856360 From mbaesken at openjdk.org Thu Mar 23 09:47:27 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 23 Mar 2023 09:47:27 GMT Subject: [jdk20u] RFR: 8304671: javac regression: Compilation with --release 8 fails on underscore in enum identifiers Message-ID: 8304671: javac regression: Compilation with --release 8 fails on underscore in enum identifiers ------------- Commit messages: - Backport 63d4afbeb17df4eff0f65041926373ee62a8a33a Changes: https://git.openjdk.org/jdk20u/pull/23/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=23&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304671 Stats: 190 lines in 2 files changed: 181 ins; 2 del; 7 mod Patch: https://git.openjdk.org/jdk20u/pull/23.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/23/head:pull/23 PR: https://git.openjdk.org/jdk20u/pull/23 From phh at openjdk.org Thu Mar 23 23:44:43 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 23 Mar 2023 23:44:43 GMT Subject: [jdk17u-dev] RFR: 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError In-Reply-To: <5j0GJu25foD_HhIKQ6kqCMEtxEuYqWsun58lgvrtsvg=.2aeb5d32-3706-45e0-9764-82732da35df3@github.com> References: <5j0GJu25foD_HhIKQ6kqCMEtxEuYqWsun58lgvrtsvg=.2aeb5d32-3706-45e0-9764-82732da35df3@github.com> Message-ID: On Tue, 21 Mar 2023 22:30:54 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [78b1686c](https://github.com/openjdk/jdk/commit/78b1686c150aeaa29c5d969b70c9c42c872246a2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 12 Jan 2023 and was reviewed by Alexey Ivanov and Tejesh R. > Thanks! Looks clean except for copyright date conflict in Win32ShellFolder2.java. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1213#pullrequestreview-1355811301 From myano at openjdk.org Fri Mar 24 06:56:39 2023 From: myano at openjdk.org (Masanori Yano) Date: Fri, 24 Mar 2023 06:56:39 GMT Subject: [jdk11u-dev] RFR: 8213531: Test javax/swing/border/TestTitledBorderLeak.java fails Message-ID: Hi, This is a backport of JDK-8213531: Test javax/swing/border/TestTitledBorderLeak.java fails. Original patch does not apply cleanly to jdk11u, because there is no line of TestTitledBorderLeak.java in ProblemList.txt of jdk11u. So I fixed only TestTitledBorderLeak.java. Testing: I tested manually on RHEL7, and tier1. ------------- Commit messages: - Backport 07d24509a68cc06f062b8249f207bc0d2148c79b Changes: https://git.openjdk.org/jdk11u-dev/pull/1817/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1817&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8213531 Stats: 88 lines in 1 file changed: 16 ins; 60 del; 12 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1817.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1817/head:pull/1817 PR: https://git.openjdk.org/jdk11u-dev/pull/1817 From serb at openjdk.org Fri Mar 24 07:14:52 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 24 Mar 2023 07:14:52 GMT Subject: [jdk11u-dev] RFR: 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError Message-ID: Hi all, This pull request contains a backport of commit [78b1686c](https://github.com/openjdk/jdk/commit/78b1686c150aeaa29c5d969b70c9c42c872246a2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 12 Jan 2023 and was reviewed by Alexey Ivanov and Tejesh R. Thanks! ------------- Commit messages: - Backport 78b1686c150aeaa29c5d969b70c9c42c872246a2 Changes: https://git.openjdk.org/jdk11u-dev/pull/1815/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1815&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8227257 Stats: 88 lines in 4 files changed: 82 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1815.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1815/head:pull/1815 PR: https://git.openjdk.org/jdk11u-dev/pull/1815 From serb at openjdk.org Fri Mar 24 07:15:45 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 24 Mar 2023 07:15:45 GMT Subject: [jdk11u-dev] RFR: 8213531: Test javax/swing/border/TestTitledBorderLeak.java fails In-Reply-To: References: Message-ID: On Fri, 24 Mar 2023 06:48:11 GMT, Masanori Yano wrote: > Hi, > > This is a backport of JDK-8213531: Test javax/swing/border/TestTitledBorderLeak.java fails. > > Original patch does not apply cleanly to jdk11u, because there is no line of TestTitledBorderLeak.java in ProblemList.txt of jdk11u. So I fixed only TestTitledBorderLeak.java. > > Testing: I tested manually on RHEL7, and tier1. What fix added that line to the problem list? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1817#issuecomment-1482355537 From myano at openjdk.org Fri Mar 24 09:01:37 2023 From: myano at openjdk.org (Masanori Yano) Date: Fri, 24 Mar 2023 09:01:37 GMT Subject: [jdk11u-dev] RFR: 8213531: Test javax/swing/border/TestTitledBorderLeak.java fails In-Reply-To: References: Message-ID: <_HZ_Y9jvZvqmsMdMvn6XQgONbJmSjvOYyoSsPFbMX-o=.6a4d04d7-559e-421a-8779-31c67e869448@github.com> On Fri, 24 Mar 2023 07:13:04 GMT, Sergey Bylokhov wrote: >> Hi, >> >> This is a backport of JDK-8213531: Test javax/swing/border/TestTitledBorderLeak.java fails. >> >> Original patch does not apply cleanly to jdk11u, because there is no line of TestTitledBorderLeak.java in ProblemList.txt of jdk11u. So I fixed only TestTitledBorderLeak.java. >> >> Testing: I tested manually on RHEL7, and tier1. > > What fix added that line to the problem list? @mrserb The line of TestTitledBorderLeak is added to the problem list at JDK-8213536. https://github.com/openjdk/jdk/commit/8ed1c25f6b8891e7dcee17164f5f2ce4fff763d3 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1817#issuecomment-1482460853 From mbaesken at openjdk.org Fri Mar 24 10:14:00 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 24 Mar 2023 10:14:00 GMT Subject: [jdk17u-dev] RFR: 8268288: jdk/jfr/api/consumer/streaming/TestOutOfProcessMigration.java fails with "Error: ShouldNotReachHere()" In-Reply-To: References: Message-ID: On Tue, 21 Mar 2023 19:22:53 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. LGTM ------------- Marked as reviewed by mbaesken (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1212#pullrequestreview-1356379943 From mbaesken at openjdk.org Fri Mar 24 11:20:57 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 24 Mar 2023 11:20:57 GMT Subject: [jdk11u-dev] Integrated: 8301170: perfMemory_windows.cpp add free_security_attr to early returns In-Reply-To: References: Message-ID: On Mon, 20 Mar 2023 14:23:59 GMT, Matthias Baesken wrote: > . This pull request has now been integrated. Changeset: 75fb8a99 Author: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/75fb8a99d66134698de29a902cd07aaaaca3575a Stats: 11 lines in 1 file changed: 5 ins; 4 del; 2 mod 8301170: perfMemory_windows.cpp add free_security_attr to early returns Backport-of: 3330f9c2ad508fdb9100a2400abdd3366342dde1 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1813 From mbaesken at openjdk.org Fri Mar 24 13:16:43 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 24 Mar 2023 13:16:43 GMT Subject: [jdk17u-dev] RFR: 8304671: javac regression: Compilation with --release 8 fails on underscore in enum identifiers Message-ID: backport of 8304671 ------------- Commit messages: - Backport 63d4afbeb17df4eff0f65041926373ee62a8a33a Changes: https://git.openjdk.org/jdk17u-dev/pull/1216/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1216&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304671 Stats: 178 lines in 2 files changed: 169 ins; 2 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1216.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1216/head:pull/1216 PR: https://git.openjdk.org/jdk17u-dev/pull/1216 From mbaesken at openjdk.org Fri Mar 24 13:16:44 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 24 Mar 2023 13:16:44 GMT Subject: [jdk17u-dev] RFR: 8304671: javac regression: Compilation with --release 8 fails on underscore in enum identifiers In-Reply-To: References: Message-ID: On Fri, 24 Mar 2023 13:09:09 GMT, Matthias Baesken wrote: > backport of 8304671 src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java copyright needs to be adjusted test/langtools/tools/javac/parser/JavacParserTest.java bug info comment does not fit in, needs to be manually adjusted + - compiler.warn.option.obsolete.source: 8 + - compiler.warn.option.obsolete.target: 8 + - compiler.warn.option.obsolete.suppression those warnings do not show up when compiling with jdk17 javac so they need to be removed from the Test setup ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1216#issuecomment-1482776281 From serb at openjdk.org Fri Mar 24 16:59:24 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 24 Mar 2023 16:59:24 GMT Subject: [jdk20u] Integrated: 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError In-Reply-To: References: Message-ID: <3Wn-7_79Nee75TYODHfBLiWMQt7FbdpWXILzcinfsTo=.c97787ec-db7d-417a-b02b-d50606051584@github.com> On Tue, 21 Mar 2023 22:03:52 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [78b1686c](https://github.com/openjdk/jdk/commit/78b1686c150aeaa29c5d969b70c9c42c872246a2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 12 Jan 2023 and was reviewed by Alexey Ivanov and Tejesh R. > Thanks! This pull request has now been integrated. Changeset: ad97686c Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk20u/commit/ad97686c8f65a2237a63c27827c5c711dafb4629 Stats: 88 lines in 4 files changed: 82 ins; 0 del; 6 mod 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError Backport-of: 78b1686c150aeaa29c5d969b70c9c42c872246a2 ------------- PR: https://git.openjdk.org/jdk20u/pull/22 From serb at openjdk.org Fri Mar 24 17:03:47 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 24 Mar 2023 17:03:47 GMT Subject: [jdk17u-dev] Integrated: 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError In-Reply-To: <5j0GJu25foD_HhIKQ6kqCMEtxEuYqWsun58lgvrtsvg=.2aeb5d32-3706-45e0-9764-82732da35df3@github.com> References: <5j0GJu25foD_HhIKQ6kqCMEtxEuYqWsun58lgvrtsvg=.2aeb5d32-3706-45e0-9764-82732da35df3@github.com> Message-ID: On Tue, 21 Mar 2023 22:30:54 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [78b1686c](https://github.com/openjdk/jdk/commit/78b1686c150aeaa29c5d969b70c9c42c872246a2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 12 Jan 2023 and was reviewed by Alexey Ivanov and Tejesh R. > Thanks! This pull request has now been integrated. Changeset: 6d61fc11 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u-dev/commit/6d61fc116f387779e483db58ed7127d4e3f3c6d1 Stats: 88 lines in 4 files changed: 82 ins; 0 del; 6 mod 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError Reviewed-by: phh Backport-of: 78b1686c150aeaa29c5d969b70c9c42c872246a2 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1213 From serb at openjdk.org Fri Mar 24 17:22:38 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 24 Mar 2023 17:22:38 GMT Subject: [jdk11u-dev] Integrated: 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError In-Reply-To: References: Message-ID: On Tue, 21 Mar 2023 22:40:13 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [78b1686c](https://github.com/openjdk/jdk/commit/78b1686c150aeaa29c5d969b70c9c42c872246a2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 12 Jan 2023 and was reviewed by Alexey Ivanov and Tejesh R. > Thanks! This pull request has now been integrated. Changeset: 88434e5c Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk11u-dev/commit/88434e5c7b86d8361e80cc0b63ef4e82d6c83f9a Stats: 88 lines in 4 files changed: 82 ins; 0 del; 6 mod 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError Backport-of: 78b1686c150aeaa29c5d969b70c9c42c872246a2 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1815 From serb at openjdk.org Fri Mar 24 19:06:35 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 24 Mar 2023 19:06:35 GMT Subject: [jdk17u-dev] Integrated: 8303102: jcmd: ManagementAgent.status truncates the text longer than O_BUFLEN In-Reply-To: <97XeHzFVop7YvQYHiYIKP2zXh6x7cYBwnRMEjuBeiXs=.ca85c142-fc81-417e-a879-efdc4f8fff93@github.com> References: <97XeHzFVop7YvQYHiYIKP2zXh6x7cYBwnRMEjuBeiXs=.ca85c142-fc81-417e-a879-efdc4f8fff93@github.com> Message-ID: On Thu, 2 Mar 2023 03:59:20 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [a43931b7](https://github.com/openjdk/jdk/commit/a43931b79cb25d218e8f9b4d4f3a106f59cb2d37) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 26 Feb 2023 and was reviewed by David Holmes. > Thanks! This pull request has now been integrated. Changeset: 637155e3 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u-dev/commit/637155e3a6e21f7a38205252a2f4f47046d06b61 Stats: 4 lines in 2 files changed: 1 ins; 0 del; 3 mod 8303102: jcmd: ManagementAgent.status truncates the text longer than O_BUFLEN Backport-of: a43931b79cb25d218e8f9b4d4f3a106f59cb2d37 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1196 From serb at openjdk.org Fri Mar 24 19:20:46 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 24 Mar 2023 19:20:46 GMT Subject: [jdk11u-dev] Integrated: 8303102: jcmd: ManagementAgent.status truncates the text longer than O_BUFLEN In-Reply-To: References: Message-ID: On Wed, 8 Mar 2023 18:56:25 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [a43931b7](https://github.com/openjdk/jdk/commit/a43931b79cb25d218e8f9b4d4f3a106f59cb2d37) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 26 Feb 2023 and was reviewed by David Holmes. > Thanks! This pull request has now been integrated. Changeset: e12516d4 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk11u-dev/commit/e12516d44c3aa66b85783a4901e06d49e3613c20 Stats: 4 lines in 2 files changed: 1 ins; 0 del; 3 mod 8303102: jcmd: ManagementAgent.status truncates the text longer than O_BUFLEN Backport-of: a43931b79cb25d218e8f9b4d4f3a106f59cb2d37 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1795 From serb at openjdk.org Fri Mar 24 19:25:42 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 24 Mar 2023 19:25:42 GMT Subject: [jdk11u-dev] RFR: 8213531: Test javax/swing/border/TestTitledBorderLeak.java fails In-Reply-To: References: Message-ID: <8Ac_LGAKZXse48Rt9y9WqCGSyL49XheSp6jVHdp1bMM=.6f96eec2-0cec-42ed-bf03-760561f755d7@github.com> On Fri, 24 Mar 2023 06:48:11 GMT, Masanori Yano wrote: > Hi, > > This is a backport of JDK-8213531: Test javax/swing/border/TestTitledBorderLeak.java fails. > > Original patch does not apply cleanly to jdk11u, because there is no line of TestTitledBorderLeak.java in ProblemList.txt of jdk11u. So I fixed only TestTitledBorderLeak.java. > > Testing: I tested manually on RHEL7, and tier1. It probably will be better to check the stability of that tests and backport that one first. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1817#issuecomment-1483302084 From duke at openjdk.org Sun Mar 26 09:03:25 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Sun, 26 Mar 2023 09:03:25 GMT Subject: [jdk11u-dev] RFR: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence [v3] In-Reply-To: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> References: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> Message-ID: > I would like to backport > JDK-8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence. > The original patch does not apply cleanly to 11u. > Because the original patch has switch expressions which can not be used in 11u, > and it has the Class jdk.javadoc.internal.doclets.formats.html.HtmlOptions which is not defined in 11u. > There is no risk, because the logic around the changes is the same as jdk17. > I confirmed the following test and all langtool tests. > test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java > > Could anyone review the fix please? Kimura Yukihiro has updated the pull request incrementally with one additional commit since the last revision: Backport e9f3e325c274f19b0f6eceea2367708e3be689e9 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1805/files - new: https://git.openjdk.org/jdk11u-dev/pull/1805/files/32a28dff..0072bb59 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1805&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1805&range=01-02 Stats: 786 lines in 94 files changed: 312 ins; 0 del; 474 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1805.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1805/head:pull/1805 PR: https://git.openjdk.org/jdk11u-dev/pull/1805 From duke at openjdk.org Sun Mar 26 11:51:27 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Sun, 26 Mar 2023 11:51:27 GMT Subject: [jdk11u-dev] RFR: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence [v4] In-Reply-To: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> References: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> Message-ID: > I would like to backport > JDK-8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence. > The original patch does not apply cleanly to 11u. > Because the original patch has switch expressions which can not be used in 11u, > and it has the Class jdk.javadoc.internal.doclets.formats.html.HtmlOptions which is not defined in 11u. > There is no risk, because the logic around the changes is the same as jdk17. > I confirmed the following test and all langtool tests. > test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java > > Could anyone review the fix please? Kimura Yukihiro has updated the pull request incrementally with one additional commit since the last revision: Backport e9f3e325c274f19b0f6eceea2367708e3be689e9 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1805/files - new: https://git.openjdk.org/jdk11u-dev/pull/1805/files/0072bb59..54d109df Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1805&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1805&range=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1805.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1805/head:pull/1805 PR: https://git.openjdk.org/jdk11u-dev/pull/1805 From serb at openjdk.org Mon Mar 27 00:11:26 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 27 Mar 2023 00:11:26 GMT Subject: [jdk17u-dev] RFR: 8302849: SurfaceManager might expose partially constructed object Message-ID: Hi all, This pull request contains a backport of commit [63ef2143](https://github.com/openjdk/jdk/commit/63ef2143289f4aac52c8b2a6b555ed2b33dc1c07) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Per Minborg on 22 Feb 2023 and was reviewed by Sergey Bylokhov. Thanks! ------------- Commit messages: - Backport 63ef2143289f4aac52c8b2a6b555ed2b33dc1c07 Changes: https://git.openjdk.org/jdk17u-dev/pull/1215/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1215&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8302849 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1215.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1215/head:pull/1215 PR: https://git.openjdk.org/jdk17u-dev/pull/1215 From duke at openjdk.org Mon Mar 27 04:46:40 2023 From: duke at openjdk.org (PoojaDP-23) Date: Mon, 27 Mar 2023 04:46:40 GMT Subject: [jdk11u-dev] RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers In-Reply-To: References: Message-ID: On Thu, 23 Mar 2023 09:26:20 GMT, Christoph Langer wrote: >> @RealCLanger - Could you please review the PR? Thanks > > Hi @PoojaDP-23, > > when looking at the scope of this backport and its successor, [JDK-8293562](https://github.com/openjdk/jdk/commit/03f25a9c6924430ec4063b801b2b6ca55b9067c9), which I've understood is what you actually want to fix, I'm a bit concerned whether this is appropriate as a backport to JDK11. After all, it completely reworks the locking in the HTTP client and we can't be sure what side effects this might cause in other productive usages. It might even unveil issues that have not been discovered in head. > > So, could you go back and give some more explanation what kind of bug you want to fix in 11u? Maybe we can find a less intrusive fix that could also differ from OpenJDK upstream? Maybe JDK-8293562 can be adapted for 11u without this one? > > Thanks > Christoph Thanks for the update @RealCLanger Yes, we need to backport JDK-8293562 to jdk-11 and backporting the dependency as well. Please let us know about the less intrusive fix, we shall evaluate if this resolves the issue. Also, could you please help us understand the following ? 1) How this backport will be different from JDK17 as this is already backported to JDK17 and what/why are we expecting side effects in JDK11 ? 2) Unit test suite execution will be sufficient to confirm the adaptability of these two backports or what exact side effects to be concerned with. Please share your response ASAP. It will help us to decide on next steps. thx ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1710#issuecomment-1484481325 From goetz at openjdk.org Mon Mar 27 05:28:42 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 27 Mar 2023 05:28:42 GMT Subject: [jdk11u-dev] RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers In-Reply-To: References: Message-ID: On Mon, 27 Mar 2023 04:44:13 GMT, PoojaDP-23 wrote: >> Hi @PoojaDP-23, >> >> when looking at the scope of this backport and its successor, [JDK-8293562](https://github.com/openjdk/jdk/commit/03f25a9c6924430ec4063b801b2b6ca55b9067c9), which I've understood is what you actually want to fix, I'm a bit concerned whether this is appropriate as a backport to JDK11. After all, it completely reworks the locking in the HTTP client and we can't be sure what side effects this might cause in other productive usages. It might even unveil issues that have not been discovered in head. >> >> So, could you go back and give some more explanation what kind of bug you want to fix in 11u? Maybe we can find a less intrusive fix that could also differ from OpenJDK upstream? Maybe JDK-8293562 can be adapted for 11u without this one? >> >> Thanks >> Christoph > > Thanks for the update @RealCLanger > > Yes, we need to backport JDK-8293562 to jdk-11 and backporting the dependency as well. Please let us know about the less intrusive fix, we shall evaluate if this resolves the issue. > > Also, could you please help us understand the following ? > > 1) How this backport will be different from JDK17 as this is already backported to JDK17 and what/why are we expecting side effects in JDK11 ? > > 2) Unit test suite execution will be sufficient to confirm the adaptability of these two backports or what exact side effects to be concerned with. > > Please share your response ASAP. It will help us to decide on next steps. thx Dear @PoojaDP-23 Christoph already reasoned why he thinks this is not appropriate for 11: " After all, it completely reworks the locking in the HTTP client and we can't be sure what side effects this might cause in other productive usages. It might even unveil issues that have not been discovered in head." You did not give a reason why you need these changes yet. Please reason for this carefully. You ask "Please let us know about the less intrusive fix," It is up to you, the Contributor, to draft a less intrusive fix. If you can not do that yourself, you also can not judge the risk of the backport properly because you have not understood the fix. ASAP is not a vocabulary used typically in open source projects where people work on a voluntary basis. Please see https://wiki.openjdk.org/display/JDKUpdates/JDK11u for a description of eligible backports. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1710#issuecomment-1484517595 From goetz at openjdk.org Mon Mar 27 05:28:44 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 27 Mar 2023 05:28:44 GMT Subject: [jdk11u-dev] RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers [v2] In-Reply-To: <_Poe83YbaW6Y1O4f0W4H6b2TIQ57JwunxBuGGy_IekU=.c3a21245-0648-4fa0-84ee-bfef0431c06f@github.com> References: <_Poe83YbaW6Y1O4f0W4H6b2TIQ57JwunxBuGGy_IekU=.c3a21245-0648-4fa0-84ee-bfef0431c06f@github.com> Message-ID: On Tue, 21 Mar 2023 06:35:39 GMT, PoojaDP-23 wrote: >> This is a backport request and this fix is a dependency for [8293562](https://github.com/openjdk/jdk/commit/03f25a9c6924430ec4063b801b2b6ca55b9067c9). >> >> This is a fix that upgrades the old HTTP and HTTPS legacy stack to use virtual-thread friendly locking instead of synchronized monitors. >> >> We have removed @java.io.serial in AuthenticationInfo.java since the serial.class file not located. > > PoojaDP-23 has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'master' into jdk11-keepalive > - address whitespace error > > Signed-off-by: Pooja.D.P > - address compilation error @java.io.Serial > > Signed-off-by: Pooja.D.P > - Backport 65393a093c6a43a0bd8ff9f79c29c3bc5756104f > > Signed-off-by: Pooja.D.P Also, you have failing tests. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1710#issuecomment-1484518536 From aph at openjdk.org Mon Mar 27 10:09:47 2023 From: aph at openjdk.org (Andrew Haley) Date: Mon, 27 Mar 2023 10:09:47 GMT Subject: [jdk11u-dev] RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers [v2] In-Reply-To: <_Poe83YbaW6Y1O4f0W4H6b2TIQ57JwunxBuGGy_IekU=.c3a21245-0648-4fa0-84ee-bfef0431c06f@github.com> References: <_Poe83YbaW6Y1O4f0W4H6b2TIQ57JwunxBuGGy_IekU=.c3a21245-0648-4fa0-84ee-bfef0431c06f@github.com> Message-ID: On Tue, 21 Mar 2023 06:35:39 GMT, PoojaDP-23 wrote: >> This is a backport request and this fix is a dependency for [8293562](https://github.com/openjdk/jdk/commit/03f25a9c6924430ec4063b801b2b6ca55b9067c9). >> >> This is a fix that upgrades the old HTTP and HTTPS legacy stack to use virtual-thread friendly locking instead of synchronized monitors. >> >> We have removed @java.io.serial in AuthenticationInfo.java since the serial.class file not located. > > PoojaDP-23 has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'master' into jdk11-keepalive > - address whitespace error > > Signed-off-by: Pooja.D.P > - address compilation error @java.io.Serial > > Signed-off-by: Pooja.D.P > - Backport 65393a093c6a43a0bd8ff9f79c29c3bc5756104f > > Signed-off-by: Pooja.D.P No. This patch will never be accepted in JDK 11u. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1710#issuecomment-1484865222 From duke at openjdk.org Mon Mar 27 12:47:37 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Mon, 27 Mar 2023 12:47:37 GMT Subject: [jdk11u-dev] RFR: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence [v4] In-Reply-To: References: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> Message-ID: On Sun, 26 Mar 2023 11:51:27 GMT, Kimura Yukihiro wrote: >> I would like to backport >> JDK-8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence. >> The original patch does not apply cleanly to 11u. >> Because the original patch has switch expressions which can not be used in 11u, >> and it has the Class jdk.javadoc.internal.doclets.formats.html.HtmlOptions which is not defined in 11u. >> There is no risk, because the logic around the changes is the same as jdk17. >> I confirmed the following test and all langtool tests. >> test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java >> >> Could anyone review the fix please? > > Kimura Yukihiro has updated the pull request incrementally with one additional commit since the last revision: > > Backport e9f3e325c274f19b0f6eceea2367708e3be689e9 Hello Paul, Thank you for your advice. I modified the fix. I would appreciate if you could review it. Thanks, Kimura Yukihiro Hello Paul, Thank you for your advice. I modified the fix. I would appreciate if you could review it. Thanks, Kimura Yukihiro ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1805#issuecomment-1485058943 PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1805#issuecomment-1485059320 From serb at openjdk.org Mon Mar 27 17:21:05 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 27 Mar 2023 17:21:05 GMT Subject: [jdk20u] Integrated: 8303102: jcmd: ManagementAgent.status truncates the text longer than O_BUFLEN In-Reply-To: References: Message-ID: On Wed, 8 Mar 2023 18:51:34 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [a43931b7](https://github.com/openjdk/jdk/commit/a43931b79cb25d218e8f9b4d4f3a106f59cb2d37) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 26 Feb 2023 and was reviewed by David Holmes. > Thanks! This pull request has now been integrated. Changeset: 22c18e9d Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk20u/commit/22c18e9d943547a8e1c66763e43b966cebf39331 Stats: 4 lines in 2 files changed: 1 ins; 0 del; 3 mod 8303102: jcmd: ManagementAgent.status truncates the text longer than O_BUFLEN Backport-of: a43931b79cb25d218e8f9b4d4f3a106f59cb2d37 ------------- PR: https://git.openjdk.org/jdk20u/pull/15 From phh at openjdk.org Mon Mar 27 17:40:53 2023 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 27 Mar 2023 17:40:53 GMT Subject: [jdk11u-dev] RFR: 8213531: Test javax/swing/border/TestTitledBorderLeak.java fails In-Reply-To: References: Message-ID: On Fri, 24 Mar 2023 06:48:11 GMT, Masanori Yano wrote: > Hi, > > This is a backport of JDK-8213531: Test javax/swing/border/TestTitledBorderLeak.java fails. > > Original patch does not apply cleanly to jdk11u, because there is no line of TestTitledBorderLeak.java in ProblemList.txt of jdk11u. So I fixed only TestTitledBorderLeak.java. > > Testing: I tested manually on RHEL7, and tier1. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1817#pullrequestreview-1359570001 From phh at openjdk.org Mon Mar 27 17:49:41 2023 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 27 Mar 2023 17:49:41 GMT Subject: [jdk11u-dev] RFR: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence [v4] In-Reply-To: References: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> Message-ID: On Sun, 26 Mar 2023 11:51:27 GMT, Kimura Yukihiro wrote: >> I would like to backport >> JDK-8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence. >> The original patch does not apply cleanly to 11u. >> Because the original patch has switch expressions which can not be used in 11u, >> and it has the Class jdk.javadoc.internal.doclets.formats.html.HtmlOptions which is not defined in 11u. >> There is no risk, because the logic around the changes is the same as jdk17. >> I confirmed the following test and all langtool tests. >> test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java >> >> Could anyone review the fix please? > > Kimura Yukihiro has updated the pull request incrementally with one additional commit since the last revision: > > Backport e9f3e325c274f19b0f6eceea2367708e3be689e9 Hi, Kimura. I accepted your original fix after you corrected me. :) Your new update changes 101 files, which won't be approved by the Maintainers, so please revert to the original patch. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1805#issuecomment-1485570396 From serb at openjdk.org Mon Mar 27 18:07:46 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 27 Mar 2023 18:07:46 GMT Subject: [jdk17u-dev] Integrated: 8302849: SurfaceManager might expose partially constructed object In-Reply-To: References: Message-ID: On Fri, 24 Mar 2023 07:33:29 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [63ef2143](https://github.com/openjdk/jdk/commit/63ef2143289f4aac52c8b2a6b555ed2b33dc1c07) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Per Minborg on 22 Feb 2023 and was reviewed by Sergey Bylokhov. > Thanks! This pull request has now been integrated. Changeset: c6a35f50 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u-dev/commit/c6a35f50b35c15dbbd6efd45c3a286e06ebabe80 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8302849: SurfaceManager might expose partially constructed object Backport-of: 63ef2143289f4aac52c8b2a6b555ed2b33dc1c07 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1215 From phh at openjdk.org Mon Mar 27 20:51:23 2023 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 27 Mar 2023 20:51:23 GMT Subject: [jdk17u-dev] RFR: 8304671: javac regression: Compilation with --release 8 fails on underscore in enum identifiers In-Reply-To: References: Message-ID: On Fri, 24 Mar 2023 13:09:09 GMT, Matthias Baesken wrote: > backport of 8304671 Clean except for JavacParser.java copyright date and JavacParserTest.java bug list. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1216#pullrequestreview-1359848720 From goetz at openjdk.org Tue Mar 28 09:58:51 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 28 Mar 2023 09:58:51 GMT Subject: [jdk17u-dev] RFR: 8275721: Name of UTC timezone in a locale changes depending on previous code Message-ID: I backport this for parity with 17.0.8-oracle. ------------- Commit messages: - Backport 543d1a8cf41d32dca161c9d8041f133a71bf0ecb Changes: https://git.openjdk.org/jdk17u-dev/pull/1217/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1217&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8275721 Stats: 108 lines in 2 files changed: 85 ins; 17 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1217.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1217/head:pull/1217 PR: https://git.openjdk.org/jdk17u-dev/pull/1217 From goetz at openjdk.org Tue Mar 28 10:01:11 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 28 Mar 2023 10:01:11 GMT Subject: [jdk11u-dev] RFR: 8275721: Name of UTC timezone in a locale changes depending on previous code Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 543d1a8cf41d32dca161c9d8041f133a71bf0ecb Changes: https://git.openjdk.org/jdk11u-dev/pull/1818/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1818&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8275721 Stats: 108 lines in 2 files changed: 85 ins; 17 del; 6 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1818.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1818/head:pull/1818 PR: https://git.openjdk.org/jdk11u-dev/pull/1818 From goetz at openjdk.org Tue Mar 28 10:19:19 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 28 Mar 2023 10:19:19 GMT Subject: [jdk17u-dev] RFR: 8282077: PKCS11 provider C_sign() impl should handle CKR_BUFFER_TOO_SMALL error Message-ID: I backport this for parity with 17.0.8-oracle. ------------- Commit messages: - Backport d7f31d0d53bfec627edc83ceb75fc6202891e186 Changes: https://git.openjdk.org/jdk17u-dev/pull/1218/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1218&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282077 Stats: 12 lines in 1 file changed: 11 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1218.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1218/head:pull/1218 PR: https://git.openjdk.org/jdk17u-dev/pull/1218 From goetz at openjdk.org Tue Mar 28 10:22:25 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 28 Mar 2023 10:22:25 GMT Subject: [jdk17u-dev] RFR: 8283062: Uninitialized warnings in libgtest with GCC 11.2 Message-ID: I backport this for parity with 17.0.8-oracle. ------------- Commit messages: - Backport a244051a8c967039d7639afcaf83f7d92af49613 Changes: https://git.openjdk.org/jdk17u-dev/pull/1219/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1219&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283062 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1219.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1219/head:pull/1219 PR: https://git.openjdk.org/jdk17u-dev/pull/1219 From goetz at openjdk.org Tue Mar 28 10:35:22 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 28 Mar 2023 10:35:22 GMT Subject: [jdk17u-dev] RFR: 8282227: Locale information for nb is not working properly Message-ID: <_2a1zHnC8nhdc52GqGmFqmgYHLYvtQ0VxiWpittozQw=.5831409b-6659-4457-9a73-4f7aa2e051d3@github.com> I backport this for parity with 17.0.8-oracle. ------------- Commit messages: - Backport 3d07b3c7f01b60ff4dc38f62407c212b48883dbf Changes: https://git.openjdk.org/jdk17u-dev/pull/1220/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1220&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282227 Stats: 79 lines in 2 files changed: 74 ins; 1 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1220.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1220/head:pull/1220 PR: https://git.openjdk.org/jdk17u-dev/pull/1220 From goetz at openjdk.org Tue Mar 28 10:43:33 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 28 Mar 2023 10:43:33 GMT Subject: [jdk17u-dev] RFR: 8286287: Reading file as UTF-16 causes Error which "shouldn't happen" Message-ID: I backport this for parity with 17.0.8-oracle. ------------- Commit messages: - Backport cc7560e995eac56709d9e55a1561135fad246cb2 Changes: https://git.openjdk.org/jdk17u-dev/pull/1221/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1221&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8286287 Stats: 54 lines in 2 files changed: 52 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1221.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1221/head:pull/1221 PR: https://git.openjdk.org/jdk17u-dev/pull/1221 From goetz at openjdk.org Tue Mar 28 12:10:43 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 28 Mar 2023 12:10:43 GMT Subject: [jdk17u-dev] Integrated: 8268288: jdk/jfr/api/consumer/streaming/TestOutOfProcessMigration.java fails with "Error: ShouldNotReachHere()" In-Reply-To: References: Message-ID: On Tue, 21 Mar 2023 19:22:53 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. This pull request has now been integrated. Changeset: ac0b7c93 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/ac0b7c9371f202748d2ee9df79aeae0005cbad7a Stats: 28 lines in 1 file changed: 11 ins; 11 del; 6 mod 8268288: jdk/jfr/api/consumer/streaming/TestOutOfProcessMigration.java fails with "Error: ShouldNotReachHere()" Reviewed-by: mbaesken Backport-of: 0a0909263194032ae7d8348484e3638f84090233 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1212 From goetz at openjdk.org Tue Mar 28 12:23:25 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 28 Mar 2023 12:23:25 GMT Subject: [jdk17u-dev] RFR: 8287541: Files.writeString fails to throw IOException for charset "windows-1252" Message-ID: I backport this along with a row of related issues of 17.0.8-oracle. ------------- Commit messages: - Backport 6fb84e2c9119bdb9c66dd49422bcab637bbd4008 Changes: https://git.openjdk.org/jdk17u-dev/pull/1222/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1222&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287541 Stats: 22 lines in 2 files changed: 4 ins; 11 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1222.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1222/head:pull/1222 PR: https://git.openjdk.org/jdk17u-dev/pull/1222 From goetz at openjdk.org Tue Mar 28 12:35:46 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 28 Mar 2023 12:35:46 GMT Subject: [jdk17u-dev] RFR: 8291637: HttpClient default keep alive timeout not followed if server sends invalid value Message-ID: <5HIXrGe6coooiH8E4gAOds7ZuXz-w7u_kHWu8e9K2XM=.09c2a367-c9fc-4a7c-8e32-8cfb4b2c630d@github.com> I backport this for parity with 17.0.8-oracle. ------------- Commit messages: - Backport b17a745d7f55941f02b0bdde83866aa5d32cce07 Changes: https://git.openjdk.org/jdk17u-dev/pull/1223/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1223&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8291637 Stats: 147 lines in 2 files changed: 147 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1223.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1223/head:pull/1223 PR: https://git.openjdk.org/jdk17u-dev/pull/1223 From goetz at openjdk.org Tue Mar 28 12:46:14 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 28 Mar 2023 12:46:14 GMT Subject: [jdk11u-dev] RFR: 8291637: HttpClient default keep alive timeout not followed if server sends invalid value Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport b17a745d7f55941f02b0bdde83866aa5d32cce07 Changes: https://git.openjdk.org/jdk11u-dev/pull/1819/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1819&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8291637 Stats: 147 lines in 2 files changed: 147 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1819.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1819/head:pull/1819 PR: https://git.openjdk.org/jdk11u-dev/pull/1819 From phh at openjdk.org Tue Mar 28 13:50:23 2023 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 28 Mar 2023 13:50:23 GMT Subject: [jdk17u-dev] RFR: 8278834: Error "Cannot read field "sym" because "this.lvar[od]" is null" when compiling [v2] In-Reply-To: References: <2rJnEjqxO8J0PJR-pqc9ns37tQQZJOL82saXnIY3uQU=.5b29e609-8d6e-4f01-af13-4af2ce6ace6a@github.com> Message-ID: <6JvdXCJszN6sv26xAyC10-qGPEa9ronrtlkdCu7Vw0c=.3dc81ca5-b99a-4b9b-938d-c4f6de6e8f82@github.com> On Thu, 23 Mar 2023 08:30:21 GMT, Glavo wrote: >> 8278834: Error "Cannot read field "sym" because "this.lvar[od]" is null" when compiling > > Glavo has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into JDK-8278834 > - Backport be0538d7c8e2cbfa599dbcb4c5c69533678a8421 Re-review. Backport has been approved, I can sponsor as soon as I see /integrate. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1141#pullrequestreview-1361131532 From goetz at openjdk.org Tue Mar 28 14:11:51 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 28 Mar 2023 14:11:51 GMT Subject: [jdk17u-dev] RFR: 8291226: Create Test Cases to cover scenarios for JDK-8278067 Message-ID: I backport this for parity with 17.0.8-oracle. ------------- Commit messages: - Backport 86ec158dfb7a770fe9a74ff8617bac938d0bb90f Changes: https://git.openjdk.org/jdk17u-dev/pull/1224/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1224&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8291226 Stats: 1277 lines in 1 file changed: 1277 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1224.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1224/head:pull/1224 PR: https://git.openjdk.org/jdk17u-dev/pull/1224 From goetz at openjdk.org Tue Mar 28 14:24:16 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 28 Mar 2023 14:24:16 GMT Subject: [jdk11u-dev] RFR: 8291226: Create Test Cases to cover scenarios for JDK-8278067 Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 86ec158dfb7a770fe9a74ff8617bac938d0bb90f Changes: https://git.openjdk.org/jdk11u-dev/pull/1820/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1820&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8291226 Stats: 1277 lines in 1 file changed: 1277 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1820.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1820/head:pull/1820 PR: https://git.openjdk.org/jdk11u-dev/pull/1820 From mdoerr at openjdk.org Tue Mar 28 16:00:04 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 28 Mar 2023 16:00:04 GMT Subject: [jdk17u-dev] RFR: 8304880: [PPC64] VerifyOops code in C1 doesn't work with ZGC Message-ID: Backport of [JDK-8304880](https://bugs.openjdk.org/browse/JDK-8304880). Doesn't apply cleanly, but this change is trivial to backport because it only removes 2 small code pieces. (Can't verify oops between raw load and load barrier with ZGC.) ------------- Commit messages: - Backport 695683b5b15c69a56fe7ee1a93482fe7c3530ca8 Changes: https://git.openjdk.org/jdk17u-dev/pull/1225/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1225&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304880 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1225.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1225/head:pull/1225 PR: https://git.openjdk.org/jdk17u-dev/pull/1225 From inakonechnyy at openjdk.org Tue Mar 28 20:20:44 2023 From: inakonechnyy at openjdk.org (Ilarion Nakonechnyy) Date: Tue, 28 Mar 2023 20:20:44 GMT Subject: [jdk17u-dev] RFR: 8302491: NoClassDefFoundError omits the original cause of an error Message-ID: The backport doesn't apply cleanly. Tested with tier1 on Mac OS. ------------- Commit messages: - Backport 5685107579f0f00b5eae881311315cec34c1ddcb Changes: https://git.openjdk.org/jdk17u-dev/pull/1226/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1226&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8302491 Stats: 58 lines in 3 files changed: 21 ins; 13 del; 24 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1226.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1226/head:pull/1226 PR: https://git.openjdk.org/jdk17u-dev/pull/1226 From goetz at openjdk.org Wed Mar 29 06:09:41 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 29 Mar 2023 06:09:41 GMT Subject: [jdk17u-dev] RFR: 8302491: NoClassDefFoundError omits the original cause of an error In-Reply-To: References: Message-ID: On Tue, 28 Mar 2023 20:13:41 GMT, Ilarion Nakonechnyy wrote: > The backport doesn't apply cleanly. Tested with tier1 on Mac OS. Please enable Github actions. Only tag the change if it is reveiwed. Please follow instructions in https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1226#issuecomment-1487997138 From duke at openjdk.org Wed Mar 29 06:42:36 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Wed, 29 Mar 2023 06:42:36 GMT Subject: [jdk11u-dev] RFR: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence [v5] In-Reply-To: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> References: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> Message-ID: > I would like to backport > JDK-8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence. > The original patch does not apply cleanly to 11u. > Because the original patch has switch expressions which can not be used in 11u, > and it has the Class jdk.javadoc.internal.doclets.formats.html.HtmlOptions which is not defined in 11u. > There is no risk, because the logic around the changes is the same as jdk17. > I confirmed the following test and all langtool tests. > test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java > > Could anyone review the fix please? Kimura Yukihiro has updated the pull request incrementally with one additional commit since the last revision: Revert backport e9f3e325c274f19b0f6eceea2367708e3be689e ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1805/files - new: https://git.openjdk.org/jdk11u-dev/pull/1805/files/54d109df..228b6910 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1805&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1805&range=03-04 Stats: 1057 lines in 94 files changed: 0 ins; 477 del; 580 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1805.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1805/head:pull/1805 PR: https://git.openjdk.org/jdk11u-dev/pull/1805 From mbaesken at openjdk.org Wed Mar 29 06:43:39 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 29 Mar 2023 06:43:39 GMT Subject: [jdk20u] Integrated: 8304671: javac regression: Compilation with --release 8 fails on underscore in enum identifiers In-Reply-To: References: Message-ID: On Thu, 23 Mar 2023 09:40:21 GMT, Matthias Baesken wrote: > 8304671: javac regression: Compilation with --release 8 fails on underscore in enum identifiers This pull request has now been integrated. Changeset: 0d717958 Author: Matthias Baesken URL: https://git.openjdk.org/jdk20u/commit/0d71795814ed255c4a6e2b51cee01a264a407ad6 Stats: 190 lines in 2 files changed: 181 ins; 2 del; 7 mod 8304671: javac regression: Compilation with --release 8 fails on underscore in enum identifiers Backport-of: 63d4afbeb17df4eff0f65041926373ee62a8a33a ------------- PR: https://git.openjdk.org/jdk20u/pull/23 From goetz at openjdk.org Wed Mar 29 07:20:42 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 29 Mar 2023 07:20:42 GMT Subject: [jdk17u-dev] Integrated: 8282077: PKCS11 provider C_sign() impl should handle CKR_BUFFER_TOO_SMALL error In-Reply-To: References: Message-ID: On Tue, 28 Mar 2023 10:11:41 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. This pull request has now been integrated. Changeset: 268a6a5a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/268a6a5a3143d26e5a2ec557874e2e903185df42 Stats: 12 lines in 1 file changed: 11 ins; 0 del; 1 mod 8282077: PKCS11 provider C_sign() impl should handle CKR_BUFFER_TOO_SMALL error Backport-of: d7f31d0d53bfec627edc83ceb75fc6202891e186 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1218 From goetz at openjdk.org Wed Mar 29 07:24:55 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 29 Mar 2023 07:24:55 GMT Subject: [jdk17u-dev] Integrated: 8283062: Uninitialized warnings in libgtest with GCC 11.2 In-Reply-To: References: Message-ID: <8mITTdskocM8lOTxKKXv92mXkmEMhgT7h4kelIh-KVk=.b5436b91-1847-4791-9cb6-24a4419d9deb@github.com> On Tue, 28 Mar 2023 10:15:44 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. This pull request has now been integrated. Changeset: 7cf28d56 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/7cf28d56a91ccae6d4f51257824a17047975ac51 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8283062: Uninitialized warnings in libgtest with GCC 11.2 Backport-of: a244051a8c967039d7639afcaf83f7d92af49613 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1219 From goetz at openjdk.org Wed Mar 29 07:27:14 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 29 Mar 2023 07:27:14 GMT Subject: [jdk17u-dev] Integrated: 8286287: Reading file as UTF-16 causes Error which "shouldn't happen" In-Reply-To: References: Message-ID: On Tue, 28 Mar 2023 10:36:24 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. This pull request has now been integrated. Changeset: 6ba50fcf Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/6ba50fcf822d26b2a1777e7803f3220ec7b01f93 Stats: 54 lines in 2 files changed: 52 ins; 2 del; 0 mod 8286287: Reading file as UTF-16 causes Error which "shouldn't happen" Backport-of: cc7560e995eac56709d9e55a1561135fad246cb2 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1221 From goetz at openjdk.org Wed Mar 29 07:27:23 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 29 Mar 2023 07:27:23 GMT Subject: [jdk11u-dev] Integrated: 8291637: HttpClient default keep alive timeout not followed if server sends invalid value In-Reply-To: References: Message-ID: On Tue, 28 Mar 2023 12:38:11 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: d8993e68 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/d8993e68ffc496c1e33ff09aaef754fcf5522565 Stats: 147 lines in 2 files changed: 147 ins; 0 del; 0 mod 8291637: HttpClient default keep alive timeout not followed if server sends invalid value Backport-of: b17a745d7f55941f02b0bdde83866aa5d32cce07 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1819 From goetz at openjdk.org Wed Mar 29 07:28:18 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 29 Mar 2023 07:28:18 GMT Subject: [jdk17u-dev] Integrated: 8287541: Files.writeString fails to throw IOException for charset "windows-1252" In-Reply-To: References: Message-ID: On Tue, 28 Mar 2023 12:15:33 GMT, Goetz Lindenmaier wrote: > I backport this along with a row of related issues of 17.0.8-oracle. This pull request has now been integrated. Changeset: 59d82117 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/59d821177de36330d14416f5359f0c0ac3242427 Stats: 22 lines in 2 files changed: 4 ins; 11 del; 7 mod 8287541: Files.writeString fails to throw IOException for charset "windows-1252" Backport-of: 6fb84e2c9119bdb9c66dd49422bcab637bbd4008 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1222 From goetz at openjdk.org Wed Mar 29 07:30:20 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 29 Mar 2023 07:30:20 GMT Subject: [jdk11u-dev] Integrated: 8291226: Create Test Cases to cover scenarios for JDK-8278067 In-Reply-To: References: Message-ID: On Tue, 28 Mar 2023 14:17:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: 835f2cab Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/835f2cab1d79616170afc1be10ef8dc861ce204c Stats: 1277 lines in 1 file changed: 1277 ins; 0 del; 0 mod 8291226: Create Test Cases to cover scenarios for JDK-8278067 Backport-of: 86ec158dfb7a770fe9a74ff8617bac938d0bb90f ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1820 From goetz at openjdk.org Wed Mar 29 07:32:04 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 29 Mar 2023 07:32:04 GMT Subject: [jdk17u-dev] Integrated: 8291637: HttpClient default keep alive timeout not followed if server sends invalid value In-Reply-To: <5HIXrGe6coooiH8E4gAOds7ZuXz-w7u_kHWu8e9K2XM=.09c2a367-c9fc-4a7c-8e32-8cfb4b2c630d@github.com> References: <5HIXrGe6coooiH8E4gAOds7ZuXz-w7u_kHWu8e9K2XM=.09c2a367-c9fc-4a7c-8e32-8cfb4b2c630d@github.com> Message-ID: On Tue, 28 Mar 2023 12:29:03 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. This pull request has now been integrated. Changeset: ec7f1698 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/ec7f16985a0ac78a99799f45f27c8926e4102479 Stats: 147 lines in 2 files changed: 147 ins; 0 del; 0 mod 8291637: HttpClient default keep alive timeout not followed if server sends invalid value Backport-of: b17a745d7f55941f02b0bdde83866aa5d32cce07 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1223 From goetz at openjdk.org Wed Mar 29 07:35:09 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 29 Mar 2023 07:35:09 GMT Subject: [jdk17u-dev] Integrated: 8291226: Create Test Cases to cover scenarios for JDK-8278067 In-Reply-To: References: Message-ID: On Tue, 28 Mar 2023 14:04:07 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. This pull request has now been integrated. Changeset: a71545b5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/a71545b516575a58d4d6719e816b878c7091340c Stats: 1277 lines in 1 file changed: 1277 ins; 0 del; 0 mod 8291226: Create Test Cases to cover scenarios for JDK-8278067 Backport-of: 86ec158dfb7a770fe9a74ff8617bac938d0bb90f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1224 From goetz at openjdk.org Wed Mar 29 08:31:02 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 29 Mar 2023 08:31:02 GMT Subject: [jdk17u-dev] RFR: 8278434: timeouts in test java/time/test/java/time/format/TestZoneTextPrinterParser.java Message-ID: I backport this for parity with 17.0.8-oracle. I resolved copyright and @bugs in the test, will mark as clean. ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/1217 Commit messages: - Backport 8dc4437d002db5d025b47f48e7420e3bae55bdec Changes: https://git.openjdk.org/jdk17u-dev/pull/1228/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1228&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8278434 Stats: 29 lines in 2 files changed: 15 ins; 7 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1228.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1228/head:pull/1228 PR: https://git.openjdk.org/jdk17u-dev/pull/1228 From duke at openjdk.org Wed Mar 29 09:07:05 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Wed, 29 Mar 2023 09:07:05 GMT Subject: [jdk11u-dev] RFR: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence [v5] In-Reply-To: References: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> Message-ID: On Wed, 29 Mar 2023 06:42:36 GMT, Kimura Yukihiro wrote: >> I would like to backport >> JDK-8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence. >> The original patch does not apply cleanly to 11u. >> Because the original patch has switch expressions which can not be used in 11u, >> and it has the Class jdk.javadoc.internal.doclets.formats.html.HtmlOptions which is not defined in 11u. >> There is no risk, because the logic around the changes is the same as jdk17. >> I confirmed the following test and all langtool tests. >> test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java >> >> Could anyone review the fix please? > > Kimura Yukihiro has updated the pull request incrementally with one additional commit since the last revision: > > Revert backport e9f3e325c274f19b0f6eceea2367708e3be689e Hello Paul, I reverted to the original pacth. Thanks, Kimura Yukihiro ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1805#issuecomment-1488209923 From thartmann at openjdk.org Wed Mar 29 10:43:22 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 29 Mar 2023 10:43:22 GMT Subject: [jdk20u] RFR: 8299259: C2: Div/Mod nodes without zero check could be split through iv phi of loop resulting in SIGFPE Message-ID: Backport of [JDK-8299259](https://bugs.openjdk.java.net/browse/JDK-8299259). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8299259: C2: Div/Mod nodes without zero check could be split through iv phi of loop resulting in SIGFPE Changes: https://git.openjdk.org/jdk20u/pull/25/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=25&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299259 Stats: 213 lines in 3 files changed: 199 ins; 11 del; 3 mod Patch: https://git.openjdk.org/jdk20u/pull/25.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/25/head:pull/25 PR: https://git.openjdk.org/jdk20u/pull/25 From thartmann at openjdk.org Wed Mar 29 10:44:29 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 29 Mar 2023 10:44:29 GMT Subject: [jdk20u] RFR: 8299179: ArrayFill with store on backedge needs to reduce length by 1 Message-ID: Backport of [JDK-8299179](https://bugs.openjdk.java.net/browse/JDK-8299179). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8299179: ArrayFill with store on backedge needs to reduce length by 1 Changes: https://git.openjdk.org/jdk20u/pull/24/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=24&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299179 Stats: 429 lines in 3 files changed: 429 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk20u/pull/24.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/24/head:pull/24 PR: https://git.openjdk.org/jdk20u/pull/24 From thartmann at openjdk.org Wed Mar 29 10:47:13 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 29 Mar 2023 10:47:13 GMT Subject: [jdk20u] RFR: 8296389: C2: PhaseCFG::convert_NeverBranch_to_Goto must handle both orders of successors Message-ID: Backport of [JDK-8296389](https://bugs.openjdk.java.net/browse/JDK-8296389). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8296389: C2: PhaseCFG::convert_NeverBranch_to_Goto must handle both orders of successors Changes: https://git.openjdk.org/jdk20u/pull/26/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=26&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296389 Stats: 188 lines in 11 files changed: 167 ins; 2 del; 19 mod Patch: https://git.openjdk.org/jdk20u/pull/26.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/26/head:pull/26 PR: https://git.openjdk.org/jdk20u/pull/26 From thartmann at openjdk.org Wed Mar 29 11:06:59 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 29 Mar 2023 11:06:59 GMT Subject: [jdk20u] RFR: 8302595: use-after-free related to GraphKit::clone_map Message-ID: <_jDYlkIr_m-H5w8HJRB4FfoLsvPqL5rFGK5VH20a06Q=.54c1b3e2-77e8-4d66-90a8-7faee852185c@github.com> Backport of [JDK-8302595](https://bugs.openjdk.java.net/browse/JDK-8302595). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8302595: use-after-free related to GraphKit::clone_map Changes: https://git.openjdk.org/jdk20u/pull/27/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=27&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8302595 Stats: 47 lines in 7 files changed: 40 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk20u/pull/27.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/27/head:pull/27 PR: https://git.openjdk.org/jdk20u/pull/27 From thartmann at openjdk.org Wed Mar 29 11:07:53 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 29 Mar 2023 11:07:53 GMT Subject: [jdk20u] RFR: 8302594: use-after-free in Node::destruct Message-ID: Backport of [JDK-8302594](https://bugs.openjdk.java.net/browse/JDK-8302594). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8302594: use-after-free in Node::destruct Changes: https://git.openjdk.org/jdk20u/pull/28/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=28&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8302594 Stats: 58 lines in 1 file changed: 31 ins; 27 del; 0 mod Patch: https://git.openjdk.org/jdk20u/pull/28.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/28/head:pull/28 PR: https://git.openjdk.org/jdk20u/pull/28 From thartmann at openjdk.org Wed Mar 29 11:11:10 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 29 Mar 2023 11:11:10 GMT Subject: [jdk20u] RFR: 8302172: [JVMCI] HotSpotResolvedJavaMethodImpl.canBeInlined must respect ForceInline Message-ID: Backport of [JDK-8302172](https://bugs.openjdk.java.net/browse/JDK-8302172). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8302172: [JVMCI] HotSpotResolvedJavaMethodImpl.canBeInlined must respect ForceInline Changes: https://git.openjdk.org/jdk20u/pull/29/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=29&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8302172 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk20u/pull/29.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/29/head:pull/29 PR: https://git.openjdk.org/jdk20u/pull/29 From thartmann at openjdk.org Wed Mar 29 11:12:35 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 29 Mar 2023 11:12:35 GMT Subject: [jdk20u] RFR: 8300823: UB: Compile::_phase_optimize_finished is initialized too late Message-ID: Backport of [JDK-8300823](https://bugs.openjdk.java.net/browse/JDK-8300823). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8300823: UB: Compile::_phase_optimize_finished is initialized too late Changes: https://git.openjdk.org/jdk20u/pull/30/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=30&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8300823 Stats: 13 lines in 1 file changed: 6 ins; 6 del; 1 mod Patch: https://git.openjdk.org/jdk20u/pull/30.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/30/head:pull/30 PR: https://git.openjdk.org/jdk20u/pull/30 From thartmann at openjdk.org Wed Mar 29 11:15:49 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 29 Mar 2023 11:15:49 GMT Subject: [jdk20u] RFR: 8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument Message-ID: Backport of [JDK-8300079](https://bugs.openjdk.java.net/browse/JDK-8300079). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument Changes: https://git.openjdk.org/jdk20u/pull/32/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=32&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8300079 Stats: 186 lines in 2 files changed: 62 ins; 32 del; 92 mod Patch: https://git.openjdk.org/jdk20u/pull/32.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/32/head:pull/32 PR: https://git.openjdk.org/jdk20u/pull/32 From thartmann at openjdk.org Wed Mar 29 11:15:53 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 29 Mar 2023 11:15:53 GMT Subject: [jdk20u] RFR: 8297730: C2: Arraycopy intrinsic throws incorrect exception Message-ID: Backport of [JDK-8297730](https://bugs.openjdk.java.net/browse/JDK-8297730). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8297730: C2: Arraycopy intrinsic throws incorrect exception Changes: https://git.openjdk.org/jdk20u/pull/31/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=31&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297730 Stats: 466 lines in 3 files changed: 410 ins; 32 del; 24 mod Patch: https://git.openjdk.org/jdk20u/pull/31.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/31/head:pull/31 PR: https://git.openjdk.org/jdk20u/pull/31 From thartmann at openjdk.org Wed Mar 29 11:17:33 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 29 Mar 2023 11:17:33 GMT Subject: [jdk20u] RFR: 8300590: [JVMCI] BytecodeFrame.equals is broken Message-ID: Backport of [JDK-8300590](https://bugs.openjdk.java.net/browse/JDK-8300590). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8300590: [JVMCI] BytecodeFrame.equals is broken Changes: https://git.openjdk.org/jdk20u/pull/33/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=33&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8300590 Stats: 145 lines in 2 files changed: 129 ins; 8 del; 8 mod Patch: https://git.openjdk.org/jdk20u/pull/33.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/33/head:pull/33 PR: https://git.openjdk.org/jdk20u/pull/33 From thartmann at openjdk.org Wed Mar 29 11:19:30 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 29 Mar 2023 11:19:30 GMT Subject: [jdk20u] RFR: 8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM Message-ID: Backport of [JDK-8289748](https://bugs.openjdk.java.net/browse/JDK-8289748). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM Changes: https://git.openjdk.org/jdk20u/pull/34/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=34&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289748 Stats: 76 lines in 2 files changed: 75 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk20u/pull/34.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/34/head:pull/34 PR: https://git.openjdk.org/jdk20u/pull/34 From thartmann at openjdk.org Wed Mar 29 11:21:22 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 29 Mar 2023 11:21:22 GMT Subject: [jdk20u] RFR: 8299959: C2: CmpU::Value must filter overflow computation against local sub computation Message-ID: <_joxE9-8ai8uzATLpVC9la73sDOdkHTAuCtABE8MbNI=.ca4b0b15-e75e-43b5-98df-7353761ab188@github.com> Backport of [JDK-8299959](https://bugs.openjdk.java.net/browse/JDK-8299959). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8299959: C2: CmpU::Value must filter overflow computation against local sub computation Changes: https://git.openjdk.org/jdk20u/pull/35/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=35&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299959 Stats: 72 lines in 2 files changed: 69 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk20u/pull/35.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/35/head:pull/35 PR: https://git.openjdk.org/jdk20u/pull/35 From thartmann at openjdk.org Wed Mar 29 11:22:29 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 29 Mar 2023 11:22:29 GMT Subject: [jdk20u] RFR: 8301338: Identical branch conditions in CompileBroker::print_heapinfo Message-ID: Backport of [JDK-8301338](https://bugs.openjdk.java.net/browse/JDK-8301338). Did not apply cleanly due to `NULL` vs. `nullptr`. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8301338: Identical branch conditions in CompileBroker::print_heapinfo Changes: https://git.openjdk.org/jdk20u/pull/36/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=36&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8301338 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk20u/pull/36.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/36/head:pull/36 PR: https://git.openjdk.org/jdk20u/pull/36 From thartmann at openjdk.org Wed Mar 29 11:48:31 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 29 Mar 2023 11:48:31 GMT Subject: [jdk20u] RFR: 8303564: C2: "Bad graph detected in build_loop_late" after a CMove is wrongly split thru phi Message-ID: <4ao5AKGCGt5ymteQjJ0-ebK6R9hLduKPf60EWDUUHEM=.9f68d1f4-82ff-437f-8858-28a9d7620c5c@github.com> Backport of [JDK-8303564](https://bugs.openjdk.java.net/browse/JDK-8303564). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8303564: C2: "Bad graph detected in build_loop_late" after a CMove is wrongly split thru phi Changes: https://git.openjdk.org/jdk20u/pull/38/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=38&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303564 Stats: 82 lines in 2 files changed: 80 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk20u/pull/38.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/38/head:pull/38 PR: https://git.openjdk.org/jdk20u/pull/38 From thartmann at openjdk.org Wed Mar 29 11:48:27 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 29 Mar 2023 11:48:27 GMT Subject: [jdk20u] RFR: 8304683: Memory leak in WB_IsMethodCompatible Message-ID: Backport of [JDK-8304683](https://bugs.openjdk.java.net/browse/JDK-8304683). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8304683: Memory leak in WB_IsMethodCompatible Changes: https://git.openjdk.org/jdk20u/pull/37/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=37&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304683 Stats: 4 lines in 1 file changed: 0 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk20u/pull/37.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/37/head:pull/37 PR: https://git.openjdk.org/jdk20u/pull/37 From thartmann at openjdk.org Wed Mar 29 11:51:39 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 29 Mar 2023 11:51:39 GMT Subject: [jdk20u] RFR: 8303511: C2: assert(get_ctrl(n) == cle_out) during unrolling Message-ID: Backport of [JDK-8303511](https://bugs.openjdk.java.net/browse/JDK-8303511). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8303511: C2: assert(get_ctrl(n) == cle_out) during unrolling Changes: https://git.openjdk.org/jdk20u/pull/39/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=39&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303511 Stats: 84 lines in 2 files changed: 82 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk20u/pull/39.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/39/head:pull/39 PR: https://git.openjdk.org/jdk20u/pull/39 From thartmann at openjdk.org Wed Mar 29 11:54:32 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 29 Mar 2023 11:54:32 GMT Subject: [jdk20u] RFR: 8201516: DebugNonSafepoints generates incorrect information Message-ID: Backport of [JDK-8201516](https://bugs.openjdk.java.net/browse/JDK-8201516). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8201516: DebugNonSafepoints generates incorrect information Changes: https://git.openjdk.org/jdk20u/pull/40/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=40&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8201516 Stats: 154 lines in 3 files changed: 152 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk20u/pull/40.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/40/head:pull/40 PR: https://git.openjdk.org/jdk20u/pull/40 From thartmann at openjdk.org Wed Mar 29 11:55:24 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 29 Mar 2023 11:55:24 GMT Subject: [jdk20u] RFR: 8290822: C2: assert in PhaseIdealLoop::do_unroll() is subject to undefined behavior Message-ID: Backport of [JDK-8290822](https://bugs.openjdk.java.net/browse/JDK-8290822). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8290822: C2: assert in PhaseIdealLoop::do_unroll() is subject to undefined behavior Changes: https://git.openjdk.org/jdk20u/pull/41/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=41&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290822 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk20u/pull/41.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/41/head:pull/41 PR: https://git.openjdk.org/jdk20u/pull/41 From thartmann at openjdk.org Wed Mar 29 11:56:39 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 29 Mar 2023 11:56:39 GMT Subject: [jdk20u] RFR: 8301491: C2: java.lang.StringUTF16::indexOfChar intrinsic called with negative character argument Message-ID: Backport of [JDK-8301491](https://bugs.openjdk.java.net/browse/JDK-8301491). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8301491: C2: java.lang.StringUTF16::indexOfChar intrinsic called with negative character argument Changes: https://git.openjdk.org/jdk20u/pull/42/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=42&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8301491 Stats: 85 lines in 2 files changed: 83 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk20u/pull/42.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/42/head:pull/42 PR: https://git.openjdk.org/jdk20u/pull/42 From thartmann at openjdk.org Wed Mar 29 11:57:39 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 29 Mar 2023 11:57:39 GMT Subject: [jdk20u] RFR: 8303508: Vector.lane() gets wrong value on x86 Message-ID: Backport of [JDK-8303508](https://bugs.openjdk.java.net/browse/JDK-8303508). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8303508: Vector.lane() gets wrong value on x86 Changes: https://git.openjdk.org/jdk20u/pull/43/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=43&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303508 Stats: 91 lines in 3 files changed: 87 ins; 3 del; 1 mod Patch: https://git.openjdk.org/jdk20u/pull/43.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/43/head:pull/43 PR: https://git.openjdk.org/jdk20u/pull/43 From thartmann at openjdk.org Wed Mar 29 11:59:33 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 29 Mar 2023 11:59:33 GMT Subject: [jdk20u] RFR: 8299570: [JVMCI] Insufficient error handling when CodeBuffer is exhausted Message-ID: Backport of [JDK-8299570](https://bugs.openjdk.java.net/browse/JDK-8299570). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8299570: [JVMCI] Insufficient error handling when CodeBuffer is exhausted Changes: https://git.openjdk.org/jdk20u/pull/44/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=44&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299570 Stats: 45 lines in 5 files changed: 26 ins; 10 del; 9 mod Patch: https://git.openjdk.org/jdk20u/pull/44.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/44/head:pull/44 PR: https://git.openjdk.org/jdk20u/pull/44 From goetz at openjdk.org Wed Mar 29 12:41:38 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 29 Mar 2023 12:41:38 GMT Subject: [jdk17u-dev] RFR: 8291638: Keep-Alive timeout of 0 should close connection immediately Message-ID: I backport this for parity with 17.0.8-oracle. ------------- Commit messages: - Backport 26ac8366360685ef0cf3447ee7db16ba7a7fa1ec Changes: https://git.openjdk.org/jdk17u-dev/pull/1229/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1229&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8291638 Stats: 40 lines in 4 files changed: 29 ins; 8 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1229.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1229/head:pull/1229 PR: https://git.openjdk.org/jdk17u-dev/pull/1229 From goetz at openjdk.org Wed Mar 29 12:41:47 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 29 Mar 2023 12:41:47 GMT Subject: [jdk11u-dev] RFR: 8291638: Keep-Alive timeout of 0 should close connection immediately Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 26ac8366360685ef0cf3447ee7db16ba7a7fa1ec Changes: https://git.openjdk.org/jdk11u-dev/pull/1821/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1821&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8291638 Stats: 40 lines in 4 files changed: 29 ins; 8 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1821.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1821/head:pull/1821 PR: https://git.openjdk.org/jdk11u-dev/pull/1821 From goetz at openjdk.org Wed Mar 29 12:51:44 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 29 Mar 2023 12:51:44 GMT Subject: [jdk17u-dev] RFR: 8288589: Files.readString ignores encoding errors for UTF-16 Message-ID: I backport this for parity with 17.0.8-oracle. ------------- Commit messages: - Backport 2728770e3d73bb11c4d6e54b5aff91588a1a780b Changes: https://git.openjdk.org/jdk17u-dev/pull/1230/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1230&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8288589 Stats: 231 lines in 4 files changed: 143 ins; 68 del; 20 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1230.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1230/head:pull/1230 PR: https://git.openjdk.org/jdk17u-dev/pull/1230 From phh at openjdk.org Wed Mar 29 13:30:06 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 29 Mar 2023 13:30:06 GMT Subject: [jdk11u-dev] RFR: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence [v5] In-Reply-To: References: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> Message-ID: On Wed, 29 Mar 2023 06:42:36 GMT, Kimura Yukihiro wrote: >> I would like to backport >> JDK-8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence. >> The original patch does not apply cleanly to 11u. >> Because the original patch has switch expressions which can not be used in 11u, >> and it has the Class jdk.javadoc.internal.doclets.formats.html.HtmlOptions which is not defined in 11u. >> There is no risk, because the logic around the changes is the same as jdk17. >> I confirmed the following test and all langtool tests. >> test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java >> >> Could anyone review the fix please? > > Kimura Yukihiro has updated the pull request incrementally with one additional commit since the last revision: > > Revert backport e9f3e325c274f19b0f6eceea2367708e3be689e Looks good. The backport has been approved in the JBS issue, so I can sponsor as soon as you add /integrate. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1805#pullrequestreview-1363106262 From rrich at openjdk.org Thu Mar 30 09:30:31 2023 From: rrich at openjdk.org (Richard Reingruber) Date: Thu, 30 Mar 2023 09:30:31 GMT Subject: [jdk17u-dev] RFR: 8304880: [PPC64] VerifyOops code in C1 doesn't work with ZGC In-Reply-To: References: Message-ID: On Tue, 28 Mar 2023 15:52:57 GMT, Martin Doerr wrote: > Backport of [JDK-8304880](https://bugs.openjdk.org/browse/JDK-8304880). Doesn't apply cleanly, but this change is trivial to backport because it only removes 2 small code pieces. (Can't verify oops between raw load and load barrier with ZGC.) Trivial indeed. Cheers, Richard. ------------- Marked as reviewed by rrich (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1225#pullrequestreview-1364705027 From mdoerr at openjdk.org Thu Mar 30 09:39:30 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 30 Mar 2023 09:39:30 GMT Subject: [jdk17u-dev] RFR: 8304880: [PPC64] VerifyOops code in C1 doesn't work with ZGC In-Reply-To: References: Message-ID: <28JFuNsa0kwMJVqBChd8yKzg7wHXbjh08fmlnH9Ru5M=.e06271c3-9a38-4720-bbc5-db0f3d006dc8@github.com> On Tue, 28 Mar 2023 15:52:57 GMT, Martin Doerr wrote: > Backport of [JDK-8304880](https://bugs.openjdk.org/browse/JDK-8304880). Doesn't apply cleanly, but this change is trivial to backport because it only removes 2 small code pieces. (Can't verify oops between raw load and load barrier with ZGC.) Thanks for the review! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1225#issuecomment-1489997365 From sgehwolf at openjdk.org Thu Mar 30 10:21:21 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 30 Mar 2023 10:21:21 GMT Subject: [jdk20u] RFR: 8304871: Use default visibility for static library builds Message-ID: Clean backport for a change to the static library build. Very little risk as it only affects static library consumers (mostly GraalVM and Mandrel). It fixes an issue there for the recent AWT changes done in the upcoming release. Testing: Manual test using Mandrel & ImageIO (awt). Broken before, fixed after. ------------- Commit messages: - Backport f0dba218ac00c0c577400b4d864ba79a9938aef7 Changes: https://git.openjdk.org/jdk20u/pull/45/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=45&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304871 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk20u/pull/45.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/45/head:pull/45 PR: https://git.openjdk.org/jdk20u/pull/45 From mbaesken at openjdk.org Thu Mar 30 12:09:33 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 30 Mar 2023 12:09:33 GMT Subject: [jdk17u-dev] Integrated: 8304671: javac regression: Compilation with --release 8 fails on underscore in enum identifiers In-Reply-To: References: Message-ID: On Fri, 24 Mar 2023 13:09:09 GMT, Matthias Baesken wrote: > backport of 8304671 This pull request has now been integrated. Changeset: 8bc5ad10 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/8bc5ad105a3da4e165dfabdd512d7d52236b7377 Stats: 178 lines in 2 files changed: 169 ins; 2 del; 7 mod 8304671: javac regression: Compilation with --release 8 fails on underscore in enum identifiers Reviewed-by: phh Backport-of: 63d4afbeb17df4eff0f65041926373ee62a8a33a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1216 From sgehwolf at openjdk.org Thu Mar 30 12:13:24 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 30 Mar 2023 12:13:24 GMT Subject: [jdk17u] RFR: 8304871: Use default visibility for static library builds Message-ID: <-L_m0Cv5Ksnk6wg8W6XPfIAEobpbaIqQHurH23QXhDw=.207e806c-6a0e-452a-b025-d1df824aa1d2@github.com> Clean, very low risk backport that I'd like to get into OpenJDK `17.0.7` as a critical fix. It's a build change that only affects the static library build (unusual config). Thus, it is a no-op on the regular OpenJDK build with shared libs. Testing: - [x] Using the manual reproducer from https://github.com/graalvm/mandrel/issues/487 with a mandrel build using a patched JDK 17. Works with the patch, is broken without it. - [ ] GHA (in progress) ------------- Commit messages: - Backport f0dba218ac00c0c577400b4d864ba79a9938aef7 Changes: https://git.openjdk.org/jdk17u/pull/367/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=367&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304871 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u/pull/367.diff Fetch: git fetch https://git.openjdk.org/jdk17u.git pull/367/head:pull/367 PR: https://git.openjdk.org/jdk17u/pull/367 From goetz at openjdk.org Thu Mar 30 12:35:13 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 30 Mar 2023 12:35:13 GMT Subject: [jdk17u-dev] RFR: 8282227: Locale information for nb is not working properly [v2] In-Reply-To: <_2a1zHnC8nhdc52GqGmFqmgYHLYvtQ0VxiWpittozQw=.5831409b-6659-4457-9a73-4f7aa2e051d3@github.com> References: <_2a1zHnC8nhdc52GqGmFqmgYHLYvtQ0VxiWpittozQw=.5831409b-6659-4457-9a73-4f7aa2e051d3@github.com> Message-ID: <0fJPftrh07SJYmcDDGyajXsXPANZWtPs-htPA8vYsZ4=.fecdd247-adc8-40ef-9f94-1ba5ef77219f@github.com> > I backport this for parity with 17.0.8-oracle. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into GoeLin-backport-3d07b3c7 - Backport 3d07b3c7f01b60ff4dc38f62407c212b48883dbf ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1220/files - new: https://git.openjdk.org/jdk17u-dev/pull/1220/files/d680b635..0daebc21 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1220&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1220&range=00-01 Stats: 1720 lines in 11 files changed: 1671 ins; 26 del; 23 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1220.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1220/head:pull/1220 PR: https://git.openjdk.org/jdk17u-dev/pull/1220 From goetz at openjdk.org Thu Mar 30 12:35:14 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 30 Mar 2023 12:35:14 GMT Subject: [jdk17u-dev] RFR: 8282227: Locale information for nb is not working properly In-Reply-To: <_2a1zHnC8nhdc52GqGmFqmgYHLYvtQ0VxiWpittozQw=.5831409b-6659-4457-9a73-4f7aa2e051d3@github.com> References: <_2a1zHnC8nhdc52GqGmFqmgYHLYvtQ0VxiWpittozQw=.5831409b-6659-4457-9a73-4f7aa2e051d3@github.com> Message-ID: On Tue, 28 Mar 2023 10:27:54 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. Three of the tests failed without containing any information about the failure. Maybe timeouts becasue 8278434 was missing. But thests of the change including this one passed. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1220#issuecomment-1490220568 From phh at openjdk.org Thu Mar 30 15:50:36 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 30 Mar 2023 15:50:36 GMT Subject: [jdk17u-dev] RFR: 8302491: NoClassDefFoundError omits the original cause of an error In-Reply-To: References: Message-ID: <-gBwad9Fe30XbinGEQXT06EHc4efeuWt0PorNfldkXo=.e9709e98-528f-4b25-bd4b-046136dc1bfc@github.com> On Tue, 28 Mar 2023 20:13:41 GMT, Ilarion Nakonechnyy wrote: > The backport doesn't apply cleanly. Tested with tier1 on Mac OS. The only non-clean place I can see is line 2735 in javaClasses.cpp, where you substituted nullptr for NULL. That isn't in the original commit, and adding it here would complicate a possible future NULL -> nullptr backport. Please change it back to NULL. Also, please enable pre-submit testing on your repo. ------------- Changes requested by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1226#pullrequestreview-1365430925 From inakonechnyy at openjdk.org Thu Mar 30 20:35:19 2023 From: inakonechnyy at openjdk.org (Ilarion Nakonechnyy) Date: Thu, 30 Mar 2023 20:35:19 GMT Subject: [jdk17u-dev] RFR: 8302491: NoClassDefFoundError omits the original cause of an error [v2] In-Reply-To: References: Message-ID: > The backporting of this patch enhances the workflow of JDK-8048190 by expanding the range of scenarios in which the root cause of a NoClassDefFoundError can be accurately reported. The patch carries a low risk as it only corrects the process of creating ExceptionInInitializerError for a specific scenario. > The patch does not apply cleanly to 17u, a little adjustment have been done. > Tested the patch with tier1 and tier2 tests. Ilarion Nakonechnyy has updated the pull request incrementally with one additional commit since the last revision: Review notes ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1226/files - new: https://git.openjdk.org/jdk17u-dev/pull/1226/files/ef0ab3f5..611e65a7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1226&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1226&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1226.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1226/head:pull/1226 PR: https://git.openjdk.org/jdk17u-dev/pull/1226 From phh at openjdk.org Thu Mar 30 21:05:19 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 30 Mar 2023 21:05:19 GMT Subject: [jdk17u-dev] RFR: 8302491: NoClassDefFoundError omits the original cause of an error [v2] In-Reply-To: References: Message-ID: On Thu, 30 Mar 2023 20:35:19 GMT, Ilarion Nakonechnyy wrote: >> The backporting of this patch enhances the workflow of JDK-8048190 by expanding the range of scenarios in which the root cause of a NoClassDefFoundError can be accurately reported. The patch carries a low risk as it only corrects the process of creating ExceptionInInitializerError for a specific scenario. >> The patch does not apply cleanly to 17u, a little adjustment have been done. >> Tested the patch with tier1 and tier2 tests. > > Ilarion Nakonechnyy has updated the pull request incrementally with one additional commit since the last revision: > > Review notes Looks good now. If you're not an Author, once the pre-submit tests are done, I can tag the JBS issue on your behalf and sponsor the commit once the backport is approved. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1226#pullrequestreview-1365925086 From goetz at openjdk.org Fri Mar 31 11:00:40 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 31 Mar 2023 11:00:40 GMT Subject: [jdk11u-dev] Integrated: 8275721: Name of UTC timezone in a locale changes depending on previous code In-Reply-To: References: Message-ID: <1_0X7sw36yt4hVN76jje8KKsCPpT2luDDdG0mCKpHCs=.13cb1829-ae11-445b-81db-281ccd850f50@github.com> On Tue, 28 Mar 2023 09:52:28 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: 00b7647f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/00b7647f83f9e6298bcbfa31635e4386a02fe4da Stats: 108 lines in 2 files changed: 85 ins; 17 del; 6 mod 8275721: Name of UTC timezone in a locale changes depending on previous code Backport-of: 543d1a8cf41d32dca161c9d8041f133a71bf0ecb ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1818 From goetz at openjdk.org Fri Mar 31 11:03:29 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 31 Mar 2023 11:03:29 GMT Subject: [jdk17u-dev] RFR: 8282227: Locale information for nb is not working properly [v2] In-Reply-To: <0fJPftrh07SJYmcDDGyajXsXPANZWtPs-htPA8vYsZ4=.fecdd247-adc8-40ef-9f94-1ba5ef77219f@github.com> References: <_2a1zHnC8nhdc52GqGmFqmgYHLYvtQ0VxiWpittozQw=.5831409b-6659-4457-9a73-4f7aa2e051d3@github.com> <0fJPftrh07SJYmcDDGyajXsXPANZWtPs-htPA8vYsZ4=.fecdd247-adc8-40ef-9f94-1ba5ef77219f@github.com> Message-ID: On Thu, 30 Mar 2023 12:35:13 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 17.0.8-oracle. > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into GoeLin-backport-3d07b3c7 > - Backport 3d07b3c7f01b60ff4dc38f62407c212b48883dbf Retest is also green, so the failures were an infra issue. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1220#issuecomment-1491744072 From goetz at openjdk.org Fri Mar 31 11:04:23 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 31 Mar 2023 11:04:23 GMT Subject: [jdk17u-dev] Integrated: 8275721: Name of UTC timezone in a locale changes depending on previous code In-Reply-To: References: Message-ID: On Tue, 28 Mar 2023 09:50:31 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. This pull request has now been integrated. Changeset: 590256dd Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/590256ddcb1bdda10131bdba2c70b919594785c0 Stats: 108 lines in 2 files changed: 85 ins; 17 del; 6 mod 8275721: Name of UTC timezone in a locale changes depending on previous code Backport-of: 543d1a8cf41d32dca161c9d8041f133a71bf0ecb ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1217 From goetz at openjdk.org Fri Mar 31 11:07:15 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 31 Mar 2023 11:07:15 GMT Subject: [jdk17u-dev] RFR: 8278434: timeouts in test java/time/test/java/time/format/TestZoneTextPrinterParser.java [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.8-oracle. > > I resolved copyright and @bugs in the test, will mark as clean. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1228/files - new: https://git.openjdk.org/jdk17u-dev/pull/1228/files/4ebdf290..4ebdf290 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1228&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1228&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1228.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1228/head:pull/1228 PR: https://git.openjdk.org/jdk17u-dev/pull/1228 From goetz at openjdk.org Fri Mar 31 11:09:37 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 31 Mar 2023 11:09:37 GMT Subject: [jdk11u-dev] Integrated: 8291638: Keep-Alive timeout of 0 should close connection immediately In-Reply-To: References: Message-ID: On Wed, 29 Mar 2023 12:34:39 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: 6dedd8a2 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/6dedd8a22b7c9e86d346290ea76f51631e63007a Stats: 40 lines in 4 files changed: 29 ins; 8 del; 3 mod 8291638: Keep-Alive timeout of 0 should close connection immediately Backport-of: 26ac8366360685ef0cf3447ee7db16ba7a7fa1ec ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1821 From goetz at openjdk.org Fri Mar 31 11:09:39 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 31 Mar 2023 11:09:39 GMT Subject: [jdk17u-dev] Integrated: 8282227: Locale information for nb is not working properly In-Reply-To: <_2a1zHnC8nhdc52GqGmFqmgYHLYvtQ0VxiWpittozQw=.5831409b-6659-4457-9a73-4f7aa2e051d3@github.com> References: <_2a1zHnC8nhdc52GqGmFqmgYHLYvtQ0VxiWpittozQw=.5831409b-6659-4457-9a73-4f7aa2e051d3@github.com> Message-ID: On Tue, 28 Mar 2023 10:27:54 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. This pull request has now been integrated. Changeset: f53661b1 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/f53661b1a907b685a237e12ed4b984153cf866d1 Stats: 79 lines in 2 files changed: 74 ins; 1 del; 4 mod 8282227: Locale information for nb is not working properly Backport-of: 3d07b3c7f01b60ff4dc38f62407c212b48883dbf ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1220 From goetz at openjdk.org Fri Mar 31 11:11:29 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 31 Mar 2023 11:11:29 GMT Subject: [jdk17u-dev] Integrated: 8291638: Keep-Alive timeout of 0 should close connection immediately In-Reply-To: References: Message-ID: On Wed, 29 Mar 2023 12:34:28 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. This pull request has now been integrated. Changeset: 1253eb40 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/1253eb403268b665b79a41c784bf7f57e19328cb Stats: 40 lines in 4 files changed: 29 ins; 8 del; 3 mod 8291638: Keep-Alive timeout of 0 should close connection immediately Backport-of: 26ac8366360685ef0cf3447ee7db16ba7a7fa1ec ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1229 From goetz at openjdk.org Fri Mar 31 11:26:05 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 31 Mar 2023 11:26:05 GMT Subject: [jdk17u-dev] RFR: 8278434: timeouts in test java/time/test/java/time/format/TestZoneTextPrinterParser.java [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.8-oracle. > > I resolved copyright and @bugs in the test, will mark as clean. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into goetz_backport_8278434 - Backport 8dc4437d002db5d025b47f48e7420e3bae55bdec - Backport 543d1a8cf41d32dca161c9d8041f133a71bf0ecb ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1228/files - new: https://git.openjdk.org/jdk17u-dev/pull/1228/files/4ebdf290..a1121923 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1228&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1228&range=01-02 Stats: 1822 lines in 15 files changed: 1766 ins; 27 del; 29 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1228.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1228/head:pull/1228 PR: https://git.openjdk.org/jdk17u-dev/pull/1228 From goetz at openjdk.org Fri Mar 31 12:15:35 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 31 Mar 2023 12:15:35 GMT Subject: [jdk17u-dev] Integrated: 8278434: timeouts in test java/time/test/java/time/format/TestZoneTextPrinterParser.java In-Reply-To: References: Message-ID: On Wed, 29 Mar 2023 08:23:21 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. > > I resolved copyright and @bugs in the test, will mark as clean. This pull request has now been integrated. Changeset: 0f72c301 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/0f72c301ea416690c4148eaddaf4b7af47ff5bf9 Stats: 29 lines in 2 files changed: 15 ins; 7 del; 7 mod 8278434: timeouts in test java/time/test/java/time/format/TestZoneTextPrinterParser.java Backport-of: 8dc4437d002db5d025b47f48e7420e3bae55bdec ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1228 From mdoerr at openjdk.org Fri Mar 31 12:34:19 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 Mar 2023 12:34:19 GMT Subject: [jdk17u-dev] Integrated: 8304880: [PPC64] VerifyOops code in C1 doesn't work with ZGC In-Reply-To: References: Message-ID: On Tue, 28 Mar 2023 15:52:57 GMT, Martin Doerr wrote: > Backport of [JDK-8304880](https://bugs.openjdk.org/browse/JDK-8304880). Doesn't apply cleanly, but this change is trivial to backport because it only removes 2 small code pieces. (Can't verify oops between raw load and load barrier with ZGC.) This pull request has now been integrated. Changeset: ac655ba0 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/ac655ba08e7386876452d2ed1a797c532a1d4056 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod 8304880: [PPC64] VerifyOops code in C1 doesn't work with ZGC Reviewed-by: rrich Backport-of: 695683b5b15c69a56fe7ee1a93482fe7c3530ca8 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1225 From duke at openjdk.org Fri Mar 31 13:28:38 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Fri, 31 Mar 2023 13:28:38 GMT Subject: [jdk11u-dev] Integrated: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence In-Reply-To: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> References: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> Message-ID: On Wed, 15 Mar 2023 07:06:55 GMT, Kimura Yukihiro wrote: > I would like to backport > JDK-8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence. > The original patch does not apply cleanly to 11u. > Because the original patch has switch expressions which can not be used in 11u, > and it has the Class jdk.javadoc.internal.doclets.formats.html.HtmlOptions which is not defined in 11u. > There is no risk, because the logic around the changes is the same as jdk17. > I confirmed the following test and all langtool tests. > test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java > > Could anyone review the fix please? This pull request has now been integrated. Changeset: 3c8c45ef Author: Kimura Yukihiro Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/3c8c45ef3e33621f69741b6c483a513e161714ee Stats: 288 lines in 11 files changed: 281 ins; 0 del; 7 mod 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence Reviewed-by: phh Backport-of: e9f3e325c274f19b0f6eceea2367708e3be689e9 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1805 From duke at openjdk.org Fri Mar 31 19:08:22 2023 From: duke at openjdk.org (Dan Lutker) Date: Fri, 31 Mar 2023 19:08:22 GMT Subject: [jdk17u-dev] RFR: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c Message-ID: Trivial backport to support building GCC 12 on Aarch64. Backport was not clean because jdk17 does not have support to disable warnings at the per file level and must disable the warning for the module. Successfully build on Linux x64 and aarc64 with gcc 12.2.0. ------------- Commit messages: - Backport 02ea338177df781912dc782e32200eaf4731a0da Changes: https://git.openjdk.org/jdk17u-dev/pull/1231/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1231&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293887 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1231.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1231/head:pull/1231 PR: https://git.openjdk.org/jdk17u-dev/pull/1231 From aph at openjdk.org Fri Mar 31 20:00:26 2023 From: aph at openjdk.org (Andrew Haley) Date: Fri, 31 Mar 2023 20:00:26 GMT Subject: [jdk17u-dev] RFR: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c In-Reply-To: References: Message-ID: On Thu, 30 Mar 2023 23:56:53 GMT, Dan Lutker wrote: > Trivial backport to support building GCC 12 on Aarch64. Backport was not clean because jdk17 does not have support to disable warnings at the per file level and must disable the warning for the module. > > Successfully build on Linux x64 and aarc64 with gcc 12.2.0. Ouch. Do we really want to turn off that warning for all of the files in the library? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1231#issuecomment-1492530577 From duke at openjdk.org Fri Mar 31 20:23:29 2023 From: duke at openjdk.org (Dan Lutker) Date: Fri, 31 Mar 2023 20:23:29 GMT Subject: [jdk17u-dev] RFR: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c In-Reply-To: References: Message-ID: <5gDMl0eMkxs5ERlJZZdsMYWQc2GaW1dkJXXXetmgSsQ=.a04ba9d4-da43-44ef-85d8-d6c20234dbcd@github.com> On Thu, 30 Mar 2023 23:56:53 GMT, Dan Lutker wrote: > Trivial backport to support building GCC 12 on Aarch64. Backport was not clean because jdk17 does not have support to disable warnings at the per file level and must disable the warning for the module. > > Successfully build on Linux x64 and aarc64 with gcc 12.2.0. I'd be happy to backport https://github.com/openjdk/jdk/commit/e45f3d5176e4affaa08480b560ca983fdbcb2846 and then we can cleanly disable warnings per file. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1231#issuecomment-1492567108 From duke at openjdk.org Fri Mar 31 21:27:25 2023 From: duke at openjdk.org (Dan Lutker) Date: Fri, 31 Mar 2023 21:27:25 GMT Subject: [jdk17u-dev] RFR: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c [v2] In-Reply-To: References: Message-ID: > Trivial backport to support building GCC 12 on Aarch64. Backport was not clean because jdk17 does not have support to disable warnings at the per file level and must disable the warning for the module. > > Successfully build on Linux x64 and aarc64 with gcc 12.2.0. Dan Lutker has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision: - Backport 02ea338177df781912dc782e32200eaf4731a0da - Backport e45f3d5176e4affaa08480b560ca983fdbcb2846 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1231/files - new: https://git.openjdk.org/jdk17u-dev/pull/1231/files/daff1cfd..c96608f6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1231&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1231&range=00-01 Stats: 9 lines in 2 files changed: 6 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1231.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1231/head:pull/1231 PR: https://git.openjdk.org/jdk17u-dev/pull/1231 From duke at openjdk.org Fri Mar 31 21:31:43 2023 From: duke at openjdk.org (Dan Lutker) Date: Fri, 31 Mar 2023 21:31:43 GMT Subject: [jdk17u-dev] RFR: 8294281: Allow warnings to be disabled on a per-file basis Message-ID: Required by https://github.com/openjdk/jdk17u-dev/pull/1231 ------------- Commit messages: - Backport e45f3d5176e4affaa08480b560ca983fdbcb2846 Changes: https://git.openjdk.org/jdk17u-dev/pull/1232/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1232&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294281 Stats: 7 lines in 1 file changed: 5 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1232.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1232/head:pull/1232 PR: https://git.openjdk.org/jdk17u-dev/pull/1232