[jdk11u-dev] RFR: 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption [v7]

Anthony Scarpino ascarpino at openjdk.org
Mon Mar 6 19:36:45 UTC 2023


On Mon, 6 Mar 2023 15:59:05 GMT, Scott Gibbons <sgibbons at openjdk.org> wrote:

>> Backporting because this change results in ~3x performance improvement in AES-CTR.
>> 
>> Risk is low.  Tested with tier1 and benchmark.
>> 
>> The PR does not backport cleanly.  The buffer name was changed, but functionally remains the same.
>
> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review comment

Something that should be verified is that this doesn't expose failed auth tag decrypted GCM data or other GCM decryption.  There maybe some unexpected differences as this change was after GCM separated from CipherCore in 17.  I believe GCM still uses CipherCore in 11.

-------------

PR: https://git.openjdk.org/jdk11u-dev/pull/1780


More information about the jdk-updates-dev mailing list