[jdk17u-dev] RFR: 8303937: Corrupted heap dumps due to missing retries for os::write() [v2]

Man Cao manc at openjdk.org
Tue Mar 14 01:35:18 UTC 2023


On Mon, 13 Mar 2023 21:26:47 GMT, Man Cao <manc at openjdk.org> wrote:

>> https://bugs.openjdk.org/browse/JDK-8303937 fixes a real bug that causes heap dump corruption.
>> 
>> Trivial merge conflict, resolved by removing (ssize_t) cast before os::write().
>> 
>> I'll need a sponsor to help push this into 17u-dev.
>
> Man Cao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
> 
>   Backport bf16b5b9880eb89b283006db090dce4346aa877b

Thanks all! Apology for missing the tests and risk assessment.
I enabled GitHub actions and all tier1 tests passed. (I used `git rebase` and `git push -f` to trigger a run for GitHub actions. Probably should have used `git merge`.)

I updated the "Fix request" comments to include risk assessment and tests on https://bugs.openjdk.org/browse/JDK-8303937, and also added back `jdk11u-fix-request` and `jdk17u-fix-request` tags. Let me know if I missed anything else.

-------------

PR: https://git.openjdk.org/jdk17u-dev/pull/1201


More information about the jdk-updates-dev mailing list