[jdk11u-dev] RFR: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence

[Kimura Yukihiro]

On Wed, 15 Mar 2023 07:06:55 GMT, Kimura Yukihiro <duke at openjdk.org> wrote:

> I would like to backport
> JDK-8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence.
> The original patch does not apply cleanly to 11u. 
> Because the original patch has switch expressions which can not be used in 11u,
> and it has the Class jdk.javadoc.internal.doclets.formats.html.HtmlOptions which is not defined in 11u. 
> There is no risk, because the logic around the changes is the same as jdk17. 
> I confirmed the following test and all langtool tests.
> test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java
> 
> Could anyone review the fix please?

Hello Paul,

Thank you for your advice.
In HtmlConfiguration.java, all variables for command line options are defined as public variable. For instance helpfile, stylesheetfile or createindex. 
Should all variables make private, including legalnotices?

Thanks,
Kimura Yukihiro

-------------

PR: https://git.openjdk.org/jdk11u-dev/pull/1805