[jdk17u-dev] RFR: 8292301: [REDO v2] C2 crash when allocating array of size too large

[Roland Westrelin]

On Thu, 16 Mar 2023 08:16:50 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> I had to resolve three files:
> src/hotspot/share/opto/callnode.cpp
> AllocateArrayNode::Ideal could not be deleted automatically.
> The patch removes       igvn->add_input_to(phase->C->root(), halt);
> but 11 has              phase->C->root()->add_req(halt);
> Just deleted anyways.
> 
> src/hotspot/share/opto/loopopts.cpp
> In the source, clone_loop() has been refactored.
> The patch touches code moved to finish_clone_loop().
> The very same code is in clone_loop() in 17. Moved
> hunk there.
> 
> src/hotspot/share/opto/phaseX.cpp
> Just placement of a comment.

Looks good to me.

-------------

Marked as reviewed by roland (Reviewer).

PR: https://git.openjdk.org/jdk17u-dev/pull/1204