[jdk11u] RFR: 8304389: [11u] Crash on Windows in C2 compiled code after 8248238 and 8218431

[Dean Long]

On Mon, 20 Mar 2023 19:01:06 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> … 8218431
>> 
>> A required fix to avoid regression in 11.0.19. See JBS issue.
>
> Actually, the configuration leading to errors exactly implements the calling conventions as speified here https://learn.microsoft.com/en-us/cpp/build/x64-calling-convention?view=msvc-170#callercallee-saved-registers .
> 
> The other configuration, doing more save-on-call, is always correct, but inefficient in case the registers are also saved-on-entry. In that case the registers are saved twice.  This is the configuration established by this change again.

@GoeLin, after more consideration, your fix does seem safest.  However, it might help to have a comment explaining why that change has been disabled.  So it might be better to comment out that .gmk logic rather than delete it.

-------------

PR Comment: https://git.openjdk.org/jdk11u/pull/70#issuecomment-1477141080