[jdk11u] RFR: 8304389: [11u] Crash on Windows in C2 compiled code after 8248238 and 8218431 [v2]

Dean Long dlong at openjdk.org
Tue Mar 21 08:07:32 UTC 2023


On Tue, 21 Mar 2023 07:51:41 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> … 8218431
>> 
>> A required fix to avoid regression in 11.0.19. See JBS issue.
>
> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Move fix to better place. Add comment with bugId

OK, this looks reasonable.  Instead of #ifdef WRONG, how about something like #ifdef DISABLED instead?
I suggest filing a separate bug/RFE to investigate the reason for the crash.
Finally, please get a 2nd review.

-------------

Marked as reviewed by dlong (Committer).

PR Review: https://git.openjdk.org/jdk11u/pull/70#pullrequestreview-1349863571


More information about the jdk-updates-dev mailing list