[jdk11u-dev] RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers

Thu Mar 23 09:28:56 UTC 2023

On Thu, 23 Mar 2023 06:45:30 GMT, PoojaDP-23 <duke at openjdk.org> wrote:

>>> @RealCLanger - Could you please review the backport PR?
>> 
>> I can have a look. But please do a merge with master before and by that, trigger GHA. Thanks.
>
> @RealCLanger - Could you please review the PR? Thanks

Hi @PoojaDP-23,

when looking at the scope of this backport and its successor, [JDK-8293562](https://github.com/openjdk/jdk/commit/03f25a9c6924430ec4063b801b2b6ca55b9067c9), which I've understood is what you actually want to fix, I'm a bit concerned whether this is appropriate as a backport to JDK11. After all, it completely reworks the locking in the HTTP client and we can't be sure what side effects this might cause in other productive usages. It might even unveil issues that have not been discovered in head.

So, could you go back and give some more explanation what kind of bug you want to fix in 11u? Maybe we can find a less intrusive fix that could also differ from OpenJDK upstream? Maybe JDK-8293562 can be adapted for 11u without this one?

Thanks
Christoph

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1710#issuecomment-1480856360