[jdk11u-dev] RFR: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence [v5]
Paul Hohensee
phh at openjdk.org
Wed Mar 29 13:30:06 UTC 2023
On Wed, 29 Mar 2023 06:42:36 GMT, Kimura Yukihiro <duke at openjdk.org> wrote:
>> I would like to backport
>> JDK-8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence.
>> The original patch does not apply cleanly to 11u.
>> Because the original patch has switch expressions which can not be used in 11u,
>> and it has the Class jdk.javadoc.internal.doclets.formats.html.HtmlOptions which is not defined in 11u.
>> There is no risk, because the logic around the changes is the same as jdk17.
>> I confirmed the following test and all langtool tests.
>> test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java
>>
>> Could anyone review the fix please?
>
> Kimura Yukihiro has updated the pull request incrementally with one additional commit since the last revision:
>
> Revert backport e9f3e325c274f19b0f6eceea2367708e3be689e
Looks good.
The backport has been approved in the JBS issue, so I can sponsor as soon as you add /integrate.
-------------
Marked as reviewed by phh (Reviewer).
PR Review: https://git.openjdk.org/jdk11u-dev/pull/1805#pullrequestreview-1363106262
More information about the jdk-updates-dev
mailing list