[jdk17u-dev] RFR: 8302491: NoClassDefFoundError omits the original cause of an error

Paul Hohensee phh at openjdk.org
Thu Mar 30 15:50:36 UTC 2023


On Tue, 28 Mar 2023 20:13:41 GMT, Ilarion Nakonechnyy <inakonechnyy at openjdk.org> wrote:

> The backport doesn't apply cleanly. Tested with tier1 on Mac OS.

The only non-clean place I can see is line 2735 in javaClasses.cpp, where you substituted nullptr for NULL. That isn't in the original commit, and adding it here would complicate a possible future NULL -> nullptr backport. Please change it back to NULL.

Also, please enable pre-submit testing on your repo.

-------------

Changes requested by phh (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/1226#pullrequestreview-1365430925


More information about the jdk-updates-dev mailing list