[jdk17u-dev] RFR: 8305994: Guarantee eventual async monitor deflation

Evgeny Astigeevich eastigeevich at openjdk.org
Tue May 2 12:45:47 UTC 2023


On Tue, 2 May 2023 09:47:38 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Unclean backport to provide monitor deflation safeguards. Patch applies cleanly, but the test implicitly relies on the logging message added by [JDK-8291418](https://github.com/openjdk/jdk/commit/6065516bb3e0e445e9383718f539ec48440d6290#diff-3ff738a107928467669ff157a9bc20b2950c378a21ada38ac69237261a480985R1547). That change is too risky to backport, so I just pulled the logging message to make test work.
> 
> There are a few follow-ups to this work, see dependent PRs.
> 
> Additional testing:
>  - [x] macos-aarch64-server-fastdebug, `runtime/Monitor`

lgtm

src/hotspot/share/runtime/synchronizer.cpp line 1669:

> 1667:   }
> 1668:   set_is_final_audit();
> 1669:   log_info(monitorinflation)("Starting the final audit.");

This is the additional line added to make the test work.

-------------

Marked as reviewed by eastigeevich (no project role).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/1316#pullrequestreview-1409020523
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1316#discussion_r1182494427


More information about the jdk-updates-dev mailing list