[jdk17u-dev] RFR: 8299570: [JVMCI] Insufficient error handling when CodeBuffer is exhausted

[Goetz Lindenmaier]

On Fri, 28 Apr 2023 11:41:58 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> I backport this for parity with 17.0.8-oracle.
>> 
>> I resolved three files due to context and NULL/nullptr.
>
> src/hotspot/cpu/aarch64/nativeInst_aarch64.cpp line 532:
> 
>> 530: // Generate a trampoline for a branch to dest.  If there's no need for a
>> 531: // trampoline, simply patch the call directly to dest.
>> 532: void NativeCall::trampoline_jump(CodeBuffer &cbuf, address dest, JVMCI_TRAPS) {
> 
> In the original changeset, this hunk has the `#if INCLUDE_JVMCI` addition. Plus `#endif` later.

Thanks for spotting this!  Fixed.

> src/hotspot/cpu/aarch64/nativeInst_aarch64.cpp line 534:
> 
>> 532: void NativeCall::trampoline_jump(CodeBuffer &cbuf, address dest, JVMCI_TRAPS) {
>> 533:   MacroAssembler a(&cbuf);
>> 534:   
> 
> Yeah, original changeset does not have a newline here?

There was some whitespace added in this line. removed.  This will fix the Pre-submit jcheck failure.

-------------

PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1308#discussion_r1183448052
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1308#discussion_r1183448418