[jdk17u-dev] RFR: 8297587: Upgrade JLine to 3.22.0

[Matthias Baesken]

On Mon, 8 May 2023 13:38:00 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> I backport this as one of the regular updates to external libs.
> 
> Some cleanups were applied to the jline sources in head:
>  8276641: Use blessed modifier order in jshell
>  8284209: Replace remaining usages of 'a the' in source code
>  These were not backported, but overwritten by the jline update:
>  It obviously resets such changes to the wording in the
>  upstream sources.
> src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/TerminalBuilder.java
> src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/win/WindowsAnsiWriter.java
> 
> src/jdk.internal.le/share/classes/module-info.java
> Resolved due to context.

In jdk20u https://github.com/openjdk/jdk20u/commit/6db9050da26f17d909df67a5e8d241f76cdc496c

I see 

src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/OSUtils.java


    private static boolean isTestCommandValid(String command) {
        return Files.isExecutable(Paths.get(command));
    }


where is this here ? is it not needed ?
Otherwise looks okay to me.

-------------

PR Review: https://git.openjdk.org/jdk17u-dev/pull/1331#pullrequestreview-1418493915