[jdk11u-dev] RFR: 8303861: Error handling step timeouts should never be blocked by OnError and others

[Alexey Pavlyutkin]

On Fri, 5 May 2023 10:24:07 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

> HI!
> 
> Here is backport of JDK-8303861. The patch fixes error reporting timeout processing for the case when a user specifies OnError hook. Before the patch in this case JVM just ignored timeout and therefore WatcherThread could not break malloc() deadlock in error reporting routine.
> 
> The patch from 17 applied with the only change: in `void WatcherThread::run()` is located in `thread.cpp` (`nonJavaThread.cpp` in 17).
> 
> Verification/regression (amd64/LTS20.04): test/hotspot/jtreg/runtime/ErrorHandling (includes updated test)

Sure, I did

alex at alex-VirtualBox:~/jdk11u-dev$ /opt/jtreg/bin/jtreg -v -jdk:./build/linux-x86_64-normal-server-release/images/jdk test/hotspot/jtreg/runtime/ErrorHandling
runner starting test: runtime/ErrorHandling/BadNativeStackInErrorHandlingTest.java
runner finished test: runtime/ErrorHandling/BadNativeStackInErrorHandlingTest.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/CreateCoredumpOnCrash.java
runner finished test: runtime/ErrorHandling/CreateCoredumpOnCrash.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/ProblematicFrameTest.java
runner finished test: runtime/ErrorHandling/ProblematicFrameTest.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/SafeFetchInErrorHandlingTest.java
runner finished test: runtime/ErrorHandling/SafeFetchInErrorHandlingTest.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/SecondaryErrorTest.java
runner finished test: runtime/ErrorHandling/SecondaryErrorTest.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/TestCrashOnOutOfMemoryError.java
runner finished test: runtime/ErrorHandling/TestCrashOnOutOfMemoryError.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/TestExitOnOutOfMemoryError.java
runner finished test: runtime/ErrorHandling/TestExitOnOutOfMemoryError.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/TestHeapDumpOnOutOfMemoryError.java
runner finished test: runtime/ErrorHandling/TestHeapDumpOnOutOfMemoryError.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/TestHeapDumpOnOutOfMemoryErrorInMetaspace.java
runner finished test: runtime/ErrorHandling/TestHeapDumpOnOutOfMemoryErrorInMetaspace.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/TestHeapDumpPath.java
runner finished test: runtime/ErrorHandling/TestHeapDumpPath.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/TestOnOutOfMemoryError.java
runner finished test: runtime/ErrorHandling/TestOnOutOfMemoryError.java
Passed. Execution successful
Test results: passed: 11

Gonna check it

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1856#issuecomment-1541441982