[jdk11u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing Connections

[Severin Gehwolf]

On Wed, 24 May 2023 09:40:47 GMT, Henry <duke at openjdk.org> wrote:

> > This patch is pretty hard to review since it includes many unrelated changes. Please try to only make _necessary_ adaptations and explain why those changes needed to be made.
> > Perhaps it makes more sense to start over by applying the JDK 17u patch and adjusting it until it works and you're confident the patch does what it's supposed to do. It's important to configure your editor in a way to not modify code that isn't being touched by the patch. Unrelated formatting changes are not OK in a backport.
> > While the JDK 17u patch builds on https://bugs.openjdk.org/browse/JDK-8229867, this backport should not include those changes. It should use the old synchronization scheme instead.
> 
> Hi @jerboaa
> 
> Where do I find the documentation for "the old synchronization scheme" ?

Look at https://github.com/openjdk/jdk/commit/65393a09 the change done as part of https://bugs.openjdk.org/browse/JDK-8229867. In essence it's changing `synchronized` methods to use `java.util.concurrent.locks` API instead.

> I am trying to make the requested changes but I would like to see how it is done to see if it is better than the manual change.

Someone else has done another backport of this change. See https://github.com/openjdk/jdk11u-dev/pull/1890 perhaps coordinate with that contributor?

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1825#issuecomment-1560960709