[jdk17u-dev] RFR: 8318953: RISC-V: Small refactoring for MacroAssembler::test_bit

Fei Yang fyang at openjdk.org
Thu Nov 2 03:44:03 UTC 2023


On Thu, 2 Nov 2023 02:53:38 GMT, Gui Cao <gcao at openjdk.org> wrote:

> Hi, this backport to make the test_bit assember function more simpler and to improve performance when the parameter (1UL << bit_pos) exceeds 32-bit range. This is a risc-v specific change. Backport is clean, risk is low.
> By the way, fastlock needs to call test_bit, because in the mainline version, the fastlock function is extracted to c2_MacroAssembler_riscv.cpp, but in jdk17u-dev, fastlock is still in riscv.ad, so PR is not in clean state.
> ### Testing:
> qemu 8.1.50:
> - [ ] Tier1 tests (release)

Looks good.

-------------

Marked as reviewed by fyang (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/1941#pullrequestreview-1709399509


More information about the jdk-updates-dev mailing list