[jdk11u-dev] RFR: 8308593: Add KEEPALIVE Extended Socket Options Support for Windows

[Terry Chow]

On Mon, 13 Nov 2023 07:21:31 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> This is an unclean backport of [JDK-8308593](https://bugs.openjdk.org/browse/JDK-8308593), which provides support for the keepalive extended socket options on Windows.
>> 
>> The following changes are the differences from the original patch in order to get this backport working for 11u:
>> 
>> make/lib/Lib-jdk.net.gmk -- Updated this script to support building extnet for Windows.
>> 
>> src/jdk.net/share/classes/jdk/net/ExtendedSocketOptions.java -- Added a case to support returning an instance of WindowsSocketOptions in PlatformSocketOptions.
>> 
>> src/java.base/windows/classes/java/net/PlainSocketImpl.java -- The Windows PlainSocketImpl class will need to have similar setOption/getOption methods as the Unix PlainSocketImpl class to support setting these extended socket options for Windows.
>> 
>> Backport passed against Tier 1 tests and was manually verified to be working on Windows.
>
> Hi @tkyc,
> please only label for approval if you have a review, i.e. the change is ready to be integrated.
> Did you make sure all relevant tests did run? Tier1 is only a basic sanity check.

@GoeLin apologies, my mistake. Aside from tier 1, I ran the keepalive tests from PR JDK-8194298 that initially added support for Linux (which passed). At the moment also I'm running the `jdk_net` test group as well just as another precaution. Let me know if there's any further testing I can do.

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2278#issuecomment-1811606783