[jdk11u-dev] RFR: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
Volker Simonis
simonis at openjdk.org
Fri Nov 24 12:42:13 UTC 2023
On Tue, 21 Nov 2023 17:23:51 GMT, Paul Hohensee <phh at openjdk.org> wrote:
> Follow-on bug fix for [JDK-8304074](https://bugs.openjdk.org/browse/JDK-8304074) backport. Clean backport from 17u, see https://github.com/openjdk/jdk17u-dev/pull/1981. The lock definition macro changed between 17 and 21, so the definition of MonitoringSupport_lock is different.
Looks good but see my inline comments.
test/jdk/com/sun/management/ThreadMXBean/ThreadAllocatedMemory.java line 28:
> 26: * @bug 6173675 8231209 8304074 8313081
> 27: * @summary Basic test of ThreadMXBean.getThreadAllocatedBytes
> 28: * @requires vm.gc == "G1"
Why have you changed this from `@requires vm.gc.G1` to `@requires vm.gc == "G1"`? I think the former should also be supported in jdk11u-dev.
test/jdk/com/sun/management/ThreadMXBean/ThreadAllocatedMemory.java line 36:
> 34: * @bug 6173675 8231209 8304074 8313081
> 35: * @summary Basic test of ThreadMXBean.getThreadAllocatedBytes
> 36: * @requires vm.gc == "Serial"
Why have you changed this from `@requires vm.gc.Serial` to `@requires vm.gc == "Serial"`? I think the former should also be supported in jdk11u-dev.
-------------
Marked as reviewed by simonis (Reviewer).
PR Review: https://git.openjdk.org/jdk11u-dev/pull/2287#pullrequestreview-1747884000
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2287#discussion_r1404311305
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2287#discussion_r1404311765
More information about the jdk-updates-dev
mailing list