[jdk17u-dev] RFR: 8271566: DSA signature length value is not accurate in P11Signature [v2]

[Andrew Dinn]

On Thu, 23 Nov 2023 17:26:34 GMT, Martin Balao <mbalao at openjdk.org> wrote:

>> Hi,
>> 
>> I would like to request a review for the backport of [8271566](https://bugs.openjdk.org/browse/JDK-8271566) to jdk17u-dev.
>> 
>> The original patch does not apply cleanly due to context differences in some parts of P11Key.java. In particular, jdk17u lacks of [8274393](https://bugs.openjdk.org/browse/JDK-8274393) that introduces `@SuppressWarnings("serial")` lines. jdk17u does not have the [8160675](https://bugs.openjdk.org/browse/JDK-8160675) enhancement so it does not need [8274393](https://bugs.openjdk.org/browse/JDK-8274393) to be backported as a dependency.
>> 
>> No regressions observed in the "jdk/sun/security/pkcs11" tests category.
>> 
>> Thanks,
>> Martin.-
>
> Martin Balao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Test.

This is really just a clean backport modulo a few small changes to accommodate the missing serialization warnings. So all good as far as correctness is concerned.

-------------

Marked as reviewed by adinn (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/1982#pullrequestreview-1747957769