[jdk17u-dev] RFR: 8277307: Pre shared key sent under both session_ticket and pre_shared_key extensions

Tue Nov 28 10:55:13 UTC 2023

On Tue, 28 Nov 2023 10:18:09 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>>> Please mention what kind of testing you have done for this. Thanks!
>> 
>> Hi @jerboaa, I was relying on GH actions catching any regression. But now that you mentioned, I'm realizing that the test extended by this backport to assert the _TLS1.2 session ticket_ is empty when negotiating _TLS 1.3_ isn't included ([`ResumeTLS13withSNI.java`](https://github.com/openjdk/jdk17u-dev/blob/785e85184b927c5672f7330f35900f14e554b1e4/test/jdk/javax/net/ssl/SSLSession/ResumeTLS13withSNI.java)).
>> 
>> So I ran the whole `test/jdk/javax/net/ssl` category including it, along with other 180 tests. It passed 100% with a 785e85184b927c5672f7330f35900f14e554b1e4 _Linux_ release build. I've also debugged `ResumeTLS13withSNI.java` to ensure the new assertion is exercised.
>
> @franferrax Please integrate and I can help sponsor this change so it gets in before rampdown (today).

Awesome, thanks @jerboaa and @GoeLin for your guidance.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1946#issuecomment-1829574215