[jdk17u-dev] RFR: 8281015: Further simplify NMT backend

Goetz Lindenmaier goetz at openjdk.org
Mon Oct 2 08:38:36 UTC 2023


I backport this as prereq of some useful NMT improvements: [JDK-8292072](https://bugs.openjdk.org/browse/JDK-8292072)j, [JDK-8292948](https://bugs.openjdk.org/browse/JDK-8292948), [JDK-8292898](https://bugs.openjdk.org/browse/JDK-8292898).

I had to do some trivial resolves and adaptions to make it build. See also extra commits.

src/hotspot/share/runtime/os.cpp
Resolved because "8286519 Better memory handling." is in the context.

src/hotspot/share/services/mallocTracker.cpp
Deleted function release() uses check_block_integrity() which is named assert_block_integrity() in head.
This came with "8280289: Enhance debug pp() command with NMT info"

The change to MallocTracker::print_pointer_information() can not be applied.
The patched code is only introduced in "8281023: NMT integration into pp debug command does not work"
which is in 19 only. The code refactored into this function stems from debug.cpp and
was introduced there in "8280289: Enhance debug pp() command with NMT info".
Omitted.

src/hotspot/share/services/mallocTracker.hpp
Also naming difference of check_block_integrity() because "8280289: Enhance debug pp() command with NMT info" not in 19.

src/hotspot/share/services/memTracker.hpp
Resolved #include.

The new code brought two calls to assert_block_integrity() which I changed to call check_block_integrity().

-------------

Commit messages:
 - Build fix
 - Chunks that did not apply clean.
 - Backport b96b743727a628c1b33cc9b3374f010c2ea30b78

Changes: https://git.openjdk.org/jdk17u-dev/pull/1820/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1820&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8281015
  Stats: 273 lines in 10 files changed: 56 ins; 147 del; 70 mod
  Patch: https://git.openjdk.org/jdk17u-dev/pull/1820.diff
  Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1820/head:pull/1820

PR: https://git.openjdk.org/jdk17u-dev/pull/1820


More information about the jdk-updates-dev mailing list