[jdk17u-dev] RFR: 8281015: Further simplify NMT backend [v2]

[Lutz Schmidt]

On Mon, 2 Oct 2023 10:42:26 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> I backport this as prereq of some useful NMT improvements: [JDK-8292072](https://bugs.openjdk.org/browse/JDK-8292072)j, [JDK-8292948](https://bugs.openjdk.org/browse/JDK-8292948), [JDK-8292898](https://bugs.openjdk.org/browse/JDK-8292898).
>> 
>> I had to do some trivial resolves and adaptions to make it build. See also extra commits.
>> 
>> src/hotspot/share/runtime/os.cpp
>> Resolved because "8286519 Better memory handling." is in the context.
>> 
>> src/hotspot/share/services/mallocTracker.cpp
>> Deleted function release() uses check_block_integrity() which is named assert_block_integrity() in head.
>> This came with "8280289: Enhance debug pp() command with NMT info"
>> 
>> The change to MallocTracker::print_pointer_information() can not be applied.
>> The patched code is only introduced in "8281023: NMT integration into pp debug command does not work"
>> which is in 19 only. The code refactored into this function stems from debug.cpp and
>> was introduced there in "8280289: Enhance debug pp() command with NMT info".
>> Omitted.
>> 
>> src/hotspot/share/services/mallocTracker.hpp
>> Also naming difference of check_block_integrity() because "8280289: Enhance debug pp() command with NMT info" not in 19.
>> 
>> src/hotspot/share/services/memTracker.hpp
>> Resolved #include.
>> 
>> The new code brought two calls to assert_block_integrity() which I changed to call check_block_integrity().
>
> Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Build fix

LGTM.

-------------

Marked as reviewed by lucy (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/1820#pullrequestreview-1657184678