[jdk17u-dev] RFR: 8298298: NMT: count deltas are printed with 32-bit signed size

Lutz Schmidt lucy at openjdk.org
Wed Oct 4 10:25:46 UTC 2023


On Tue, 3 Oct 2023 19:21:15 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> A useful bugfix for NMT>
> 
> Trivial resolves in code.
> The test that got extended by  a few new cases is not in 17. 
> I added the test body so that the new test cases are checked.

LGTM.
One minimal formatting request. 
Thanks for the backport work.

src/hotspot/share/utilities/globalDefinitions.hpp line 144:

> 142: 
> 143: #define SSIZE_FORMAT             "%"   PRIdPTR
> 144: #define SSIZE_PLUS_FORMAT        "%+"         PRIdPTR

alignment would be nice.

-------------

Marked as reviewed by lucy (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/1824#pullrequestreview-1657183814
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1824#discussion_r1345561026


More information about the jdk-updates-dev mailing list