[jdk17u-dev] Integrated: 8291550: RISC-V: jdk uses misaligned memory access when AvoidUnalignedAccess enabled

Olga Mikhaltsova omikhaltcova at openjdk.org
Sun Oct 8 13:56:20 UTC 2023


On Fri, 6 Oct 2023 12:22:20 GMT, Olga Mikhaltsova <omikhaltcova at openjdk.org> wrote:

> I'd like to backport JDK-8291550 to jdk17u. This fix is related only to RISC-V.
> 
> The patch applies not cleanly. It differs from the original one in the following:
> 
> **1.** **src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp**
> 
> `#undef VFCVT_SAFE` was removed because there is no `#define VFCVT_SAFE(VFLOATCVT)` (JDK-8306966)
> 
> **2.** **src/hotspot/cpu/riscv/gc/shared/barrierSetNMethod_riscv.cpp**
> 
> The difference is in context due to method signature change by JDK-8299229
> `void NativeNMethodBarrier::verify() const {..`
> `bool NativeNMethodBarrier::check_barrier(err_msg& msg) const {..`
> 
> `msg.print(..)` was replaced with `tty->print_cr(..)`
> 
> **3.** **src/hotspot/cpu/riscv/interp_masm_riscv.cpp**
> 
> The changes were not applied to 
> `void InterpreterMacroAssembler::load_resolved_indy_entry(Register cache, Register index) {`
> This method doesn't exist, it was added by JDK-8301995.
> 
> **4.** **src/hotspot/cpu/riscv/macroAssembler_riscv.cpp**
> 
> The difference is in context due to the method signature change by JDK-8298075
> `address MacroAssembler::get_target_of_li32(address insn_addr) {`
> `static address get_target_of_li32(address insn_addr) `{
> 
> `NULL` was replaced with `nullptr` by JDK-8301496.
> 
> **5.** **src/hotspot/cpu/riscv/nativeInst_riscv.cpp**
>          **src/hotspot/cpu/riscv/nativeInst_riscv.hpp**
>  
> `NULL` was replaced with `nullptr` by JDK-8301496
> 
> **Testing:** tier1 tests successfully passed on a RISC-V HiFive board with Linux.

This pull request has now been integrated.

Changeset: adef8e46
Author:    Olga Mikhaltsova <omikhaltcova at openjdk.org>
URL:       https://git.openjdk.org/jdk17u-dev/commit/adef8e467c0e2f36146627ace77f79d874c26783
Stats:     234 lines in 12 files changed: 148 ins; 0 del; 86 mod

8291550: RISC-V: jdk uses misaligned memory access when AvoidUnalignedAccess enabled

Reviewed-by: vkempik
Backport-of: 37093441661c26f333aac00d16aea00c3341d314

-------------

PR: https://git.openjdk.org/jdk17u-dev/pull/1852


More information about the jdk-updates-dev mailing list