[jdk17u-dev] RFR: 8284047: Harmonize/Standardize the SSLSocket/SSLEngine/SSLSocketSSLEngine test templates

[Lutz Schmidt]

On Fri, 6 Oct 2023 07:22:56 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> I backport this for parity with 17.0.10-oracle.
> 
> test/jdk/javax/net/ssl/ALPN/SSLServerSocketAlpnTest.java
> test/jdk/javax/net/ssl/ALPN/SSLSocketAlpnTest.java
> Copyright.
> Deleting a larger block failed because 17 calls initCause(remote) where the original change calls addSuppressed(remote);
> 
> test/jdk/javax/net/ssl/templates/SSLSocketSSLEngineTemplate.java
> This could not be deleted because of the same difference mentioned above.
> 
> test/jdk/javax/net/ssl/templates/SSLSocketTemplate.java
> Copyright.
> 
> These difference are all because 8282723: Add constructors taking a cause to JSSE exceptions
> is not in 17.  I did not find a usage of addSuppressed() in the new code, so it should work without further adaptions.
> Ran all tests modified, passing.

LGTM

-------------

Marked as reviewed by lucy (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/1849#pullrequestreview-1667412869