[jdk17u-dev] RFR: 8302017: Allocate BadPaddingException only if it will be thrown

Saint Wesonga duke at openjdk.org
Tue Oct 17 04:44:27 UTC 2023


On Tue, 10 Oct 2023 21:01:01 GMT, Brian Stafford <bstafford at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/rsa/RSAPadding.java line 70:
>> 
>>> 68:  * the algorithm described in previous releases are in later releases.
>>> 69:  * However, additional comments/checks/clarifications were added to the
>>> 70:  * latter versions based on real-world experience (e.g. stricter v1.5
>> 
>> nit: I'm not sure this change in wording is necessary
>
> Ah, this is a change to this file that's on tip (although it wasn't part of the original change, I believe it went in via a different PR).

This change is from https://github.com/openjdk/jdk21u/commit/4cec141a90bc5d3b8ec17c024291d9c74a112cd4 and should not have been included when resolving the conflicts.

-------------

PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1864#discussion_r1361500075


More information about the jdk-updates-dev mailing list