[jdk17u-dev] RFR: 8308593: Add KEEPALIVE Extended Socket Options Support for Windows

[Paul Hohensee]

On Mon, 18 Sep 2023 18:33:42 GMT, Terry Chow <duke at openjdk.org> wrote:

> This is an unclean backport of [JDK-8308593](https://bugs.openjdk.org/browse/JDK-8308593), which provides support for the keepalive extended socket options on Windows.
> 
> The following changes were made in these files to resolve conflicts and issues:
> 1. make/modules/jdk.net/Lib.gmk -- I updated this script to support building extnet for Windows.
> 
> 2. jdk.net/share/classes/jdk/net/ExtendedSocketOptions.java -- I added a case to support returning an instance of WindowsSocketOptions in PlatformSocketOptions.
> 
> Tier 1 tests were ran and they're passing along with the existing keepalive tests. I also manually tested and confirmed the patch to be working on Windows.

You need a review before you can integrate, which this is.

In Lib.gmk, the copyright line should read

Copyright (c) 2016, 2023, Oracle and/or its affiliates. All rights reserved.

Similarly in ExtendedSocketOptions.java, the copyright line should red

Copyright (c) 2014, 2023 Oracle and/or its affiliates. All rights reserved.

The changes to Lib.gmk come from [JDK-8284890](https://bugs.openjdk.org/browse/JDK-8284890). It seems to me can't be backported because it involved a public API change, so adding linker options in this backport is ok. Same with the change in ExtendedSocketOptions.java to return a Windows-specific PlatformSocketOptions object, and the addition of WindowsSocketOptions.java/c.

So, aside from the above trivial copyright line changes, ltgm. The backport has been approved by the maintainers, so once you've fixed those, you can add a /integrate comment.

-------------

Changes requested by phh (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/1751#pullrequestreview-1698227445