[jdk17u-dev] RFR: 8308593: Add KEEPALIVE Extended Socket Options Support for Windows [v2]
Paul Hohensee
phh at openjdk.org
Thu Oct 26 21:43:37 UTC 2023
On Thu, 26 Oct 2023 17:27:04 GMT, Terry Chow <duke at openjdk.org> wrote:
>> This is an unclean backport of [JDK-8308593](https://bugs.openjdk.org/browse/JDK-8308593), which provides support for the keepalive extended socket options on Windows.
>>
>> The following changes were made in these files to resolve conflicts and issues:
>> 1. make/modules/jdk.net/Lib.gmk -- I updated this script to support building extnet for Windows.
>>
>> 2. jdk.net/share/classes/jdk/net/ExtendedSocketOptions.java -- I added a case to support returning an instance of WindowsSocketOptions in PlatformSocketOptions.
>>
>> Tier 1 tests were ran and they're passing along with the existing keepalive tests. I also manually tested and confirmed the patch to be working on Windows.
>
> Terry Chow has updated the pull request incrementally with one additional commit since the last revision:
>
> Code review -- updated copyright lines
Marked as reviewed by phh (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk17u-dev/pull/1751#pullrequestreview-1700684999
More information about the jdk-updates-dev
mailing list