[jdk11u-dev] RFR: 8221396: Clean up serviceability/sa/TestUniverse.java

[Goetz Lindenmaier]

On Tue, 26 Sep 2023 07:12:19 GMT, toshiogata <duke at openjdk.org> wrote:

> Hi all,
> 
> This is a backport of JDK-8221396: Clean up serviceability/sa/TestUniverse.java  
> I would like to backport this enhancement to jdk11u for test maintainability.
> 
> The original patch does not apply cleanly to jdk11u, because JDK-8238268 was backported ahead. As for TestUniverse.java, JDK-8238268 simply changes `@requires vm.hasSAandCanAttach` to `@requires vm.hasSA`, and the identical change can be safely applied to this patch.
> 
> The risk is low as this fix only affects testing.  
> There is a related Issue: JDK-8231931, and I submit the corresponding PR https://github.com/openjdk/jdk11u-dev/pull/2149. Testing was done after applying this related patch.  
> Testing: the affected test under all available GCs.
> 
> Thank you.

One more question: are you aware that Skara lists you as "null" in the fix request?
Does your user lack some information? Or is this a Skara problem?
Maybe we should open a Skara ticket for this.

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2148#issuecomment-1782469770