[jdk11u-dev] Integrated: 8221396: Clean up serviceability/sa/TestUniverse.java
toshiogata
duke at openjdk.org
Mon Oct 30 00:09:41 UTC 2023
On Tue, 26 Sep 2023 07:12:19 GMT, toshiogata <duke at openjdk.org> wrote:
> Hi all,
>
> This is a backport of JDK-8221396: Clean up serviceability/sa/TestUniverse.java
> I would like to backport this enhancement to jdk11u for test maintainability.
>
> The original patch does not apply cleanly to jdk11u, because JDK-8238268 was backported ahead. As for TestUniverse.java, JDK-8238268 simply changes `@requires vm.hasSAandCanAttach` to `@requires vm.hasSA`, and the identical change can be safely applied to this patch.
>
> The risk is low as this fix only affects testing.
> There is a related Issue: JDK-8231931, and I submit the corresponding PR https://github.com/openjdk/jdk11u-dev/pull/2149. Testing was done after applying this related patch.
> Testing: the affected test under all available GCs.
>
> Thank you.
This pull request has now been integrated.
Changeset: b9936cdf
Author: t.ogata <ogata.toshitaka at fujitsu.com>
Committer: Paul Hohensee <phh at openjdk.org>
URL: https://git.openjdk.org/jdk11u-dev/commit/b9936cdf6bb9806f76034cb44adea5c5808eaf55
Stats: 92 lines in 1 file changed: 42 ins; 34 del; 16 mod
8221396: Clean up serviceability/sa/TestUniverse.java
Reviewed-by: phh
Backport-of: 229d923b27a6c01616291aea6c8d4c86930bf7d2
-------------
PR: https://git.openjdk.org/jdk11u-dev/pull/2148
More information about the jdk-updates-dev
mailing list