[jdk17u-dev] RFR: 8300696: [AIX] AttachReturnError fails [v2]

[Deepa Kumari]

On Wed, 25 Oct 2023 11:47:25 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> > > There is something wrong with this patch. Why are the linux parts in there?
> > 
> > 
> > I made changes to address a Linux-specific error encountered in the GHA check. The modification ensures that the l_path variable is correctly assigned to l_pathdup when it is not a null pointer, improving the code's behavior and resolving the error on the Linux platform and also not affecting on AIX.
> 
> No, please don't add in changes that have nothing to do with the bug title, especially not if the patch mentions a single platform and the change affects other platforms, and/or if the issue was fixed upstream with a different bug.
> 
> * If this is an upstream bug unfixed: fix there, downport fix
> * If this is an upstream bug that has been fixed upstream: downport fix
> * If this is a downstream-only issue (that is rare): fix downstream either with a separate bug id or as part of the originating bug
> 
> In this case you need to downport https://bugs.openjdk.org/browse/JDK-8297242 . If this patch relies on https://bugs.openjdk.org/browse/JDK-8297242, downport that one first, then this one.

Thank you so much @tstuefe. Now I understood. I will follow the recommended approach.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1896#issuecomment-1787368902