[jdk17u-dev] RFR: 8312065: Socket.connect does not timeout when profiling [v4]

[Vyom Tewari]

On Wed, 6 Sep 2023 02:52:13 GMT, Long Yang <duke at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a fix for [JDK-8312065](https://bugs.openjdk.org/browse/JDK-8312065).
>> 
>> The old SocketImpl is still present in JDK 17, can be enabled with -Djdk.net.usePlainSocketImpl.
>> 
>> I have verified that this problem exists on Linux and macOS, and I feel that it also exists on AIX, 
>> so I repaired these 3 platforms. Windows implementations are different, so don't have this problem.
>> 
>> All callers of NET_Poll() already check for EINTR, so the fix is to remove do-while loop in the implementation of NET_Poll().
>> 
>> Other methods, such as NET_Read, NET_NonBlockingRead, NET_Accept, NET_Connect, are not affected.
>> Because if Socket has timeout, it will call NET_Timeout first, and then call them. NET_Timeout has a correct timeout implementation and is not affected by profiling signals.
>> If the Socket does not have a timeout, and if the system call is interrupted by a signal, the [Linux Kernel will automatically retry](https://man7.org/linux/man-pages/man7/signal.7.html), and the application code will not be aware of it.
>> 
>> Thanks!
>
> Long Yang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   push to trigger github workflows

test/jdk/java/net/Socket/B8312065.java line 61:

> 59:                 e.printStackTrace();
> 60:             } finally {
> 61:                 System.out.println("Test FAILED");

don't you think "Test FAILED" will print always ?

test/jdk/java/net/Socket/B8312065.java line 73:

> 71:             socket.connect(new InetSocketAddress("192.168.255.255", 8080), 2000);
> 72:         } catch (SocketTimeoutException e) {
> 73:             System.out.println("Test passed");

i will suggest you to provide a check that test 'socket.connect' throws 'SocketTimeoutException'  only after the time expires.

store time just before socket connect and in catch block check if time spent is >= timeout specified.

-------------

PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1639#discussion_r1317173545
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1639#discussion_r1317171907