[jdk17u-dev] RFR: 8312065: Socket.connect does not timeout when profiling [v6]

Long Yang duke at openjdk.org
Fri Sep 8 11:34:57 UTC 2023


On Fri, 8 Sep 2023 11:15:41 GMT, Andrei Pangin <apangin at openjdk.org> wrote:

>> Long Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add a RETRY macro argument to avoid code duplication
>
> src/java.base/linux/native/libnet/linux_close.c line 49:
> 
>> 47: #define false 0
>> 48: #endif
>> 49: 
> 
> Since the file already includes `jvm.h`, you can use `JNI_TRUE`/`JNI_FALSE` to avoid introducing more ifdefs

Andrei, thanks. Pushed.

-------------

PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1639#discussion_r1319746288


More information about the jdk-updates-dev mailing list