[jdk17u-dev] RFR: 8312065: Socket.connect does not timeout when profiling [v8]

Long Yang duke at openjdk.org
Fri Sep 8 13:54:50 UTC 2023


On Fri, 8 Sep 2023 12:23:27 GMT, Vyom Tewari <vtewari at openjdk.org> wrote:

>> Long Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use JNI_TRUE/JNI_FALSE to avoid introducing more ifdefs
>
> test/jdk/java/net/Socket/B8312065.java line 71:
> 
>> 69:         t.start();
>> 70: 
>> 71:         long startMillis = System.currentTimeMillis();
> 
> please use monotonically increasing time(System.nanoTime()) in place of 'currentTimeMillis'

Thanks, vyommani.  I have pushed. System wall-clock may be changed at any time, It is indeed more reasonable to use `nanoTime`.

-------------

PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1639#discussion_r1319901114


More information about the jdk-updates-dev mailing list