[jdk17u-dev] RFR: 8313322: RISC-V: implement MD5 intrinsic [v2]
Ilya Gavrilin
duke at openjdk.org
Thu Sep 14 12:29:30 UTC 2023
> Please review this backport of md5 intrinsics to jdk17u-dev.
>
> Backport is not clean because:
>
> - There was no no iterator for `class AbstractRegSet`, as an example `RegSetIterator` from aarch64 used: https://github.com/openjdk/jdk17u-dev/blob/0ddf1ebe3df119be2029b12feee93d0128e7cae0/src/hotspot/cpu/aarch64/register_aarch64.hpp#L379-L421
> - Method `uint AbstractRegSet::size()` was missing
> - Also for `size()` method we need `population_count()` function, so included `population_count.hpp` in `register_riscv.hpp`
> - MD5 generation requires huge `codeBuffer`, with old codeBuffer sizes got error during intrinsic generation, so extended them:
>
> code_size1: 19000 -> 20000
> code_size2: 28000 -> 30000
Ilya Gavrilin has updated the pull request incrementally with one additional commit since the last revision:
add missing include to register_riscv.hpp
-------------
Changes:
- all: https://git.openjdk.org/jdk17u-dev/pull/1739/files
- new: https://git.openjdk.org/jdk17u-dev/pull/1739/files/87a4f953..4bb6e0de
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1739&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1739&range=00-01
Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/jdk17u-dev/pull/1739.diff
Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1739/head:pull/1739
PR: https://git.openjdk.org/jdk17u-dev/pull/1739
More information about the jdk-updates-dev
mailing list