[jdk17u-dev] RFR: 8312065: Socket.connect does not timeout when profiling [v10]

Denghui Dong ddong at openjdk.org
Fri Sep 15 08:22:56 UTC 2023


On Thu, 14 Sep 2023 12:37:37 GMT, Long Yang <duke at openjdk.org> wrote:

>> Long Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into JDK-8312065-fix
>>  - use monotonically increasing time(System.nanoTime()) in place of currentTimeMillis
>>  - use JNI_TRUE/JNI_FALSE to avoid introducing more ifdefs
>>  - update comments
>>  - Add a RETRY macro argument to avoid code duplication
>>  - Check if SocketTimeoutException meets the specified time. Print detailed failure message.
>>  - push to trigger github workflows
>>  - Remove useless CountDownLatch
>>  - use libNativeThread to get OS thread id and send signal
>>  - 8312065: Socket.connect does not timeout as expected when profiling
>
>> You are still missing the fix request comment that states reason, risk and testing in the JBS bug. You can issue another approval request (Use: approval request " to do that, or edit JBS. For example see https://bugs.openjdk.org/browse/JDK-8232933
> 
> GoeLin, Thanks. Updated.

@yanglong1010 I'm not a committer of jdk-updates project :-(

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1639#issuecomment-1720872813


More information about the jdk-updates-dev mailing list