[jdk17u-dev] RFR: 8273522: Rename test property vm.cds.archived.java.heap to vm.cds.write.archived.java.heap

Goetz Lindenmaier goetz at openjdk.org
Mon Sep 18 07:56:08 UTC 2023


I backport this to simplify backport of tests that use the new property name.

Resolves were simple, only the method checking the flags set does not match good:

src/hotspot/share/cds/heapShared.hpp
Skipped. is_heap_object_archiving_allowed(), the predecessor of can_write(), does not have this assertion.

src/hotspot/share/prims/whitebox.cpp
I had to adapt this.
In 17, method is_heap_object_archiving_allowed() is called in WB_IsJavaHeapArchiveSupported()
Between 17 and 18, this has been renamed to can_write().
Also, WB_IsJavaHeapArchiveSupported() has been changed to call can_use(),
where this change reverts this to call can_write().
So I leave the call as-is, this shows the desired behaviour.

test/hotspot/jtreg/runtime/cds/SharedStrings.java
test/hotspot/jtreg/runtime/cds/appcds/cacheObject/ArchivedModuleWithCustomImageTest.java
test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/FlagCombo.java
test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/InternSharedString.java
test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/LargePages.java
test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/LockSharedStrings.java
test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/SharedStringsBasicPlus.java
test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/SharedStringsWbTest.java
test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/SysDictCrash.java
test/hotspot/jtreg/runtime/cds/serviceability/ReplaceCriticalClassesForSubgraphs.java
test/lib/jdk/test/whitebox/WhiteBox.java
Trivial resolves of the property.

test/lib/sun/hotspot/WhiteBox.java: No such file or directory
Skipped, was merged with the other WhiteBox.

-------------

Commit messages:
 - Backport 922e86f4ff28c7b17af8e7b5867a40fc76b7fdd7

Changes: https://git.openjdk.org/jdk17u-dev/pull/1748/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1748&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8273522
  Stats: 50 lines in 38 files changed: 0 ins; 2 del; 48 mod
  Patch: https://git.openjdk.org/jdk17u-dev/pull/1748.diff
  Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1748/head:pull/1748

PR: https://git.openjdk.org/jdk17u-dev/pull/1748


More information about the jdk-updates-dev mailing list